)]}'
{"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"30e341f6adb8baae2cfbb230f968cf731e1b4de3","unresolved":false,"context_lines":[{"line_number":9607,"context_line":"                       \u0027delete_relationship\u0027)"},{"line_number":9608,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":9609,"context_line":"                       \u0027get_relationship_info\u0027)"},{"line_number":9610,"context_line":"    def test_retain_target_volume_invalid_parameters_1("},{"line_number":9611,"context_line":"            self, get_relationship_info,"},{"line_number":9612,"context_line":"            delete_relationship,"},{"line_number":9613,"context_line":"            delete_vdisk):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_42e2bad5","line":9610,"range":{"start_line":9610,"start_character":13,"end_line":9610,"end_character":19},"updated":"2020-09-22 11:01:04.000000000","message":"this case doesn\u0027t retain the target volume, rather deletes it","commit_id":"3b0e9e0cda21b40455f0ba7f5c2ed361c61a72fc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"30e341f6adb8baae2cfbb230f968cf731e1b4de3","unresolved":false,"context_lines":[{"line_number":9638,"context_line":"                       \u0027delete_relationship\u0027)"},{"line_number":9639,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":9640,"context_line":"                       \u0027get_relationship_info\u0027)"},{"line_number":9641,"context_line":"    def test_retain_target_volume_invalid_parameters_2("},{"line_number":9642,"context_line":"            self, get_relationship_info,"},{"line_number":9643,"context_line":"            delete_relationship,"},{"line_number":9644,"context_line":"            delete_vdisk):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_82cfb255","line":9641,"range":{"start_line":9641,"start_character":13,"end_line":9641,"end_character":19},"updated":"2020-09-22 11:01:04.000000000","message":"same as L#9610","commit_id":"3b0e9e0cda21b40455f0ba7f5c2ed361c61a72fc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"30e341f6adb8baae2cfbb230f968cf731e1b4de3","unresolved":false,"context_lines":[{"line_number":9672,"context_line":"                       \u0027delete_relationship\u0027)"},{"line_number":9673,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":9674,"context_line":"                       \u0027get_relationship_info\u0027)"},{"line_number":9675,"context_line":"    def test_retain_target_volume_invalid_parameters_3("},{"line_number":9676,"context_line":"            self, get_relationship_info,"},{"line_number":9677,"context_line":"            delete_relationship,"},{"line_number":9678,"context_line":"            delete_vdisk):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_e2094e95","line":9675,"range":{"start_line":9675,"start_character":13,"end_line":9675,"end_character":19},"updated":"2020-09-22 11:01:04.000000000","message":"same","commit_id":"3b0e9e0cda21b40455f0ba7f5c2ed361c61a72fc"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":26575,"name":"Ankit Arora","email":"aarora06@in.ibm.com","username":"aarora06"},"change_message_id":"74a9f444ff17c34d967092c17b1b4b77c8025f49","unresolved":false,"context_lines":[{"line_number":147,"context_line":"               \u0027performs a complete cycle at most once each period. \u0027"},{"line_number":148,"context_line":"               \u0027The default is 300 seconds, and the valid seconds \u0027"},{"line_number":149,"context_line":"               \u0027are 60-86400.\u0027),"},{"line_number":150,"context_line":"    cfg.BoolOpt(\u0027retain_aux_volume\u0027,"},{"line_number":151,"context_line":"                default\u003dFalse,"},{"line_number":152,"context_line":"                help\u003d\u0027Enable or disable retaining of aux volume on secondary \u0027"},{"line_number":153,"context_line":"                     \u0027storage during delete of the volume on primary storage \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_fe96ac4b","line":150,"updated":"2020-08-10 06:34:12.000000000","message":"The properties in this section are being registered to the backend_default section. Are we getting the retain_aux_volume property from backend_default section in the code? If not, this property needs to be registered in the appropriate section.","commit_id":"d12a13c52cd567c65501f0b8fc71f0afefc64a2e"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"9c29679a7bb77775639218738c6e5942353fdbd7","unresolved":false,"context_lines":[{"line_number":147,"context_line":"               \u0027performs a complete cycle at most once each period. \u0027"},{"line_number":148,"context_line":"               \u0027The default is 300 seconds, and the valid seconds \u0027"},{"line_number":149,"context_line":"               \u0027are 60-86400.\u0027),"},{"line_number":150,"context_line":"    cfg.BoolOpt(\u0027retain_aux_volume\u0027,"},{"line_number":151,"context_line":"                default\u003dFalse,"},{"line_number":152,"context_line":"                help\u003d\u0027Enable or disable retaining of aux volume on secondary \u0027"},{"line_number":153,"context_line":"                     \u0027storage during delete of the volume on primary storage \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_34b7893d","line":150,"in_reply_to":"9f560f44_fe96ac4b","updated":"2020-08-12 06:01:54.000000000","message":"This section \u0027storwize_svc_opts\u0027 is to register the properties which can be defined under both sections \u0027backend_defaults\u0027 and a StorwizeSVC volume backend section. So, defined this property \u0027retain_aux_volume\u0027 under the section \u0027storwize_svc_opts\u0027 since it is very specific to storwize SVC backend. \nAny property defined under the section \u0027backend_defaults\u0027 is common and applicable to all storwize volume backends which is not the completely generic way. With the current approach, this property is restricted to a volume backend defined a specific storwize svc pool name.","commit_id":"d12a13c52cd567c65501f0b8fc71f0afefc64a2e"},{"author":{"_account_id":26575,"name":"Ankit Arora","email":"aarora06@in.ibm.com","username":"aarora06"},"change_message_id":"74a9f444ff17c34d967092c17b1b4b77c8025f49","unresolved":false,"context_lines":[{"line_number":3148,"context_line":"                    volume[\u0027name\u0027],"},{"line_number":3149,"context_line":"                    target_vol\u003dTrue,"},{"line_number":3150,"context_line":"                    force_unmap\u003dforce_unmap,"},{"line_number":3151,"context_line":"                    retain_aux_volume\u003dself.configuration.safe_get("},{"line_number":3152,"context_line":"                        \u0027retain_aux_volume\u0027))"},{"line_number":3153,"context_line":"            if not self._active_backend_id:"},{"line_number":3154,"context_line":"                self._master_backend_helpers.delete_rc_volume("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_3ec82472","line":3151,"updated":"2020-08-10 06:34:12.000000000","message":"From which section are we getting the retain_aux_volume property?","commit_id":"d12a13c52cd567c65501f0b8fc71f0afefc64a2e"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"9c29679a7bb77775639218738c6e5942353fdbd7","unresolved":false,"context_lines":[{"line_number":3148,"context_line":"                    volume[\u0027name\u0027],"},{"line_number":3149,"context_line":"                    target_vol\u003dTrue,"},{"line_number":3150,"context_line":"                    force_unmap\u003dforce_unmap,"},{"line_number":3151,"context_line":"                    retain_aux_volume\u003dself.configuration.safe_get("},{"line_number":3152,"context_line":"                        \u0027retain_aux_volume\u0027))"},{"line_number":3153,"context_line":"            if not self._active_backend_id:"},{"line_number":3154,"context_line":"                self._master_backend_helpers.delete_rc_volume("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_14b40535","line":3151,"in_reply_to":"9f560f44_3ec82472","updated":"2020-08-12 06:01:54.000000000","message":"From any storwize volume backend section. It should not come from other sections like DEFAULT.","commit_id":"d12a13c52cd567c65501f0b8fc71f0afefc64a2e"},{"author":{"_account_id":26575,"name":"Ankit Arora","email":"aarora06@in.ibm.com","username":"aarora06"},"change_message_id":"74a9f444ff17c34d967092c17b1b4b77c8025f49","unresolved":false,"context_lines":[{"line_number":5729,"context_line":"            try:"},{"line_number":5730,"context_line":"                self._master_backend_helpers.delete_rc_volume("},{"line_number":5731,"context_line":"                    volume.name, force_unmap\u003dforce_unmap)"},{"line_number":5732,"context_line":"                self._aux_backend_helpers.delete_rc_volume("},{"line_number":5733,"context_line":"                    volume.name, target_vol\u003dTrue, force_unmap\u003dforce_unmap)"},{"line_number":5734,"context_line":"                volumes_model_update.append("},{"line_number":5735,"context_line":"                    {\u0027id\u0027: volume.id, \u0027status\u0027: \u0027deleted\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_de7ac821","line":5732,"updated":"2020-08-10 06:34:12.000000000","message":"Do we need to send the retain_aux_volume property value for this delete rc volume method as well?\n\nIt would be better if we can directly get the configuration value for retain_aux_volume in the delete_rc_volume method.","commit_id":"d12a13c52cd567c65501f0b8fc71f0afefc64a2e"},{"author":{"_account_id":26575,"name":"Ankit Arora","email":"aarora06@in.ibm.com","username":"aarora06"},"change_message_id":"4930f617529d87f788fd6afd66ec542d8d4e86f1","unresolved":false,"context_lines":[{"line_number":5729,"context_line":"            try:"},{"line_number":5730,"context_line":"                self._master_backend_helpers.delete_rc_volume("},{"line_number":5731,"context_line":"                    volume.name, force_unmap\u003dforce_unmap)"},{"line_number":5732,"context_line":"                self._aux_backend_helpers.delete_rc_volume("},{"line_number":5733,"context_line":"                    volume.name, target_vol\u003dTrue, force_unmap\u003dforce_unmap)"},{"line_number":5734,"context_line":"                volumes_model_update.append("},{"line_number":5735,"context_line":"                    {\u0027id\u0027: volume.id, \u0027status\u0027: \u0027deleted\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_d41f2d6e","line":5732,"in_reply_to":"9f560f44_b47c3973","updated":"2020-08-12 06:46:02.000000000","message":"ok .. so will you be doing the changes for the same?\n\nOr is it ok to leave this delete_rc_volume as is? - because if delete_rc_volume is called from here and user has set the retain_aux_volume property in the configuration, then that value will not be considered here.","commit_id":"d12a13c52cd567c65501f0b8fc71f0afefc64a2e"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"ce04e653f0b673fa7cd5a386c2699b8a65c398a8","unresolved":false,"context_lines":[{"line_number":5729,"context_line":"            try:"},{"line_number":5730,"context_line":"                self._master_backend_helpers.delete_rc_volume("},{"line_number":5731,"context_line":"                    volume.name, force_unmap\u003dforce_unmap)"},{"line_number":5732,"context_line":"                self._aux_backend_helpers.delete_rc_volume("},{"line_number":5733,"context_line":"                    volume.name, target_vol\u003dTrue, force_unmap\u003dforce_unmap)"},{"line_number":5734,"context_line":"                volumes_model_update.append("},{"line_number":5735,"context_line":"                    {\u0027id\u0027: volume.id, \u0027status\u0027: \u0027deleted\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_8fa800dc","line":5732,"in_reply_to":"9f560f44_d41f2d6e","updated":"2020-08-17 05:33:31.000000000","message":"Yes. Making the changes to delete_rc_volume prototype and to function calls in order to pass one extra argument.","commit_id":"d12a13c52cd567c65501f0b8fc71f0afefc64a2e"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"9c29679a7bb77775639218738c6e5942353fdbd7","unresolved":false,"context_lines":[{"line_number":5729,"context_line":"            try:"},{"line_number":5730,"context_line":"                self._master_backend_helpers.delete_rc_volume("},{"line_number":5731,"context_line":"                    volume.name, force_unmap\u003dforce_unmap)"},{"line_number":5732,"context_line":"                self._aux_backend_helpers.delete_rc_volume("},{"line_number":5733,"context_line":"                    volume.name, target_vol\u003dTrue, force_unmap\u003dforce_unmap)"},{"line_number":5734,"context_line":"                volumes_model_update.append("},{"line_number":5735,"context_line":"                    {\u0027id\u0027: volume.id, \u0027status\u0027: \u0027deleted\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_b47c3973","line":5732,"in_reply_to":"9f560f44_de7ac821","updated":"2020-08-12 06:01:54.000000000","message":"This property is not accessible to delete_rc_volume since it is a storwizeHelpers function. We need to make more changes after driver initialization to access that property directly from delete_rc_volume.","commit_id":"d12a13c52cd567c65501f0b8fc71f0afefc64a2e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"30e341f6adb8baae2cfbb230f968cf731e1b4de3","unresolved":false,"context_lines":[{"line_number":2217,"context_line":"                storwize_const.REPLICA_CHG_VOL_PREFIX + vol_name,"},{"line_number":2218,"context_line":"                force_unmap\u003dforce_unmap,"},{"line_number":2219,"context_line":"                force_delete\u003dFalse)"},{"line_number":2220,"context_line":"            # We want to retain the aux volume after retyping"},{"line_number":2221,"context_line":"            # from mirror to non mirror storage template or"},{"line_number":2222,"context_line":"            # on delete of the primary volume based on user\u0027s"},{"line_number":2223,"context_line":"            # choice of config value for storwize_svc_retain_aux_volume."}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_9cdc37e2","line":2220,"range":{"start_line":2220,"start_character":25,"end_line":2220,"end_character":31},"updated":"2020-09-22 11:01:04.000000000","message":"retain/remove","commit_id":"3b0e9e0cda21b40455f0ba7f5c2ed361c61a72fc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"30e341f6adb8baae2cfbb230f968cf731e1b4de3","unresolved":false,"context_lines":[{"line_number":2217,"context_line":"                storwize_const.REPLICA_CHG_VOL_PREFIX + vol_name,"},{"line_number":2218,"context_line":"                force_unmap\u003dforce_unmap,"},{"line_number":2219,"context_line":"                force_delete\u003dFalse)"},{"line_number":2220,"context_line":"            # We want to retain the aux volume after retyping"},{"line_number":2221,"context_line":"            # from mirror to non mirror storage template or"},{"line_number":2222,"context_line":"            # on delete of the primary volume based on user\u0027s"},{"line_number":2223,"context_line":"            # choice of config value for storwize_svc_retain_aux_volume."}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_dcf34f72","line":2220,"range":{"start_line":2220,"start_character":53,"end_line":2220,"end_character":61},"updated":"2020-09-22 11:01:04.000000000","message":"retyping of primary volume","commit_id":"3b0e9e0cda21b40455f0ba7f5c2ed361c61a72fc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"30e341f6adb8baae2cfbb230f968cf731e1b4de3","unresolved":false,"context_lines":[{"line_number":2222,"context_line":"            # on delete of the primary volume based on user\u0027s"},{"line_number":2223,"context_line":"            # choice of config value for storwize_svc_retain_aux_volume."},{"line_number":2224,"context_line":"            # Default value is False."},{"line_number":2225,"context_line":"            if (retain_aux_volume is False and target_vol) or not target_vol:"},{"line_number":2226,"context_line":"                self.delete_vdisk(vol_name,"},{"line_number":2227,"context_line":"                                  force_unmap\u003dforce_unmap,"},{"line_number":2228,"context_line":"                                  force_delete\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_bcf81b4a","line":2225,"range":{"start_line":2225,"start_character":16,"end_line":2225,"end_character":42},"updated":"2020-09-22 11:01:04.000000000","message":"better to change this with\nnot retain_aux_volume","commit_id":"3b0e9e0cda21b40455f0ba7f5c2ed361c61a72fc"}]}