)]}'
{"cinder/image/image_utils.py":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"52c6493505385c688a4414f5baf9fd6f33d33c21","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                default\u003dTrue,"},{"line_number":65,"context_line":"                help\u003d\u0027When possible, compress images uploaded \u0027"},{"line_number":66,"context_line":"                \u0027to the image service\u0027),"},{"line_number":67,"context_line":"    cfg.IntOpt(\u0027image_conversion_cpu_limit\u0027,"},{"line_number":68,"context_line":"               default\u003d60,"},{"line_number":69,"context_line":"               help\u003d\u0027CPU time limit in seconds for \"qemu-img info\" calls\u0027),"},{"line_number":70,"context_line":"    cfg.IntOpt(\u0027image_conversion_address_space_limit\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_5c2bff2e","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":42},"updated":"2020-11-03 15:54:45.000000000","message":"Is it feasible to rename this to \"image_info_cpu_limit\"?","commit_id":"0e7362dfc64efb2c089043405edf7c99b9af87ee"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"d5d49f715b8b6b1b0d670f36f7ee3db83d106008","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                default\u003dTrue,"},{"line_number":65,"context_line":"                help\u003d\u0027When possible, compress images uploaded \u0027"},{"line_number":66,"context_line":"                \u0027to the image service\u0027),"},{"line_number":67,"context_line":"    cfg.IntOpt(\u0027image_conversion_cpu_limit\u0027,"},{"line_number":68,"context_line":"               default\u003d60,"},{"line_number":69,"context_line":"               help\u003d\u0027CPU time limit in seconds for \"qemu-img info\" calls\u0027),"},{"line_number":70,"context_line":"    cfg.IntOpt(\u0027image_conversion_address_space_limit\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_c2806e49","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":42},"in_reply_to":"1f621f24_1775b4cb","updated":"2020-11-11 12:32:39.000000000","message":"Thanks for the detailed explanation, Brian.\n\nLet\u0027s wait for Eric\u0027s decision.","commit_id":"0e7362dfc64efb2c089043405edf7c99b9af87ee"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"28f28002016fc2a566d9189a65972f5f316d6120","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                default\u003dTrue,"},{"line_number":65,"context_line":"                help\u003d\u0027When possible, compress images uploaded \u0027"},{"line_number":66,"context_line":"                \u0027to the image service\u0027),"},{"line_number":67,"context_line":"    cfg.IntOpt(\u0027image_conversion_cpu_limit\u0027,"},{"line_number":68,"context_line":"               default\u003d60,"},{"line_number":69,"context_line":"               help\u003d\u0027CPU time limit in seconds for \"qemu-img info\" calls\u0027),"},{"line_number":70,"context_line":"    cfg.IntOpt(\u0027image_conversion_address_space_limit\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_1775b4cb","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":42},"in_reply_to":"1f621f24_5c2bff2e","updated":"2020-11-06 17:58:54.000000000","message":"Yes, we can redefine the options like this:\n\n    cfg.IntOpt(\u0027image_qemu_img_info_cpu_limit\u0027,\n               deprecated_name\u003d\u0027image_conversion_cpu_limit\u0027,\n               deprecated_since\u003d\u0027Wallaby\u0027,\n               default\u003d60,\n               help\u003d\u0027CPU time limit in seconds for \"qemu-img info\" calls\u0027),\n    cfg.IntOpt(\u0027image_qemu_img_info_address_space_limit\u0027,\n               deprecated_name\u003d\u0027image_conversion_address_space_limit\u0027,\n               deprecated_since\u003d\u0027Wallaby\u0027,\n               default\u003d1,\n               help\u003d\u0027Address space limit in GB for \"qemu-img info\" calls\u0027),\n\noslo.config will look for the old names if the new ones aren\u0027t found, and if they are in the config file, it will log a message the first time they are accessed.  The generated config file will show this:\n\n    # CPU time limit in seconds for \"qemu-img info\" calls (integer value)\n    # Deprecated group/name - [DEFAULT]/image_conversion_cpu_limit\n    #image_qemu_img_info_cpu_limit \u003d 60\n\n    # Address space limit in GB for \"qemu-img info\" calls (integer value)\n    # Deprecated group/name - [DEFAULT]/image_conversion_address_space_limit\n    #image_qemu_img_info_address_space_limit \u003d 1\n\nThe deprecated_since doesn\u0027t really do anything, but is there for us to know when to remove the deprecated names (if we want to do that).  Of course, we will have to change to using the new names in our code (or else we will cause the deprecation message to be logged).\n\nAnother possibility is to add advanced\u003dTrue to the option definitions.  Then what happens is the options are moved to the end of the \"# from cinder\" section and look like this:\n\n    # CPU time limit in seconds for \"qemu-img info\" calls (integer value)\n    # Deprecated group/name - [DEFAULT]/image_conversion_cpu_limit\n    # Advanced Option: intended for advanced users and not used\n    # by the majority of users, and might have a significant\n    # effect on stability and/or performance.\n    #image_qemu_img_info_cpu_limit \u003d 60\n    \n    # Address space limit in GB for \"qemu-img info\" calls (integer value)\n    # Deprecated group/name - [DEFAULT]/image_conversion_address_space_limit\n    # Advanced Option: intended for advanced users and not used\n    # by the majority of users, and might have a significant\n    # effect on stability and/or performance.\n    #image_qemu_img_info_address_space_limit \u003d 1\n\nOr we could keep the old names but make them \"advanced\" with the new help text.  I think Eric\u0027s aim here is to keep the options available so support can tell operators to change them, but we don\u0027t want people monkeying with them thinking that they do something other than what they do.  So I would be OK with changing the help text, marking them advanced, and keeping the names if that\u0027s what Eric thinks best.","commit_id":"0e7362dfc64efb2c089043405edf7c99b9af87ee"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"52c6493505385c688a4414f5baf9fd6f33d33c21","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    cfg.IntOpt(\u0027image_conversion_cpu_limit\u0027,"},{"line_number":68,"context_line":"               default\u003d60,"},{"line_number":69,"context_line":"               help\u003d\u0027CPU time limit in seconds for \"qemu-img info\" calls\u0027),"},{"line_number":70,"context_line":"    cfg.IntOpt(\u0027image_conversion_address_space_limit\u0027,"},{"line_number":71,"context_line":"               default\u003d1,"},{"line_number":72,"context_line":"               help\u003d\u0027Address space limit in GB for \"qemu-img info\" calls\u0027),"},{"line_number":73,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_9c1c7714","line":70,"range":{"start_line":70,"start_character":16,"end_line":70,"end_character":52},"updated":"2020-11-03 15:54:45.000000000","message":"and this to \"image_info_address_space_limit\"?","commit_id":"0e7362dfc64efb2c089043405edf7c99b9af87ee"}]}