)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"bf0a78abfac839f083c3979654798bcfed225f0f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     GirishChilukuri \u003cgirish.chilukuri@ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-08-25 12:36:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Storwize]:Datareduction pool call optimisation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Data_reduction is a pool specific property, this property"},{"line_number":10,"context_line":"should be saved for a specific pool during intialisation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_2cab3088","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"updated":"2020-09-22 19:45:35.000000000","message":"Please either add the missing \u0027[\u0027 or remove the extra \u0027]\u0027","commit_id":"e96e3205a4f16a6ccbd151132a058930cbfed3eb"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"1039fa4b7b9c641d307e937668765534c5291b32","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     GirishChilukuri \u003cgirish.chilukuri@ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-08-25 12:36:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Storwize]:Datareduction pool call optimisation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Data_reduction is a pool specific property, this property"},{"line_number":10,"context_line":"should be saved for a specific pool during intialisation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_439a656e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"in_reply_to":"9f560f44_2cab3088","updated":"2020-09-25 21:02:31.000000000","message":"Added the missing \u0027[\u0027","commit_id":"e96e3205a4f16a6ccbd151132a058930cbfed3eb"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"bf0a78abfac839f083c3979654798bcfed225f0f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Storwize]:Datareduction pool call optimisation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Data_reduction is a pool specific property, this property"},{"line_number":10,"context_line":"should be saved for a specific pool during intialisation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"With this calls to get_pool_attrs can be avoided which are done"},{"line_number":13,"context_line":"during each create_vdisk to check if pool is a data_reduction_pool."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_6c90884f","line":10,"range":{"start_line":10,"start_character":43,"end_line":10,"end_character":56},"updated":"2020-09-22 19:45:35.000000000","message":"initialisation","commit_id":"e96e3205a4f16a6ccbd151132a058930cbfed3eb"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"1039fa4b7b9c641d307e937668765534c5291b32","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Storwize]:Datareduction pool call optimisation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Data_reduction is a pool specific property, this property"},{"line_number":10,"context_line":"should be saved for a specific pool during intialisation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"With this calls to get_pool_attrs can be avoided which are done"},{"line_number":13,"context_line":"during each create_vdisk to check if pool is a data_reduction_pool."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_037d0d1b","line":10,"range":{"start_line":10,"start_character":43,"end_line":10,"end_character":56},"in_reply_to":"9f560f44_6c90884f","updated":"2020-09-25 21:02:31.000000000","message":"corrected the typo.","commit_id":"e96e3205a4f16a6ccbd151132a058930cbfed3eb"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"bf0a78abfac839f083c3979654798bcfed225f0f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Data_reduction is a pool specific property, this property"},{"line_number":10,"context_line":"should be saved for a specific pool during intialisation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"With this calls to get_pool_attrs can be avoided which are done"},{"line_number":13,"context_line":"during each create_vdisk to check if pool is a data_reduction_pool."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"closes bug: #1890591"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_6c9ec854","line":12,"range":{"start_line":12,"start_character":9,"end_line":12,"end_character":10},"updated":"2020-09-22 19:45:35.000000000","message":"I believe you need a comma here.\n\nOr rephrase it to something like \"This reduces the calls to get_pool_attrs everytime create_vdisk is called, in order to check if pool is a data_reduction_pool.\"","commit_id":"e96e3205a4f16a6ccbd151132a058930cbfed3eb"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"1039fa4b7b9c641d307e937668765534c5291b32","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Data_reduction is a pool specific property, this property"},{"line_number":10,"context_line":"should be saved for a specific pool during intialisation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"With this calls to get_pool_attrs can be avoided which are done"},{"line_number":13,"context_line":"during each create_vdisk to check if pool is a data_reduction_pool."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"closes bug: #1890591"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_e39c595c","line":12,"range":{"start_line":12,"start_character":9,"end_line":12,"end_character":10},"in_reply_to":"9f560f44_6c9ec854","updated":"2020-09-25 21:02:31.000000000","message":"Added comma.","commit_id":"e96e3205a4f16a6ccbd151132a058930cbfed3eb"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"7f26d8c39c6cf5b9ceff0840ea7326c862d8cf25","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     GirishChilukuri \u003cgirish.chilukuri@ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-25 20:31:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[SVF]:Pool information is not saved in stats"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize Family] Data_reduction is a pool specific property,"},{"line_number":10,"context_line":"this property should be saved for a specific pool during initialisation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_6c83ffcc","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":44},"updated":"2020-09-28 19:53:42.000000000","message":"This sounds like a issue report rather than a bugfix commit message. Something like \"Reduce slowness by caching pool information\" would be better.","commit_id":"a5b5fb5ae5f6c68336caa7097a8ccd0dbdad9172"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"7974139a3559cbf82775deb4da5f75c6cf3ce921","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     GirishChilukuri \u003cgirish.chilukuri@ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-25 20:31:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[SVF]:Pool information is not saved in stats"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize Family] Data_reduction is a pool specific property,"},{"line_number":10,"context_line":"this property should be saved for a specific pool during initialisation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_150b5522","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":44},"in_reply_to":"9f560f44_6c83ffcc","updated":"2020-09-29 17:53:56.000000000","message":"Hi Lucio,\nI have Update the commit message.","commit_id":"a5b5fb5ae5f6c68336caa7097a8ccd0dbdad9172"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"bf0a78abfac839f083c3979654798bcfed225f0f","unresolved":false,"context_lines":[{"line_number":5537,"context_line":"        self._set_flag(\u0027reserved_percentage\u0027, 25)"},{"line_number":5538,"context_line":"        self._set_flag(\u0027storwize_svc_multihostmap_enabled\u0027, True)"},{"line_number":5539,"context_line":"        self._set_flag(\u0027storwize_svc_vol_rsize\u0027, rsize)"},{"line_number":5540,"context_line":"        stats \u003d self.driver.get_volume_stats(True)"},{"line_number":5541,"context_line":"        for each_pool in stats[\u0027pools\u0027]:"},{"line_number":5542,"context_line":"            self.assertIn(each_pool[\u0027pool_name\u0027],"},{"line_number":5543,"context_line":"                          self._def_flags[\u0027storwize_svc_volpool_name\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_71234106","line":5540,"range":{"start_line":5540,"start_character":45,"end_line":5540,"end_character":49},"updated":"2020-09-22 19:45:35.000000000","message":"any reason for adding this?","commit_id":"e96e3205a4f16a6ccbd151132a058930cbfed3eb"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"1039fa4b7b9c641d307e937668765534c5291b32","unresolved":false,"context_lines":[{"line_number":5537,"context_line":"        self._set_flag(\u0027reserved_percentage\u0027, 25)"},{"line_number":5538,"context_line":"        self._set_flag(\u0027storwize_svc_multihostmap_enabled\u0027, True)"},{"line_number":5539,"context_line":"        self._set_flag(\u0027storwize_svc_vol_rsize\u0027, rsize)"},{"line_number":5540,"context_line":"        stats \u003d self.driver.get_volume_stats(True)"},{"line_number":5541,"context_line":"        for each_pool in stats[\u0027pools\u0027]:"},{"line_number":5542,"context_line":"            self.assertIn(each_pool[\u0027pool_name\u0027],"},{"line_number":5543,"context_line":"                          self._def_flags[\u0027storwize_svc_volpool_name\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_43c5455b","line":5540,"range":{"start_line":5540,"start_character":45,"end_line":5540,"end_character":49},"in_reply_to":"9f560f44_71234106","updated":"2020-09-25 21:02:31.000000000","message":"Initial behavior of SVC driver is pool information is not saved in stats. With this code change pool information is saved in stats. The purpose of this test case is to set the new values for reseved_percentage, storwize_svc_vol_rsize flag and get the updated values. \n\nget_volume_stats will return the stats information which already saved, if True is not passed. To get the updated values True is passed to get_volume_stats","commit_id":"e96e3205a4f16a6ccbd151132a058930cbfed3eb"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"bf0a78abfac839f083c3979654798bcfed225f0f","unresolved":false,"context_lines":[{"line_number":8384,"context_line":""},{"line_number":8385,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":8386,"context_line":"                       \u0027is_data_reduction_pool\u0027)"},{"line_number":8387,"context_line":"    def test_is_volume_type_dr_pools_1(self, is_data_reduction_pool):"},{"line_number":8388,"context_line":"        is_data_reduction_pool.return_value \u003d True"},{"line_number":8389,"context_line":"        pool \u003d \u0027openstack\u0027"},{"line_number":8390,"context_line":"        opts \u003d {\u0027mirror_pool\u0027: \u0027openstack2\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ccc43463","line":8387,"range":{"start_line":8387,"start_character":36,"end_line":8387,"end_character":38},"updated":"2020-09-22 19:45:35.000000000","message":"nit: you may also use ddt to reduce repeated code.","commit_id":"e96e3205a4f16a6ccbd151132a058930cbfed3eb"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"bf0a78abfac839f083c3979654798bcfed225f0f","unresolved":false,"context_lines":[{"line_number":8384,"context_line":""},{"line_number":8385,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":8386,"context_line":"                       \u0027is_data_reduction_pool\u0027)"},{"line_number":8387,"context_line":"    def test_is_volume_type_dr_pools_1(self, is_data_reduction_pool):"},{"line_number":8388,"context_line":"        is_data_reduction_pool.return_value \u003d True"},{"line_number":8389,"context_line":"        pool \u003d \u0027openstack\u0027"},{"line_number":8390,"context_line":"        opts \u003d {\u0027mirror_pool\u0027: \u0027openstack2\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0cbbcce4","line":8387,"range":{"start_line":8387,"start_character":36,"end_line":8387,"end_character":38},"updated":"2020-09-22 19:45:35.000000000","message":"nit: you may assign meaningful names to the tests (e.g. test_is_volume_type_dr_pools_dr, test_is_volume_type_dr_pools_nodr,  test_is_volume_type_dr_pools_hyperswap_dr, test_is_volume_type_dr_pools_hyperswap_nodr).\n\nIt makes it easier to investigate when someone breaks the feature in the future.","commit_id":"e96e3205a4f16a6ccbd151132a058930cbfed3eb"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"1039fa4b7b9c641d307e937668765534c5291b32","unresolved":false,"context_lines":[{"line_number":8384,"context_line":""},{"line_number":8385,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":8386,"context_line":"                       \u0027is_data_reduction_pool\u0027)"},{"line_number":8387,"context_line":"    def test_is_volume_type_dr_pools_1(self, is_data_reduction_pool):"},{"line_number":8388,"context_line":"        is_data_reduction_pool.return_value \u003d True"},{"line_number":8389,"context_line":"        pool \u003d \u0027openstack\u0027"},{"line_number":8390,"context_line":"        opts \u003d {\u0027mirror_pool\u0027: \u0027openstack2\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0397cd91","line":8387,"range":{"start_line":8387,"start_character":36,"end_line":8387,"end_character":38},"in_reply_to":"9f560f44_0cbbcce4","updated":"2020-09-25 21:02:31.000000000","message":"Assigned meaningful names to tests.","commit_id":"e96e3205a4f16a6ccbd151132a058930cbfed3eb"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"1039fa4b7b9c641d307e937668765534c5291b32","unresolved":false,"context_lines":[{"line_number":8384,"context_line":""},{"line_number":8385,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":8386,"context_line":"                       \u0027is_data_reduction_pool\u0027)"},{"line_number":8387,"context_line":"    def test_is_volume_type_dr_pools_1(self, is_data_reduction_pool):"},{"line_number":8388,"context_line":"        is_data_reduction_pool.return_value \u003d True"},{"line_number":8389,"context_line":"        pool \u003d \u0027openstack\u0027"},{"line_number":8390,"context_line":"        opts \u003d {\u0027mirror_pool\u0027: \u0027openstack2\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_633969a1","line":8387,"range":{"start_line":8387,"start_character":36,"end_line":8387,"end_character":38},"in_reply_to":"9f560f44_ccc43463","updated":"2020-09-25 21:02:31.000000000","message":"Used ddt to reduce repeated code.","commit_id":"e96e3205a4f16a6ccbd151132a058930cbfed3eb"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"8bbd28031ce7aa548583492263221553cc5e2821","unresolved":false,"context_lines":[{"line_number":5602,"context_line":"            data[\u0027replication_enabled\u0027] \u003d self._replica_enabled"},{"line_number":5603,"context_line":"            data[\u0027replication_targets\u0027] \u003d self._get_replication_targets()"},{"line_number":5604,"context_line":"            data[\u0027consistent_group_replication_enabled\u0027] \u003d True"},{"line_number":5605,"context_line":"        self._stats \u003d data"},{"line_number":5606,"context_line":""},{"line_number":5607,"context_line":"    def _build_pool_stats(self, pool):"},{"line_number":5608,"context_line":"        \"\"\"Build pool status\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_daceef81","line":5605,"updated":"2020-08-18 04:45:42.000000000","message":"during create_vdisk_param if the volume_type pool matches with the pool data reduction in _stats then mark is_data_reduction as true if not found then only refetch the get_pool_attrs","commit_id":"4e3d43f83c46cc5dc0e62d43389f9a60f4c3f4f5"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"8bbd28031ce7aa548583492263221553cc5e2821","unresolved":false,"context_lines":[{"line_number":5631,"context_line":"                           storwize_svc_multihostmap_enabled)"},{"line_number":5632,"context_line":"            backend_state \u003d (\u0027up\u0027 if pool_data[\u0027status\u0027] \u003d\u003d \u0027online\u0027 else"},{"line_number":5633,"context_line":"                             \u0027down\u0027)"},{"line_number":5634,"context_line":"            pool_stats \u003d {"},{"line_number":5635,"context_line":"                \u0027pool_name\u0027: pool_data[\u0027name\u0027],"},{"line_number":5636,"context_line":"                \u0027total_capacity_gb\u0027: total_capacity_gb,"},{"line_number":5637,"context_line":"                \u0027free_capacity_gb\u0027: free_capacity_gb,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_faead3d5","line":5634,"updated":"2020-08-18 04:45:42.000000000","message":"add the data_reduction attribute in the pool stats","commit_id":"4e3d43f83c46cc5dc0e62d43389f9a60f4c3f4f5"}]}