)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8d0013a65418523d1c7344f655fd3d6850b4bb4c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"reduce the performance impact of volume zeroing. Note that this may"},{"line_number":11,"context_line":"cause volume clearing processes to get backed up on  a busy system, use"},{"line_number":12,"context_line":"with care."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2d556f57aaca8a8ccc6f0f767f1cec28c3f9bc86"},{"line_number":15,"context_line":"Implements: when-deleting-volume-dd-performance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAU3%2F%2FyuI%3D","line":13,"updated":"2014-02-24 19:07:00.000000000","message":"Need DocImpact","commit_id":"c73159ca33f04c956845e97829693053425e81e7"}],"cinder/volume/driver.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"cd8ee485f6b8a47040b54e52cc0d851d5203716d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"               default\u003dNone,"},{"line_number":78,"context_line":"               help\u003d\u0027The flag to pass to ionice to alter the i/o priority \u0027"},{"line_number":79,"context_line":"                    \u0027of the process used to zero a volume after deletion, \u0027"},{"line_number":80,"context_line":"                    \u0027for example \"-c3\" for idle only priority\u0027),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027iscsi_helper\u0027,"},{"line_number":82,"context_line":"               default\u003d\u0027tgtadm\u0027,"},{"line_number":83,"context_line":"               help\u003d\u0027iscsi target user-land tool to use\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2Bhl0%3D","line":80,"updated":"2014-02-20 17:59:55.000000000","message":"End with period.","commit_id":"e2ae4239863be5468209b5bbee1c0d4dac7da4ec"}],"cinder/volume/utils.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"cd8ee485f6b8a47040b54e52cc0d851d5203716d","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    if ionice is not None:"},{"line_number":185,"context_line":"        cmd.insert(0, \u0027ionice\u0027)"},{"line_number":186,"context_line":"        cmd.insert(1, ionice)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    # Perform the copy"},{"line_number":189,"context_line":"    execute(*cmd, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2Bhj0%3D","line":186,"updated":"2014-02-20 17:59:55.000000000","message":"Consider rewriting these two lines to make it more clear:\n cmd \u003d [\u0027ionice\u0027, ionice] + cmd\n or\n cmd[:0] \u003d [\u0027ionice\u0027, ionice]\n or anything else you prefer that is clearer","commit_id":"e2ae4239863be5468209b5bbee1c0d4dac7da4ec"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8d0013a65418523d1c7344f655fd3d6850b4bb4c","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        volume_clear_size \u003d volume_size"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    if volume_clear_ionice is None:"},{"line_number":204,"context_line":"        volume_clear_ionice \u003d CONF.volume_clear_ionice"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    LOG.info(_(\"Performing secure delete on volume: %s\") % volume_path)"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FyuY%3D","line":204,"updated":"2014-02-24 19:07:00.000000000","message":"This may be a bit anal, but I am not a fan of having config options that can be passed in with no checking.  Would it be possible to make sure that the user has passed one of -c0, -c1, -c2 or -c3 and in not throw an invalid input exception.  I think that is better than possibly hitting a weird process execution error that might not be clear to the user.","commit_id":"c73159ca33f04c956845e97829693053425e81e7"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"635ab93941d20cc24e558164bda4fed19728b061","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        volume_clear_size \u003d volume_size"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    if volume_clear_ionice is None:"},{"line_number":204,"context_line":"        volume_clear_ionice \u003d CONF.volume_clear_ionice"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    LOG.info(_(\"Performing secure delete on volume: %s\") % volume_path)"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2Fl68%3D","line":204,"in_reply_to":"AAAAU3%2F%2FmGk%3D","updated":"2014-02-25 19:02:10.000000000","message":"Vote in the channel was to allow admins to shoot themselves in the foot... we can always add more later","commit_id":"c73159ca33f04c956845e97829693053425e81e7"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"58ea21cd1e310ac9ffbd3f4e80745fb431439037","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        volume_clear_size \u003d volume_size"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    if volume_clear_ionice is None:"},{"line_number":204,"context_line":"        volume_clear_ionice \u003d CONF.volume_clear_ionice"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    LOG.info(_(\"Performing secure delete on volume: %s\") % volume_path)"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FmGk%3D","line":204,"in_reply_to":"AAAAU3%2F%2FmRo%3D","updated":"2014-02-25 18:47:51.000000000","message":"I\u0027m with Jay on this one.  I prefer checking conf options on driver init and barfing if something\u0027s wrong.  There are dumb admins, but also ones that just make a typo here and there :)","commit_id":"c73159ca33f04c956845e97829693053425e81e7"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"4437e00b024878d0a6f014fc5d2cc40b67cade1b","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        volume_clear_size \u003d volume_size"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    if volume_clear_ionice is None:"},{"line_number":204,"context_line":"        volume_clear_ionice \u003d CONF.volume_clear_ionice"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    LOG.info(_(\"Performing secure delete on volume: %s\") % volume_path)"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2FmRo%3D","line":204,"in_reply_to":"AAAAU3%2F%2FyuY%3D","updated":"2014-02-25 18:37:01.000000000","message":"Admin conceivably might also want to set -c and / or -i... I\u0027m fine with letting a dumb admin shoot themselves in the foot but I\u0027ll canvas opinions....","commit_id":"c73159ca33f04c956845e97829693053425e81e7"}]}