)]}'
{"cinder/volume/drivers/nimble.py":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"858f2033df707f63ccaee1784853d16643afe302","unresolved":false,"context_lines":[{"line_number":728,"context_line":"            except AttributeError:"},{"line_number":729,"context_line":"                pass"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"            if attachment_list is not None and len(attachment_list) \u003e 1:"},{"line_number":732,"context_line":"                LOG.info(\"Volume %(volume)s is attached to multiple \""},{"line_number":733,"context_line":"                         \"instances on host %(host_name)s, \""},{"line_number":734,"context_line":"                         \"skip terminate volume connection\","}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_a6f046dc","side":"PARENT","line":731,"range":{"start_line":731,"start_character":46,"end_line":731,"end_character":72},"updated":"2020-09-17 20:27:00.000000000","message":"Is it really OK to remove this condition?\n\nSeems that it will consider a volume as multiattached, even when len(attachment_list) \u003d\u003d 1.","commit_id":"fb7edff4d05a057a77703f7b0c4f356fd185b175"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"af2622653148b84c89a475b12997f1a4ecacb294","unresolved":false,"context_lines":[{"line_number":728,"context_line":"            except AttributeError:"},{"line_number":729,"context_line":"                pass"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"            if attachment_list is not None and len(attachment_list) \u003e 1:"},{"line_number":732,"context_line":"                LOG.info(\"Volume %(volume)s is attached to multiple \""},{"line_number":733,"context_line":"                         \"instances on host %(host_name)s, \""},{"line_number":734,"context_line":"                         \"skip terminate volume connection\","}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_8181a2a3","line":731,"updated":"2020-09-18 12:20:18.000000000","message":"I would still make this:\n\n    if attachment_list and len(attachment_list) \u003e 1\n\nBut that\u0027s really just a personal preference.","commit_id":"3424be870698673c55fd0788416bd0770e22b7ff"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"c1ea0ff6c6bd3809a88760596bd28672da50b4b9","unresolved":false,"context_lines":[{"line_number":728,"context_line":"            except AttributeError:"},{"line_number":729,"context_line":"                pass"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"            if attachment_list is not None and len(attachment_list) \u003e 1:"},{"line_number":732,"context_line":"                LOG.info(\"Volume %(volume)s is attached to multiple \""},{"line_number":733,"context_line":"                         \"instances on host %(host_name)s, \""},{"line_number":734,"context_line":"                         \"skip terminate volume connection\","}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_b5a05c93","line":731,"in_reply_to":"9f560f44_8181a2a3","updated":"2020-09-18 15:24:44.000000000","message":"I asked Ajitha and he said it\u0027s ok to leave it this way.\n\nI also think it\u0027s more pythonic to omit `is not None`, but it\u0027s not mandatory.\n\nThere\u0027re several occurences of such conditions in this file. It may be addressed in another patch, if there\u0027s an interest to do so.","commit_id":"3424be870698673c55fd0788416bd0770e22b7ff"}],"doc/source/configuration/block-storage/drivers/nimble-volume-driver.rst":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f20d924c0727b2021c5b83a13111f1ac52ad0554","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  PERF_POL_NAME is the name of a performance policy which exists on the"},{"line_number":129,"context_line":"  Nimble array and should be enabled for every volume in a volume type."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  .. note::"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"     When upgrading to Openstack deployment to Victoria or later, do unset ``nimble:multi-initiator`` extra-spec and set ``multiattach\u003d\u0027\u003cis\u003e True\u0027``."},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_6d33b4f7","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":2},"updated":"2020-09-17 12:59:40.000000000","message":"This indentation causes the note to also be blockquoted in the resulting HTML output. Dedent this line so there is no leading space and it should be fine.","commit_id":"a643f72958f016fe71de2dc863d9108b4ef7da99"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f20d924c0727b2021c5b83a13111f1ac52ad0554","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  .. note::"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"     When upgrading to Openstack deployment to Victoria or later, do unset ``nimble:multi-initiator`` extra-spec and set ``multiattach\u003d\u0027\u003cis\u003e True\u0027``."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"nimble:dedupe\u0027\u003d\u0027true\u0027"},{"line_number":136,"context_line":"  Used to enable dedupe support for a volume-type."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_ad4aec57","line":133,"updated":"2020-09-17 12:59:40.000000000","message":"Would be good to break this line into multiple so it is not so long.","commit_id":"a643f72958f016fe71de2dc863d9108b4ef7da99"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"91d83856853c52ad684564a8d7790812fd6f4576","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":".. note::"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    When upgrading to Openstack deployment to Victoria or later,"},{"line_number":134,"context_line":"    do unset ``nimble:multi-initiator`` extra-spec and set ``multiattach\u003d\u0027\u003cis\u003e True\u0027``."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"nimble:dedupe\u0027\u003d\u0027true\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f560f44_0b2c9baa","line":133,"range":{"start_line":133,"start_character":22,"end_line":133,"end_character":31},"updated":"2020-09-17 20:01:10.000000000","message":"OpenStack","commit_id":"fc7cdcd917374956125e9e173c3bb9b951f43697"}]}