)]}'
{"cinder/scheduler/manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8dd29d719c3548970f99453ee33b0f000b5da9e5","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            self.backup_api.create_backup(context, backup)"},{"line_number":639,"context_line":"        except exception.ServiceNotFound:"},{"line_number":640,"context_line":"            self.db.volume_update(context, volume_id,"},{"line_number":641,"context_line":"                                  {\u0027status\u0027: volume[\u0027previous_status\u0027],"},{"line_number":642,"context_line":"                                   \u0027previous_status\u0027: volume[\u0027status\u0027]})"},{"line_number":643,"context_line":"            msg \u003d \"Service not found for creating backup.\""},{"line_number":644,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_51342b49","line":641,"range":{"start_line":641,"start_character":45,"end_line":641,"end_character":70},"updated":"2020-09-23 14:21:09.000000000","message":"nit: This is an ORM instance, it\u0027s better to use attribute notation:\n\n  volume.previous_status","commit_id":"4ee46fb437ecb6fb71dc01a9a76d7e0554260f6f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ee9272ca7937c46c4e35e44b3af577be441ea1a1","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            self.backup_api.create_backup(context, backup)"},{"line_number":639,"context_line":"        except exception.ServiceNotFound:"},{"line_number":640,"context_line":"            self.db.volume_update(context, volume_id,"},{"line_number":641,"context_line":"                                  {\u0027status\u0027: volume[\u0027previous_status\u0027],"},{"line_number":642,"context_line":"                                   \u0027previous_status\u0027: volume[\u0027status\u0027]})"},{"line_number":643,"context_line":"            msg \u003d \"Service not found for creating backup.\""},{"line_number":644,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_51b70b86","line":641,"range":{"start_line":641,"start_character":45,"end_line":641,"end_character":70},"in_reply_to":"9f560f44_51342b49","updated":"2020-09-23 14:28:18.000000000","message":"I use the same code style as in the rest of backup-related code for the consistency. IMO, we should change this in a follow-up patch across all the code","commit_id":"4ee46fb437ecb6fb71dc01a9a76d7e0554260f6f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"64c8b3efec89425ade4e2f68de92b1db0d34f53c","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            self.backup_api.create_backup(context, backup)"},{"line_number":639,"context_line":"        except exception.ServiceNotFound:"},{"line_number":640,"context_line":"            self.db.volume_update(context, volume_id,"},{"line_number":641,"context_line":"                                  {\u0027status\u0027: volume[\u0027previous_status\u0027],"},{"line_number":642,"context_line":"                                   \u0027previous_status\u0027: volume[\u0027status\u0027]})"},{"line_number":643,"context_line":"            msg \u003d \"Service not found for creating backup.\""},{"line_number":644,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_e41648a7","line":641,"range":{"start_line":641,"start_character":45,"end_line":641,"end_character":70},"in_reply_to":"9f560f44_51b70b86","updated":"2020-09-24 10:39:49.000000000","message":"I just think we should not be introducing additional technical debt if we can, that\u0027s all.","commit_id":"4ee46fb437ecb6fb71dc01a9a76d7e0554260f6f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8dd29d719c3548970f99453ee33b0f000b5da9e5","unresolved":false,"context_lines":[{"line_number":639,"context_line":"        except exception.ServiceNotFound:"},{"line_number":640,"context_line":"            self.db.volume_update(context, volume_id,"},{"line_number":641,"context_line":"                                  {\u0027status\u0027: volume[\u0027previous_status\u0027],"},{"line_number":642,"context_line":"                                   \u0027previous_status\u0027: volume[\u0027status\u0027]})"},{"line_number":643,"context_line":"            msg \u003d \"Service not found for creating backup.\""},{"line_number":644,"context_line":"            LOG.error(msg)"},{"line_number":645,"context_line":"            vol_utils.update_backup_error(backup, msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_b13ca730","line":642,"updated":"2020-09-23 14:21:09.000000000","message":"ditto","commit_id":"4ee46fb437ecb6fb71dc01a9a76d7e0554260f6f"}],"releasenotes/notes/bug-1896087-rollback-volume-status-bd04951f929bb88d.yaml":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"84c9eb7541185b1a27880de078dd5304248f8220","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Volume status will be rollbacked to the previous state if backup creation"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_efcab36b","line":1,"updated":"2020-09-23 17:12:23.000000000","message":"Please follow the format as in [0] to keep our release notes pretty [1].\n\n[0] https://review.opendev.org/#/c/746319/\n[1] https://docs.openstack.org/releasenotes/cinder/unreleased.html#bug-fixes","commit_id":"f7737e8348b1cf4cb3a71bd7e0df672bdacab354"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c18a125a18533b9df4bd98a43cfa507aebb82029","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Volume status will be rollbacked to the previous state if backup creation"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_0a72757c","line":1,"in_reply_to":"9f560f44_efcab36b","updated":"2020-09-23 17:54:04.000000000","message":"Done","commit_id":"f7737e8348b1cf4cb3a71bd7e0df672bdacab354"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f21bf5f6e254a842521743d7fbe276e4ca47885a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Volume status will be rollbacked to the previous state if backup creation"},{"line_number":5,"context_line":"    fails when backup service is not available"},{"line_number":6,"context_line":"    (`bug #1896087 \u003chttps://bugs.launchpad.net/cinder/+bug/1896087\u003e`_)"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_ead7414e","line":4,"range":{"start_line":4,"start_character":26,"end_line":4,"end_character":36},"updated":"2020-09-23 17:49:34.000000000","message":"\"rolled back\" would be more correct.","commit_id":"f7737e8348b1cf4cb3a71bd7e0df672bdacab354"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c18a125a18533b9df4bd98a43cfa507aebb82029","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Volume status will be rollbacked to the previous state if backup creation"},{"line_number":5,"context_line":"    fails when backup service is not available"},{"line_number":6,"context_line":"    (`bug #1896087 \u003chttps://bugs.launchpad.net/cinder/+bug/1896087\u003e`_)"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_aa59c9fd","line":4,"range":{"start_line":4,"start_character":26,"end_line":4,"end_character":36},"in_reply_to":"9f560f44_ead7414e","updated":"2020-09-23 17:54:04.000000000","message":"Done","commit_id":"f7737e8348b1cf4cb3a71bd7e0df672bdacab354"}]}