)]}'
{"cinder/volume/drivers/hpe/hpe_3par_iscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"967c3ebfe232ac6ba888b2a54e6a6f92e1aeea8b","unresolved":true,"context_lines":[{"line_number":141,"context_line":"        self.protocol \u003d \u0027iSCSI\u0027"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _do_setup(self, common):"},{"line_number":144,"context_line":"        client_obj \u003d common.client"},{"line_number":145,"context_line":"        is_primera \u003d client_obj.is_primera_array()"},{"line_number":146,"context_line":"        if is_primera:"},{"line_number":147,"context_line":"            LOG.error(\"For Primera, only FC is supported. \""},{"line_number":148,"context_line":"                      \"iSCSI cannot be used\")"},{"line_number":149,"context_line":"            raise NotImplementedError()"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        self.iscsi_ips \u003d {}"},{"line_number":152,"context_line":"        common.client_login()"}],"source_content_type":"text/x-python","patch_set":3,"id":"d4f3c057_4b8b299a","side":"PARENT","line":149,"range":{"start_line":144,"start_character":0,"end_line":149,"end_character":39},"updated":"2021-01-27 14:58:53.000000000","message":"Walter has mentioned that Primera iSCSI driver is most likely supported now thanks to changes on the storage side of things.\n\nIf that\u0027s the case, wouldn\u0027t it be best to check if the specific storage we are connecting to has that specific REST-API or firmware version installed and fail if it doesn\u0027t?\n\nOtherwise the driver may fail with unexpected errors, right?","commit_id":"918e913defa7dcfec58de752b85d922d6b01f905"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"22aa85134d5ebffdd3777ef1a3811c36f6278188","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        self.protocol \u003d \u0027iSCSI\u0027"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _do_setup(self, common):"},{"line_number":144,"context_line":"        client_obj \u003d common.client"},{"line_number":145,"context_line":"        is_primera \u003d client_obj.is_primera_array()"},{"line_number":146,"context_line":"        if is_primera:"},{"line_number":147,"context_line":"            LOG.error(\"For Primera, only FC is supported. \""},{"line_number":148,"context_line":"                      \"iSCSI cannot be used\")"},{"line_number":149,"context_line":"            raise NotImplementedError()"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        self.iscsi_ips \u003d {}"},{"line_number":152,"context_line":"        common.client_login()"}],"source_content_type":"text/x-python","patch_set":3,"id":"dc44e76d_1d527b90","side":"PARENT","line":149,"range":{"start_line":144,"start_character":0,"end_line":149,"end_character":39},"in_reply_to":"d4f3c057_4b8b299a","updated":"2021-01-30 10:59:32.000000000","message":"Done","commit_id":"918e913defa7dcfec58de752b85d922d6b01f905"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"93448e8d95d55b5493be4556b608508fb2f9b679","unresolved":true,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    VERSION \u003d \"4.0.5\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    # The name of the CI wiki page."},{"line_number":137,"context_line":"    CI_WIKI_NAME \u003d \"HPE_Storage_CI\""}],"source_content_type":"text/x-python","patch_set":3,"id":"f59b99c1_1c7417f0","line":134,"range":{"start_line":134,"start_character":3,"end_line":134,"end_character":21},"updated":"2021-01-27 21:23:26.000000000","message":"I think you should increment the driver version and update the version history.  You may want to refer to a HPE bulletin or something that indicates under what conditions Primera can be used with this driver.","commit_id":"9d4a069f5cacd2d6d758da78b990e9b4af5828d7"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"22aa85134d5ebffdd3777ef1a3811c36f6278188","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    VERSION \u003d \"4.0.5\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    # The name of the CI wiki page."},{"line_number":137,"context_line":"    CI_WIKI_NAME \u003d \"HPE_Storage_CI\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fec7ccc8_1d26d335","line":134,"range":{"start_line":134,"start_character":3,"end_line":134,"end_character":21},"in_reply_to":"f59b99c1_1c7417f0","updated":"2021-01-30 10:59:32.000000000","message":"Done","commit_id":"9d4a069f5cacd2d6d758da78b990e9b4af5828d7"}],"releasenotes/notes/hpe-3par-primera-add-iscsi-5af339643dfa0928.yaml":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"967c3ebfe232ac6ba888b2a54e6a6f92e1aeea8b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    HPE 3PAR Driver: For Primera backend, add support for iSCSI driver."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"35c3e270_e79e045c","line":4,"updated":"2021-01-27 14:58:53.000000000","message":"-1: Please indicate under what conditions it will work now (but didn\u0027t before): Firmware version, REST-API version, etc.","commit_id":"9d4a069f5cacd2d6d758da78b990e9b4af5828d7"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"22aa85134d5ebffdd3777ef1a3811c36f6278188","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    HPE 3PAR Driver: For Primera backend, add support for iSCSI driver."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fab6d621_b445d489","line":4,"in_reply_to":"35c3e270_e79e045c","updated":"2021-01-30 10:59:32.000000000","message":"Done","commit_id":"9d4a069f5cacd2d6d758da78b990e9b4af5828d7"}]}