)]}'
{"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"6c2c822dc9cd216a1cca409b1394509bb257dd78","unresolved":true,"context_lines":[{"line_number":1043,"context_line":"            hosts_map_info \u003d self.ssh.lsvdiskhostmap(volume_name)"},{"line_number":1044,"context_line":"            hosts_map_info_list \u003d list(hosts_map_info.select(\u0027host_name\u0027))"},{"line_number":1045,"context_line":"            if host_name and host_name in hosts_map_info_list:"},{"line_number":1046,"context_line":"                LOG.info(\"get_host_from_connector: hosts_map_info:\""},{"line_number":1047,"context_line":"                         \" %s\", hosts_map_info_list)"},{"line_number":1048,"context_line":"                LOG.info(\u0027Leave: get_host_from_connector: host %s.\u0027, host_name)"},{"line_number":1049,"context_line":"                return host_name"},{"line_number":1050,"context_line":"            elif host_name:"},{"line_number":1051,"context_line":"                LOG.info(\u0027get_host_from_connector: host %s not mapped \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"095f42c0_487daa92","line":1048,"range":{"start_line":1046,"start_character":0,"end_line":1048,"end_character":24},"updated":"2021-03-08 13:57:54.000000000","message":"These should be LOG.debug.","commit_id":"76eacc7637a24d911d872ae78a219ef871f493d1"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"966183da63133090c042b4e3291ec1c7cd236986","unresolved":true,"context_lines":[{"line_number":1043,"context_line":"            hosts_map_info \u003d self.ssh.lsvdiskhostmap(volume_name)"},{"line_number":1044,"context_line":"            hosts_map_info_list \u003d list(hosts_map_info.select(\u0027host_name\u0027))"},{"line_number":1045,"context_line":"            if host_name and host_name in hosts_map_info_list:"},{"line_number":1046,"context_line":"                LOG.info(\"get_host_from_connector: hosts_map_info:\""},{"line_number":1047,"context_line":"                         \" %s\", hosts_map_info_list)"},{"line_number":1048,"context_line":"                LOG.info(\u0027Leave: get_host_from_connector: host %s.\u0027, host_name)"},{"line_number":1049,"context_line":"                return host_name"},{"line_number":1050,"context_line":"            elif host_name:"},{"line_number":1051,"context_line":"                LOG.info(\u0027get_host_from_connector: host %s not mapped \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"2d257ab8_49c559d1","line":1048,"range":{"start_line":1046,"start_character":0,"end_line":1048,"end_character":24},"in_reply_to":"095f42c0_487daa92","updated":"2021-03-08 14:57:43.000000000","message":"Addressed review comments.","commit_id":"76eacc7637a24d911d872ae78a219ef871f493d1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0a9f67055260efcd5f7a6f4fed92f1cce24a6cf2","unresolved":true,"context_lines":[{"line_number":1039,"context_line":"                if host_name:"},{"line_number":1040,"context_line":"                    break"},{"line_number":1041,"context_line":""},{"line_number":1042,"context_line":"        if volume_name:"},{"line_number":1043,"context_line":"            hosts_map_info \u003d self.ssh.lsvdiskhostmap(volume_name)"},{"line_number":1044,"context_line":"            hosts_map_info_list \u003d list(hosts_map_info.select(\u0027host_name\u0027))"},{"line_number":1045,"context_line":"            if host_name and host_name in hosts_map_info_list:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ad5bb5cd_f001f8c0","line":1042,"range":{"start_line":1042,"start_character":8,"end_line":1042,"end_character":23},"updated":"2021-03-16 22:35:56.000000000","message":"would it make sense to make this condition:\n\n    if host_name and volume_name:\n\nbecause if you make it through the above loop, and host_name is still None,  you don\u0027t need to do any of the work at lines 1043 and 1044","commit_id":"99079be503249015b076463b295418ff7ba8041e"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"88e6ae066cec372256262a639e428e86e78eed12","unresolved":true,"context_lines":[{"line_number":1039,"context_line":"                if host_name:"},{"line_number":1040,"context_line":"                    break"},{"line_number":1041,"context_line":""},{"line_number":1042,"context_line":"        if volume_name:"},{"line_number":1043,"context_line":"            hosts_map_info \u003d self.ssh.lsvdiskhostmap(volume_name)"},{"line_number":1044,"context_line":"            hosts_map_info_list \u003d list(hosts_map_info.select(\u0027host_name\u0027))"},{"line_number":1045,"context_line":"            if host_name and host_name in hosts_map_info_list:"}],"source_content_type":"text/x-python","patch_set":3,"id":"881215f9_f1c09bce","line":1042,"range":{"start_line":1042,"start_character":8,"end_line":1042,"end_character":23},"in_reply_to":"ad5bb5cd_f001f8c0","updated":"2021-03-17 07:58:20.000000000","message":"it is a good idea to check for hostname at line 1042 along with volume_name, This also skips check for hostname at lines 1045 and 1050.\naddressed the review comment.","commit_id":"99079be503249015b076463b295418ff7ba8041e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0a9f67055260efcd5f7a6f4fed92f1cce24a6cf2","unresolved":true,"context_lines":[{"line_number":1042,"context_line":"        if volume_name:"},{"line_number":1043,"context_line":"            hosts_map_info \u003d self.ssh.lsvdiskhostmap(volume_name)"},{"line_number":1044,"context_line":"            hosts_map_info_list \u003d list(hosts_map_info.select(\u0027host_name\u0027))"},{"line_number":1045,"context_line":"            if host_name and host_name in hosts_map_info_list:"},{"line_number":1046,"context_line":"                LOG.debug(\"get_host_from_connector: hosts_map_info:\""},{"line_number":1047,"context_line":"                          \" %s\", hosts_map_info_list)"},{"line_number":1048,"context_line":"                LOG.debug(\u0027Leave: get_host_from_connector host %s\u0027, host_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"e494a3ac_092e6bed","line":1045,"range":{"start_line":1045,"start_character":12,"end_line":1045,"end_character":62},"updated":"2021-03-16 22:35:56.000000000","message":"Since host_name is either None or a string, this could just be:\n\n    if host_name in hosts_map_info_list:","commit_id":"99079be503249015b076463b295418ff7ba8041e"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"88e6ae066cec372256262a639e428e86e78eed12","unresolved":true,"context_lines":[{"line_number":1042,"context_line":"        if volume_name:"},{"line_number":1043,"context_line":"            hosts_map_info \u003d self.ssh.lsvdiskhostmap(volume_name)"},{"line_number":1044,"context_line":"            hosts_map_info_list \u003d list(hosts_map_info.select(\u0027host_name\u0027))"},{"line_number":1045,"context_line":"            if host_name and host_name in hosts_map_info_list:"},{"line_number":1046,"context_line":"                LOG.debug(\"get_host_from_connector: hosts_map_info:\""},{"line_number":1047,"context_line":"                          \" %s\", hosts_map_info_list)"},{"line_number":1048,"context_line":"                LOG.debug(\u0027Leave: get_host_from_connector host %s\u0027, host_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9886e22f_19e48c1a","line":1045,"range":{"start_line":1045,"start_character":12,"end_line":1045,"end_character":62},"in_reply_to":"e494a3ac_092e6bed","updated":"2021-03-17 07:58:20.000000000","message":"addressed review comment.","commit_id":"99079be503249015b076463b295418ff7ba8041e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0a9f67055260efcd5f7a6f4fed92f1cce24a6cf2","unresolved":true,"context_lines":[{"line_number":1047,"context_line":"                          \" %s\", hosts_map_info_list)"},{"line_number":1048,"context_line":"                LOG.debug(\u0027Leave: get_host_from_connector host %s\u0027, host_name)"},{"line_number":1049,"context_line":"                return host_name"},{"line_number":1050,"context_line":"            elif host_name:"},{"line_number":1051,"context_line":"                LOG.debug(\u0027get_host_from_connector: host %s not mapped \u0027"},{"line_number":1052,"context_line":"                          \u0027to volume\u0027, host_name)"},{"line_number":1053,"context_line":"                host_name \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68c8a4_447a27b4","line":1050,"range":{"start_line":1050,"start_character":12,"end_line":1050,"end_character":27},"updated":"2021-03-16 22:35:56.000000000","message":"if you accept the suggestion at line 1042, then this could become a simple \u0027else\u0027","commit_id":"99079be503249015b076463b295418ff7ba8041e"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"88e6ae066cec372256262a639e428e86e78eed12","unresolved":true,"context_lines":[{"line_number":1047,"context_line":"                          \" %s\", hosts_map_info_list)"},{"line_number":1048,"context_line":"                LOG.debug(\u0027Leave: get_host_from_connector host %s\u0027, host_name)"},{"line_number":1049,"context_line":"                return host_name"},{"line_number":1050,"context_line":"            elif host_name:"},{"line_number":1051,"context_line":"                LOG.debug(\u0027get_host_from_connector: host %s not mapped \u0027"},{"line_number":1052,"context_line":"                          \u0027to volume\u0027, host_name)"},{"line_number":1053,"context_line":"                host_name \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f890d3e_aa3d3801","line":1050,"range":{"start_line":1050,"start_character":12,"end_line":1050,"end_character":27},"in_reply_to":"9a68c8a4_447a27b4","updated":"2021-03-17 07:58:20.000000000","message":"suggestion at line 1042 is accepted and modified \u0027elif\u0027 to \u0027else\u0027","commit_id":"99079be503249015b076463b295418ff7ba8041e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0a9f67055260efcd5f7a6f4fed92f1cce24a6cf2","unresolved":true,"context_lines":[{"line_number":1049,"context_line":"                return host_name"},{"line_number":1050,"context_line":"            elif host_name:"},{"line_number":1051,"context_line":"                LOG.debug(\u0027get_host_from_connector: host %s not mapped \u0027"},{"line_number":1052,"context_line":"                          \u0027to volume\u0027, host_name)"},{"line_number":1053,"context_line":"                host_name \u003d None"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"        if host_name:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9daea4ef_dbff242e","line":1052,"updated":"2021-03-16 22:35:56.000000000","message":"definitely a good idea to log this situation","commit_id":"99079be503249015b076463b295418ff7ba8041e"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"88e6ae066cec372256262a639e428e86e78eed12","unresolved":true,"context_lines":[{"line_number":1049,"context_line":"                return host_name"},{"line_number":1050,"context_line":"            elif host_name:"},{"line_number":1051,"context_line":"                LOG.debug(\u0027get_host_from_connector: host %s not mapped \u0027"},{"line_number":1052,"context_line":"                          \u0027to volume\u0027, host_name)"},{"line_number":1053,"context_line":"                host_name \u003d None"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"        if host_name:"}],"source_content_type":"text/x-python","patch_set":3,"id":"a81b19f7_edb41f19","line":1052,"in_reply_to":"9daea4ef_dbff242e","updated":"2021-03-17 07:58:20.000000000","message":"thanks Brian","commit_id":"99079be503249015b076463b295418ff7ba8041e"}],"releasenotes/notes/bug-1892034-Volume-name-is-not-validated-for-host-4ec0d1bd14281c77.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0a9f67055260efcd5f7a6f4fed92f1cce24a6cf2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1892034 \u003chttps://bugs.launchpad.net/cinder/+bug/1892034\u003e`_:"},{"line_number":5,"context_line":"    IBM Storwize: Fixed issue in get_host_from_connector that volume name"},{"line_number":6,"context_line":"    is not validated to get the host during terminate connection when the"},{"line_number":7,"context_line":"    volume name is passed as input."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4b6b8c18_feb11af4","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":17},"updated":"2021-03-16 22:35:56.000000000","message":"The driver name should come first (the way you have it on https://review.opendev.org/c/openstack/cinder/+/771783/ )","commit_id":"99079be503249015b076463b295418ff7ba8041e"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"88e6ae066cec372256262a639e428e86e78eed12","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1892034 \u003chttps://bugs.launchpad.net/cinder/+bug/1892034\u003e`_:"},{"line_number":5,"context_line":"    IBM Storwize: Fixed issue in get_host_from_connector that volume name"},{"line_number":6,"context_line":"    is not validated to get the host during terminate connection when the"},{"line_number":7,"context_line":"    volume name is passed as input."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"712948e9_b499f8ee","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":17},"in_reply_to":"4b6b8c18_feb11af4","updated":"2021-03-17 07:58:20.000000000","message":"updated the release notes, driver name comes first.\nAddressed review comments.","commit_id":"99079be503249015b076463b295418ff7ba8041e"}]}