)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ac6782322971048aaf240032d47322d5041c47a0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow up SolidFire storage assisted migration issues"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch Addresses a few observed issues in the change that"},{"line_number":10,"context_line":"adds storage assisted migration support to the SolidFire driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I125c71ba69ed203c6029540064aa953ef2e07034"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"0476a8dd_fe7c6b5b","line":9,"range":{"start_line":9,"start_character":43,"end_line":9,"end_character":56},"updated":"2021-06-28 10:08:41.000000000","message":"nit: It\u0027s usually a good idea to add the Change-Id of the referred patch, that way the patches are somewhat linked when grepping the commit messages.","commit_id":"1ce3c49ffa0a4be42f0c676caa894eeb5dd4699d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ac6782322971048aaf240032d47322d5041c47a0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"11c130e8_828fdc6c","line":13,"updated":"2021-06-28 10:08:41.000000000","message":"-1: Missing LP bug and description the issues, so we don\u0027t know exactly what issues are being fixed.\n\n-1: The patch is also missing a release note.","commit_id":"1ce3c49ffa0a4be42f0c676caa894eeb5dd4699d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6abf7271520a816bf0325b7d040a7323c26a6163","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7b13af52_a465480c","updated":"2022-07-08 14:55:16.000000000","message":"please, fix conflicts.. ","commit_id":"1ce3c49ffa0a4be42f0c676caa894eeb5dd4699d"}],"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"189fa8684384a51c481886f8eaa40943455cf2b6","unresolved":false,"context_lines":[{"line_number":2461,"context_line":"                 {\"vol_id\": volume.id, \"host\": host[\"host\"]})"},{"line_number":2462,"context_line":""},{"line_number":2463,"context_line":"        if volume.status not in (fields.VolumeStatus.AVAILABLE,"},{"line_number":2464,"context_line":"                                 fields.VolumeStatus.RETYPING):"},{"line_number":2465,"context_line":"            msg \u003d _(\"Volume status must be \u0027available\u0027 to execute \""},{"line_number":2466,"context_line":"                    \"storage assisted migration.\")"},{"line_number":2467,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f621f24_2d4ff792","line":2464,"updated":"2020-11-03 11:36:33.000000000","message":"This is necessary for a successful storage assisted migration upon retype operation, once this bugfix patch [0] is merged.\n\n[0] https://review.opendev.org/#/c/739548/","commit_id":"bdf6e10f95e8194ca4c8a284107d4cab642d299e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ac6782322971048aaf240032d47322d5041c47a0","unresolved":false,"context_lines":[{"line_number":271,"context_line":"          2.1.0  - Add Cinder Active/Active support"},{"line_number":272,"context_line":"                    - Enable Active/Active support flag"},{"line_number":273,"context_line":"                    - Implement Active/Active replication support"},{"line_number":274,"context_line":"          2.2.0  - Enable driver IPv6 api request"},{"line_number":275,"context_line":"                 - Add storage assisted volume migration support"},{"line_number":276,"context_line":"          2.2.1  - Fix bug #1891914 fix error on cluster workload rebalancing"},{"line_number":277,"context_line":"                   by adding xNotPrimary to the retryable exception list"}],"source_content_type":"text/x-python","patch_set":6,"id":"928f799f_cb9526a6","line":274,"updated":"2021-06-28 10:08:41.000000000","message":"Adding a line on an older version like this looks odd to me, but it should be ok since this is a vendor internal thing.","commit_id":"1ce3c49ffa0a4be42f0c676caa894eeb5dd4699d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ac6782322971048aaf240032d47322d5041c47a0","unresolved":true,"context_lines":[{"line_number":2524,"context_line":"                 {\"vol_id\": volume.id, \"host\": host[\"host\"]})"},{"line_number":2525,"context_line":""},{"line_number":2526,"context_line":"        if volume.status not in (fields.VolumeStatus.AVAILABLE,"},{"line_number":2527,"context_line":"                                 fields.VolumeStatus.RETYPING):"},{"line_number":2528,"context_line":"            msg \u003d _(\"Volume status must be \u0027available\u0027 to execute \""},{"line_number":2529,"context_line":"                    \"storage assisted migration.\")"},{"line_number":2530,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"77b54012_faac8966","line":2527,"updated":"2021-06-28 10:08:41.000000000","message":"-1: It can also be fields.VolumeStatus.MAINTENANCE as can be seen in https://github.com/openstack/cinder/blob/f340058145f9473b6cf2694e0620c2ca8964b728/cinder/volume/api.py#L1540-L1543","commit_id":"1ce3c49ffa0a4be42f0c676caa894eeb5dd4699d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ac6782322971048aaf240032d47322d5041c47a0","unresolved":true,"context_lines":[{"line_number":2525,"context_line":""},{"line_number":2526,"context_line":"        if volume.status not in (fields.VolumeStatus.AVAILABLE,"},{"line_number":2527,"context_line":"                                 fields.VolumeStatus.RETYPING):"},{"line_number":2528,"context_line":"            msg \u003d _(\"Volume status must be \u0027available\u0027 to execute \""},{"line_number":2529,"context_line":"                    \"storage assisted migration.\")"},{"line_number":2530,"context_line":"            LOG.error(msg)"},{"line_number":2531,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"e83f9aab_2aa15e35","line":2528,"updated":"2021-06-28 10:08:41.000000000","message":"-1: Please update the message with the new possible states","commit_id":"1ce3c49ffa0a4be42f0c676caa894eeb5dd4699d"}]}