)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a293a1da7e4f6fc8c5d4510ced9217aa5412f7eb","unresolved":false,"context_lines":[{"line_number":2627,"context_line":""},{"line_number":2628,"context_line":"                # Append cacheable flag for iSCSI/FC/NVMe-oF and only when"},{"line_number":2629,"context_line":"                # cacheable is not set in driver level"},{"line_number":2630,"context_line":"                if volume_stats.get(\u0027storage_protocol\u0027) in ["},{"line_number":2631,"context_line":"                        \u0027iSCSI\u0027, \u0027FC\u0027, \u0027NVMe-oF\u0027]:"},{"line_number":2632,"context_line":"                    if volume_stats.get(\u0027pools\u0027):"},{"line_number":2633,"context_line":"                        for pool in volume_stats.get(\u0027pools\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f583aaa7","line":2630,"updated":"2020-09-23 14:58:43.000000000","message":"The main question here is -- do we need to modify this check to look at \u0027storage_protocol\u0027 for such drivers, or should drivers be reporting this at the top level instead of inside \u0027pools\u0027?","commit_id":"19a128c31b3ea80dde590abf731a54947d34e6ba"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9829f8c08fb779ed87968d1330928624e4a73a16","unresolved":false,"context_lines":[{"line_number":2627,"context_line":""},{"line_number":2628,"context_line":"                # Append cacheable flag for iSCSI/FC/NVMe-oF and only when"},{"line_number":2629,"context_line":"                # cacheable is not set in driver level"},{"line_number":2630,"context_line":"                if volume_stats.get(\u0027storage_protocol\u0027) in ["},{"line_number":2631,"context_line":"                        \u0027iSCSI\u0027, \u0027FC\u0027, \u0027NVMe-oF\u0027]:"},{"line_number":2632,"context_line":"                    if volume_stats.get(\u0027pools\u0027):"},{"line_number":2633,"context_line":"                        for pool in volume_stats.get(\u0027pools\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_78e02fcd","line":2630,"in_reply_to":"9f560f44_9874239e","updated":"2020-09-23 15:15:50.000000000","message":"Followed up with\n\n    https://review.opendev.org/753752\n\nto adjust the SPDK driver to match others.","commit_id":"19a128c31b3ea80dde590abf731a54947d34e6ba"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a43721396850185b3a867828ae0da1df3ff30a45","unresolved":false,"context_lines":[{"line_number":2627,"context_line":""},{"line_number":2628,"context_line":"                # Append cacheable flag for iSCSI/FC/NVMe-oF and only when"},{"line_number":2629,"context_line":"                # cacheable is not set in driver level"},{"line_number":2630,"context_line":"                if volume_stats.get(\u0027storage_protocol\u0027) in ["},{"line_number":2631,"context_line":"                        \u0027iSCSI\u0027, \u0027FC\u0027, \u0027NVMe-oF\u0027]:"},{"line_number":2632,"context_line":"                    if volume_stats.get(\u0027pools\u0027):"},{"line_number":2633,"context_line":"                        for pool in volume_stats.get(\u0027pools\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9874239e","line":2630,"in_reply_to":"9f560f44_f583aaa7","updated":"2020-09-23 15:03:25.000000000","message":"It does seem like it should be a top level thing, not per pool.","commit_id":"19a128c31b3ea80dde590abf731a54947d34e6ba"}]}