)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f051ca08a2c1511625e0373e4a86c4d87cadf3e2","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix PowerFlex volume type conversion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix bug with PowerFlex storage-assisted volume migration when volume"},{"line_number":10,"context_line":"can be migrated without conversion of its type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icf27ea898507ffec5e410788efcdca3649a73c99"},{"line_number":13,"context_line":"Closes-Bug: #1897598"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"85441f35_7db16706","line":10,"updated":"2021-04-13 12:47:19.000000000","message":"This statement is completely misleading.  I think the point of the bug is that the driver currently does migration without conversion in cases where it *should* be doing conversion?  So maybe something like this:\n\nFix bug where the PowerFlex driver was performing storage-assisted volume migration without conversion in cases where it should have been converting to/from thin/thick provisioned volumes.","commit_id":"d51dbe91ea2ef4a2c2430267f68a4353980bfc70"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"865d626cdb3835c4c05b1c7967723e5dcdaba1e2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix PowerFlex volume type conversion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix bug with PowerFlex storage-assisted volume migration when volume"},{"line_number":10,"context_line":"can be migrated without conversion of its type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icf27ea898507ffec5e410788efcdca3649a73c99"},{"line_number":13,"context_line":"Closes-Bug: #1897598"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dc8cd88b_6c103da7","line":10,"in_reply_to":"85441f35_7db16706","updated":"2021-04-14 05:34:23.000000000","message":"Done","commit_id":"d51dbe91ea2ef4a2c2430267f68a4353980bfc70"}],"cinder/tests/unit/volume/drivers/dell_emc/powerflex/test_migrate_volume.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f051ca08a2c1511625e0373e4a86c4d87cadf3e2","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    (\u0027thick\u0027, \u0027ThinProvisioned\u0027, \u0027ThinToThick\u0027, \u0027None\u0027, True),"},{"line_number":38,"context_line":"    (\u0027compressed\u0027, \u0027ThinProvisioned\u0027, \u0027NoConversion\u0027, \u0027Normal\u0027, False),"},{"line_number":39,"context_line":"    (\u0027compressed\u0027, \u0027ThickProvisioned\u0027, \u0027ThickToThin\u0027, \u0027Normal\u0027, False),"},{"line_number":40,"context_line":"    (\u0027compressed\u0027, \u0027ThickProvisioned\u0027, \u0027ThickToThin\u0027, \u0027None\u0027, False)"},{"line_number":41,"context_line":")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3b7f93cf_e6c5aeb6","side":"PARENT","line":40,"range":{"start_line":40,"start_character":6,"end_line":40,"end_character":16},"updated":"2021-04-13 12:47:19.000000000","message":"You pointed out to Arkady that compressed volumes are handled in a different location in the code from the changes you made.  Is that still being tested?","commit_id":"91da9df53200bc5d78cf7f3f5b967e41f3cafef9"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"865d626cdb3835c4c05b1c7967723e5dcdaba1e2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    (\u0027thick\u0027, \u0027ThinProvisioned\u0027, \u0027ThinToThick\u0027, \u0027None\u0027, True),"},{"line_number":38,"context_line":"    (\u0027compressed\u0027, \u0027ThinProvisioned\u0027, \u0027NoConversion\u0027, \u0027Normal\u0027, False),"},{"line_number":39,"context_line":"    (\u0027compressed\u0027, \u0027ThickProvisioned\u0027, \u0027ThickToThin\u0027, \u0027Normal\u0027, False),"},{"line_number":40,"context_line":"    (\u0027compressed\u0027, \u0027ThickProvisioned\u0027, \u0027ThickToThin\u0027, \u0027None\u0027, False)"},{"line_number":41,"context_line":")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"337e4e78_d0c4b6df","side":"PARENT","line":40,"range":{"start_line":40,"start_character":6,"end_line":40,"end_character":16},"in_reply_to":"3b7f93cf_e6c5aeb6","updated":"2021-04-14 05:34:23.000000000","message":"Yes, it is still being tested.\nActually, PowerFlex does not have special provisioning for Compressed volumes.\nThe type of this volumes are ThinProvisioned with compression set to Normal.","commit_id":"91da9df53200bc5d78cf7f3f5b967e41f3cafef9"}],"cinder/volume/drivers/dell_emc/powerflex/driver.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c9d95e4ab1a24fb5f10e291744c0074ccbad6c7c","unresolved":true,"context_lines":[{"line_number":92,"context_line":"          3.5.3 - Add revert volume to snapshot support"},{"line_number":93,"context_line":"          3.5.4 - Fix for Bug #1823200. See OSSN-0086 for details."},{"line_number":94,"context_line":"          3.5.5 - Rebrand VxFlex OS to PowerFlex."},{"line_number":95,"context_line":"          3.5.6 - Fix for Bug #1897598."},{"line_number":96,"context_line":"    \"\"\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    VERSION \u003d \"3.5.6\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ed5b3a71_e6f1a8a2","line":95,"updated":"2021-02-16 13:34:04.000000000","message":"Would have been nice to give a clue what that bug is without needing to look up the bug.","commit_id":"745031d189c9a99fc52e01a2296c0c80352e817f"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"8b5059f9750e05e0aee9b4429d51ae6da6f4e8b7","unresolved":false,"context_lines":[{"line_number":92,"context_line":"          3.5.3 - Add revert volume to snapshot support"},{"line_number":93,"context_line":"          3.5.4 - Fix for Bug #1823200. See OSSN-0086 for details."},{"line_number":94,"context_line":"          3.5.5 - Rebrand VxFlex OS to PowerFlex."},{"line_number":95,"context_line":"          3.5.6 - Fix for Bug #1897598."},{"line_number":96,"context_line":"    \"\"\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    VERSION \u003d \"3.5.6\""}],"source_content_type":"text/x-python","patch_set":1,"id":"063a6aed_cfaa507b","line":95,"in_reply_to":"ed5b3a71_e6f1a8a2","updated":"2021-02-16 14:16:18.000000000","message":"Done.","commit_id":"745031d189c9a99fc52e01a2296c0c80352e817f"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"1c02b3dadcadda0f014d38b6ad1c38581017ad50","unresolved":true,"context_lines":[{"line_number":1397,"context_line":"            dst_pool_name"},{"line_number":1398,"context_line":"        )"},{"line_number":1399,"context_line":"        if ("},{"line_number":1400,"context_line":"                real_provisioning \u003d\u003d \"ThickProvisioned\" and"},{"line_number":1401,"context_line":"                (provisioning \u003d\u003d \"ThinProvisioned\" or"},{"line_number":1402,"context_line":"                 not pool_supports_thick_vols)"},{"line_number":1403,"context_line":"        ):"}],"source_content_type":"text/x-python","patch_set":2,"id":"4d207501_ba133b3e","line":1400,"updated":"2021-02-16 15:35:11.000000000","message":"Do we need to handle Compressed volume here also?","commit_id":"d51dbe91ea2ef4a2c2430267f68a4353980bfc70"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"58db9793614871a9ae3ddf8d281b9d261423a953","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"            dst_pool_name"},{"line_number":1398,"context_line":"        )"},{"line_number":1399,"context_line":"        if ("},{"line_number":1400,"context_line":"                real_provisioning \u003d\u003d \"ThickProvisioned\" and"},{"line_number":1401,"context_line":"                (provisioning \u003d\u003d \"ThinProvisioned\" or"},{"line_number":1402,"context_line":"                 not pool_supports_thick_vols)"},{"line_number":1403,"context_line":"        ):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5129192a_70d3cd74","line":1400,"in_reply_to":"379c6f93_3beb6c21","updated":"2021-02-16 15:40:13.000000000","message":"thanks","commit_id":"d51dbe91ea2ef4a2c2430267f68a4353980bfc70"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"bda053d5e20d80d43f3f11d8d3f7e50e4eb5142a","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"            dst_pool_name"},{"line_number":1398,"context_line":"        )"},{"line_number":1399,"context_line":"        if ("},{"line_number":1400,"context_line":"                real_provisioning \u003d\u003d \"ThickProvisioned\" and"},{"line_number":1401,"context_line":"                (provisioning \u003d\u003d \"ThinProvisioned\" or"},{"line_number":1402,"context_line":"                 not pool_supports_thick_vols)"},{"line_number":1403,"context_line":"        ):"}],"source_content_type":"text/x-python","patch_set":2,"id":"379c6f93_3beb6c21","line":1400,"in_reply_to":"4d207501_ba133b3e","updated":"2021-02-16 15:38:27.000000000","message":"Compressed volumes are thin provisioned but they also have compression method attribute.\nCompression is handled on line #1411.","commit_id":"d51dbe91ea2ef4a2c2430267f68a4353980bfc70"}],"releasenotes/notes/bug-1897598-powerflex-volume-type-conversion.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c9d95e4ab1a24fb5f10e291744c0074ccbad6c7c","unresolved":true,"context_lines":[{"line_number":3,"context_line":"fixes:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    `Bug #1897598 \u003chttps://bugs.launchpad.net/cinder/+bug/1897598\u003e`_:"},{"line_number":6,"context_line":"    Fix bug with volume migration when volume can be migrated without"},{"line_number":7,"context_line":"    conversion of its type."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e243a80e_6c6bc4df","line":6,"updated":"2021-02-16 13:34:04.000000000","message":"This should say what driver this applies to. With the way it is currently worded, it makes it sound like there is an issue with Cinder as a whole with being able to migrate volumes.","commit_id":"745031d189c9a99fc52e01a2296c0c80352e817f"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"8b5059f9750e05e0aee9b4429d51ae6da6f4e8b7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"fixes:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    `Bug #1897598 \u003chttps://bugs.launchpad.net/cinder/+bug/1897598\u003e`_:"},{"line_number":6,"context_line":"    Fix bug with volume migration when volume can be migrated without"},{"line_number":7,"context_line":"    conversion of its type."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"942ea798_86ab4061","line":6,"in_reply_to":"e243a80e_6c6bc4df","updated":"2021-02-16 14:16:18.000000000","message":"Done.","commit_id":"745031d189c9a99fc52e01a2296c0c80352e817f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f051ca08a2c1511625e0373e4a86c4d87cadf3e2","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"fixes:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    `Bug #1897598 \u003chttps://bugs.launchpad.net/cinder/+bug/1897598\u003e`_:"},{"line_number":6,"context_line":"    Fix bug with PowerFlex storage-assisted volume migration when volume"},{"line_number":7,"context_line":"    can be migrated without conversion of its type."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"80e41da6_52ea0f03","line":5,"updated":"2021-04-13 12:47:19.000000000","message":"-1: Please follow the release note format: https://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers","commit_id":"d51dbe91ea2ef4a2c2430267f68a4353980bfc70"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"865d626cdb3835c4c05b1c7967723e5dcdaba1e2","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"fixes:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    `Bug #1897598 \u003chttps://bugs.launchpad.net/cinder/+bug/1897598\u003e`_:"},{"line_number":6,"context_line":"    Fix bug with PowerFlex storage-assisted volume migration when volume"},{"line_number":7,"context_line":"    can be migrated without conversion of its type."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5c76559b_2a287851","line":5,"in_reply_to":"80e41da6_52ea0f03","updated":"2021-04-14 05:34:23.000000000","message":"Done","commit_id":"d51dbe91ea2ef4a2c2430267f68a4353980bfc70"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f051ca08a2c1511625e0373e4a86c4d87cadf3e2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    `Bug #1897598 \u003chttps://bugs.launchpad.net/cinder/+bug/1897598\u003e`_:"},{"line_number":6,"context_line":"    Fix bug with PowerFlex storage-assisted volume migration when volume"},{"line_number":7,"context_line":"    can be migrated without conversion of its type."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"79a9e7a8_1f20f1d9","line":7,"updated":"2021-04-13 12:47:19.000000000","message":"I think that as a summary of what you fixed, this sentence is misleading.  (See my comment in your commit message.)  You should probably emphasize that formerly volumes were being migrated without conversion when they should have been converted, and now the driver respects the requested provisioning if possible during storage-assisted volume migration.  (I\u0027m sure you can say it better, that\u0027s just the general idea.)","commit_id":"d51dbe91ea2ef4a2c2430267f68a4353980bfc70"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"865d626cdb3835c4c05b1c7967723e5dcdaba1e2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    `Bug #1897598 \u003chttps://bugs.launchpad.net/cinder/+bug/1897598\u003e`_:"},{"line_number":6,"context_line":"    Fix bug with PowerFlex storage-assisted volume migration when volume"},{"line_number":7,"context_line":"    can be migrated without conversion of its type."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ad3ca11c_ef1a39dd","line":7,"in_reply_to":"79a9e7a8_1f20f1d9","updated":"2021-04-14 05:34:23.000000000","message":"Done","commit_id":"d51dbe91ea2ef4a2c2430267f68a4353980bfc70"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"20cc256c7960ab985b23760f1d07ae83a1cb5a02","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"fixes:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    PowerFlex driver `Bug #1897598"},{"line_number":6,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1897598\u003e`_: Fix bug with"},{"line_number":7,"context_line":"    PowerFlex storage-assisted volume migration when volume migration was"},{"line_number":8,"context_line":"    performed without conversion of volume type in cases where it should have"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5bd9ac93_ebd67642","line":5,"updated":"2021-04-21 20:42:54.000000000","message":"If you update, please follow our current pattern of starting with the bug link, then the more detailed description.","commit_id":"82cda2cf318f506ea4a7fcfbb216006999e0916b"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"6ade155a97867b30127b0b4421eef8039929621b","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"fixes:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    PowerFlex driver `Bug #1897598"},{"line_number":6,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1897598\u003e`_: Fix bug with"},{"line_number":7,"context_line":"    PowerFlex storage-assisted volume migration when volume migration was"},{"line_number":8,"context_line":"    performed without conversion of volume type in cases where it should have"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"686728fd_05e01356","line":5,"in_reply_to":"5bd9ac93_ebd67642","updated":"2021-04-22 06:40:43.000000000","message":"I\u0027m a bit confused. \nIn the contributor guide which Brian mentioned above the pattern is\n\u003cdriver name\u003e \u003cbug link\u003e and then description.","commit_id":"82cda2cf318f506ea4a7fcfbb216006999e0916b"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"181c98d63fe202b25d06f13288d646eaef7a9199","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"fixes:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    PowerFlex driver `Bug #1897598"},{"line_number":6,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1897598\u003e`_: Fix bug with"},{"line_number":7,"context_line":"    PowerFlex storage-assisted volume migration when volume migration was"},{"line_number":8,"context_line":"    performed without conversion of volume type in cases where it should have"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c2e3ad3e_badcf02d","line":5,"in_reply_to":"686728fd_05e01356","updated":"2021-04-23 21:53:08.000000000","message":"Maybe Sean just wants to \u003chttps://bugs.launchpad.net/cinder/+bug/1897598\u003e`_: to be the first line in the description.","commit_id":"82cda2cf318f506ea4a7fcfbb216006999e0916b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a50028c32e0e4245b9376bf7b37aa80d4aad6a32","unresolved":true,"context_lines":[{"line_number":3,"context_line":"fixes:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    PowerFlex driver `Bug #1897598"},{"line_number":6,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1897598\u003e`_: Fix bug with"},{"line_number":7,"context_line":"    PowerFlex storage-assisted volume migration when volume migration was"},{"line_number":8,"context_line":"    performed without conversion of volume type in cases where it should have"},{"line_number":9,"context_line":"    been converted to/from thin/thick provisioned."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2f22e24a_c8e06973","line":6,"range":{"start_line":6,"start_character":56,"end_line":6,"end_character":59},"updated":"2021-05-03 14:39:51.000000000","message":"We merged a change recently to the docs specifying that this should be past tense (\"Fixed\")\nhttps://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers\n\nOtherwise, I think you\u0027re following the current pattern (except maybe the B in bug should be lowercase).","commit_id":"82cda2cf318f506ea4a7fcfbb216006999e0916b"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"da18f2f036ef9949812971e43fd9d04103cd00df","unresolved":false,"context_lines":[{"line_number":3,"context_line":"fixes:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    PowerFlex driver `Bug #1897598"},{"line_number":6,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1897598\u003e`_: Fix bug with"},{"line_number":7,"context_line":"    PowerFlex storage-assisted volume migration when volume migration was"},{"line_number":8,"context_line":"    performed without conversion of volume type in cases where it should have"},{"line_number":9,"context_line":"    been converted to/from thin/thick provisioned."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8405caa5_0df44fac","line":6,"range":{"start_line":6,"start_character":56,"end_line":6,"end_character":59},"in_reply_to":"2f22e24a_c8e06973","updated":"2021-05-04 08:12:52.000000000","message":"Done","commit_id":"82cda2cf318f506ea4a7fcfbb216006999e0916b"}]}