)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"061358b71f21a41aea79534a4ebf055900f81a7c","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[SVF]:Fix in change_vdisk_iogrp during retype"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize Family] During retyping a volume between I/O"},{"line_number":10,"context_line":"groups, if movevdisk fails, rmvdiskaccess should be done for"},{"line_number":11,"context_line":"new I/O group before failing the retype operation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes bug: #1896214"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"d03668c5_47d4bb7b","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":26},"updated":"2020-12-07 10:48:52.000000000","message":"the bug states that addvdiskaccess failed so this statement seems wrong","commit_id":"7f40f644c9ad47516bd6b138ca49057f8f50935d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"07e46d25f56ab49312a6fa2eeca625bd27caa566","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[SVF]:Fix in change_vdisk_iogrp during retype"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize Family] Fixed issues in change_vdisk_iogrp."},{"line_number":10,"context_line":"During retyping a volume between I/O groups, if addvdiskaccess fails"},{"line_number":11,"context_line":"an exception is raised and if movevdisk fails rmvdiskaccess should be"},{"line_number":12,"context_line":"done for new I/O group before failing the retype operation."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes bug: #1896214"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"b3b28c99_ae38945a","line":11,"range":{"start_line":10,"start_character":45,"end_line":11,"end_character":22},"updated":"2020-12-08 06:12:01.000000000","message":"I was expecting something related to changing order of execution of movevdisk and addvdiskaccess as per IBM documentation here but anyway this is also ok.","commit_id":"11455693438652a67b5c0d9fcd0af0a9f062ca7f"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4e42aa7c01e4e171ee4fdccb3b0a89eec699adda","unresolved":false,"context_lines":[{"line_number":2483,"context_line":"            self.ssh.addvdiskaccess(vdisk, str(iogrp[0]))"},{"line_number":2484,"context_line":"            try:"},{"line_number":2485,"context_line":"                self.ssh.movevdisk(vdisk, str(iogrp[0]))"},{"line_number":2486,"context_line":"            except:"},{"line_number":2487,"context_line":"                self.ssh.rmvdiskaccess(vdisk, str(iogrp[0]))"},{"line_number":2488,"context_line":"                msg \u003d (_(\u0027movevdisk command failed for %(vdisk), \u0027"},{"line_number":2489,"context_line":"                         \u0027performing rmdiskaccess for %(iogrp)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a817a3ee","line":2486,"updated":"2020-09-30 13:23:27.000000000","message":"pep8: E722 do not use bare \u0027except\u0027","commit_id":"496c26fcf4328b1489a821de5b543c210e77b0f7"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4e42aa7c01e4e171ee4fdccb3b0a89eec699adda","unresolved":false,"context_lines":[{"line_number":2483,"context_line":"            self.ssh.addvdiskaccess(vdisk, str(iogrp[0]))"},{"line_number":2484,"context_line":"            try:"},{"line_number":2485,"context_line":"                self.ssh.movevdisk(vdisk, str(iogrp[0]))"},{"line_number":2486,"context_line":"            except:"},{"line_number":2487,"context_line":"                self.ssh.rmvdiskaccess(vdisk, str(iogrp[0]))"},{"line_number":2488,"context_line":"                msg \u003d (_(\u0027movevdisk command failed for %(vdisk), \u0027"},{"line_number":2489,"context_line":"                         \u0027performing rmdiskaccess for %(iogrp)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_88145feb","line":2486,"updated":"2020-09-30 13:23:27.000000000","message":"pep8: H201: no \u0027except:\u0027 at least use \u0027except Exception:\u0027","commit_id":"496c26fcf4328b1489a821de5b543c210e77b0f7"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3edaa48e737dbba7abd11970b5e9e518942e9c25","unresolved":false,"context_lines":[{"line_number":2483,"context_line":"            self.ssh.addvdiskaccess(vdisk, str(iogrp[0]))"},{"line_number":2484,"context_line":"            try:"},{"line_number":2485,"context_line":"                self.ssh.movevdisk(vdisk, str(iogrp[0]))"},{"line_number":2486,"context_line":"            except exception.VolumeBackendAPIException as e:"},{"line_number":2487,"context_line":"                self.ssh.rmvdiskaccess(vdisk, str(iogrp[0]))"},{"line_number":2488,"context_line":"                msg \u003d (_(\u0027movevdisk command failed for %(vdisk), \u0027"},{"line_number":2489,"context_line":"                         \u0027performing rmdiskaccess for %(iogrp)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_86d60bf2","line":2486,"updated":"2020-09-30 20:27:29.000000000","message":"pep8: F841 local variable \u0027e\u0027 is assigned to but never used","commit_id":"7c12842f0261043077691c06804d23c8c30e559d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8201e61bbfe5c3a52a27477768105fefe2853c1c","unresolved":true,"context_lines":[{"line_number":2481,"context_line":"                      {\u0027code_level\u0027: state[\u0027code_level\u0027]})"},{"line_number":2482,"context_line":"        else:"},{"line_number":2483,"context_line":"            self.ssh.addvdiskaccess(vdisk, str(iogrp[0]))"},{"line_number":2484,"context_line":"            try:"},{"line_number":2485,"context_line":"                self.ssh.movevdisk(vdisk, str(iogrp[0]))"},{"line_number":2486,"context_line":"            except exception.VolumeBackendAPIException as e:"},{"line_number":2487,"context_line":"                self.ssh.rmvdiskaccess(vdisk, str(iogrp[0]))"},{"line_number":2488,"context_line":"                msg \u003d (_(\u0027movevdisk command failed for %(vdisk),\u0027"},{"line_number":2489,"context_line":"                         \u0027performing rmdiskaccess for %(iogrp)s.\u0027"},{"line_number":2490,"context_line":"                         \u0027Exception: %(err)s.\u0027),"},{"line_number":2491,"context_line":"                       {\u0027vdisk\u0027: vdisk, \u0027iogrp\u0027: iogrp[0], \u0027err\u0027: e})"},{"line_number":2492,"context_line":"                LOG.exception(msg)"},{"line_number":2493,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":2494,"context_line":"            self.ssh.rmvdiskaccess(vdisk, str(iogrp[1]))"},{"line_number":2495,"context_line":""},{"line_number":2496,"context_line":"    def vdisk_by_uid(self, vdisk_uid):"}],"source_content_type":"text/x-python","patch_set":8,"id":"f37f6a6a_1115da76","line":2493,"range":{"start_line":2484,"start_character":12,"end_line":2493,"end_character":67},"updated":"2020-12-07 10:38:14.000000000","message":"Why aren\u0027t we doing this before addvdiskaccess operation as done originally? that way we can avoid doing rmvdiskaccess in the except block","commit_id":"7f40f644c9ad47516bd6b138ca49057f8f50935d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"061358b71f21a41aea79534a4ebf055900f81a7c","unresolved":true,"context_lines":[{"line_number":2481,"context_line":"                      {\u0027code_level\u0027: state[\u0027code_level\u0027]})"},{"line_number":2482,"context_line":"        else:"},{"line_number":2483,"context_line":"            self.ssh.addvdiskaccess(vdisk, str(iogrp[0]))"},{"line_number":2484,"context_line":"            try:"},{"line_number":2485,"context_line":"                self.ssh.movevdisk(vdisk, str(iogrp[0]))"},{"line_number":2486,"context_line":"            except exception.VolumeBackendAPIException as e:"},{"line_number":2487,"context_line":"                self.ssh.rmvdiskaccess(vdisk, str(iogrp[0]))"},{"line_number":2488,"context_line":"                msg \u003d (_(\u0027movevdisk command failed for %(vdisk),\u0027"},{"line_number":2489,"context_line":"                         \u0027performing rmdiskaccess for %(iogrp)s.\u0027"},{"line_number":2490,"context_line":"                         \u0027Exception: %(err)s.\u0027),"},{"line_number":2491,"context_line":"                       {\u0027vdisk\u0027: vdisk, \u0027iogrp\u0027: iogrp[0], \u0027err\u0027: e})"},{"line_number":2492,"context_line":"                LOG.exception(msg)"},{"line_number":2493,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":2494,"context_line":"            self.ssh.rmvdiskaccess(vdisk, str(iogrp[1]))"},{"line_number":2495,"context_line":""},{"line_number":2496,"context_line":"    def vdisk_by_uid(self, vdisk_uid):"}],"source_content_type":"text/x-python","patch_set":8,"id":"253703e1_dcfb374f","line":2493,"range":{"start_line":2484,"start_character":12,"end_line":2493,"end_character":67},"in_reply_to":"f37f6a6a_1115da76","updated":"2020-12-07 10:48:52.000000000","message":"After checking the bug report, the failing method is addvdiskaccess and not movevdisk,\nthe way to do it seems right (i.e. execute movevdisk after addvdisk) but this exception block should enclose addvdisk and not this method","commit_id":"7f40f644c9ad47516bd6b138ca49057f8f50935d"},{"author":{"_account_id":32073,"name":"Sharath Kacham","email":"sharath.kacham1@ibm.com","username":"sharathkacham"},"change_message_id":"7f81b9658d3d5b59412e90bbdd12111711aa36ab","unresolved":true,"context_lines":[{"line_number":2481,"context_line":"                      {\u0027code_level\u0027: state[\u0027code_level\u0027]})"},{"line_number":2482,"context_line":"        else:"},{"line_number":2483,"context_line":"            self.ssh.addvdiskaccess(vdisk, str(iogrp[0]))"},{"line_number":2484,"context_line":"            try:"},{"line_number":2485,"context_line":"                self.ssh.movevdisk(vdisk, str(iogrp[0]))"},{"line_number":2486,"context_line":"            except exception.VolumeBackendAPIException as e:"},{"line_number":2487,"context_line":"                self.ssh.rmvdiskaccess(vdisk, str(iogrp[0]))"},{"line_number":2488,"context_line":"                msg \u003d (_(\u0027movevdisk command failed for %(vdisk),\u0027"},{"line_number":2489,"context_line":"                         \u0027performing rmdiskaccess for %(iogrp)s.\u0027"},{"line_number":2490,"context_line":"                         \u0027Exception: %(err)s.\u0027),"},{"line_number":2491,"context_line":"                       {\u0027vdisk\u0027: vdisk, \u0027iogrp\u0027: iogrp[0], \u0027err\u0027: e})"},{"line_number":2492,"context_line":"                LOG.exception(msg)"},{"line_number":2493,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":2494,"context_line":"            self.ssh.rmvdiskaccess(vdisk, str(iogrp[1]))"},{"line_number":2495,"context_line":""},{"line_number":2496,"context_line":"    def vdisk_by_uid(self, vdisk_uid):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9e2d0a1d_dc97204f","line":2493,"range":{"start_line":2484,"start_character":12,"end_line":2493,"end_character":67},"in_reply_to":"f37f6a6a_1115da76","updated":"2020-12-07 14:46:18.000000000","message":"As per IBM documentation, addvdiskaccess is done before movevdisk.\nhttps://www.ibm.com/support/knowledgecenter/STSLR9_8.2.1/com.ibm.fs9100_821.doc/svc_migratevdiskiogrpscli_42lens.html\n\nAnd as per the defect, addvdiskaccess failed with error and movevdisk is already done.\nSo, we had to revert volume to older iogrp manually.\nBut with this fix, if addvdiskaccess fails, we do not move further and if movevdisk fails with exception, we do rmvdiskaccess in the except block.","commit_id":"7f40f644c9ad47516bd6b138ca49057f8f50935d"}],"releasenotes/notes/bug-1896214-Fix-in-change_vdisk_iogrp-during-retype-ef83ccf27d8829f5.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bc798fb50a8d7308cc75bc8c446bb2edc1f46334","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1896214 \u003chttps://bugs.launchpad.net/cinder/+bug/1896214\u003e`_:"},{"line_number":5,"context_line":"    IBM Spectrum Virtualize Family: Fixed issues in change_vdisk_iogrp."},{"line_number":6,"context_line":"    During retyping a volume between I/O groups, if movevdisk fails"},{"line_number":7,"context_line":"    rmvdiskaccess should be done for new I/O group before failing the"},{"line_number":8,"context_line":"    retype operation."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f621f24_227ceb1d","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":36},"updated":"2020-11-07 14:09:25.000000000","message":"According to the cinder release note style guide [0], the driver name should come first, followed by the bug link.\n\n[0] https://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers","commit_id":"84bb9890236424123169529309a6edcb724f668f"}]}