)]}'
{"cinder/tests/unit/volume/flows/test_create_volume_flow.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4e704c65a859c9684d1ab4e8cc224a545aa35258","unresolved":false,"context_lines":[{"line_number":1255,"context_line":"            exception\u003derr)"},{"line_number":1256,"context_line":""},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"@ddt.ddt"},{"line_number":1259,"context_line":"class CreateVolumeFlowManagerGlanceCinderBackendCase(test.TestCase):"},{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_0ca8108a","line":1258,"updated":"2020-10-06 18:27:06.000000000","message":"I think we want to change this to:\n    @ddt.ddt(testNameFormat\u003dddt.TestNameFormat.INDEX_ONLY)\n\n\nThis results in tests named\n    cinder.tests.unit.volume.flows.test_create_volume_flow.CreateVolumeFlowManagerGlanceCinderBackendCase.test__extract_cinder_ids_11\n\ninstead of\n    cinder.tests.unit.volume.flows.test_create_volume_flow.CreateVolumeFlowManagerGlanceCinderBackendCase.test__extract_cinder_ids_11____cinder___glance_store_name_4cd72b2b_5a4f_4f24_93dc_7c0212002916_garbage_______","commit_id":"22012e92968c08ea66ddfcf6dabba9ba0694b145"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"20e16e7dfde4b7fa778fbef1c187d5f9156dfeb0","unresolved":false,"context_lines":[{"line_number":1255,"context_line":"            exception\u003derr)"},{"line_number":1256,"context_line":""},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"@ddt.ddt"},{"line_number":1259,"context_line":"class CreateVolumeFlowManagerGlanceCinderBackendCase(test.TestCase):"},{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_850df736","line":1258,"in_reply_to":"9f560f44_0ca8108a","updated":"2020-10-08 12:45:03.000000000","message":"I agree, thanks for pointing out the option.  (I should really be more familiar with DDT; I just have \"folk knowledge\" of it.)","commit_id":"22012e92968c08ea66ddfcf6dabba9ba0694b145"}],"cinder/volume/flows/manager/create_volume.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b3c28b9df13f9bae04310717dc38e6febd405a6a","unresolved":false,"context_lines":[{"line_number":673,"context_line":"                    vol_id \u003d parts.path.split(\u0027/\u0027)[-1]"},{"line_number":674,"context_line":"                else:"},{"line_number":675,"context_line":"                    vol_id \u003d parts.netloc"},{"line_number":676,"context_line":"                if uuidutils.is_uuid_like(vol_id):"},{"line_number":677,"context_line":"                    ids.append(vol_id)"},{"line_number":678,"context_line":"                # TODO: log a message if it\u0027s not a UUID?"},{"line_number":679,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_62059079","line":676,"range":{"start_line":676,"start_character":19,"end_line":676,"end_character":28},"updated":"2020-10-01 21:43:39.000000000","message":"Forgot to import uuidutils!","commit_id":"0eaed8707308d4f143a771d9ad74b67ced2afe27"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fc1b1e83f7ab0642ebd769f43328d51600b9fac1","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        direct_url, locations \u003d image_location"},{"line_number":703,"context_line":"        urls \u003d set([direct_url] + [loc.get(\u0027url\u0027) for loc in locations or []])"},{"line_number":704,"context_line":"        image_volume_ids \u003d self._extract_cinder_ids(urls)"},{"line_number":705,"context_line":"        image_volumes \u003d self.db.volume_get_all_by_host("},{"line_number":706,"context_line":"            context, volume[\u0027host\u0027], filters\u003d{\u0027id\u0027: image_volume_ids})"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"        for image_volume in image_volumes:"},{"line_number":709,"context_line":"            # For the case image volume is stored in the service tenant,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f621f24_0b4cba9c","line":706,"range":{"start_line":705,"start_character":24,"end_line":706,"end_character":70},"updated":"2020-11-02 09:36:09.000000000","message":"This only works for the case when the volume created is in the same backend as the image-volume is.\nEg: \nimage-volume host is, hostname@cephdriver-1#cephdriver-1 (created in ceph backend)\nand we request a volume to be created in lvm backend then this searches the volume with host value of hostname@lvmdriver-1#lvmdriver-1\nwhich returns empty list","commit_id":"9359fb37539cb0b37b3389b9dab83733aeb5945c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5932c2b4ec5a17d766bcadd597c55ccc804f6276","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        direct_url, locations \u003d image_location"},{"line_number":703,"context_line":"        urls \u003d set([direct_url] + [loc.get(\u0027url\u0027) for loc in locations or []])"},{"line_number":704,"context_line":"        image_volume_ids \u003d self._extract_cinder_ids(urls)"},{"line_number":705,"context_line":"        image_volumes \u003d self.db.volume_get_all_by_host("},{"line_number":706,"context_line":"            context, volume[\u0027host\u0027], filters\u003d{\u0027id\u0027: image_volume_ids})"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"        for image_volume in image_volumes:"},{"line_number":709,"context_line":"            # For the case image volume is stored in the service tenant,"}],"source_content_type":"text/x-python","patch_set":7,"id":"f20509b0_d0b5e918","line":706,"range":{"start_line":705,"start_character":24,"end_line":706,"end_character":70},"in_reply_to":"1f621f24_0b4cba9c","updated":"2021-08-18 18:35:33.000000000","message":"Ignore this, since we are performing a clone operation, the backend should be same as the source image-volume\u0027s backend.","commit_id":"9359fb37539cb0b37b3389b9dab83733aeb5945c"}]}