)]}'
{"cinder/image/glance.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"293cfc16844938fa39cbca6c7b2e2bf037e55154","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import itertools"},{"line_number":21,"context_line":"import random"},{"line_number":22,"context_line":"import shutil"},{"line_number":23,"context_line":"import sys"},{"line_number":24,"context_line":"import textwrap"},{"line_number":25,"context_line":"import time"},{"line_number":26,"context_line":"import urllib"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_96df020b","line":23,"updated":"2020-10-07 12:45:05.000000000","message":"pep8: F401 \u0027sys\u0027 imported but unused","commit_id":"b5351128f6cc06adb5d18ba3463b0ffaf65023fd"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"882483147e95a7dd71161b59cafccbe663bba5ee","unresolved":false,"context_lines":[{"line_number":619,"context_line":"    \"\"\"Transform the exception for the image but keep its traceback intact.\"\"\""},{"line_number":620,"context_line":"    _exc_type, exc_value, exc_trace \u003d sys.exc_info()"},{"line_number":621,"context_line":"    new_exc \u003d _translate_image_exception(image_id, exc_value)"},{"line_number":622,"context_line":"    raise new_exc"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"def _reraise_translated_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c4f25f6f","line":622,"updated":"2020-10-07 19:37:38.000000000","message":"This changes behavior. Need to keep the traceback of the original exception (as noted in docstring).","commit_id":"ee80ce3f646fe81aa09ae4d57e6f2a3f54a76ea2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3b250c0c60017398f139f76bc0fe9e97d4b54cfb","unresolved":false,"context_lines":[{"line_number":619,"context_line":"    \"\"\"Transform the exception for the image but keep its traceback intact.\"\"\""},{"line_number":620,"context_line":"    _exc_type, exc_value, exc_trace \u003d sys.exc_info()"},{"line_number":621,"context_line":"    new_exc \u003d _translate_image_exception(image_id, exc_value)"},{"line_number":622,"context_line":"    raise new_exc"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"def _reraise_translated_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_2c868b66","line":622,"in_reply_to":"9f560f44_c4f25f6f","updated":"2020-10-08 23:11:51.000000000","message":"I think the thing to do here is:\n\n  raise new_exc.with_traceback(exc_trace)","commit_id":"ee80ce3f646fe81aa09ae4d57e6f2a3f54a76ea2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"882483147e95a7dd71161b59cafccbe663bba5ee","unresolved":false,"context_lines":[{"line_number":626,"context_line":"    \"\"\"Transform the exception but keep its traceback intact.\"\"\""},{"line_number":627,"context_line":"    _exc_type, exc_value, exc_trace \u003d sys.exc_info()"},{"line_number":628,"context_line":"    new_exc \u003d _translate_plain_exception(exc_value)"},{"line_number":629,"context_line":"    raise new_exc"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"def _translate_image_exception(image_id, exc_value):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_24e4fba7","line":629,"updated":"2020-10-07 19:37:38.000000000","message":"Same.","commit_id":"ee80ce3f646fe81aa09ae4d57e6f2a3f54a76ea2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f38b199abc634c3958f5a90232eec2115327acf7","unresolved":false,"context_lines":[{"line_number":619,"context_line":"    \"\"\"Transform the exception for the image but keep its traceback intact.\"\"\""},{"line_number":620,"context_line":"    _exc_type, exc_value, exc_trace \u003d sys.exc_info()"},{"line_number":621,"context_line":"    new_exc \u003d _translate_image_exception(image_id, exc_value)"},{"line_number":622,"context_line":"    raise new_exc.with_traceback(exc_trace)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"def _reraise_translated_exception():"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4f675fb9","line":622,"updated":"2020-10-10 02:00:34.000000000","message":"We don\u0027t have test coverage for this or the next function.  This change looks correct, but it would be good to have tests.  Not sure if they need to be added as part of this patch, or could be done as a followup, though.","commit_id":"b76440a7ea5567d6d86c1ca7fede9563d58d1ce9"}],"cinder/image/image_utils.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"882483147e95a7dd71161b59cafccbe663bba5ee","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                    message \u003d _(\u0027Failed to verify signature for \u0027"},{"line_number":480,"context_line":"                                \u0027image: %(image)s due to \u0027"},{"line_number":481,"context_line":"                                \u0027error: %(error)s \u0027) % {\u0027image\u0027: image_id,"},{"line_number":482,"context_line":"                                                        \u0027error\u0027: str(ex)}"},{"line_number":483,"context_line":"                    LOG.error(message)"},{"line_number":484,"context_line":"                    raise exception.ImageSignatureVerificationException("},{"line_number":485,"context_line":"                        reason\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a4f76b5a","line":482,"range":{"start_line":482,"start_character":65,"end_line":482,"end_character":69},"updated":"2020-10-07 19:37:38.000000000","message":"This should just be removed. The ex variable is being formatted into %s, so forcing a conversion to str() here is redundant and unnecessary.","commit_id":"ee80ce3f646fe81aa09ae4d57e6f2a3f54a76ea2"}]}