)]}'
{"cinder/openstack/common/__init__.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"94eb1d60a9e3d33d911db6945ee7adc56153802e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import six"},{"line_number":2,"context_line":"six.add_move(six.MovedModule(\u0027mox\u0027, \u0027mox\u0027, \u0027mox3.mox\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2F1ys%3D","line":1,"updated":"2014-03-03 21:09:22.000000000","message":"It\u0027s kind of concerning to see a file appear with code in it but no header.  I don\u0027t know whether this is ok or bad in this instance.","commit_id":"aa11fecb7199e406c369ec32fdc4572feab999bb"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4c4ae74be6c443fc3b1dbb8de8499d692fd7f77f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import six"},{"line_number":2,"context_line":"six.add_move(six.MovedModule(\u0027mox\u0027, \u0027mox\u0027, \u0027mox3.mox\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2F0jE%3D","line":1,"in_reply_to":"AAAAVn%2F%2F1ys%3D","updated":"2014-03-03 23:12:30.000000000","message":"Eric, this is actually in oslo-incubator:\n\nhttps://github.com/openstack/oslo-incubator/commit/c178e567cb48d3bc67dcf06bcbb4c6a97df9f434#diff-a26ce47ac8cffa8aeae29c808910ccb1\n\nJim Carey and I talked about this the other day and it looks like something that shouldn\u0027t have gotten through review.  Jim didn\u0027t push this up with his changes for Nova.  I can remove the change for our purposes if you wish.","commit_id":"aa11fecb7199e406c369ec32fdc4572feab999bb"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"0f29b8f43ef91191690bd87e25e9858191361f76","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import six"},{"line_number":2,"context_line":"six.add_move(six.MovedModule(\u0027mox\u0027, \u0027mox\u0027, \u0027mox3.mox\u0027))"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAVn%2F%2FX%2FQ%3D","line":2,"updated":"2014-03-06 14:48:02.000000000","message":"This still looks bogus... is there much effort required to remove it? Or explain why it is needed?","commit_id":"ebaa668c92da85668948a288f80f906888eda41a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"de50e7689d671966ca15379cb684826ef9102eb3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import six"},{"line_number":2,"context_line":"six.add_move(six.MovedModule(\u0027mox\u0027, \u0027mox\u0027, \u0027mox3.mox\u0027))"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAVn%2F%2FXiA%3D","line":2,"in_reply_to":"AAAAVn%2F%2FX%2FQ%3D","updated":"2014-03-06 15:38:58.000000000","message":"Duncan, I have taken a closer look at this.  The commit it goes with is:  https://github.com/openstack/oslo-incubator/commit/c178e567cb48d3bc67dcf06bcbb4c6a97df9f434\n\nSo, in this case it is using six to set-up mox to be compatible for Python3 testing.  I think it is harmless but I can remove it if it really bothers you.  I would then need to also rebase https://review.openstack.org/#/c/70465/ .","commit_id":"ebaa668c92da85668948a288f80f906888eda41a"}],"cinder/openstack/common/config/generator.py":[{"author":{"_account_id":6094,"name":"Navneet Singh","email":"navsinghnitd@gmail.com","username":"singn"},"change_message_id":"7a971fec617041abfd8a2b7630472010c4cc2c5d","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    for value in group._opts.values():"},{"line_number":150,"context_line":"        # NOTE(llu): Temporary workaround for bug #1262148, wait until"},{"line_number":151,"context_line":"        # newly released oslo.config support \u0027\u003d\u003d\u0027 operator."},{"line_number":152,"context_line":"        if not(value[\u0027opt\u0027] !\u003d opt):"},{"line_number":153,"context_line":"            return True"},{"line_number":154,"context_line":"    return False"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAU3%2F%2FhL4%3D","line":152,"updated":"2014-02-26 06:27:45.000000000","message":"It seems you want if value[\u0027opt\u0027] \u003d\u003d opt:","commit_id":"4d86e0ea969fd5d14ddf5bc320756ad6813dae8e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"07d29bcdf6b11486da85875c77e6a3a1547d5b1d","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    for value in group._opts.values():"},{"line_number":150,"context_line":"        # NOTE(llu): Temporary workaround for bug #1262148, wait until"},{"line_number":151,"context_line":"        # newly released oslo.config support \u0027\u003d\u003d\u0027 operator."},{"line_number":152,"context_line":"        if not(value[\u0027opt\u0027] !\u003d opt):"},{"line_number":153,"context_line":"            return True"},{"line_number":154,"context_line":"    return False"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAU3%2F%2FZig%3D","line":152,"in_reply_to":"AAAAU3%2F%2FhL4%3D","updated":"2014-02-26 21:01:12.000000000","message":"Navneet, it appears that this was done on purpose if you read the comment and check out the bug in question.  This is the way the code currently is in Oslo, so I don\u0027t know that we want to change it:  https://github.com/openstack/oslo-incubator/blob/master/openstack/common/config/generator.py#L152","commit_id":"4d86e0ea969fd5d14ddf5bc320756ad6813dae8e"}],"etc/cinder/cinder.conf.sample":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"220b71f3bbd802d18b8c3e23d07805a80545dd05","unresolved":false,"context_lines":[{"line_number":1953,"context_line":""},{"line_number":1954,"context_line":""},{"line_number":1955,"context_line":"[keystone_authtoken]"},{"line_number":1956,"context_line":""},{"line_number":1957,"context_line":"#"},{"line_number":1958,"context_line":"# Options defined in keystoneclient.middleware.auth_token"},{"line_number":1959,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"AAAAVn%2F%2FpgM%3D","side":"PARENT","line":1956,"updated":"2014-03-04 21:20:28.000000000","message":"I think the keystone_authtoken section is supposed to still be here.","commit_id":"d8d9531295b234dfd2d92958c28732557518a0a3"}]}