)]}'
{"cinder/scheduler/host_manager.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7cbfcd51a0c5a11a3a73bceda3aa4b181134d766","unresolved":false,"context_lines":[{"line_number":938,"context_line":"        available_backup_hosts \u003d self._list_available_backup_hosts(az)"},{"line_number":939,"context_line":"        if not host or not CONF.backup_use_same_host:"},{"line_number":940,"context_line":"            backup_host \u003d self._get_any_available_backup_service(az, driver)"},{"line_number":941,"context_line":"        elif host in available_backup_hosts:"},{"line_number":942,"context_line":"            backup_host \u003d host"},{"line_number":943,"context_line":"        if not backup_host:"},{"line_number":944,"context_line":"            raise exception.ServiceNotFound(service_id\u003d\u0027cinder-backup\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_d38ed0ce","line":941,"range":{"start_line":941,"start_character":13,"end_line":941,"end_character":44},"updated":"2020-11-04 14:35:59.000000000","message":"I\u0027m not sure what\u0027s the issue here, we are already checking if the service is up on L#983","commit_id":"d2d0607e4adf4afc4005c8bc45271e39b1b6aef6"},{"author":{"_account_id":32537,"name":"ZhaoYixin","email":"zhaoyixin@inspur.com","username":"zhaoyixin"},"change_message_id":"d125291d1bee41299fbceff8de04f87ec9b98d30","unresolved":false,"context_lines":[{"line_number":994,"context_line":"        for srv in services:"},{"line_number":995,"context_line":"            if srv.is_up and self._az_matched(srv, availability_zone):"},{"line_number":996,"context_line":"                hosts.append(srv.host)"},{"line_number":997,"context_line":"            elif not srv.is_up and srv.host in self.backup_service_states:"},{"line_number":998,"context_line":"                del self.backup_service_states[srv.host]"},{"line_number":999,"context_line":"        return hosts"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_3cba6cdd","line":998,"range":{"start_line":997,"start_character":0,"end_line":998,"end_character":56},"updated":"2020-11-05 02:00:05.000000000","message":"The point is here. When going to L#940, it is not checking if the service is up in function \u0027_list_backup_services\u0027.","commit_id":"d2d0607e4adf4afc4005c8bc45271e39b1b6aef6"}],"cinder/tests/unit/scheduler/test_host_manager.py":[{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"614056d5886223c3e389c6caf820370a9b0aace4","unresolved":false,"context_lines":[{"line_number":1271,"context_line":"    @mock.patch(\u0027cinder.db.service_get_all\u0027)"},{"line_number":1272,"context_line":"    def test_list_available_backup_hosts(self, _mock_service_get_all):"},{"line_number":1273,"context_line":"        services \u003d ["},{"line_number":1274,"context_line":"            dict(id\u003d1, host\u003d\u0027host1\u0027, topic\u003d\u0027backup\u0027, disabled\u003dFalse,"},{"line_number":1275,"context_line":"                 availability_zone\u003d\u0027zone1\u0027, updated_at\u003dtimeutils.utcnow(),"},{"line_number":1276,"context_line":"                 uuid\u003d\u002736ede0e2-1b3c-41b0-9cd3-66e1f56dc959\u0027),"},{"line_number":1277,"context_line":"            dict(id\u003d2, host\u003d\u0027host2\u0027, topic\u003d\u0027backup\u0027, disabled\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_89c1e0e7","line":1274,"updated":"2020-11-03 10:37:01.000000000","message":"Use {} instead of dict()","commit_id":"eca55022184d25f37cdbe02b49327fcea608fc25"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"614056d5886223c3e389c6caf820370a9b0aace4","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"                \u0027driver_name\u0027: \u0027swift\u0027,"},{"line_number":1300,"context_line":"                \u0027availability_zone\u0027: \u0027zone1\u0027"},{"line_number":1301,"context_line":"            }"},{"line_number":1302,"context_line":"        }"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"        res_hosts \u003d self.host_manager._list_available_backup_hosts(\u0027zone1\u0027)"},{"line_number":1305,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_498ea8d0","line":1302,"updated":"2020-11-03 10:37:01.000000000","message":"Unit tests only test True scenario, makes sense to also test False scenario for down cinder backup service","commit_id":"eca55022184d25f37cdbe02b49327fcea608fc25"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6d9d84799881428eaad1b700a7db4c74b045156e","unresolved":false,"context_lines":[{"line_number":1318,"context_line":"        }"},{"line_number":1319,"context_line":""},{"line_number":1320,"context_line":"        self.assertEqual(expected_hosts, res_hosts)"},{"line_number":1321,"context_line":"        self.assertEqual(expected_backup_service_states, self.host_manager.backup_service_states)"},{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":""},{"line_number":1324,"context_line":"class BackendStateTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_960f38e0","line":1321,"updated":"2020-11-03 14:25:19.000000000","message":"pep8: E501 line too long (97 \u003e 79 characters)","commit_id":"eca55022184d25f37cdbe02b49327fcea608fc25"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"ba3728909959afb92fb7cde6b9cb1406a78df17a","unresolved":false,"context_lines":[{"line_number":1291,"context_line":""},{"line_number":1292,"context_line":"        with mock.patch.dict(self.host_manager.backup_service_states,"},{"line_number":1293,"context_line":"                             mocked_backup_service_states):"},{"line_number":1294,"context_line":"            actual_host \u003d self.host_manager.\\"},{"line_number":1295,"context_line":"                _get_available_backup_service_host(None, \u0027az1\u0027)"},{"line_number":1296,"context_line":"            self.assertEqual(\u0027host1\u0027, actual_host)"},{"line_number":1297,"context_line":"            actual_host \u003d self.host_manager. \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_62f44cf3","line":1294,"updated":"2020-11-04 10:44:16.000000000","message":"If a line of code must extend over more than one line, use parenthesis () around the code instead of \\ at the end of the line.","commit_id":"b1180b92ff46816f16e3477de7d6a57cc8a3141e"}]}