)]}'
{"cinder/tests/unit/volume/drivers/hitachi/test_hitachi_hbsd_rest_fc.py":[{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"429531d305ec14304d04eb53eadbc75fb2b24195","unresolved":false,"context_lines":[{"line_number":567,"context_line":"                               FakeResponse(202, COMPLETED_SUCCEEDED_RESULT)]"},{"line_number":568,"context_line":"        self.driver.delete_volume(TEST_VOLUME[0])"},{"line_number":569,"context_line":"        self.assertEqual(7, request.call_count)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    @mock.patch.object(requests.Session, \"request\")"},{"line_number":572,"context_line":"    def test_extend_volume(self, request):"},{"line_number":573,"context_line":"        request.side_effect \u003d [FakeResponse(200, GET_LDEV_RESULT),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_5c292836","line":570,"updated":"2020-11-05 02:23:12.000000000","message":"Need a unit test of raising an exception.","commit_id":"f57e89c60d3d62846eb9c3d884649bcfb9ebce27"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"362b8eb2bbec1f98d49fd6bddcdfa68096eee864","unresolved":false,"context_lines":[{"line_number":567,"context_line":"                               FakeResponse(202, COMPLETED_SUCCEEDED_RESULT)]"},{"line_number":568,"context_line":"        self.driver.delete_volume(TEST_VOLUME[0])"},{"line_number":569,"context_line":"        self.assertEqual(7, request.call_count)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    @mock.patch.object(requests.Session, \"request\")"},{"line_number":572,"context_line":"    def test_extend_volume(self, request):"},{"line_number":573,"context_line":"        request.side_effect \u003d [FakeResponse(200, GET_LDEV_RESULT),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_e42b2d2d","line":570,"in_reply_to":"1f621f24_5c292836","updated":"2020-11-06 08:20:55.000000000","message":"Done","commit_id":"f57e89c60d3d62846eb9c3d884649bcfb9ebce27"}],"cinder/volume/drivers/hitachi/hbsd_rest.py":[{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"429531d305ec14304d04eb53eadbc75fb2b24195","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        if not loop.start(interval\u003d10).wait():"},{"line_number":353,"context_line":"            msg \u003d utils.output_log("},{"line_number":354,"context_line":"                MSG.PAIR_STATUS_WAIT_TIMEOUT, svol\u003dldev)"},{"line_number":355,"context_line":"            raise utils.HBSDError(msg)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def _delete_pair_from_storage(self, pvol, svol):"},{"line_number":358,"context_line":"        \"\"\"Disconnect the volume pair that consists of the specified LDEVs.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_9c22a051","line":355,"range":{"start_line":355,"start_character":12,"end_line":355,"end_character":38},"updated":"2020-11-05 02:23:12.000000000","message":"The _wait_copy_pair_deleting() may raise utils.HBSDError, but the delete_volume() does not catch it.","commit_id":"f57e89c60d3d62846eb9c3d884649bcfb9ebce27"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"362b8eb2bbec1f98d49fd6bddcdfa68096eee864","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        if not loop.start(interval\u003d10).wait():"},{"line_number":353,"context_line":"            msg \u003d utils.output_log("},{"line_number":354,"context_line":"                MSG.PAIR_STATUS_WAIT_TIMEOUT, svol\u003dldev)"},{"line_number":355,"context_line":"            raise utils.HBSDError(msg)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def _delete_pair_from_storage(self, pvol, svol):"},{"line_number":358,"context_line":"        \"\"\"Disconnect the volume pair that consists of the specified LDEVs.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_849fd95d","line":355,"range":{"start_line":355,"start_character":12,"end_line":355,"end_character":38},"in_reply_to":"1f621f24_9c22a051","updated":"2020-11-06 08:20:55.000000000","message":"Done","commit_id":"f57e89c60d3d62846eb9c3d884649bcfb9ebce27"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"1669537d64e7ee282676257201a5fdd3973e83eb","unresolved":true,"context_lines":[{"line_number":57,"context_line":"UNKN \u003d 0xff"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"_STATUS_TABLE \u003d {"},{"line_number":60,"context_line":"    \u0027SMPL\u0027: SMPL,"},{"line_number":61,"context_line":"    \u0027COPY\u0027: COPY,"},{"line_number":62,"context_line":"    \u0027RCPY\u0027: COPY,"},{"line_number":63,"context_line":"    \u0027PAIR\u0027: PAIR,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba038a6f_f369b030","line":60,"updated":"2020-12-24 20:43:32.000000000","message":"nit: it might be obvious for you, but these acronyms are not self-explanatory for everybody, and requires consulting external documentation.\n\nFor instance, I can\u0027t tell if \u0027PFUS\u0027: PSUS and \u0027SSUS\u0027: PSUS are typos or not.\n\nYou might want to give some meaningful names to them in a future patch.","commit_id":"acfb3361cddedbf148935427c2840e7141800b58"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"ede04084e8944924d3cc72874aa45e03bbae6618","unresolved":false,"context_lines":[{"line_number":57,"context_line":"UNKN \u003d 0xff"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"_STATUS_TABLE \u003d {"},{"line_number":60,"context_line":"    \u0027SMPL\u0027: SMPL,"},{"line_number":61,"context_line":"    \u0027COPY\u0027: COPY,"},{"line_number":62,"context_line":"    \u0027RCPY\u0027: COPY,"},{"line_number":63,"context_line":"    \u0027PAIR\u0027: PAIR,"}],"source_content_type":"text/x-python","patch_set":5,"id":"87bcc0e4_0903517e","line":60,"in_reply_to":"ba038a6f_f369b030","updated":"2020-12-25 05:13:03.000000000","message":"I think that requires consideration. I will submit another patch for readability.","commit_id":"acfb3361cddedbf148935427c2840e7141800b58"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"1669537d64e7ee282676257201a5fdd3973e83eb","unresolved":true,"context_lines":[{"line_number":648,"context_line":"            return None"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"        pvol, svol_info \u003d self._get_copy_pair_info(ldev)"},{"line_number":651,"context_line":"        if svol_info and svol_info[0][\u0027status\u0027] in (\u0027SMPP\u0027, \u0027PSUP\u0027):"},{"line_number":652,"context_line":"            self._wait_copy_pair_deleting(svol_info[0][\u0027ldev\u0027])"},{"line_number":653,"context_line":"            return self.get_pair_info(ldev)"},{"line_number":654,"context_line":"        if pvol is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"be9ed042_4a0c5306","line":651,"updated":"2020-12-24 20:43:32.000000000","message":"nit: I believe that this already fixes the issue, but you may want to follow the style used in other places (e.g. L623, L630):\n\n    if _STATUS_TABLE.get(svol_info[0][\u0027status\u0027]) in (SMPP, PSUP):","commit_id":"acfb3361cddedbf148935427c2840e7141800b58"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"ede04084e8944924d3cc72874aa45e03bbae6618","unresolved":false,"context_lines":[{"line_number":648,"context_line":"            return None"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"        pvol, svol_info \u003d self._get_copy_pair_info(ldev)"},{"line_number":651,"context_line":"        if svol_info and svol_info[0][\u0027status\u0027] in (\u0027SMPP\u0027, \u0027PSUP\u0027):"},{"line_number":652,"context_line":"            self._wait_copy_pair_deleting(svol_info[0][\u0027ldev\u0027])"},{"line_number":653,"context_line":"            return self.get_pair_info(ldev)"},{"line_number":654,"context_line":"        if pvol is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ee8c6b73_54422d72","line":651,"in_reply_to":"be9ed042_4a0c5306","updated":"2020-12-25 05:13:03.000000000","message":"In this case, I cannot directly use _STASU_TABLE.get() because the driver need to check whether the volume status is \u0027PSUP\u0027 or not. The _STASU_TABLE doesn\u0027t return the value of \u0027PSUP\u0027 now.\nI\u0027ll fix this point at the same time as we submit a patch for readability.","commit_id":"acfb3361cddedbf148935427c2840e7141800b58"}],"releasenotes/notes/hitachi-fix-delete-volume-issues-e648525e597505fd.yaml":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"7054c52832dd19c1b6d7f82d555bd03b9d48eb1e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1908792 \u003chttps://bugs.launchpad.net/cinder/+bug/1908792\u003e`_:"},{"line_number":5,"context_line":"    Fix for Hitachi driver allowing delete_volume after create_cloned_volume."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7909c861_ee82b9be","line":3,"updated":"2020-12-24 01:28:56.000000000","message":"Please follow the new format [0] for driver specific bug fix release notes:\n\n    Hitachi driver `bug #1908792\n    \u003chttps://bugs.launchpad.net/cinder/+bug/1908792\u003e`_: Fix ...\n\n[0] https://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers","commit_id":"33420430982b5dd3558827f7d36a6d364671f9a5"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"5b2488d8ae6ab04642cb976db150f32dcbb63371","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1908792 \u003chttps://bugs.launchpad.net/cinder/+bug/1908792\u003e`_:"},{"line_number":5,"context_line":"    Fix for Hitachi driver allowing delete_volume after create_cloned_volume."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8cd944a8_1e8b3463","line":3,"in_reply_to":"7909c861_ee82b9be","updated":"2020-12-24 05:32:01.000000000","message":"Done","commit_id":"33420430982b5dd3558827f7d36a6d364671f9a5"}]}