)]}'
{"cinder/policies/snapshot_metadata.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e5519b5c9aa6e668df19c991fce220d913fb4c72","unresolved":true,"context_lines":[{"line_number":22,"context_line":"DELETE_POLICY \u003d \u0027volume:delete_snapshot_metadata\u0027"},{"line_number":23,"context_line":"UPDATE_POLICY \u003d \u0027volume:update_snapshot_metadata\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"deprecated_get_snapshot_metadata \u003d policy.DeprecatedRule("},{"line_number":26,"context_line":"    name\u003dGET_POLICY,"},{"line_number":27,"context_line":"    check_str\u003dbase.RULE_ADMIN_OR_OWNER"},{"line_number":28,"context_line":")"}],"source_content_type":"text/x-python","patch_set":6,"id":"bc5b3050_7198b517","line":25,"range":{"start_line":25,"start_character":42,"end_line":25,"end_character":56},"updated":"2021-09-03 18:46:33.000000000","message":"We\u0027ll need to make sure we update this to use CinderDeprecatedRule.","commit_id":"d8bd67b32a4d01a98d1b14e2c817dde3caeba89e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"427d6023e29b1b277e6d9075c2686e239231957d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"DELETE_POLICY \u003d \u0027volume:delete_snapshot_metadata\u0027"},{"line_number":23,"context_line":"UPDATE_POLICY \u003d \u0027volume:update_snapshot_metadata\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"deprecated_get_snapshot_metadata \u003d policy.DeprecatedRule("},{"line_number":26,"context_line":"    name\u003dGET_POLICY,"},{"line_number":27,"context_line":"    check_str\u003dbase.RULE_ADMIN_OR_OWNER"},{"line_number":28,"context_line":")"}],"source_content_type":"text/x-python","patch_set":6,"id":"ae1c8b03_a7a268bb","line":25,"range":{"start_line":25,"start_character":42,"end_line":25,"end_character":56},"in_reply_to":"bc5b3050_7198b517","updated":"2021-09-03 18:48:32.000000000","message":"Done","commit_id":"d8bd67b32a4d01a98d1b14e2c817dde3caeba89e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5ea40f068bb0959bf87bca40061a10d9a776d1b0","unresolved":true,"context_lines":[{"line_number":22,"context_line":"DELETE_POLICY \u003d \u0027volume:delete_snapshot_metadata\u0027"},{"line_number":23,"context_line":"UPDATE_POLICY \u003d \u0027volume:update_snapshot_metadata\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"deprecated_get_snapshot_metadata \u003d policy.CinderDeprecatedRule("},{"line_number":26,"context_line":"    name\u003dGET_POLICY,"},{"line_number":27,"context_line":"    check_str\u003dbase.RULE_ADMIN_OR_OWNER"},{"line_number":28,"context_line":")"}],"source_content_type":"text/x-python","patch_set":7,"id":"ab20a162_3a866f62","line":25,"range":{"start_line":25,"start_character":35,"end_line":25,"end_character":41},"updated":"2021-09-03 19:38:47.000000000","message":"nit: base*","commit_id":"a7e180e812363e1079891170b36bc21ebb9b8937"}],"cinder/tests/unit/policies/test_snapshot_metadata.py":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"2fbd7bd3fba1630327bb3dba1805e5681720cc92","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        metadata \u003d {\u0027inside\u0027: \u0027out\u0027}"},{"line_number":144,"context_line":"        snapshot \u003d self._create_snapshot(metadata\u003dmetadata)"},{"line_number":145,"context_line":"        rule_name \u003d policy.DELETE_POLICY"},{"line_number":146,"context_line":"        url \u003d \u0027%s/%s/metadata/inside\u0027 % (self.api_path, snapshot.id)"},{"line_number":147,"context_line":"        req \u003d fake_api.HTTPRequest.blank(url, version\u003dself.api_version)"},{"line_number":148,"context_line":"        req.method \u003d \u0027DELETE\u0027"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"37362eb5_298cac68","line":146,"updated":"2021-09-13 18:32:12.000000000","message":"Probably I\u0027m missing something but shouldn\u0027t this be \u0027path\u0027: \u0027/snapshots/{snapshot_id}/metadata/{key}\u0027","commit_id":"f32676c9aefe0899fe3591bb255a258f0dae2fa2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4a4ca3b7890e49fe71174373760152e04d3f6c60","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        metadata \u003d {\u0027inside\u0027: \u0027out\u0027}"},{"line_number":144,"context_line":"        snapshot \u003d self._create_snapshot(metadata\u003dmetadata)"},{"line_number":145,"context_line":"        rule_name \u003d policy.DELETE_POLICY"},{"line_number":146,"context_line":"        url \u003d \u0027%s/%s/metadata/inside\u0027 % (self.api_path, snapshot.id)"},{"line_number":147,"context_line":"        req \u003d fake_api.HTTPRequest.blank(url, version\u003dself.api_version)"},{"line_number":148,"context_line":"        req.method \u003d \u0027DELETE\u0027"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"24c20277_244df27e","line":146,"in_reply_to":"37362eb5_298cac68","updated":"2021-09-13 19:39:25.000000000","message":"It\u0027s kind of hard to read, but \u0027inside\u0027 is the key (see line 143).  So I think this is an OK URL.","commit_id":"f32676c9aefe0899fe3591bb255a258f0dae2fa2"}]}
