)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0d0c3312b078691f9502862df5babc50de278495","unresolved":false,"context_lines":[{"line_number":16,"context_line":"other volumes in the storage group. The staging storage group and"},{"line_number":17,"context_line":"masking views facilitate a seamless live migration operation in"},{"line_number":18,"context_line":"upgraded releases."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I4d28d8ed2375f68eed511de5c25898362eac1def"},{"line_number":21,"context_line":"Closes-Bug: #1867163"},{"line_number":22,"context_line":"(cherry picked from commit 197e024747ca04daeb35a9eaa9f1350089211ea3)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f621f24_75fb3678","line":19,"updated":"2020-11-09 17:40:28.000000000","message":"Please add the file conflicts in the description (see stable policy [1]). Some explanation of the changes would be also good.\n\nConflicts:\n   cinder/tests/unit/volume/drivers/dell_emc/vmax/test_vmax.py\n   cinder/volume/drivers/dell_emc/vmax/common.py\n   cinder/volume/drivers/dell_emc/vmax/fc.py\n   cinder/volume/drivers/dell_emc/vmax/iscsi.py\n   cinder/volume/drivers/dell_emc/vmax/masking.py\n   cinder/volume/drivers/dell_emc/vmax/utils.py\n\n\n[1] https://docs.openstack.org/project-team-guide/stable-branches.html#conflicts","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"}],"cinder/tests/unit/volume/drivers/dell_emc/vmax/test_vmax.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0d0c3312b078691f9502862df5babc50de278495","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    test_volume_attachment \u003d volume_attachment.VolumeAttachment("},{"line_number":254,"context_line":"        id\u003d\u00272b06255d-f5f0-4520-a953-b029196add6b\u0027, volume_id\u003dtest_volume.id,"},{"line_number":255,"context_line":"        connector\u003dconnector)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    location_info \u003d {\u0027location_info\u0027: \u0027000197800123#SRP_1#Diamond#DSS\u0027,"},{"line_number":258,"context_line":"                     \u0027storage_protocol\u0027: \u0027FC\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_0f174b53","line":255,"updated":"2020-11-09 17:40:28.000000000","message":"This was added in Rocky with patch I7313c704ac45ea3e813e4816815d1d6a8ea39a9b\n\nIs this necessary for this backport?","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"673514516d81b85e26030258e1f4fc1d191b0537","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    test_volume_attachment \u003d volume_attachment.VolumeAttachment("},{"line_number":254,"context_line":"        id\u003d\u00272b06255d-f5f0-4520-a953-b029196add6b\u0027, volume_id\u003dtest_volume.id,"},{"line_number":255,"context_line":"        connector\u003dconnector)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    location_info \u003d {\u0027location_info\u0027: \u0027000197800123#SRP_1#Diamond#DSS\u0027,"},{"line_number":258,"context_line":"                     \u0027storage_protocol\u0027: \u0027FC\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fd031f8_e436be21","line":255,"in_reply_to":"1f621f24_0f174b53","updated":"2021-05-25 10:50:20.000000000","message":"Yes it is, it is necessary for tests\nVMAXMigrateTest.test_get_volume_host_list\nVMAXMigrateTest.test_get_volume_host_list_no_attachments","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0d0c3312b078691f9502862df5babc50de278495","unresolved":false,"context_lines":[{"line_number":3712,"context_line":"        with mock.patch.object(self.masking,"},{"line_number":3713,"context_line":"                               \u0027remove_and_reset_members\u0027) as mock_rm:"},{"line_number":3714,"context_line":"            self.common._remove_members("},{"line_number":3715,"context_line":"                array, volume, device_id, extra_specs, self.data.connector)"},{"line_number":3716,"context_line":"            mock_rm.assert_called_once_with("},{"line_number":3717,"context_line":"                array, volume, device_id, volume_name,"},{"line_number":3718,"context_line":"                extra_specs, True, self.data.connector, async_grp\u003dNone)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_ea00fd03","line":3715,"updated":"2020-11-09 17:40:28.000000000","message":"nit: unnecessary change","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"673514516d81b85e26030258e1f4fc1d191b0537","unresolved":false,"context_lines":[{"line_number":3712,"context_line":"        with mock.patch.object(self.masking,"},{"line_number":3713,"context_line":"                               \u0027remove_and_reset_members\u0027) as mock_rm:"},{"line_number":3714,"context_line":"            self.common._remove_members("},{"line_number":3715,"context_line":"                array, volume, device_id, extra_specs, self.data.connector)"},{"line_number":3716,"context_line":"            mock_rm.assert_called_once_with("},{"line_number":3717,"context_line":"                array, volume, device_id, volume_name,"},{"line_number":3718,"context_line":"                extra_specs, True, self.data.connector, async_grp\u003dNone)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a9f13fdd_91b6006e","line":3715,"in_reply_to":"1f621f24_ea00fd03","updated":"2021-05-25 10:50:20.000000000","message":"Sure, I will change this","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"}],"cinder/volume/drivers/dell_emc/vmax/common.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3af7c40430849b4bdcf4aea796131d84b1ad8afd","unresolved":false,"context_lines":[{"line_number":533,"context_line":"        if is_live_migration and len(source_storage_group_list) \u003d\u003d 1:"},{"line_number":534,"context_line":"            LOG.info(\"Volume %s is mapped. Failed live migration case\","},{"line_number":535,"context_line":"                     volume_name)"},{"line_number":536,"context_line":"            return "},{"line_number":537,"context_line":"        source_nf_sg \u003d None"},{"line_number":538,"context_line":"        target_nf_sg \u003d None"},{"line_number":539,"context_line":"        legacy_cleanup \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_9d1b071a","line":536,"updated":"2020-10-30 01:54:15.000000000","message":"pep8: W291 trailing whitespace","commit_id":"95803760304bbcdf5a00edd198affde9c6e933fa"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3af7c40430849b4bdcf4aea796131d84b1ad8afd","unresolved":false,"context_lines":[{"line_number":559,"context_line":"                        array, device_info[\u0027device_id\u0027], volume_name,"},{"line_number":560,"context_line":"                        storage_group, extra_specs)"},{"line_number":561,"context_line":"                    LOG.debug(\"Removed %(dev_id)s from source STG storage \""},{"line_number":562,"context_line":"                          \"group %(sg)s in the live migration process.\","},{"line_number":563,"context_line":"                          {\u0027dev_id\u0027: device_info[\u0027device_id\u0027],"},{"line_number":564,"context_line":"                           \u0027sg\u0027: storage_group})"},{"line_number":565,"context_line":"        if source_nf_sg:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_7d18ab1c","line":562,"updated":"2020-10-30 01:54:15.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"95803760304bbcdf5a00edd198affde9c6e933fa"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3af7c40430849b4bdcf4aea796131d84b1ad8afd","unresolved":false,"context_lines":[{"line_number":560,"context_line":"                        storage_group, extra_specs)"},{"line_number":561,"context_line":"                    LOG.debug(\"Removed %(dev_id)s from source STG storage \""},{"line_number":562,"context_line":"                          \"group %(sg)s in the live migration process.\","},{"line_number":563,"context_line":"                          {\u0027dev_id\u0027: device_info[\u0027device_id\u0027],"},{"line_number":564,"context_line":"                           \u0027sg\u0027: storage_group})"},{"line_number":565,"context_line":"        if source_nf_sg:"},{"line_number":566,"context_line":"            # Remove volume from non fast storage group"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_ddd29f34","line":563,"updated":"2020-10-30 01:54:15.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"95803760304bbcdf5a00edd198affde9c6e933fa"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3af7c40430849b4bdcf4aea796131d84b1ad8afd","unresolved":false,"context_lines":[{"line_number":650,"context_line":"            extra_specs \u003d rep_extra_specs"},{"line_number":651,"context_line":"        device_info_dict, is_live_migration, source_storage_group_list \u003d ("},{"line_number":652,"context_line":"            self.find_host_lun_id(volume, connector[\u0027host\u0027], extra_specs,"},{"line_number":653,"context_line":"                connector\u003dconnector))"},{"line_number":654,"context_line":"        masking_view_dict \u003d self._populate_masking_dict("},{"line_number":655,"context_line":"            volume, connector, extra_specs)"},{"line_number":656,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_bdd7e323","line":653,"updated":"2020-10-30 01:54:15.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"95803760304bbcdf5a00edd198affde9c6e933fa"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0d0c3312b078691f9502862df5babc50de278495","unresolved":false,"context_lines":[{"line_number":536,"context_line":"            return"},{"line_number":537,"context_line":"        source_nf_sg \u003d None"},{"line_number":538,"context_line":"        target_nf_sg \u003d None"},{"line_number":539,"context_line":"        legacy_cleanup \u003d False"},{"line_number":540,"context_line":"        array \u003d extra_specs[utils.ARRAY]"},{"line_number":541,"context_line":"        if self.utils.does_vol_need_rdf_management_group(extra_specs):"},{"line_number":542,"context_line":"            async_grp \u003d self.utils.get_async_rdf_managed_grp_name("}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_0a38d93a","line":539,"updated":"2020-11-09 17:40:28.000000000","message":"this flag is newly introduced. why do we need this? (and the related changes below)","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"673514516d81b85e26030258e1f4fc1d191b0537","unresolved":false,"context_lines":[{"line_number":536,"context_line":"            return"},{"line_number":537,"context_line":"        source_nf_sg \u003d None"},{"line_number":538,"context_line":"        target_nf_sg \u003d None"},{"line_number":539,"context_line":"        legacy_cleanup \u003d False"},{"line_number":540,"context_line":"        array \u003d extra_specs[utils.ARRAY]"},{"line_number":541,"context_line":"        if self.utils.does_vol_need_rdf_management_group(extra_specs):"},{"line_number":542,"context_line":"            async_grp \u003d self.utils.get_async_rdf_managed_grp_name("}],"source_content_type":"text/x-python","patch_set":4,"id":"91f92b65_900d8cec","line":539,"in_reply_to":"1f621f24_0a38d93a","updated":"2021-05-25 10:50:20.000000000","message":"I will put this in the description.  With the supporting of multi-attach in Rocky the code the backport was not straight forward.  This extra condition was required","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0d0c3312b078691f9502862df5babc50de278495","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                    LOG.debug(\"Removed %(dev_id)s from source STG storage \""},{"line_number":562,"context_line":"                              \"group %(sg)s in the live migration process.\","},{"line_number":563,"context_line":"                              {\u0027dev_id\u0027: device_info[\u0027device_id\u0027],"},{"line_number":564,"context_line":"                               \u0027sg\u0027: storage_group})"},{"line_number":565,"context_line":"        if source_nf_sg:"},{"line_number":566,"context_line":"            # Remove volume from non fast storage group"},{"line_number":567,"context_line":"            self.masking.remove_volume_from_sg("}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_2ab035dd","line":564,"updated":"2020-11-09 17:40:28.000000000","message":"This was not part of the patch on Rocky, and the above code part was refactored in Rocky with patch I7313c704ac45ea3e813e4816815d1d6a8ea39a9b.\nI guess this is why this extra change is needed.","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"673514516d81b85e26030258e1f4fc1d191b0537","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                    LOG.debug(\"Removed %(dev_id)s from source STG storage \""},{"line_number":562,"context_line":"                              \"group %(sg)s in the live migration process.\","},{"line_number":563,"context_line":"                              {\u0027dev_id\u0027: device_info[\u0027device_id\u0027],"},{"line_number":564,"context_line":"                               \u0027sg\u0027: storage_group})"},{"line_number":565,"context_line":"        if source_nf_sg:"},{"line_number":566,"context_line":"            # Remove volume from non fast storage group"},{"line_number":567,"context_line":"            self.masking.remove_volume_from_sg("}],"source_content_type":"text/x-python","patch_set":4,"id":"09613a68_61d2135d","line":564,"in_reply_to":"1f621f24_2ab035dd","updated":"2021-05-25 10:50:20.000000000","message":"I will put this in the description.  With the supporting of multi-attach in Rocky the code the backport was not straight forward.  This extra condition was required","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0d0c3312b078691f9502862df5babc50de278495","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            LOG.debug(\"Removed %(dev_id)s from source NONFAST storage \""},{"line_number":571,"context_line":"                      \"group %(sg)s in the live migration process.\","},{"line_number":572,"context_line":"                      {\u0027dev_id\u0027: device_info[\u0027device_id\u0027],"},{"line_number":573,"context_line":"                       \u0027sg\u0027: source_nf_sg})"},{"line_number":574,"context_line":"        elif target_nf_sg:"},{"line_number":575,"context_line":"            for storage_group in source_storage_group_list:"},{"line_number":576,"context_line":"                if storage_group.lower \u003d\u003d target_nf_sg:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_2a97953c","line":573,"updated":"2020-11-09 17:40:28.000000000","message":"change seems unrelated","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"673514516d81b85e26030258e1f4fc1d191b0537","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            LOG.debug(\"Removed %(dev_id)s from source NONFAST storage \""},{"line_number":571,"context_line":"                      \"group %(sg)s in the live migration process.\","},{"line_number":572,"context_line":"                      {\u0027dev_id\u0027: device_info[\u0027device_id\u0027],"},{"line_number":573,"context_line":"                       \u0027sg\u0027: source_nf_sg})"},{"line_number":574,"context_line":"        elif target_nf_sg:"},{"line_number":575,"context_line":"            for storage_group in source_storage_group_list:"},{"line_number":576,"context_line":"                if storage_group.lower \u003d\u003d target_nf_sg:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5539032d_65f7f04b","line":573,"in_reply_to":"1f621f24_2a97953c","updated":"2021-05-25 10:50:20.000000000","message":"I will leave this as the , is not necessary","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0d0c3312b078691f9502862df5babc50de278495","unresolved":false,"context_lines":[{"line_number":649,"context_line":"        if self.utils.is_volume_failed_over(volume):"},{"line_number":650,"context_line":"            extra_specs \u003d rep_extra_specs"},{"line_number":651,"context_line":"        device_info_dict, is_live_migration, source_storage_group_list \u003d ("},{"line_number":652,"context_line":"            self.find_host_lun_id(volume, connector[\u0027host\u0027], extra_specs,"},{"line_number":653,"context_line":"                                  connector\u003dconnector))"},{"line_number":654,"context_line":"        masking_view_dict \u003d self._populate_masking_dict("},{"line_number":655,"context_line":"            volume, connector, extra_specs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_aa756534","line":652,"range":{"start_line":652,"start_character":42,"end_line":652,"end_character":59},"updated":"2020-11-09 17:40:28.000000000","message":"the rocky patch replaces this to \n\nconnector.get(\u0027host\u0027)\n\nshouldn\u0027t be replaced in Queens, too?","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"673514516d81b85e26030258e1f4fc1d191b0537","unresolved":false,"context_lines":[{"line_number":649,"context_line":"        if self.utils.is_volume_failed_over(volume):"},{"line_number":650,"context_line":"            extra_specs \u003d rep_extra_specs"},{"line_number":651,"context_line":"        device_info_dict, is_live_migration, source_storage_group_list \u003d ("},{"line_number":652,"context_line":"            self.find_host_lun_id(volume, connector[\u0027host\u0027], extra_specs,"},{"line_number":653,"context_line":"                                  connector\u003dconnector))"},{"line_number":654,"context_line":"        masking_view_dict \u003d self._populate_masking_dict("},{"line_number":655,"context_line":"            volume, connector, extra_specs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ca940f4_08491cbe","line":652,"range":{"start_line":652,"start_character":42,"end_line":652,"end_character":59},"in_reply_to":"1f621f24_aa756534","updated":"2021-05-25 10:50:20.000000000","message":"Sure.  I can change this","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0d0c3312b078691f9502862df5babc50de278495","unresolved":false,"context_lines":[{"line_number":1227,"context_line":"                            elif \u0027STG-\u0027 in storage_group:"},{"line_number":1228,"context_line":"                                staging_host \u003d \u0027stg\u0027 + hoststr.lower()"},{"line_number":1229,"context_line":"                                if staging_host in storage_group.lower():"},{"line_number":1230,"context_line":"                                    is_live_migration \u003d True"},{"line_number":1231,"context_line":"        else:"},{"line_number":1232,"context_line":"            exception_message \u003d (_(\"Cannot retrieve volume %(vol)s \""},{"line_number":1233,"context_line":"                                   \"from the array.\") % {\u0027vol\u0027: volume_name})"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_caa701bd","line":1230,"updated":"2020-11-09 17:40:28.000000000","message":"This was not part of the patch on Rocky, and the above code part was refactored in Rocky with patch I7313c704ac45ea3e813e4816815d1d6a8ea39a9b.\nI guess this is why this extra change is needed.","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"}],"cinder/volume/drivers/dell_emc/vmax/masking.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0d0c3312b078691f9502862df5babc50de278495","unresolved":false,"context_lines":[{"line_number":1610,"context_line":"                device_info_dict[\u0027array\u0027], device_info_dict[\u0027device_id\u0027])"},{"line_number":1611,"context_line":"            if storage_group_list and len(storage_group_list) \u003d\u003d 1:"},{"line_number":1612,"context_line":"                if \u0027STG-\u0027 in storage_group_list[0]:"},{"line_number":1613,"context_line":"                    return"},{"line_number":1614,"context_line":"        if is_source_nf_sg is False:"},{"line_number":1615,"context_line":"            storage_group \u003d self.rest.get_storage_group("},{"line_number":1616,"context_line":"                device_info_dict[\u0027array\u0027], source_nf_sg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_6adcede3","line":1613,"updated":"2020-11-09 17:40:28.000000000","message":"changes here also seems to be related to patch I7313c704ac45ea3e813e4816815d1d6a8ea39a9b, which is not present in Queens","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"}],"cinder/volume/drivers/dell_emc/vmax/rest.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3af7c40430849b4bdcf4aea796131d84b1ad8afd","unresolved":false,"context_lines":[{"line_number":533,"context_line":"        :param array: the array serial number"},{"line_number":534,"context_line":"        :param params: dict of optional filters"},{"line_number":535,"context_line":"        :returns: storage group dict or None"},{"line_number":536,"context_line":"        \"\"\""},{"line_number":537,"context_line":"        return self.get_resource("},{"line_number":538,"context_line":"            array, SLOPROVISIONING, \u0027storagegroup\u0027, params\u003dparams)"},{"line_number":539,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_1ddd3742","line":536,"updated":"2020-10-30 01:54:15.000000000","message":"pep8: H405  multi line docstring summary not separated with an empty line","commit_id":"95803760304bbcdf5a00edd198affde9c6e933fa"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0d0c3312b078691f9502862df5babc50de278495","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        :returns: storage group dict or None"},{"line_number":537,"context_line":"        \"\"\""},{"line_number":538,"context_line":"        return self.get_resource("},{"line_number":539,"context_line":"            array, SLOPROVISIONING, \u0027storagegroup\u0027, params\u003dparams)"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    def get_num_vols_in_sg(self, array, storage_group_name):"},{"line_number":542,"context_line":"        \"\"\"Get the number of volumes in a storage group."}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_ca69c1f9","line":539,"updated":"2020-11-09 17:40:28.000000000","message":"This was added in Rocky with patch I7313c704ac45ea3e813e4816815d1d6a8ea39a9b. I guess this is used somewhere in this patch and that\u0027s why it is needed.","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"673514516d81b85e26030258e1f4fc1d191b0537","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        :returns: storage group dict or None"},{"line_number":537,"context_line":"        \"\"\""},{"line_number":538,"context_line":"        return self.get_resource("},{"line_number":539,"context_line":"            array, SLOPROVISIONING, \u0027storagegroup\u0027, params\u003dparams)"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    def get_num_vols_in_sg(self, array, storage_group_name):"},{"line_number":542,"context_line":"        \"\"\"Get the number of volumes in a storage group."}],"source_content_type":"text/x-python","patch_set":4,"id":"c7c7b843_108bc080","line":539,"in_reply_to":"1f621f24_ca69c1f9","updated":"2021-05-25 10:50:20.000000000","message":"Yes, it is called on line 1604 of masking.py","commit_id":"6b7490703f0e422eef00868889a2cba64a1ab19b"}]}