)]}'
{"cinder/api/v2/views/volumes.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"392b8ab285e31991f485bc2be0da5b630fc574eb","unresolved":true,"context_lines":[{"line_number":98,"context_line":"                volume.get(\u0027migration_status\u0027))"},{"line_number":99,"context_line":"            if volume.admin_metadata and \u0027format\u0027 in volume.admin_metadata:"},{"line_number":100,"context_line":"                volume_ref[\u0027volume\u0027][\u0027metadata\u0027][\u0027format\u0027] \u003d ("},{"line_number":101,"context_line":"                    volume.admin_metadata[\u0027format\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # NOTE(xyang): Display group_id as consistencygroup_id in detailed"},{"line_number":104,"context_line":"        # view of the volume if group is converted from cg."}],"source_content_type":"text/x-python","patch_set":6,"id":"33aca538_5cfafe7c","line":101,"updated":"2020-12-08 15:05:02.000000000","message":"Why do we want to return this info here?","commit_id":"af344f5c49ddc6f3987f4b4ab6632a47976e1bd5"}],"cinder/tests/unit/test_image_utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d1d11293f5eefa0b6ec61f74ffee84562c6c831f","unresolved":true,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"class TestResizeImage(test.TestCase):"},{"line_number":350,"context_line":"    @mock.patch(\u0027cinder.utils.execute\u0027)"},{"line_number":351,"context_line":"    def test_defaults(self, mock_exec):"},{"line_number":352,"context_line":"        source \u003d mock.sentinel.source"},{"line_number":353,"context_line":"        size \u003d mock.sentinel.size"},{"line_number":354,"context_line":"        format \u003d mock.sentinel.format"}],"source_content_type":"text/x-python","patch_set":9,"id":"ad5edc19_e6f4405f","line":351,"range":{"start_line":351,"start_character":8,"end_line":351,"end_character":21},"updated":"2021-03-03 23:26:41.000000000","message":"two things:\n1. after your revisions, this is more like \"test_with_format\". \n2. i think it would be a good idea to also have a \"test_defaults\" that doesn\u0027t pass the format so we could detect something stupid like \u0027-f None\u0027 being passed to qemu-img if someone refactored the resize_image utility.","commit_id":"3b60aa37f8986011fdb2327fc0fd2b76e8608d8b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"24172753da1247f3e23ff8cbcc03c86fae0eeb7f","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"class TestResizeImage(test.TestCase):"},{"line_number":350,"context_line":"    @mock.patch(\u0027cinder.utils.execute\u0027)"},{"line_number":351,"context_line":"    def test_defaults(self, mock_exec):"},{"line_number":352,"context_line":"        source \u003d mock.sentinel.source"},{"line_number":353,"context_line":"        size \u003d mock.sentinel.size"},{"line_number":354,"context_line":"        format \u003d mock.sentinel.format"}],"source_content_type":"text/x-python","patch_set":9,"id":"da41b4ed_0ee94fe3","line":351,"range":{"start_line":351,"start_character":8,"end_line":351,"end_character":21},"in_reply_to":"ad5edc19_e6f4405f","updated":"2021-03-05 21:44:35.000000000","message":"Done","commit_id":"3b60aa37f8986011fdb2327fc0fd2b76e8608d8b"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/test_nfs_base.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d1d11293f5eefa0b6ec61f74ffee84562c6c831f","unresolved":true,"context_lines":[{"line_number":560,"context_line":"        locations \u003d self.driver._construct_image_nfs_url(img_loc)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        self.assertIn(\"nfs://host/path/image-id\", locations)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"    @mock.patch(\u0027cinder.objects.volume.Volume.get_by_id\u0027)"},{"line_number":565,"context_line":"    def test_extend_volume(self, mock_get):"},{"line_number":566,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"11bf40ec_cf068baf","line":563,"updated":"2021-03-03 23:26:41.000000000","message":"These revisions look good.  It might be a good idea to have a test that doesn\u0027t set the format in volume admin metadata to make sure nothing blows up when it\u0027s missing. (Unless we know that will never happen, but I think we don\u0027t know that?)","commit_id":"3b60aa37f8986011fdb2327fc0fd2b76e8608d8b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"24172753da1247f3e23ff8cbcc03c86fae0eeb7f","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        locations \u003d self.driver._construct_image_nfs_url(img_loc)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        self.assertIn(\"nfs://host/path/image-id\", locations)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"    @mock.patch(\u0027cinder.objects.volume.Volume.get_by_id\u0027)"},{"line_number":565,"context_line":"    def test_extend_volume(self, mock_get):"},{"line_number":566,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"01cb6c5f_1caf8cb8","line":563,"in_reply_to":"11bf40ec_cf068baf","updated":"2021-03-05 21:44:35.000000000","message":"Sorry about this, these were changes when format was necessary to be passed (not considering legacy volumes). Updated tests now.","commit_id":"3b60aa37f8986011fdb2327fc0fd2b76e8608d8b"}],"cinder/volume/drivers/netapp/dataontap/nfs_base.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"174aac25becdb26f09ef899ac4e45d842feda89d","unresolved":true,"context_lines":[{"line_number":656,"context_line":"            image_utils.resize_image(path, new_size,"},{"line_number":657,"context_line":"                                     run_as_root\u003dself._execute_as_root,"},{"line_number":658,"context_line":"                                     file_format\u003dfile_format)"},{"line_number":659,"context_line":"            if file_format \u003d\u003d \u0027qcow2\u0027 and not self._is_file_size_equal("},{"line_number":660,"context_line":"                    path, new_size):"},{"line_number":661,"context_line":"                raise exception.InvalidResults("},{"line_number":662,"context_line":"                    _(\u0027Resizing image file failed.\u0027))"}],"source_content_type":"text/x-python","patch_set":11,"id":"836bad24_5cdeb440","line":659,"range":{"start_line":659,"start_character":15,"end_line":659,"end_character":37},"updated":"2021-03-11 23:11:18.000000000","message":"I don\u0027t think this will ever happen in the netapp driver, is this necessary?","commit_id":"057aa7740e8393379c441b09938646d286d17903"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2bfef3a7bc18234cd7f97e6fe3a68c405af697de","unresolved":false,"context_lines":[{"line_number":656,"context_line":"            image_utils.resize_image(path, new_size,"},{"line_number":657,"context_line":"                                     run_as_root\u003dself._execute_as_root,"},{"line_number":658,"context_line":"                                     file_format\u003dfile_format)"},{"line_number":659,"context_line":"            if file_format \u003d\u003d \u0027qcow2\u0027 and not self._is_file_size_equal("},{"line_number":660,"context_line":"                    path, new_size):"},{"line_number":661,"context_line":"                raise exception.InvalidResults("},{"line_number":662,"context_line":"                    _(\u0027Resizing image file failed.\u0027))"}],"source_content_type":"text/x-python","patch_set":11,"id":"4dc9e476_5e1cf90c","line":659,"range":{"start_line":659,"start_character":15,"end_line":659,"end_character":37},"in_reply_to":"836bad24_5cdeb440","updated":"2021-03-12 13:04:55.000000000","message":"The \"nfs_qcow2_volumes\" option will create qcow2 volumes w/ the netapp nfs driver, so this does make sense.","commit_id":"057aa7740e8393379c441b09938646d286d17903"}],"cinder/volume/drivers/remotefs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"15aca2047e7c741992e9be965f0a70de8f398318","unresolved":false,"context_lines":[{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"        if utils.paths_normcase_equal(info[\u0027active_file\u0027],"},{"line_number":1741,"context_line":"                                      info[\u0027snapshot_file\u0027]):"},{"line_number":1742,"context_line":"            # blockRebase/Pull base into active"},{"line_number":1743,"context_line":"            # info[\u0027base\u0027] \u003d\u003e snapshot_file"},{"line_number":1744,"context_line":""},{"line_number":1745,"context_line":"            file_to_delete \u003d info[\u0027base_file\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_412e7c43","line":1742,"updated":"2020-11-03 15:13:00.000000000","message":"This scenario will change the format of the base volume file, so the volume file format would need to be updated.","commit_id":"98676ca204bcbced03498387fb58a7ae89d1d2b9"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"aa48a55082b765405a5a6d4a98dfb848f8ea0378","unresolved":false,"context_lines":[{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"        if utils.paths_normcase_equal(info[\u0027active_file\u0027],"},{"line_number":1741,"context_line":"                                      info[\u0027snapshot_file\u0027]):"},{"line_number":1742,"context_line":"            # blockRebase/Pull base into active"},{"line_number":1743,"context_line":"            # info[\u0027base\u0027] \u003d\u003e snapshot_file"},{"line_number":1744,"context_line":""},{"line_number":1745,"context_line":"            file_to_delete \u003d info[\u0027base_file\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_ace71cac","line":1742,"in_reply_to":"1f621f24_412e7c43","updated":"2020-11-12 05:53:43.000000000","message":"Done","commit_id":"98676ca204bcbced03498387fb58a7ae89d1d2b9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"952fb6a92edc6a38218566902b00abdc23e42db0","unresolved":true,"context_lines":[{"line_number":357,"context_line":"            # QCOW2 volumes are inherently sparse, so this setting"},{"line_number":358,"context_line":"            # will override the _sparsed_volumes setting."},{"line_number":359,"context_line":"            self._create_qcow2_file(volume_path, volume_size)"},{"line_number":360,"context_line":"            self.format \u003d \u0027qcow2\u0027"},{"line_number":361,"context_line":"        elif getattr(self.configuration,"},{"line_number":362,"context_line":"                     self.driver_prefix + \u0027_sparsed_volumes\u0027, False):"},{"line_number":363,"context_line":"            self._create_sparsed_file(volume_path, volume_size)"}],"source_content_type":"text/x-python","patch_set":11,"id":"00216cae_07c5d3c3","line":360,"range":{"start_line":360,"start_character":12,"end_line":360,"end_character":33},"updated":"2021-03-11 23:24:30.000000000","message":"I think this might cause problems if the admin changes the *fs_qcow2_volumes option after creating raw volumes on the deployment?","commit_id":"057aa7740e8393379c441b09938646d286d17903"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"92a09bc7ab9857571aee03d52af2bf66f953773b","unresolved":true,"context_lines":[{"line_number":357,"context_line":"            # QCOW2 volumes are inherently sparse, so this setting"},{"line_number":358,"context_line":"            # will override the _sparsed_volumes setting."},{"line_number":359,"context_line":"            self._create_qcow2_file(volume_path, volume_size)"},{"line_number":360,"context_line":"            self.format \u003d \u0027qcow2\u0027"},{"line_number":361,"context_line":"        elif getattr(self.configuration,"},{"line_number":362,"context_line":"                     self.driver_prefix + \u0027_sparsed_volumes\u0027, False):"},{"line_number":363,"context_line":"            self._create_sparsed_file(volume_path, volume_size)"}],"source_content_type":"text/x-python","patch_set":11,"id":"78615771_5b58b878","line":360,"range":{"start_line":360,"start_character":12,"end_line":360,"end_character":33},"in_reply_to":"00216cae_07c5d3c3","updated":"2021-03-12 12:57:40.000000000","message":"Never mind, this should be fine for create_volume.","commit_id":"057aa7740e8393379c441b09938646d286d17903"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e7a45db5e6854645ad997b1ab22d7397e8d3562f","unresolved":true,"context_lines":[{"line_number":588,"context_line":"        # thus the initial \u0027size\u0027 parameter is not honored"},{"line_number":589,"context_line":"        # this sets the size to the one asked in the first place by the user"},{"line_number":590,"context_line":"        # and then verify the final virtual size"},{"line_number":591,"context_line":"        image_utils.resize_image(self.local_path(volume), volume.size,"},{"line_number":592,"context_line":"                                 run_as_root\u003dself._execute_as_root)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        data \u003d image_utils.qemu_img_info(self.local_path(volume),"}],"source_content_type":"text/x-python","patch_set":11,"id":"ea7e404c_941c87cf","line":591,"range":{"start_line":591,"start_character":8,"end_line":591,"end_character":32},"updated":"2021-03-11 23:21:07.000000000","message":"Does this call need to pass a format parameter?","commit_id":"057aa7740e8393379c441b09938646d286d17903"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a3196379d69a7ed73a39189476bbc009779d4f21","unresolved":false,"context_lines":[{"line_number":588,"context_line":"        # thus the initial \u0027size\u0027 parameter is not honored"},{"line_number":589,"context_line":"        # this sets the size to the one asked in the first place by the user"},{"line_number":590,"context_line":"        # and then verify the final virtual size"},{"line_number":591,"context_line":"        image_utils.resize_image(self.local_path(volume), volume.size,"},{"line_number":592,"context_line":"                                 run_as_root\u003dself._execute_as_root)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        data \u003d image_utils.qemu_img_info(self.local_path(volume),"}],"source_content_type":"text/x-python","patch_set":11,"id":"8dc4b33b_55a205e5","line":591,"range":{"start_line":591,"start_character":8,"end_line":591,"end_character":32},"in_reply_to":"ea7e404c_941c87cf","updated":"2021-03-12 13:25:13.000000000","message":"This is actually purposefully using auto-detection, so it doesn\u0027t need a format parameter passed.","commit_id":"057aa7740e8393379c441b09938646d286d17903"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2ff447c7a98a1713e38462e96de764d968dbb890","unresolved":true,"context_lines":[{"line_number":1782,"context_line":"            snap_info[snapshot.volume.id] \u003d info[\u0027snapshot_file\u0027]"},{"line_number":1783,"context_line":"            snapshot.volume.admin_metadata[\u0027format\u0027] \u003d \u0027qcow2\u0027"},{"line_number":1784,"context_line":"            with snapshot.volume.obj_as_admin():"},{"line_number":1785,"context_line":"                snapshot.volume.save()"},{"line_number":1786,"context_line":"        else:"},{"line_number":1787,"context_line":"            # blockCommit snapshot into base"},{"line_number":1788,"context_line":"            # info[\u0027base\u0027] \u003c\u003d snapshot_file"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f3685ac_3777fc17","line":1785,"updated":"2021-03-12 13:38:00.000000000","message":"This can\u0027t be saved until after _nova_assisted_vol_snap_delete() at line 1799 has completed.  If we save this here and the call to Nova fails, the format field in the database is now wrong.","commit_id":"057aa7740e8393379c441b09938646d286d17903"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"44303a85a1b0580f8c5dccaeda5d59bd72e6b953","unresolved":false,"context_lines":[{"line_number":1782,"context_line":"            snap_info[snapshot.volume.id] \u003d info[\u0027snapshot_file\u0027]"},{"line_number":1783,"context_line":"            snapshot.volume.admin_metadata[\u0027format\u0027] \u003d \u0027qcow2\u0027"},{"line_number":1784,"context_line":"            with snapshot.volume.obj_as_admin():"},{"line_number":1785,"context_line":"                snapshot.volume.save()"},{"line_number":1786,"context_line":"        else:"},{"line_number":1787,"context_line":"            # blockCommit snapshot into base"},{"line_number":1788,"context_line":"            # info[\u0027base\u0027] \u003c\u003d snapshot_file"}],"source_content_type":"text/x-python","patch_set":11,"id":"16a50b14_97793346","line":1785,"in_reply_to":"5f3685ac_3777fc17","updated":"2021-03-12 18:16:47.000000000","message":"Done","commit_id":"057aa7740e8393379c441b09938646d286d17903"}]}