)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/powermax/powermax_data.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"02f93fba749a3bc3b3fd5c6ed60baf7e8e87eef0","unresolved":true,"context_lines":[{"line_number":1663,"context_line":"        }"},{"line_number":1664,"context_line":"    }"},{"line_number":1665,"context_line":""},{"line_number":1666,"context_line":"    port_info_off \u003d deepcopy(port_info)"},{"line_number":1667,"context_line":"    port_info_off.update({\"symmetrixPort\": {"},{"line_number":1668,"context_line":"        \"director_status\": \"Offline\","},{"line_number":1669,"context_line":"        \"port_status\": \"OFF\"}})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ddf7186a_e0dc0e30","line":1666,"updated":"2021-03-02 13:27:38.000000000","message":"not sure why you\u0027re doing the deepcopy and update, because you\u0027re  replacing the entire dict with the content of the update, so you could just set port_info_off to the literal used in the update.  This isn\u0027t incorrect, just thought I\u0027d point it out to make sure the result is what you want.","commit_id":"b62f250bc327e5444c6bed9963c815c647de9193"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"582ee537f2ccdfdc27c4eac210831986b60780cf","unresolved":false,"context_lines":[{"line_number":1663,"context_line":"        }"},{"line_number":1664,"context_line":"    }"},{"line_number":1665,"context_line":""},{"line_number":1666,"context_line":"    port_info_off \u003d deepcopy(port_info)"},{"line_number":1667,"context_line":"    port_info_off.update({\"symmetrixPort\": {"},{"line_number":1668,"context_line":"        \"director_status\": \"Offline\","},{"line_number":1669,"context_line":"        \"port_status\": \"OFF\"}})"}],"source_content_type":"text/x-python","patch_set":4,"id":"dd1fabe9_0471616e","line":1666,"in_reply_to":"ddf7186a_e0dc0e30","updated":"2021-03-02 15:17:35.000000000","message":"Thanks Brian.  We use deepcopy if there is any chance the original dict may be changed and might impact other tests.  Perhaps its overused but it has solved unit test issues for us in the past.","commit_id":"b62f250bc327e5444c6bed9963c815c647de9193"}],"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_masking.py":[{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"68f25b6d0915845cab001eed4bb369e93e0323e6","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"                       return_value\u003d[\u0027FA-1D:4\u0027])"},{"line_number":1244,"context_line":"    def test_check_director_and_port_status(self, mock_port_ids, mock_port):"},{"line_number":1245,"context_line":"        self.mask._check_director_and_port_status("},{"line_number":1246,"context_line":"            self.data.array, self.data.port_group_name_f)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_d8051f13","line":1246,"updated":"2020-11-09 10:31:53.000000000","message":"Unit test doesn\u0027t cover scenarios of down director/port groups or raising of exception and various exception messages.","commit_id":"b484d08f39f059240da7489fa3902c5e1e16a0bd"}],"cinder/volume/drivers/dell_emc/powermax/iscsi.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4f823187c79473b8de9630f4f225f6e96eef0e1c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2020 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_5de10b2a","line":1,"updated":"2020-11-06 19:29:07.000000000","message":"pep8: E902 TokenError: EOF in multi-line string","commit_id":"42845a1853250bb080fd20ece3914c89687a2b79"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4f823187c79473b8de9630f4f225f6e96eef0e1c","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @classmethod"},{"line_number":161,"context_line":"    def get_driver_options(cls):"},{"line_number":162,"context_line":"        additional_opts \u003d cls._get_oslo_driver_opts("},{"line_number":163,"context_line":"            \u0027san_ip\u0027, \u0027san_login\u0027, \u0027san_password\u0027, \u0027driver_ssl_cert_verify\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_bdd3ff5f","line":160,"updated":"2020-11-06 19:29:07.000000000","message":"pep8: E303 too many blank lines (3)","commit_id":"42845a1853250bb080fd20ece3914c89687a2b79"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"cc39119e3bcda339b8f1e4c32c7f1d3e702490a9","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        :param snapshot: the cinder snapshot object"},{"line_number":681,"context_line":"        \"\"\""},{"line_number":682,"context_line":"        self.common.revert_to_snapshot(volume, snapshot)"},{"line_number":683,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_7e966e95","line":683,"updated":"2020-11-09 17:56:29.000000000","message":"pep8: W391 blank line at end of file","commit_id":"b484d08f39f059240da7489fa3902c5e1e16a0bd"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"68f25b6d0915845cab001eed4bb369e93e0323e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1f621f24_15176253","line":684,"updated":"2020-11-09 10:31:53.000000000","message":"pep8 will likely complain here about two blank lines","commit_id":"b484d08f39f059240da7489fa3902c5e1e16a0bd"}],"cinder/volume/drivers/dell_emc/powermax/masking.py":[{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"5383a04d1762b7119f7b01ffb646588699b60d2f","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                    port_status \u003d port_details.get(\u0027port_status\u0027)"},{"line_number":251,"context_line":"                    if not director_status or not port_status:"},{"line_number":252,"context_line":"                        exc_msg \u003d (\"Unable to get the director or port status \""},{"line_number":253,"context_line":"                                   \"for port %(port)s.\" % {\u0027port\u0027: port})"},{"line_number":254,"context_line":"                    elif not (director_status.lower() \u003d\u003d \u0027online\u0027 and ("},{"line_number":255,"context_line":"                            port_status.lower() \u003d\u003d \u0027on\u0027)):"},{"line_number":256,"context_line":"                        exc_msg \u003d (\"The director status is %(ds)s and the \""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_9830c7ea","line":253,"updated":"2020-11-09 10:35:54.000000000","message":"change port to dir:port for better insight for end user into where problem lies","commit_id":"b484d08f39f059240da7489fa3902c5e1e16a0bd"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"5383a04d1762b7119f7b01ffb646588699b60d2f","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                        exc_msg \u003d (\"The director status is %(ds)s and the \""},{"line_number":257,"context_line":"                                   \"port status is %(ps)s.\""},{"line_number":258,"context_line":"                                   % {\u0027ds\u0027: director_status,"},{"line_number":259,"context_line":"                                      \u0027ps\u0027: port_status})"},{"line_number":260,"context_line":"                else:"},{"line_number":261,"context_line":"                    exc_msg \u003d (\"Unable to get port details for port \""},{"line_number":262,"context_line":"                               \"%(port)s.\" % {\u0027port\u0027: port})"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_d8535f16","line":259,"updated":"2020-11-09 10:35:54.000000000","message":"Give the dir:port key to the user here also.","commit_id":"b484d08f39f059240da7489fa3902c5e1e16a0bd"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"5383a04d1762b7119f7b01ffb646588699b60d2f","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                                      \u0027ps\u0027: port_status})"},{"line_number":260,"context_line":"                else:"},{"line_number":261,"context_line":"                    exc_msg \u003d (\"Unable to get port details for port \""},{"line_number":262,"context_line":"                               \"%(port)s.\" % {\u0027port\u0027: port})"},{"line_number":263,"context_line":"            else:"},{"line_number":264,"context_line":"                exc_msg \u003d (\"Unable to get port information for port %(port)s.\""},{"line_number":265,"context_line":"                           % {\u0027port\u0027: port})"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_185af728","line":262,"updated":"2020-11-09 10:35:54.000000000","message":"And here","commit_id":"b484d08f39f059240da7489fa3902c5e1e16a0bd"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"5383a04d1762b7119f7b01ffb646588699b60d2f","unresolved":false,"context_lines":[{"line_number":261,"context_line":"                    exc_msg \u003d (\"Unable to get port details for port \""},{"line_number":262,"context_line":"                               \"%(port)s.\" % {\u0027port\u0027: port})"},{"line_number":263,"context_line":"            else:"},{"line_number":264,"context_line":"                exc_msg \u003d (\"Unable to get port information for port %(port)s.\""},{"line_number":265,"context_line":"                           % {\u0027port\u0027: port})"},{"line_number":266,"context_line":"        if exc_msg:"},{"line_number":267,"context_line":"            LOG.error(exc_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_78420b40","line":264,"updated":"2020-11-09 10:35:54.000000000","message":"And here","commit_id":"b484d08f39f059240da7489fa3902c5e1e16a0bd"}]}