)]}'
{"cinder/api/validation/parameter_types.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8d764792ac044587e4d13e252957cc3f7f413ca7","unresolved":true,"context_lines":[{"line_number":224,"context_line":"    # means a hostname. The hostname grammar in RFC952 does"},{"line_number":225,"context_line":"    # not allow for underscores in hostnames. However, this"},{"line_number":226,"context_line":"    # schema allows them, because it sometimes occurs in"},{"line_number":227,"context_line":"    # real systems. As it is a cinder host, not a hostname,"},{"line_number":228,"context_line":"    # and due to some driver needs, colons and forward slashes"},{"line_number":229,"context_line":"    # were also included in the regex."},{"line_number":230,"context_line":"    \u0027pattern\u0027: \u0027^[a-zA-Z0-9-._#@:/+]*$\u0027"},{"line_number":231,"context_line":"}"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c1e0e240_91fe42ba","line":229,"range":{"start_line":227,"start_character":20,"end_line":229,"end_character":37},"updated":"2021-01-08 19:11:53.000000000","message":"I wonder whether it would make sense to just change the pattern here instead of introducing a new one.  It\u0027s also used in services.py and workers.py, and I think those might run into the same problem you\u0027re fixing here?  Also, it\u0027s a widening regex, so it won\u0027t invalidate any of the current names (and it just acts as a character screen, it doesn\u0027t really detect a pattern).\n\nIf you do compress them into one, i think your name of \u0027cinder_host\u0027 is much better than \u0027hostname\u0027.","commit_id":"a4a6bcd3d02c9ba44128b43aed866056ee61848e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5a5984ce71dc78c3f641bae406b12a56b204c439","unresolved":true,"context_lines":[{"line_number":224,"context_line":"    # means a hostname. The hostname grammar in RFC952 does"},{"line_number":225,"context_line":"    # not allow for underscores in hostnames. However, this"},{"line_number":226,"context_line":"    # schema allows them, because it sometimes occurs in"},{"line_number":227,"context_line":"    # real systems. As it is a cinder host, not a hostname,"},{"line_number":228,"context_line":"    # and due to some driver needs, colons and forward slashes"},{"line_number":229,"context_line":"    # were also included in the regex."},{"line_number":230,"context_line":"    \u0027pattern\u0027: \u0027^[a-zA-Z0-9-._#@:/+]*$\u0027"},{"line_number":231,"context_line":"}"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"963ab75f_8f9f13f7","line":229,"range":{"start_line":227,"start_character":20,"end_line":229,"end_character":37},"in_reply_to":"8fb808b7_d53aa091","updated":"2021-02-24 21:31:24.000000000","message":"parameter_types.hostname is used to validate the \"cluster_name\" argument in api/schemas/workers.py:\n    https://opendev.org/openstack/cinder/src/commit/c6b2ea4253b332454dfac62feee187ba19ef84ba/cinder/api/schemas/workers.py#L26\n\nI suspect that location is not one that we want to add the full cinder_host spec to, so we probably need to keep the two different validation specs.\n\nIt probably should be added for enable_and_disable, freeze_and_thaw, and failover_host in api/schemas/services.py, but I\u0027ll submit a follow-up patch for that so we can make sure to review them carefully.","commit_id":"a4a6bcd3d02c9ba44128b43aed866056ee61848e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e7294ae49cf765d6f564c35c73f1fe299fa3b71f","unresolved":true,"context_lines":[{"line_number":224,"context_line":"    # means a hostname. The hostname grammar in RFC952 does"},{"line_number":225,"context_line":"    # not allow for underscores in hostnames. However, this"},{"line_number":226,"context_line":"    # schema allows them, because it sometimes occurs in"},{"line_number":227,"context_line":"    # real systems. As it is a cinder host, not a hostname,"},{"line_number":228,"context_line":"    # and due to some driver needs, colons and forward slashes"},{"line_number":229,"context_line":"    # were also included in the regex."},{"line_number":230,"context_line":"    \u0027pattern\u0027: \u0027^[a-zA-Z0-9-._#@:/+]*$\u0027"},{"line_number":231,"context_line":"}"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e9ea193f_11faf93b","line":229,"range":{"start_line":227,"start_character":20,"end_line":229,"end_character":37},"in_reply_to":"963ab75f_8f9f13f7","updated":"2021-02-25 03:41:08.000000000","message":"OK, sounds like we need both definitions.  Thanks for looking more closely.","commit_id":"a4a6bcd3d02c9ba44128b43aed866056ee61848e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b496dad7ed4ff78fc5f2e100e1580fbddae62a6d","unresolved":true,"context_lines":[{"line_number":224,"context_line":"    # means a hostname. The hostname grammar in RFC952 does"},{"line_number":225,"context_line":"    # not allow for underscores in hostnames. However, this"},{"line_number":226,"context_line":"    # schema allows them, because it sometimes occurs in"},{"line_number":227,"context_line":"    # real systems. As it is a cinder host, not a hostname,"},{"line_number":228,"context_line":"    # and due to some driver needs, colons and forward slashes"},{"line_number":229,"context_line":"    # were also included in the regex."},{"line_number":230,"context_line":"    \u0027pattern\u0027: \u0027^[a-zA-Z0-9-._#@:/+]*$\u0027"},{"line_number":231,"context_line":"}"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fab4a4c2_0e6bfd10","line":229,"range":{"start_line":227,"start_character":20,"end_line":229,"end_character":37},"in_reply_to":"c1e0e240_91fe42ba","updated":"2021-02-17 16:25:40.000000000","message":"Your line of thinking seems good here, I just need to verify if there is anywhere that we actually do want to validate something more like a \"hostname\" instead of the full cinder host identifier.  Not totally sure.","commit_id":"a4a6bcd3d02c9ba44128b43aed866056ee61848e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"24a40f121546631cef49faada5fd354dce1de403","unresolved":true,"context_lines":[{"line_number":224,"context_line":"    # means a hostname. The hostname grammar in RFC952 does"},{"line_number":225,"context_line":"    # not allow for underscores in hostnames. However, this"},{"line_number":226,"context_line":"    # schema allows them, because it sometimes occurs in"},{"line_number":227,"context_line":"    # real systems. As it is a cinder host, not a hostname,"},{"line_number":228,"context_line":"    # and due to some driver needs, colons and forward slashes"},{"line_number":229,"context_line":"    # were also included in the regex."},{"line_number":230,"context_line":"    \u0027pattern\u0027: \u0027^[a-zA-Z0-9-._#@:/+]*$\u0027"},{"line_number":231,"context_line":"}"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8fb808b7_d53aa091","line":229,"range":{"start_line":227,"start_character":20,"end_line":229,"end_character":37},"in_reply_to":"fab4a4c2_0e6bfd10","updated":"2021-02-24 13:29:40.000000000","message":"OK, ping me when you decide and i\u0027ll re-review.  We definitely should get this into Wallaby.","commit_id":"a4a6bcd3d02c9ba44128b43aed866056ee61848e"}]}