)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3221a06e530c25ca2381962064d2a8659f960895","unresolved":true,"context_lines":[{"line_number":10,"context_line":"for JovianDSS data storage."},{"line_number":11,"context_line":"Added support of revert to snapshot functionality."},{"line_number":12,"context_line":"Also it expands unit-test coverage for JovianDSS driver."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If0444fe479750dd79f3d3c3eb83b9d5c3e14053c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ac4cb985_b5bc0b6e","line":13,"updated":"2020-12-17 19:10:17.000000000","message":"add:\n\n  Implements: bp jdss-add-cert-and-snapshot-revert","commit_id":"44976401b3b2c98bb0c9de9f2a49729f2e94c17a"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"faa3c3460ac186a8980de3f954dc3aa98953527e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"JovianDSS: add support of self-signed certificates and snapshot restore"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added support of authenticity verification through self-signed certificates"},{"line_number":10,"context_line":"for JovianDSS data storage."},{"line_number":11,"context_line":"Added support of revert to snapshot functionality."},{"line_number":12,"context_line":"Expanded unit-test coverage for JovianDSS driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"de2aa6ce_34e61f25","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":75},"updated":"2021-02-26 10:03:26.000000000","message":"lines should be wrapped at 72 chars.\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"b7759426b2a3c703e6380c19b66a5cba060bfdb3"}],"cinder/volume/drivers/open_e/iscsi.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"37335f6f5d68d64b8283cd24ffcc3ce093870dd6","unresolved":true,"context_lines":[{"line_number":117,"context_line":"            msg \u003d (_(\"Unable to identify pool %s\") % self._pool)"},{"line_number":118,"context_line":"            raise exception.VolumeDriverException(msg)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        valid_bsize \u003d [\u002732K\u0027, \u002764K\u0027, \u0027128K\u0027, \u0027256K\u0027, \u0027512K\u0027, \u00271M\u0027]"},{"line_number":121,"context_line":"        if self.block_size not in valid_bsize:"},{"line_number":122,"context_line":"            raise exception.InvalidConfigurationValue("},{"line_number":123,"context_line":"                value\u003dself.block_size,"},{"line_number":124,"context_line":"                option\u003d\u0027jovian_block_size\u0027)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _get_target_name(self, volume_name):"},{"line_number":127,"context_line":"        \"\"\"Return iSCSI target name to access volume.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9c699ac3_18c2654a","line":124,"range":{"start_line":120,"start_character":0,"end_line":124,"end_character":43},"updated":"2021-03-17 01:08:25.000000000","message":"See my comment in options.py -- you can define the config option so that it will throw an exception when cinder is started, which will make it easier for operators to deal with.","commit_id":"e59083fac840f7e2b1da35f1310f0c08c0b9bb30"}],"cinder/volume/drivers/open_e/jovian_common/rest_proxy.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"2817c1acc566cc60cf3347d74af0d32738fe1aa5","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        self.user \u003d config.get(\u0027san_login\u0027, \u0027admin\u0027)"},{"line_number":63,"context_line":"        self.password \u003d config.get(\u0027san_password\u0027, \u0027admin\u0027)"},{"line_number":64,"context_line":"        self.verify \u003d config.get(\u0027driver_ssl_cert_verify\u0027, True)"},{"line_number":65,"context_line":"        self.cert \u003d config.get(\u0027driver_ssl_cert_path\u0027, None)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"46da68ce_ae34b697","line":65,"updated":"2021-02-23 13:11:49.000000000","message":"nit: default value of dictionary.get() is None.\nThis can be simply written as ...\nconfig.get(\u0027driver_ssl_cert_path\u0027)\n\nSame comment applies at few other places as well.","commit_id":"b7759426b2a3c703e6380c19b66a5cba060bfdb3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"98b923259fa162fd0fc2f0a81571d4c753361761","unresolved":true,"context_lines":[{"line_number":147,"context_line":"            jexc.JDSSOSException),"},{"line_number":148,"context_line":"           interval\u003d2,"},{"line_number":149,"context_line":"           backoff_rate\u003d2,"},{"line_number":150,"context_line":"           retries\u003d7)"},{"line_number":151,"context_line":"    def _send(self, pr):"},{"line_number":152,"context_line":"        \"\"\"Send prepared request"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1fe3fd4d_20a5dabe","line":150,"range":{"start_line":150,"start_character":19,"end_line":150,"end_character":20},"updated":"2021-03-16 20:50:31.000000000","message":"looks like you could use self.retry_n here (or jovian_rest_send_repeats directly) and change the default value to 7.  If you deprecate the option in Wallaby you can remove it in Xena if you don\u0027t want operators to be able to adjust this.\n\nYou\u0027ll need to call this out in your release note in the upgrades section (if you change the default) and in the deprecations section (if you want to eventually remove it).","commit_id":"e59083fac840f7e2b1da35f1310f0c08c0b9bb30"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"37335f6f5d68d64b8283cd24ffcc3ce093870dd6","unresolved":true,"context_lines":[{"line_number":147,"context_line":"            jexc.JDSSOSException),"},{"line_number":148,"context_line":"           interval\u003d2,"},{"line_number":149,"context_line":"           backoff_rate\u003d2,"},{"line_number":150,"context_line":"           retries\u003d7)"},{"line_number":151,"context_line":"    def _send(self, pr):"},{"line_number":152,"context_line":"        \"\"\"Send prepared request"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"11aca0ca_4e8bf37d","line":150,"range":{"start_line":150,"start_character":19,"end_line":150,"end_character":20},"in_reply_to":"1fe3fd4d_20a5dabe","updated":"2021-03-17 01:08:25.000000000","message":"(The above is not relevant, wallaby is the first release of this driver)","commit_id":"e59083fac840f7e2b1da35f1310f0c08c0b9bb30"}],"cinder/volume/drivers/open_e/options.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"562b59c114aa5a73f9d9a1cbd3fba0f5fbb71ddf","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    cfg.ListOpt(\u0027san_hosts\u0027,"},{"line_number":20,"context_line":"                default\u003d\u0027\u0027,"},{"line_number":21,"context_line":"                help\u003d\u0027IP address of Open-E JovianDSS SA\u0027),"},{"line_number":22,"context_line":"    cfg.IntOpt(\u0027jovian_rest_send_repeats\u0027,"},{"line_number":23,"context_line":"               default\u003d3,"},{"line_number":24,"context_line":"               help\u003d\u0027Number of retries to send REST request.\u0027),"},{"line_number":25,"context_line":"    cfg.IntOpt(\u0027jovian_recovery_delay\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fc1282dd_6e692388","side":"PARENT","line":22,"updated":"2021-03-16 20:36:10.000000000","message":"This is being removed without a deprecation period. Should be deprecated first.","commit_id":"30501b9ecd6d4ed8dd6405be01795d8634013b24"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"37335f6f5d68d64b8283cd24ffcc3ce093870dd6","unresolved":true,"context_lines":[{"line_number":39,"context_line":"jdss_volume_opts \u003d ["},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027jovian_block_size\u0027,"},{"line_number":41,"context_line":"               default\u003d\u002764K\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027Block size can be: 32K, 64K, 128K, 256K, 512K, 1M\u0027),"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":8,"id":"38e64a8a_31503812","line":42,"range":{"start_line":42,"start_character":20,"end_line":42,"end_character":71},"updated":"2021-03-17 01:08:25.000000000","message":"instead of listing the options in the help string, you can tell oslo.config to only accept particular values like this:\n\n    cfg.StrOpt(\u0027jovian_block_size\u0027,\n               default\u003d\u002764K\u0027,\n               help\u003d\u0027Block size of backend storage\u0027,\n               choices\u003d[(\u002732K\u0027, \u002732 Kibibytes (32,768 bytes)\u0027),\n                        (\u002764K\u0027, \u002764 Kibibytes (65,536 bytes)\u0027),\n                        (\u0027128K\u0027, \u0027128 ...\u0027),\n                        (\u0027256K\u0027, \u0027256 ...\u0027),\n                        (\u0027512K\u0027, \u0027512 ...\u0027),\n                        (\u00271M\u0027, \u00271 Mebibyte (1,048,576 bytes)\u0027)]),\n\nthis will show up in the sample config like this:\n\n  # Block size of backend storage (string value)\n  # Possible values:\n  # 32K - 32 Kibibytes (32,768 bytes)\n  # 64K - 64 Kibibytes (65,536 bytes)\n  # 128K - 128 ...\n  # 256K - 256 ...\n  # 512K - 512 ...\n  # 1M - 1 Mebibyte (1,048,576 bytes)\n  #jovian_block_size \u003d 64K\n\nYou can do this in a follow up patch if you don\u0027t have to do any revisions on this one.","commit_id":"e59083fac840f7e2b1da35f1310f0c08c0b9bb30"}],"doc/source/configuration/block-storage/drivers/open-e-joviandss-driver.rst":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"562b59c114aa5a73f9d9a1cbd3fba0f5fbb71ddf","unresolved":true,"context_lines":[{"line_number":74,"context_line":"   * - ``jovian_block_size``"},{"line_number":75,"context_line":"     - 128K"},{"line_number":76,"context_line":"     - Block size for newly created volumes"},{"line_number":77,"context_line":"   * - ``jovian_rest_send_repeats``"},{"line_number":78,"context_line":"     - 3"},{"line_number":79,"context_line":"     - Number of times that driver will try to send REST request"},{"line_number":80,"context_line":"   * - ``san_api_port``"}],"source_content_type":"text/x-rst","patch_set":8,"id":"92f469c8_5dc65ef2","side":"PARENT","line":77,"updated":"2021-03-16 20:36:10.000000000","message":"As noted before.  Options shouldn\u0027t be removed without a deprecation period.","commit_id":"30501b9ecd6d4ed8dd6405be01795d8634013b24"}],"doc/source/reference/support-matrix.ini":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a6298749d3e5c26271e98b821b1f397d2f1b56ee","unresolved":true,"context_lines":[{"line_number":619,"context_line":"driver.netapp_solidfire\u003dcomplete"},{"line_number":620,"context_line":"driver.nexenta\u003dmissing"},{"line_number":621,"context_line":"driver.nfs\u003dmissing"},{"line_number":622,"context_line":"driver.nimble\u003dcomplete"},{"line_number":623,"context_line":"driver.opene_joviandss\u003dmissing"},{"line_number":624,"context_line":"driver.prophetstor\u003dcomplete"},{"line_number":625,"context_line":"driver.pure\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":9,"id":"4c4bd73d_23aa7d8d","line":622,"range":{"start_line":622,"start_character":0,"end_line":622,"end_character":22},"updated":"2021-03-18 00:26:35.000000000","message":"This line from commit 0d06d497c is what caused the merge conflict.","commit_id":"d01148326c686182677ebef335c1a522288fcfae"}]}