)]}'
{"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f42bdc0bbed3c7fe2cb54798956f43cb5279226","unresolved":true,"context_lines":[{"line_number":1049,"context_line":"            msg \u003d (\u0027Volume name [%s] already exists \u0027"},{"line_number":1050,"context_line":"                   \u0027in SolidFire backend.\u0027) % sf_volume_name"},{"line_number":1051,"context_line":"            LOG.error(msg)"},{"line_number":1052,"context_line":"            raise DuplicateSfVolumeNames(message\u003dmsg)"},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"        sf_volid \u003d None"},{"line_number":1055,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"a4bb4d42_c2fbd09d","line":1052,"range":{"start_line":1052,"start_character":18,"end_line":1052,"end_character":40},"updated":"2020-12-07 19:05:48.000000000","message":"I think you should fix up exception -- DuplicateSfVolumeNames inherits from exception.Duplicate which inherits from CinderException directly rather than from VolumeDriverException or VolumeBackendAPIException like most other exceptions raised by this driver (and other drivers).\n\nI don\u0027t know if this causes any particular problem now, but it should probably be cleaned up (as a separate patch) to prevent issues in the future.","commit_id":"12130ff6e03c9385fbaa452b6a5176f4e1ea92bd"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"34bc921ea7ae2233760536f7fd6efb8225fae3c8","unresolved":true,"context_lines":[{"line_number":1049,"context_line":"            msg \u003d (\u0027Volume name [%s] already exists \u0027"},{"line_number":1050,"context_line":"                   \u0027in SolidFire backend.\u0027) % sf_volume_name"},{"line_number":1051,"context_line":"            LOG.error(msg)"},{"line_number":1052,"context_line":"            raise DuplicateSfVolumeNames(message\u003dmsg)"},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"        sf_volid \u003d None"},{"line_number":1055,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"19ada40c_970a8ef8","line":1052,"range":{"start_line":1052,"start_character":18,"end_line":1052,"end_character":40},"in_reply_to":"a4bb4d42_c2fbd09d","updated":"2020-12-22 18:06:36.000000000","message":"Hi Eric, Thanks for your comment. Do you think this should be fixed in this backport as well? As this exception is also used in line 1222 I think it would be better to provide a patch separately to fix all references to DuplicateSfVolumeNames exception.","commit_id":"12130ff6e03c9385fbaa452b6a5176f4e1ea92bd"}]}