)]}'
{"cinder/volume/driver.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"75d3937a932df5798d80bb25fa27fa736293c3b6","unresolved":false,"context_lines":[{"line_number":394,"context_line":"            except Exception as err:"},{"line_number":395,"context_line":"                self.remove_export(context, volume)"},{"line_number":396,"context_line":"                err_msg \u003d (_(\u0027Unable to fetch connection information from \u0027"},{"line_number":397,"context_line":"                             \u0027backend: %(err)s\u0027) % {\u0027err\u0027: str(err)})"},{"line_number":398,"context_line":"                LOG.error(err_msg)"},{"line_number":399,"context_line":"                raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":400,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FJi4%3D","line":397,"updated":"2014-03-08 04:17:14.000000000","message":"remove the cast to str","commit_id":"58b4802acdccc5d2010b5bbc9e3fd1a1f9b86358"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"4fbc2607c72373b5907fdbc361fa99a547cb3cb6","unresolved":false,"context_lines":[{"line_number":394,"context_line":"            except Exception as err:"},{"line_number":395,"context_line":"                self.remove_export(context, volume)"},{"line_number":396,"context_line":"                err_msg \u003d (_(\u0027Unable to fetch connection information from \u0027"},{"line_number":397,"context_line":"                             \u0027backend: %(err)s\u0027) % {\u0027err\u0027: str(err)})"},{"line_number":398,"context_line":"                LOG.error(err_msg)"},{"line_number":399,"context_line":"                raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":400,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FGs8%3D","line":397,"in_reply_to":"AAAAVn%2F%2FJi4%3D","updated":"2014-03-09 17:40:53.000000000","message":"Done","commit_id":"58b4802acdccc5d2010b5bbc9e3fd1a1f9b86358"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"b043c224808a9c6d5f4158748408167c48435499","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                self.terminate_connection(volume, properties, force\u003dforce)"},{"line_number":442,"context_line":"            except Exception as err:"},{"line_number":443,"context_line":"                err_msg \u003d (_(\u0027Unable to terminate volume connection: %(err)s\u0027)"},{"line_number":444,"context_line":"                           % {\u0027err\u0027: str(err)})"},{"line_number":445,"context_line":"                LOG.error(err_msg)"},{"line_number":446,"context_line":"                raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FgX8%3D","line":444,"updated":"2014-03-05 17:56:05.000000000","message":"str to sixtype?","commit_id":"58b4802acdccc5d2010b5bbc9e3fd1a1f9b86358"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"75d3937a932df5798d80bb25fa27fa736293c3b6","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                self.terminate_connection(volume, properties, force\u003dforce)"},{"line_number":442,"context_line":"            except Exception as err:"},{"line_number":443,"context_line":"                err_msg \u003d (_(\u0027Unable to terminate volume connection: %(err)s\u0027)"},{"line_number":444,"context_line":"                           % {\u0027err\u0027: str(err)})"},{"line_number":445,"context_line":"                LOG.error(err_msg)"},{"line_number":446,"context_line":"                raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FJjA%3D","line":444,"updated":"2014-03-08 04:17:14.000000000","message":"the cast to str should be removed altogether here.","commit_id":"58b4802acdccc5d2010b5bbc9e3fd1a1f9b86358"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"4fbc2607c72373b5907fdbc361fa99a547cb3cb6","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                self.terminate_connection(volume, properties, force\u003dforce)"},{"line_number":442,"context_line":"            except Exception as err:"},{"line_number":443,"context_line":"                err_msg \u003d (_(\u0027Unable to terminate volume connection: %(err)s\u0027)"},{"line_number":444,"context_line":"                           % {\u0027err\u0027: str(err)})"},{"line_number":445,"context_line":"                LOG.error(err_msg)"},{"line_number":446,"context_line":"                raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FGsw%3D","line":444,"in_reply_to":"AAAAVn%2F%2FJjA%3D","updated":"2014-03-09 17:40:53.000000000","message":"Done","commit_id":"58b4802acdccc5d2010b5bbc9e3fd1a1f9b86358"},{"author":{"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},"change_message_id":"11c64164cbd07dc36f9ba78a89b528f05c7e81f6","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            try:"},{"line_number":393,"context_line":"                conn \u003d self.initialize_connection(volume, properties)"},{"line_number":394,"context_line":"            except Exception as err:"},{"line_number":395,"context_line":"                self.remove_export(context, volume)"},{"line_number":396,"context_line":"                err_msg \u003d (_(\u0027Unable to fetch connection information from \u0027"},{"line_number":397,"context_line":"                             \u0027backend: %(err)s\u0027) % {\u0027err\u0027: err})"},{"line_number":398,"context_line":"                LOG.error(err_msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FEoE%3D","line":395,"updated":"2014-03-10 07:24:13.000000000","message":"Exception do not occur here? Is it not necessary to check the exception?","commit_id":"1cda35abc7ca76c956978a10f69b72953b469f30"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"d90f335c5f3a0383820d273c901885b5290af0e4","unresolved":false,"context_lines":[{"line_number":393,"context_line":"                conn \u003d self.initialize_connection(volume, properties)"},{"line_number":394,"context_line":"            except Exception as err:"},{"line_number":395,"context_line":"                self.remove_export(context, volume)"},{"line_number":396,"context_line":"                err_msg \u003d (_(\u0027Unable to fetch connection information from \u0027"},{"line_number":397,"context_line":"                             \u0027backend: %(err)s\u0027) % {\u0027err\u0027: err})"},{"line_number":398,"context_line":"                LOG.error(err_msg)"},{"line_number":399,"context_line":"                raise exception.VolumeBackendAPIException(data\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FBNs%3D","line":396,"updated":"2014-03-10 17:10:51.000000000","message":"Message should be logged before remove_export. Suggest using the excutils.save_and_reraise_exception() to ensure original exception is thrown.","commit_id":"1cda35abc7ca76c956978a10f69b72953b469f30"}]}