)]}'
{"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"502b4c87a8ef9e87094de4613495ab79719b222d","unresolved":true,"context_lines":[{"line_number":3480,"context_line":""},{"line_number":3481,"context_line":"    def _extend_volume_op(self, volume, new_size, old_size\u003dNone):"},{"line_number":3482,"context_line":"        LOG.debug(\u0027enter: _extend_volume_op: volume %s\u0027, volume[\u0027id\u0027])"},{"line_number":3483,"context_line":"        opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"},{"line_number":3484,"context_line":"                                      volume_metadata\u003d"},{"line_number":3485,"context_line":"                                      volume.get(\u0027volume_matadata\u0027))"},{"line_number":3486,"context_line":"        volume_name \u003d self._get_target_vol(volume)"}],"source_content_type":"text/x-python","patch_set":6,"id":"621359b3_51bf59e8","line":3483,"updated":"2021-01-08 04:41:27.000000000","message":"let\u0027s call this below when the add_vdisk_qos is called, so we can avoid unnecessary calls if extend if failed.","commit_id":"835f1c29c2f4f30fe22f5b933459aa8dd4423514"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"ba11d2788ad1be42ace8cf8ded8ff22746a3ba56","unresolved":false,"context_lines":[{"line_number":3480,"context_line":""},{"line_number":3481,"context_line":"    def _extend_volume_op(self, volume, new_size, old_size\u003dNone):"},{"line_number":3482,"context_line":"        LOG.debug(\u0027enter: _extend_volume_op: volume %s\u0027, volume[\u0027id\u0027])"},{"line_number":3483,"context_line":"        opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"},{"line_number":3484,"context_line":"                                      volume_metadata\u003d"},{"line_number":3485,"context_line":"                                      volume.get(\u0027volume_matadata\u0027))"},{"line_number":3486,"context_line":"        volume_name \u003d self._get_target_vol(volume)"}],"source_content_type":"text/x-python","patch_set":6,"id":"22bafe91_0c5df452","line":3483,"in_reply_to":"621359b3_51bf59e8","updated":"2021-02-05 05:48:09.000000000","message":"You mean update_vdisk_qos call, right?. will address.","commit_id":"835f1c29c2f4f30fe22f5b933459aa8dd4423514"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"133bdfc770154975e6d30c524f33319a41ba0043","unresolved":true,"context_lines":[{"line_number":1454,"context_line":"                else:"},{"line_number":1455,"context_line":"                    msg \u003d (_(\"I/O Throttle rate cannot be negative or Zero. \""},{"line_number":1456,"context_line":"                             \"So skipping setting of I/O Throttle rate on \""},{"line_number":1457,"context_line":"                             \"volumes\"))"},{"line_number":1458,"context_line":"                    LOG.warning(msg)"},{"line_number":1459,"context_line":"                    continue"},{"line_number":1460,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"12b4767c_1e695e9a","line":1457,"range":{"start_line":1457,"start_character":35,"end_line":1457,"end_character":39},"updated":"2021-02-26 15:57:43.000000000","message":"suggest \u0027.\u0027 at EOL.","commit_id":"52711c0681e24f2f35d6513c2ba24dd8690b14af"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"fe650c2f83772f03dc081c39715cd437567fd585","unresolved":false,"context_lines":[{"line_number":1454,"context_line":"                else:"},{"line_number":1455,"context_line":"                    msg \u003d (_(\"I/O Throttle rate cannot be negative or Zero. \""},{"line_number":1456,"context_line":"                             \"So skipping setting of I/O Throttle rate on \""},{"line_number":1457,"context_line":"                             \"volumes\"))"},{"line_number":1458,"context_line":"                    LOG.warning(msg)"},{"line_number":1459,"context_line":"                    continue"},{"line_number":1460,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"f6183f0d_f7979bb5","line":1457,"range":{"start_line":1457,"start_character":35,"end_line":1457,"end_character":39},"in_reply_to":"12b4767c_1e695e9a","updated":"2021-03-01 05:02:40.000000000","message":"Done","commit_id":"52711c0681e24f2f35d6513c2ba24dd8690b14af"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"133bdfc770154975e6d30c524f33319a41ba0043","unresolved":true,"context_lines":[{"line_number":1469,"context_line":"                                 \"for IOThrottling_unit on Storage Template. \""},{"line_number":1470,"context_line":"                                 \"It should be one of the values: \""},{"line_number":1471,"context_line":"                                 \"%(expected)s. So skipping setting of I/O \""},{"line_number":1472,"context_line":"                                 \"Throttle rate on volumes\") %"},{"line_number":1473,"context_line":"                               dict(actual\u003dvalue, expected\u003denum_values))"},{"line_number":1474,"context_line":"                        LOG.warning(msg)"},{"line_number":1475,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":8,"id":"8e17509a_2f7680fe","line":1472,"range":{"start_line":1472,"start_character":56,"end_line":1472,"end_character":60},"updated":"2021-02-26 15:57:43.000000000","message":"Same comment here.","commit_id":"52711c0681e24f2f35d6513c2ba24dd8690b14af"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"fe650c2f83772f03dc081c39715cd437567fd585","unresolved":false,"context_lines":[{"line_number":1469,"context_line":"                                 \"for IOThrottling_unit on Storage Template. \""},{"line_number":1470,"context_line":"                                 \"It should be one of the values: \""},{"line_number":1471,"context_line":"                                 \"%(expected)s. So skipping setting of I/O \""},{"line_number":1472,"context_line":"                                 \"Throttle rate on volumes\") %"},{"line_number":1473,"context_line":"                               dict(actual\u003dvalue, expected\u003denum_values))"},{"line_number":1474,"context_line":"                        LOG.warning(msg)"},{"line_number":1475,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":8,"id":"93039339_08515a18","line":1472,"range":{"start_line":1472,"start_character":56,"end_line":1472,"end_character":60},"in_reply_to":"8e17509a_2f7680fe","updated":"2021-03-01 05:02:40.000000000","message":"Done","commit_id":"52711c0681e24f2f35d6513c2ba24dd8690b14af"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ad42db3f4485883e04ea6294940a7859cf601f6c","unresolved":true,"context_lines":[{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"            # Add the QoS."},{"line_number":1420,"context_line":"            if scope and scope \u003d\u003d \u0027qos\u0027:"},{"line_number":1421,"context_line":"                if key in self.svc_qos.keys():"},{"line_number":1422,"context_line":"                    try:"},{"line_number":1423,"context_line":"                        type_fn \u003d self.svc_qos[key][\u0027type\u0027]"},{"line_number":1424,"context_line":"                        value \u003d type_fn(value)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fc0f8dbb_55d5e06d","line":1421,"range":{"start_line":1421,"start_character":19,"end_line":1421,"end_character":45},"updated":"2021-03-09 20:53:45.000000000","message":"You do this throughout your patch.  You don\u0027t need to use the .keys() function, you can simply do\n\n  key in self.svc_qos\n\nto find out if a key is in a dict.","commit_id":"0f691b4f5de1231ad604efb2817301766a8a9620"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"6a1f74ad9084c201d1097827372d1548ab1b3d09","unresolved":false,"context_lines":[{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"            # Add the QoS."},{"line_number":1420,"context_line":"            if scope and scope \u003d\u003d \u0027qos\u0027:"},{"line_number":1421,"context_line":"                if key in self.svc_qos.keys():"},{"line_number":1422,"context_line":"                    try:"},{"line_number":1423,"context_line":"                        type_fn \u003d self.svc_qos[key][\u0027type\u0027]"},{"line_number":1424,"context_line":"                        value \u003d type_fn(value)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fca0b8c5_dd0672cd","line":1421,"range":{"start_line":1421,"start_character":19,"end_line":1421,"end_character":45},"in_reply_to":"fc0f8dbb_55d5e06d","updated":"2021-03-10 11:33:52.000000000","message":"Done. Updated all instances.","commit_id":"0f691b4f5de1231ad604efb2817301766a8a9620"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ad42db3f4485883e04ea6294940a7859cf601f6c","unresolved":true,"context_lines":[{"line_number":2598,"context_line":"        if iothrottling in qos:"},{"line_number":2599,"context_line":"            throttling_value \u003d qos[iothrottling]"},{"line_number":2600,"context_line":"            key_unit \u003d self.svc_qos[iothrottling].get(\u0027unit\u0027, None)"},{"line_number":2601,"context_line":"            throttling_unit \u003d qos[key_unit]"},{"line_number":2602,"context_line":""},{"line_number":2603,"context_line":"            # check if throttling unit specified is in allowed units"},{"line_number":2604,"context_line":"            # if not allowed - we will go with default unit - iops"}],"source_content_type":"text/x-python","patch_set":11,"id":"cd64a260_61836902","line":2601,"range":{"start_line":2601,"start_character":34,"end_line":2601,"end_character":42},"updated":"2021-03-09 20:53:45.000000000","message":"if the previous line sets key_unit to None, this will give you a KeyError","commit_id":"0f691b4f5de1231ad604efb2817301766a8a9620"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"e9c69aaecc50eb98e803a879269185fc98425c68","unresolved":false,"context_lines":[{"line_number":2598,"context_line":"        if iothrottling in qos:"},{"line_number":2599,"context_line":"            throttling_value \u003d qos[iothrottling]"},{"line_number":2600,"context_line":"            key_unit \u003d self.svc_qos[iothrottling].get(\u0027unit\u0027, None)"},{"line_number":2601,"context_line":"            throttling_unit \u003d qos[key_unit]"},{"line_number":2602,"context_line":""},{"line_number":2603,"context_line":"            # check if throttling unit specified is in allowed units"},{"line_number":2604,"context_line":"            # if not allowed - we will go with default unit - iops"}],"source_content_type":"text/x-python","patch_set":11,"id":"3dde60e0_fa425e48","line":2601,"range":{"start_line":2601,"start_character":34,"end_line":2601,"end_character":42},"in_reply_to":"230c251d_1e42746e","updated":"2021-03-10 14:31:56.000000000","message":"Thanks. Updated","commit_id":"0f691b4f5de1231ad604efb2817301766a8a9620"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"6a1f74ad9084c201d1097827372d1548ab1b3d09","unresolved":false,"context_lines":[{"line_number":2598,"context_line":"        if iothrottling in qos:"},{"line_number":2599,"context_line":"            throttling_value \u003d qos[iothrottling]"},{"line_number":2600,"context_line":"            key_unit \u003d self.svc_qos[iothrottling].get(\u0027unit\u0027, None)"},{"line_number":2601,"context_line":"            throttling_unit \u003d qos[key_unit]"},{"line_number":2602,"context_line":""},{"line_number":2603,"context_line":"            # check if throttling unit specified is in allowed units"},{"line_number":2604,"context_line":"            # if not allowed - we will go with default unit - iops"}],"source_content_type":"text/x-python","patch_set":11,"id":"f866c7be_78965c2e","line":2601,"range":{"start_line":2601,"start_character":34,"end_line":2601,"end_character":42},"in_reply_to":"cd64a260_61836902","updated":"2021-03-10 11:33:52.000000000","message":"Fixed it. Key_unit contains value always(Line 754).","commit_id":"0f691b4f5de1231ad604efb2817301766a8a9620"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4cd2d13c14d4da04431cd0bf03c87814ccdd0274","unresolved":false,"context_lines":[{"line_number":2598,"context_line":"        if iothrottling in qos:"},{"line_number":2599,"context_line":"            throttling_value \u003d qos[iothrottling]"},{"line_number":2600,"context_line":"            key_unit \u003d self.svc_qos[iothrottling].get(\u0027unit\u0027, None)"},{"line_number":2601,"context_line":"            throttling_unit \u003d qos[key_unit]"},{"line_number":2602,"context_line":""},{"line_number":2603,"context_line":"            # check if throttling unit specified is in allowed units"},{"line_number":2604,"context_line":"            # if not allowed - we will go with default unit - iops"}],"source_content_type":"text/x-python","patch_set":11,"id":"230c251d_1e42746e","line":2601,"range":{"start_line":2601,"start_character":34,"end_line":2601,"end_character":42},"in_reply_to":"f866c7be_78965c2e","updated":"2021-03-10 13:09:49.000000000","message":"Thanks for the reference.  See my comment in that function on PS 12.","commit_id":"0f691b4f5de1231ad604efb2817301766a8a9620"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ad42db3f4485883e04ea6294940a7859cf601f6c","unresolved":true,"context_lines":[{"line_number":3290,"context_line":"            raise exception.VolumeDriverException(reason\u003dmsg)"},{"line_number":3291,"context_line":""},{"line_number":3292,"context_line":"    def _update_replication_properties(self, ctxt, volume, model_update):"},{"line_number":3293,"context_line":"        vol_metadata \u003d dict()"},{"line_number":3294,"context_line":"        if not model_update:"},{"line_number":3295,"context_line":"            model_update \u003d dict()"},{"line_number":3296,"context_line":"        elif \u0027metadata\u0027 in model_update.keys():"},{"line_number":3297,"context_line":"            vol_metadata \u003d model_update[\u0027metadata\u0027]"},{"line_number":3298,"context_line":""},{"line_number":3299,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3300,"context_line":"                                                  volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"8d31b4c4_90b711b9","line":3297,"range":{"start_line":3293,"start_character":0,"end_line":3297,"end_character":51},"updated":"2021-03-09 20:53:45.000000000","message":"how about instead:\n\n    model_update \u003d model_update or dict()\n    vol_metadata \u003d model_update.get(\u0027metadata\u0027, {})","commit_id":"0f691b4f5de1231ad604efb2817301766a8a9620"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"6a1f74ad9084c201d1097827372d1548ab1b3d09","unresolved":false,"context_lines":[{"line_number":3290,"context_line":"            raise exception.VolumeDriverException(reason\u003dmsg)"},{"line_number":3291,"context_line":""},{"line_number":3292,"context_line":"    def _update_replication_properties(self, ctxt, volume, model_update):"},{"line_number":3293,"context_line":"        vol_metadata \u003d dict()"},{"line_number":3294,"context_line":"        if not model_update:"},{"line_number":3295,"context_line":"            model_update \u003d dict()"},{"line_number":3296,"context_line":"        elif \u0027metadata\u0027 in model_update.keys():"},{"line_number":3297,"context_line":"            vol_metadata \u003d model_update[\u0027metadata\u0027]"},{"line_number":3298,"context_line":""},{"line_number":3299,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3300,"context_line":"                                                  volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"b6d25c09_391dc648","line":3297,"range":{"start_line":3293,"start_character":0,"end_line":3297,"end_character":51},"in_reply_to":"8d31b4c4_90b711b9","updated":"2021-03-10 11:33:52.000000000","message":"Done","commit_id":"0f691b4f5de1231ad604efb2817301766a8a9620"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ad42db3f4485883e04ea6294940a7859cf601f6c","unresolved":true,"context_lines":[{"line_number":3299,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3300,"context_line":"                                                  volume[\u0027id\u0027])"},{"line_number":3301,"context_line":"        model_update[\u0027metadata\u0027] \u003d db_metadata if db_metadata else dict()"},{"line_number":3302,"context_line":"        if ((\u0027IOThrottle_rate\u0027 not in vol_metadata.keys()) and"},{"line_number":3303,"context_line":"                (\u0027IOThrottle_rate\u0027 in model_update[\u0027metadata\u0027].keys())):"},{"line_number":3304,"context_line":"            del model_update[\u0027metadata\u0027][\u0027IOThrottle_rate\u0027]"},{"line_number":3305,"context_line":"        model_update[\u0027metadata\u0027].update(vol_metadata)"},{"line_number":3306,"context_line":""},{"line_number":3307,"context_line":"        rel_info \u003d self._helpers.get_relationship_info(volume.name)"},{"line_number":3308,"context_line":"        rep_properties \u003d {"},{"line_number":3309,"context_line":"            \u0027Id\u0027: \u0027id\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"8711abb7_82730f07","line":3306,"range":{"start_line":3302,"start_character":0,"end_line":3306,"end_character":0},"updated":"2021-03-09 20:53:45.000000000","message":"Just want to check on the logic here.  Basically what\u0027s happening is that the vol_metadata will determine whether IOThrottle_rate will be in the model_update, and if so, what its value will be.  So this should be equivalent:\n\n    if \u0027IOThrottle_rate\u0027 in model_update[\u0027metadata\u0027]:\n        del model_update[\u0027metadata\u0027][\u0027IOThrottle_rate\u0027]\n    model_update[\u0027metadata\u0027].update(vol_metadata)\n\nI just want to make sure that\u0027s what you want to do here.","commit_id":"0f691b4f5de1231ad604efb2817301766a8a9620"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"e9c69aaecc50eb98e803a879269185fc98425c68","unresolved":false,"context_lines":[{"line_number":3299,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3300,"context_line":"                                                  volume[\u0027id\u0027])"},{"line_number":3301,"context_line":"        model_update[\u0027metadata\u0027] \u003d db_metadata if db_metadata else dict()"},{"line_number":3302,"context_line":"        if ((\u0027IOThrottle_rate\u0027 not in vol_metadata.keys()) and"},{"line_number":3303,"context_line":"                (\u0027IOThrottle_rate\u0027 in model_update[\u0027metadata\u0027].keys())):"},{"line_number":3304,"context_line":"            del model_update[\u0027metadata\u0027][\u0027IOThrottle_rate\u0027]"},{"line_number":3305,"context_line":"        model_update[\u0027metadata\u0027].update(vol_metadata)"},{"line_number":3306,"context_line":""},{"line_number":3307,"context_line":"        rel_info \u003d self._helpers.get_relationship_info(volume.name)"},{"line_number":3308,"context_line":"        rep_properties \u003d {"},{"line_number":3309,"context_line":"            \u0027Id\u0027: \u0027id\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"876a323e_e84c0e9d","line":3306,"range":{"start_line":3302,"start_character":0,"end_line":3306,"end_character":0},"in_reply_to":"56c42b16_f55a0e15","updated":"2021-03-10 14:31:56.000000000","message":"Yes. That is what exactly we are expecting.","commit_id":"0f691b4f5de1231ad604efb2817301766a8a9620"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4cd2d13c14d4da04431cd0bf03c87814ccdd0274","unresolved":true,"context_lines":[{"line_number":3299,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3300,"context_line":"                                                  volume[\u0027id\u0027])"},{"line_number":3301,"context_line":"        model_update[\u0027metadata\u0027] \u003d db_metadata if db_metadata else dict()"},{"line_number":3302,"context_line":"        if ((\u0027IOThrottle_rate\u0027 not in vol_metadata.keys()) and"},{"line_number":3303,"context_line":"                (\u0027IOThrottle_rate\u0027 in model_update[\u0027metadata\u0027].keys())):"},{"line_number":3304,"context_line":"            del model_update[\u0027metadata\u0027][\u0027IOThrottle_rate\u0027]"},{"line_number":3305,"context_line":"        model_update[\u0027metadata\u0027].update(vol_metadata)"},{"line_number":3306,"context_line":""},{"line_number":3307,"context_line":"        rel_info \u003d self._helpers.get_relationship_info(volume.name)"},{"line_number":3308,"context_line":"        rep_properties \u003d {"},{"line_number":3309,"context_line":"            \u0027Id\u0027: \u0027id\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"56c42b16_f55a0e15","line":3306,"range":{"start_line":3302,"start_character":0,"end_line":3306,"end_character":0},"in_reply_to":"766d0d71_658e283d","updated":"2021-03-10 13:09:49.000000000","message":"OK, thanks for the explanation.  The important point I wanted to check is that when *both* the vol_metadata and the db have the IOThrottle_rate in the metadata, line 3302 will make sure that the value from the vol_metadata is what\u0027s stored in model_update.  Just want to make sure that\u0027s what you want.","commit_id":"0f691b4f5de1231ad604efb2817301766a8a9620"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"6a1f74ad9084c201d1097827372d1548ab1b3d09","unresolved":false,"context_lines":[{"line_number":3299,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3300,"context_line":"                                                  volume[\u0027id\u0027])"},{"line_number":3301,"context_line":"        model_update[\u0027metadata\u0027] \u003d db_metadata if db_metadata else dict()"},{"line_number":3302,"context_line":"        if ((\u0027IOThrottle_rate\u0027 not in vol_metadata.keys()) and"},{"line_number":3303,"context_line":"                (\u0027IOThrottle_rate\u0027 in model_update[\u0027metadata\u0027].keys())):"},{"line_number":3304,"context_line":"            del model_update[\u0027metadata\u0027][\u0027IOThrottle_rate\u0027]"},{"line_number":3305,"context_line":"        model_update[\u0027metadata\u0027].update(vol_metadata)"},{"line_number":3306,"context_line":""},{"line_number":3307,"context_line":"        rel_info \u003d self._helpers.get_relationship_info(volume.name)"},{"line_number":3308,"context_line":"        rep_properties \u003d {"},{"line_number":3309,"context_line":"            \u0027Id\u0027: \u0027id\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"766d0d71_658e283d","line":3306,"range":{"start_line":3302,"start_character":0,"end_line":3306,"end_character":0},"in_reply_to":"8711abb7_82730f07","updated":"2021-03-10 11:33:52.000000000","message":"The input parameter model_update(vol_metadata) of the _update_replication_properties() does not have \u0027metadata\u0027 with the field \u0027IOThrottle_rate\u0027 while retyping a volume(volume retype from a vol_type with qos_attributes to vol_type with no_qos_attributes) where as the volume_metadata from DATABASE contains the same field \u0027IOThrottle_rate\u0027.\nOur requirement in this case is to delete that field \u0027IOThrottle_rate\u0027 from volume_metadata. \nSo, made a condition with the combination of both updated_volume_metadata and database_volume_metadata.","commit_id":"0f691b4f5de1231ad604efb2817301766a8a9620"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f8a42194dbe6e294d012dfee87004cee66710581","unresolved":true,"context_lines":[{"line_number":3713,"context_line":"                                               new_size)"},{"line_number":3714,"context_line":"                # Add the QoS IOThrottling value to Volume Metadata"},{"line_number":3715,"context_line":"                model_update \u003d dict()"},{"line_number":3716,"context_line":"                model_update \u003d self._qos_model_update(model_update, volume)"},{"line_number":3717,"context_line":"                # Update the Volume Metadata in the DB"},{"line_number":3718,"context_line":"                self.db.volume_metadata_update("},{"line_number":3719,"context_line":"                    context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":11,"id":"53c01f40_b1c97149","line":3716,"range":{"start_line":3716,"start_character":54,"end_line":3716,"end_character":66},"updated":"2021-03-09 17:39:29.000000000","message":"Can just pass None or dict() here and skip line 3715.","commit_id":"0f691b4f5de1231ad604efb2817301766a8a9620"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"6a1f74ad9084c201d1097827372d1548ab1b3d09","unresolved":false,"context_lines":[{"line_number":3713,"context_line":"                                               new_size)"},{"line_number":3714,"context_line":"                # Add the QoS IOThrottling value to Volume Metadata"},{"line_number":3715,"context_line":"                model_update \u003d dict()"},{"line_number":3716,"context_line":"                model_update \u003d self._qos_model_update(model_update, volume)"},{"line_number":3717,"context_line":"                # Update the Volume Metadata in the DB"},{"line_number":3718,"context_line":"                self.db.volume_metadata_update("},{"line_number":3719,"context_line":"                    context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":11,"id":"a98966f2_d575c4c4","line":3716,"range":{"start_line":3716,"start_character":54,"end_line":3716,"end_character":66},"in_reply_to":"53c01f40_b1c97149","updated":"2021-03-10 11:33:52.000000000","message":"Updated","commit_id":"0f691b4f5de1231ad604efb2817301766a8a9620"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4cd2d13c14d4da04431cd0bf03c87814ccdd0274","unresolved":true,"context_lines":[{"line_number":742,"context_line":""},{"line_number":743,"context_line":"class StorwizeHelpers(object):"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"    # All the supported QoS key are saved in this dict. When a new"},{"line_number":746,"context_line":"    # key is going to add, three values MUST be set:"},{"line_number":747,"context_line":"    # \u0027default\u0027: to indicate the value, when the parameter is disabled."},{"line_number":748,"context_line":"    # \u0027param\u0027: to indicate the corresponding parameter in the command."},{"line_number":749,"context_line":"    # \u0027type\u0027: to indicate the type of this value."},{"line_number":750,"context_line":"    WAIT_TIME \u003d 5"},{"line_number":751,"context_line":"    svc_qos \u003d {\u0027IOThrottling\u0027: {\u0027default\u0027: \u00270\u0027,"},{"line_number":752,"context_line":"                                \u0027param\u0027: \u0027rate\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"40078410_5b390332","line":749,"range":{"start_line":745,"start_character":0,"end_line":749,"end_character":49},"updated":"2021-03-10 13:09:49.000000000","message":"does this need to be updated to include \u0027unit\u0027?","commit_id":"abaefd2adb100a786a301cc84ac9b90055b0420d"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"e9c69aaecc50eb98e803a879269185fc98425c68","unresolved":false,"context_lines":[{"line_number":742,"context_line":""},{"line_number":743,"context_line":"class StorwizeHelpers(object):"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"    # All the supported QoS key are saved in this dict. When a new"},{"line_number":746,"context_line":"    # key is going to add, three values MUST be set:"},{"line_number":747,"context_line":"    # \u0027default\u0027: to indicate the value, when the parameter is disabled."},{"line_number":748,"context_line":"    # \u0027param\u0027: to indicate the corresponding parameter in the command."},{"line_number":749,"context_line":"    # \u0027type\u0027: to indicate the type of this value."},{"line_number":750,"context_line":"    WAIT_TIME \u003d 5"},{"line_number":751,"context_line":"    svc_qos \u003d {\u0027IOThrottling\u0027: {\u0027default\u0027: \u00270\u0027,"},{"line_number":752,"context_line":"                                \u0027param\u0027: \u0027rate\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"176e59dc_0f69c47e","line":749,"range":{"start_line":745,"start_character":0,"end_line":749,"end_character":49},"in_reply_to":"40078410_5b390332","updated":"2021-03-10 14:31:56.000000000","message":"In my opinion, not needed, as \u0027unit\u0027 indicates a random string value and today that random string is \u0027IOThrottling_unit\u0027. But it is more informative if I add that. I will update.","commit_id":"abaefd2adb100a786a301cc84ac9b90055b0420d"}]}