)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5c3ec0f152398cf3e60106b30b5af7db9300a211","unresolved":true,"context_lines":[{"line_number":2573,"context_line":"                                  \u0027id\u0027: self.driver.__class__.__name__})"},{"line_number":2574,"context_line":"        else:"},{"line_number":2575,"context_line":"            slowmsg \u003d \"The \" + self.driver.__class__.__name__ + \" volume \" \\"},{"line_number":2576,"context_line":"                      \"driver\u0027s get_volume_stats operation ran for \" \\"},{"line_number":2577,"context_line":"                      \"%(seconds).1f seconds.  This may indicate a \" \\"},{"line_number":2578,"context_line":"                      \"performance problem with the backend which can lead \" \\"},{"line_number":2579,"context_line":"                      \"to instability.\""}],"source_content_type":"text/x-python","patch_set":2,"id":"a3489938_7c70f50c","line":2576,"range":{"start_line":2576,"start_character":32,"end_line":2576,"end_character":48},"updated":"2021-01-14 10:23:07.000000000","message":"nit: This can be %(func_name)s","commit_id":"0d2da523eb6275ce733a0f338a444f9103b2cdbe"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e44a080af20af3d226c6a8888507d7251eb7de3e","unresolved":true,"context_lines":[{"line_number":2573,"context_line":"                                  \u0027id\u0027: self.driver.__class__.__name__})"},{"line_number":2574,"context_line":"        else:"},{"line_number":2575,"context_line":"            slowmsg \u003d \"The \" + self.driver.__class__.__name__ + \" volume \" \\"},{"line_number":2576,"context_line":"                      \"driver\u0027s get_volume_stats operation ran for \" \\"},{"line_number":2577,"context_line":"                      \"%(seconds).1f seconds.  This may indicate a \" \\"},{"line_number":2578,"context_line":"                      \"performance problem with the backend which can lead \" \\"},{"line_number":2579,"context_line":"                      \"to instability.\""}],"source_content_type":"text/x-python","patch_set":2,"id":"f2473959_e88b27e7","line":2576,"range":{"start_line":2576,"start_character":32,"end_line":2576,"end_character":48},"in_reply_to":"a3489938_7c70f50c","updated":"2021-03-02 16:44:31.000000000","message":"I think that would report \"get_stats\" instead?","commit_id":"0d2da523eb6275ce733a0f338a444f9103b2cdbe"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5c3ec0f152398cf3e60106b30b5af7db9300a211","unresolved":true,"context_lines":[{"line_number":2574,"context_line":"        else:"},{"line_number":2575,"context_line":"            slowmsg \u003d \"The \" + self.driver.__class__.__name__ + \" volume \" \\"},{"line_number":2576,"context_line":"                      \"driver\u0027s get_volume_stats operation ran for \" \\"},{"line_number":2577,"context_line":"                      \"%(seconds).1f seconds.  This may indicate a \" \\"},{"line_number":2578,"context_line":"                      \"performance problem with the backend which can lead \" \\"},{"line_number":2579,"context_line":"                      \"to instability.\""},{"line_number":2580,"context_line":""},{"line_number":2581,"context_line":"            @timeutils.time_it("},{"line_number":2582,"context_line":"                LOG, log_level\u003dlogging.WARN, message\u003dslowmsg,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e2868059_36cb407e","line":2579,"range":{"start_line":2577,"start_character":5,"end_line":2579,"end_character":39},"updated":"2021-01-14 10:23:07.000000000","message":"nit: I think this is addressed to operators, so maybe we should rephrase it to something less low level, as not mentioning the method and mentioning that this is getting the stats from the storage system.","commit_id":"0d2da523eb6275ce733a0f338a444f9103b2cdbe"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e44a080af20af3d226c6a8888507d7251eb7de3e","unresolved":true,"context_lines":[{"line_number":2574,"context_line":"        else:"},{"line_number":2575,"context_line":"            slowmsg \u003d \"The \" + self.driver.__class__.__name__ + \" volume \" \\"},{"line_number":2576,"context_line":"                      \"driver\u0027s get_volume_stats operation ran for \" \\"},{"line_number":2577,"context_line":"                      \"%(seconds).1f seconds.  This may indicate a \" \\"},{"line_number":2578,"context_line":"                      \"performance problem with the backend which can lead \" \\"},{"line_number":2579,"context_line":"                      \"to instability.\""},{"line_number":2580,"context_line":""},{"line_number":2581,"context_line":"            @timeutils.time_it("},{"line_number":2582,"context_line":"                LOG, log_level\u003dlogging.WARN, message\u003dslowmsg,"}],"source_content_type":"text/x-python","patch_set":2,"id":"94db03b0_a71707a5","line":2579,"range":{"start_line":2577,"start_character":5,"end_line":2579,"end_character":39},"in_reply_to":"e2868059_36cb407e","updated":"2021-03-02 16:44:31.000000000","message":"I\u0027m not sure I agree -- since get_volume_stats is part of the driver API, I think it could be useful for an admin to take the message to their driver vendor of \"get_volume_stats is too slow\".","commit_id":"0d2da523eb6275ce733a0f338a444f9103b2cdbe"}]}