)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cf65740c9eeeec7c5449a4c38dc82cdb1095022e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Xuan Yandong \u003cxuanyandong@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-09-23 02:20:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Restrict manage to encrypt volume type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We can not unmanage encrypt volume,"},{"line_number":10,"context_line":"so we can not manage volume to encrypt volume type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"4cd42c35_8e9d5dda","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":38},"updated":"2021-09-24 01:08:53.000000000","message":"How about: Prohibit volume manage to an encrypted volume type","commit_id":"9d53cf150c9530310a6e90575c7f04ccbbb14a2c"},{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"23320b72b9e7fee82b72dc07d85693f8b1590d87","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xuan Yandong \u003cxuanyandong@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-09-23 02:20:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Restrict manage to encrypt volume type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We can not unmanage encrypt volume,"},{"line_number":10,"context_line":"so we can not manage volume to encrypt volume type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"03fc33f3_f6d2239a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":38},"in_reply_to":"4cd42c35_8e9d5dda","updated":"2021-11-23 03:12:42.000000000","message":"Done","commit_id":"9d53cf150c9530310a6e90575c7f04ccbbb14a2c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cf65740c9eeeec7c5449a4c38dc82cdb1095022e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Restrict manage to encrypt volume type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We can not unmanage encrypt volume,"},{"line_number":10,"context_line":"so we can not manage volume to encrypt volume type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic2da41f3962c1108f974aca952bce3da6d6ac277"},{"line_number":13,"context_line":"Closes-bug: #1909207"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"a4d8d87b_0eda8cf1","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":51},"updated":"2021-09-24 01:08:53.000000000","message":"Maybe something like:\n\nManaging a volume to an encrypted volume type should not be allowed.  One reason is that there is no way for an operator to specify an encryption key ID for the volume.  Another is that we already don\u0027t allow a volume of an encrypted type to be un-managed, so this change will be symmetric.","commit_id":"9d53cf150c9530310a6e90575c7f04ccbbb14a2c"},{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"23320b72b9e7fee82b72dc07d85693f8b1590d87","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Restrict manage to encrypt volume type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We can not unmanage encrypt volume,"},{"line_number":10,"context_line":"so we can not manage volume to encrypt volume type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic2da41f3962c1108f974aca952bce3da6d6ac277"},{"line_number":13,"context_line":"Closes-bug: #1909207"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a965bf2_73d2db23","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":51},"in_reply_to":"a4d8d87b_0eda8cf1","updated":"2021-11-23 03:12:42.000000000","message":"Done","commit_id":"9d53cf150c9530310a6e90575c7f04ccbbb14a2c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cf65740c9eeeec7c5449a4c38dc82cdb1095022e","unresolved":true,"context_lines":[{"line_number":10,"context_line":"so we can not manage volume to encrypt volume type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic2da41f3962c1108f974aca952bce3da6d6ac277"},{"line_number":13,"context_line":"Closes-bug: #1909207"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"46710714_105bc172","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":20},"updated":"2021-09-24 01:08:53.000000000","message":"Please change this to 1944577","commit_id":"9d53cf150c9530310a6e90575c7f04ccbbb14a2c"},{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"23320b72b9e7fee82b72dc07d85693f8b1590d87","unresolved":false,"context_lines":[{"line_number":10,"context_line":"so we can not manage volume to encrypt volume type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic2da41f3962c1108f974aca952bce3da6d6ac277"},{"line_number":13,"context_line":"Closes-bug: #1909207"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa05a189_b2197846","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":20},"in_reply_to":"46710714_105bc172","updated":"2021-11-23 03:12:42.000000000","message":"Done","commit_id":"9d53cf150c9530310a6e90575c7f04ccbbb14a2c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"4e56a535b32773da44678b400a0c148ae95fe101","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1df4d547_ee0ad5d8","updated":"2021-11-22 04:25:30.000000000","message":"run-DellEMC SC CI","commit_id":"dce17983c9e88ad89cbf7761dbbcd07e58465ecf"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"b6d43a760f479a1c3a19c76d94b931c9764da598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"514f9397_4ae79e1e","updated":"2021-11-22 06:41:40.000000000","message":"run-DellEMC SC CI","commit_id":"dce17983c9e88ad89cbf7761dbbcd07e58465ecf"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"26366c1b97ff70d0a8299db3079eb371c443b8a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9f1f4a4a_edb42000","updated":"2021-11-22 03:56:33.000000000","message":"run-DellEMC SC CI","commit_id":"dce17983c9e88ad89cbf7761dbbcd07e58465ecf"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"6f2028281bbfe3f839601568585aa7417d6a21ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e6a91c95_07a53a95","updated":"2021-11-22 06:48:24.000000000","message":"run-DellEMC SC CI","commit_id":"dce17983c9e88ad89cbf7761dbbcd07e58465ecf"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"be3fa0071ba2450924b1a02706b7de7083530bac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6388da10_be5ec083","updated":"2021-11-22 04:07:43.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"dce17983c9e88ad89cbf7761dbbcd07e58465ecf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d9901bd83a41d8cf13889014cb1c7523b4f75d92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3fd11fa2_580a1ea3","updated":"2021-11-22 14:33:37.000000000","message":"suggestion inline","commit_id":"de102eddc2ea75ad16ab9277caedc1714e5ab507"},{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"23320b72b9e7fee82b72dc07d85693f8b1590d87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"0406b025_e384eafa","updated":"2021-11-23 03:12:42.000000000","message":"Thanks for review very much.","commit_id":"d1d3ba4ca4eff618798b8a217ec35e6ea83bd6bb"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0e1c094254415769e66c68ae15e7baaa335f8f5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"534c47f5_bd1ad38c","updated":"2022-02-11 10:49:23.000000000","message":"Code changes \u0026 UT look good. Zuul also passed. So +1.","commit_id":"1656e8e5c6b833bbe8d0ed2ae587a6a72e2a165f"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"09b4f2f44b4abd1d30c1ee04912e35866d2105f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"716b0f57_6c755085","updated":"2021-12-09 06:32:40.000000000","message":"LGTM","commit_id":"1656e8e5c6b833bbe8d0ed2ae587a6a72e2a165f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"889815e47f6c752260e7ffc087a43953db83b3cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e92883d4_fde7db44","updated":"2021-12-08 14:44:34.000000000","message":"Setting +RP since this fixes a significant issue.","commit_id":"1656e8e5c6b833bbe8d0ed2ae587a6a72e2a165f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c95bb1b91c2da162a518c8706a5851d54c783188","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"6bd5e5f3_427601a8","updated":"2022-02-11 13:50:37.000000000","message":"Sorry this has been sitting so long.  This is important for the yoga release (and we promised the the xena release notes that it would be backported to xena).  See comment inline.","commit_id":"1656e8e5c6b833bbe8d0ed2ae587a6a72e2a165f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"21d08b53bc95c968f93b7a6cd7cda6efaffcde14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"b1b749c8_11971f0e","updated":"2022-03-10 02:51:22.000000000","message":"See comment inline.","commit_id":"ec849592d03f4070f69d423ff4ef044ab2512389"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d9ae829ecc95e08173953dbf4f19ebc0b640df15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"9c252c7f_0cc10044","updated":"2022-03-21 14:04:02.000000000","message":"Looks like this should be good once Eric\u0027s comment is addressed.","commit_id":"365449c2d4443bc175d7b6927e4e43d3fead2d48"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"fea6584b9f603b2939f87b678b31e3bbca77ef8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"14c70345_1755c27d","updated":"2022-03-19 07:02:32.000000000","message":"run-DellEMC PowerStore CI","commit_id":"365449c2d4443bc175d7b6927e4e43d3fead2d48"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"cf52a4dcfd58357795a7171a9d58b108d8edcfac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"857e3f64_c71f9906","updated":"2022-03-21 16:55:39.000000000","message":"Looks good, waiting for Zuul vote.","commit_id":"8088dc9580356ca51581c56888c9022848f543b1"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"1dabf48880377c568bd43f34bdd697239d241933","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"6f829861_241cfcba","updated":"2022-03-21 18:26:26.000000000","message":"Thanks for working on this.","commit_id":"8088dc9580356ca51581c56888c9022848f543b1"}],"api-ref/source/v3/volume-manage.inc":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"455d9051bbd1dde98ef81987ece507e121f078a2","unresolved":true,"context_lines":[{"line_number":24,"context_line":"The API chooses the size of the volume by rounding up the size of"},{"line_number":25,"context_line":"the existing storage volume to the next gibibyte (GiB)."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"You cannot manage an encrypted volume."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Prior to microversion 3.16 host field was required, with the possibility of"},{"line_number":30,"context_line":"defining the cluster it is no longer required, but we must have either a host"}],"source_content_type":"text/x-c++src","patch_set":19,"id":"6f475b88_6c419db7","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":38},"updated":"2022-03-21 13:41:38.000000000","message":"I think it would be better to be more specific here -- the data on the volume isn\u0027t the issue, it\u0027s that you can\u0027t manage to an encrypted type.","commit_id":"365449c2d4443bc175d7b6927e4e43d3fead2d48"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7d2db19383182f76a3121daac5dedafc9a028e88","unresolved":false,"context_lines":[{"line_number":24,"context_line":"The API chooses the size of the volume by rounding up the size of"},{"line_number":25,"context_line":"the existing storage volume to the next gibibyte (GiB)."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"You cannot manage an encrypted volume."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Prior to microversion 3.16 host field was required, with the possibility of"},{"line_number":30,"context_line":"defining the cluster it is no longer required, but we must have either a host"}],"source_content_type":"text/x-c++src","patch_set":19,"id":"ecb66834_f97d51c5","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":38},"in_reply_to":"6f475b88_6c419db7","updated":"2022-03-21 15:49:07.000000000","message":"Good point, I was being sloppy here.","commit_id":"365449c2d4443bc175d7b6927e4e43d3fead2d48"}],"cinder/tests/unit/api/contrib/test_volume_manage.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"29865e73b3f8d5918bd671e42390cc91f4ac47ff","unresolved":true,"context_lines":[{"line_number":484,"context_line":"              {\u0027host\u0027: \u0027host@backend#[dead:beef::cafe]:/vol01\u0027})"},{"line_number":485,"context_line":"    @ddt.unpack"},{"line_number":486,"context_line":"    @mock.patch(\u0027cinder.volume.api.API.manage_existing\u0027, wraps\u003dapi_manage)"},{"line_number":487,"context_line":"    def test_manage_to_default_volume_type(self, mock_api_manage, host):"},{"line_number":488,"context_line":"        \"\"\"Test successful manage volume to default type execution."},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        Tests for correct operation when valid arguments are passed in the"}],"source_content_type":"text/x-python","patch_set":18,"id":"674b4796_fd3f2f1e","line":487,"range":{"start_line":487,"start_character":8,"end_line":487,"end_character":42},"updated":"2022-03-17 13:37:55.000000000","message":"A few problems with this:\n\n1. This test doesn\u0027t seem to have anything to do with the default volume type.\n\n2. Your key code change is happening in the function that\u0027s mocked out here, so this test doesn\u0027t really test your change.\n\n3. This test is an exact duplicate of test_manage_volume_ok, so it\u0027s not needed.","commit_id":"ec849592d03f4070f69d423ff4ef044ab2512389"}],"cinder/tests/unit/api/contrib/test_volume_type_encryption.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"41902e1ddfcf92eca20bcaac5bfe670aaf72e2b1","unresolved":true,"context_lines":[{"line_number":605,"context_line":"        }"},{"line_number":606,"context_line":"        self.assertEqual(expected, res_dict)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    def test_manage_to_encrypt_type(self):"},{"line_number":609,"context_line":"        # Create the volume type and encryption"},{"line_number":610,"context_line":"        volume_type \u003d self._default_volume_type"},{"line_number":611,"context_line":"        self._create_type_and_encryption(volume_type)"}],"source_content_type":"text/x-python","patch_set":11,"id":"98da1393_01d42ada","line":608,"updated":"2021-09-28 06:18:44.000000000","message":"you also need another test where you don\u0027t pass volume type and check if default volume type taken in that case","commit_id":"c16b1c19d3e7f4874b4c9d864831374437c06132"},{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"23320b72b9e7fee82b72dc07d85693f8b1590d87","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        }"},{"line_number":606,"context_line":"        self.assertEqual(expected, res_dict)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    def test_manage_to_encrypt_type(self):"},{"line_number":609,"context_line":"        # Create the volume type and encryption"},{"line_number":610,"context_line":"        volume_type \u003d self._default_volume_type"},{"line_number":611,"context_line":"        self._create_type_and_encryption(volume_type)"}],"source_content_type":"text/x-python","patch_set":11,"id":"a1496c46_dd5e7f9b","line":608,"in_reply_to":"98da1393_01d42ada","updated":"2021-11-23 03:12:42.000000000","message":"Done","commit_id":"c16b1c19d3e7f4874b4c9d864831374437c06132"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5b8beda40e68b12eaa63063d4dfb9f6412f14d1e","unresolved":true,"context_lines":[{"line_number":605,"context_line":"        }"},{"line_number":606,"context_line":"        self.assertEqual(expected, res_dict)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    def test_manage_to_encrypt_type(self):"},{"line_number":609,"context_line":"        # Create the volume type and encryption"},{"line_number":610,"context_line":"        volume_type \u003d self._default_volume_type"},{"line_number":611,"context_line":"        self._create_type_and_encryption(volume_type)"}],"source_content_type":"text/x-python","patch_set":18,"id":"8dc7ae20_58220d9e","line":608,"range":{"start_line":608,"start_character":8,"end_line":608,"end_character":35},"updated":"2022-03-17 13:51:36.000000000","message":"This test is not in the correct file.  This file is testing the encryption extension, whereas what you want to test is the manage extension.","commit_id":"ec849592d03f4070f69d423ff4ef044ab2512389"}],"cinder/volume/api.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"a0c2302aaea0d3da975a18451e2c137a6499d7e8","unresolved":true,"context_lines":[{"line_number":1809,"context_line":"                                                     volume_type[\u0027id\u0027])"},{"line_number":1810,"context_line":"            if is_encrypted:"},{"line_number":1811,"context_line":"                msg \u003d _(\"Managing to encrypted volume type is not supported.\")"},{"line_number":1812,"context_line":"                LOG.exception(msg)"},{"line_number":1813,"context_line":"                raise exception.InvalidVolumeType(msg)"},{"line_number":1814,"context_line":""},{"line_number":1815,"context_line":"        if volume_type and \u0027extra_specs\u0027 not in volume_type:"}],"source_content_type":"text/x-python","patch_set":2,"id":"b45c52a4_cf6256f4","line":1812,"range":{"start_line":1812,"start_character":20,"end_line":1812,"end_character":29},"updated":"2021-01-02 14:13:17.000000000","message":"It should be LOG.error","commit_id":"d5699332121a2e46aacc76ba798a44dc381c8b19"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"d3ef800fe182e72e9caffaf88c61e010756b14ca","unresolved":true,"context_lines":[{"line_number":1809,"context_line":"                                                     volume_type[\u0027id\u0027])"},{"line_number":1810,"context_line":"            if is_encrypted:"},{"line_number":1811,"context_line":"                msg \u003d _(\"Managing to encrypted volume type is not supported.\")"},{"line_number":1812,"context_line":"                LOG.exception(msg)"},{"line_number":1813,"context_line":"                raise exception.InvalidVolumeType(msg)"},{"line_number":1814,"context_line":""},{"line_number":1815,"context_line":"        if volume_type and \u0027extra_specs\u0027 not in volume_type:"}],"source_content_type":"text/x-python","patch_set":2,"id":"c4c9e585_0a1a9077","line":1812,"range":{"start_line":1812,"start_character":20,"end_line":1812,"end_character":29},"in_reply_to":"b45c52a4_cf6256f4","updated":"2021-02-19 15:58:21.000000000","message":"I agree with Ivan\u0027s comment. This issue will be address by https://blueprints.launchpad.net/cinder/+spec/sizing-encrypted-volumes.","commit_id":"d5699332121a2e46aacc76ba798a44dc381c8b19"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"cf52a4dcfd58357795a7171a9d58b108d8edcfac","unresolved":false,"context_lines":[{"line_number":1809,"context_line":"                                                     volume_type[\u0027id\u0027])"},{"line_number":1810,"context_line":"            if is_encrypted:"},{"line_number":1811,"context_line":"                msg \u003d _(\"Managing to encrypted volume type is not supported.\")"},{"line_number":1812,"context_line":"                LOG.exception(msg)"},{"line_number":1813,"context_line":"                raise exception.InvalidVolumeType(msg)"},{"line_number":1814,"context_line":""},{"line_number":1815,"context_line":"        if volume_type and \u0027extra_specs\u0027 not in volume_type:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1eb9673a_c130f3d3","line":1812,"range":{"start_line":1812,"start_character":20,"end_line":1812,"end_character":29},"in_reply_to":"c4c9e585_0a1a9077","updated":"2022-03-21 16:55:39.000000000","message":"Done","commit_id":"d5699332121a2e46aacc76ba798a44dc381c8b19"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cf65740c9eeeec7c5449a4c38dc82cdb1095022e","unresolved":true,"context_lines":[{"line_number":1804,"context_line":"                raise exception.InvalidVolume("},{"line_number":1805,"context_line":"                    _(\"Unable to manage existing volume.\""},{"line_number":1806,"context_line":"                      \" The volume is already managed\"))"},{"line_number":1807,"context_line":"        if volume_type:"},{"line_number":1808,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"},{"line_number":1809,"context_line":"                                                     volume_type[\u0027id\u0027])"},{"line_number":1810,"context_line":"            if is_encrypted:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9e261ca8_7411cce1","line":1807,"range":{"start_line":1807,"start_character":11,"end_line":1807,"end_character":22},"updated":"2021-09-24 01:08:53.000000000","message":"Two things:\n\n1. I wonder if we should check for this at the REST API layer (in contrib.volume_manage.VolumeManageController) and reject it there.  I think we have all the information we need available in the REST API layer, and then we won\u0027t have to make a call to the volume api.\n\n2. If no volume_type is specified in the request, I believe the volume will be managed to the default volume type, and I don\u0027t think there\u0027s any prohibition against an operator configuring an encrypted volume type as the default.  So I think you need to check for that case as well.  There\u0027s a volume_types.get_default_volume_type() function you can use.","commit_id":"9d53cf150c9530310a6e90575c7f04ccbbb14a2c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"15c3fcf606568a9b433d72ed17d03c38acc8242f","unresolved":true,"context_lines":[{"line_number":1804,"context_line":"                raise exception.InvalidVolume("},{"line_number":1805,"context_line":"                    _(\"Unable to manage existing volume.\""},{"line_number":1806,"context_line":"                      \" The volume is already managed\"))"},{"line_number":1807,"context_line":"        if volume_type:"},{"line_number":1808,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"},{"line_number":1809,"context_line":"                                                     volume_type[\u0027id\u0027])"},{"line_number":1810,"context_line":"            if is_encrypted:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ee5af1f4_9cf6e6e3","line":1807,"range":{"start_line":1807,"start_character":11,"end_line":1807,"end_character":22},"in_reply_to":"9e261ca8_7411cce1","updated":"2021-09-24 15:19:23.000000000","message":"I am re-thinking point #1.  There\u0027s not really an advantage to moving this check into the VolumeManageController.  Making it here is fine.","commit_id":"9d53cf150c9530310a6e90575c7f04ccbbb14a2c"},{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"23320b72b9e7fee82b72dc07d85693f8b1590d87","unresolved":false,"context_lines":[{"line_number":1804,"context_line":"                raise exception.InvalidVolume("},{"line_number":1805,"context_line":"                    _(\"Unable to manage existing volume.\""},{"line_number":1806,"context_line":"                      \" The volume is already managed\"))"},{"line_number":1807,"context_line":"        if volume_type:"},{"line_number":1808,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"},{"line_number":1809,"context_line":"                                                     volume_type[\u0027id\u0027])"},{"line_number":1810,"context_line":"            if is_encrypted:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dd17205d_1388c711","line":1807,"range":{"start_line":1807,"start_character":11,"end_line":1807,"end_character":22},"in_reply_to":"ee5af1f4_9cf6e6e3","updated":"2021-11-23 03:12:42.000000000","message":"Done","commit_id":"9d53cf150c9530310a6e90575c7f04ccbbb14a2c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4765d185cfdb150f671c72f8284d57734090c638","unresolved":true,"context_lines":[{"line_number":1797,"context_line":"                raise exception.InvalidVolume("},{"line_number":1798,"context_line":"                    _(\"Unable to manage existing volume.\""},{"line_number":1799,"context_line":"                      \" The volume is already managed\"))"},{"line_number":1800,"context_line":"        default_volume_type \u003d volume_types.get_default_volume_type(context)"},{"line_number":1801,"context_line":"        if volume_type or default_volume_type:"},{"line_number":1802,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"},{"line_number":1803,"context_line":"                                                     volume_type[\u0027id\u0027] or"}],"source_content_type":"text/x-python","patch_set":10,"id":"ed396d14_ca0d190a","line":1800,"range":{"start_line":1800,"start_character":8,"end_line":1800,"end_character":75},"updated":"2021-09-27 07:53:04.000000000","message":"I don\u0027t see the default type used if the user doesn\u0027t supply it. I think it\u0027s a good idea to use default if no type is provided. but let\u0027s see what other\u0027s think\n\n    if not volume_type:\n        volume_type \u003d default_volume_type","commit_id":"411d2575968dbe79b414960eea1fc65b9ecfcc9d"},{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"23320b72b9e7fee82b72dc07d85693f8b1590d87","unresolved":false,"context_lines":[{"line_number":1797,"context_line":"                raise exception.InvalidVolume("},{"line_number":1798,"context_line":"                    _(\"Unable to manage existing volume.\""},{"line_number":1799,"context_line":"                      \" The volume is already managed\"))"},{"line_number":1800,"context_line":"        default_volume_type \u003d volume_types.get_default_volume_type(context)"},{"line_number":1801,"context_line":"        if volume_type or default_volume_type:"},{"line_number":1802,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"},{"line_number":1803,"context_line":"                                                     volume_type[\u0027id\u0027] or"}],"source_content_type":"text/x-python","patch_set":10,"id":"ce380e80_8ed9f7b7","line":1800,"range":{"start_line":1800,"start_character":8,"end_line":1800,"end_character":75},"in_reply_to":"9ce6d012_6db0e4b1","updated":"2021-11-23 03:12:42.000000000","message":"Done","commit_id":"411d2575968dbe79b414960eea1fc65b9ecfcc9d"},{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"2717019cab0b84cde5554ac3f986fcfa19daa13f","unresolved":true,"context_lines":[{"line_number":1797,"context_line":"                raise exception.InvalidVolume("},{"line_number":1798,"context_line":"                    _(\"Unable to manage existing volume.\""},{"line_number":1799,"context_line":"                      \" The volume is already managed\"))"},{"line_number":1800,"context_line":"        default_volume_type \u003d volume_types.get_default_volume_type(context)"},{"line_number":1801,"context_line":"        if volume_type or default_volume_type:"},{"line_number":1802,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"},{"line_number":1803,"context_line":"                                                     volume_type[\u0027id\u0027] or"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ce6d012_6db0e4b1","line":1800,"range":{"start_line":1800,"start_character":8,"end_line":1800,"end_character":75},"in_reply_to":"ed396d14_ca0d190a","updated":"2021-09-27 11:34:46.000000000","message":"yes, this is ok, thanks very much","commit_id":"411d2575968dbe79b414960eea1fc65b9ecfcc9d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4765d185cfdb150f671c72f8284d57734090c638","unresolved":true,"context_lines":[{"line_number":1800,"context_line":"        default_volume_type \u003d volume_types.get_default_volume_type(context)"},{"line_number":1801,"context_line":"        if volume_type or default_volume_type:"},{"line_number":1802,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"},{"line_number":1803,"context_line":"                                                     volume_type[\u0027id\u0027] or"},{"line_number":1804,"context_line":"                                                     default_volume_type.id)"},{"line_number":1805,"context_line":"            if is_encrypted:"},{"line_number":1806,"context_line":"                msg \u003d _(\"Managing to encrypted volume type is not supported.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"6bfef1fe_2c3f4837","line":1803,"range":{"start_line":1803,"start_character":53,"end_line":1803,"end_character":70},"updated":"2021-09-27 07:53:04.000000000","message":"if there is no volume type supplied then this will generate KeyError","commit_id":"411d2575968dbe79b414960eea1fc65b9ecfcc9d"},{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"23320b72b9e7fee82b72dc07d85693f8b1590d87","unresolved":false,"context_lines":[{"line_number":1800,"context_line":"        default_volume_type \u003d volume_types.get_default_volume_type(context)"},{"line_number":1801,"context_line":"        if volume_type or default_volume_type:"},{"line_number":1802,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"},{"line_number":1803,"context_line":"                                                     volume_type[\u0027id\u0027] or"},{"line_number":1804,"context_line":"                                                     default_volume_type.id)"},{"line_number":1805,"context_line":"            if is_encrypted:"},{"line_number":1806,"context_line":"                msg \u003d _(\"Managing to encrypted volume type is not supported.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"cf01e7c3_7f515254","line":1803,"range":{"start_line":1803,"start_character":53,"end_line":1803,"end_character":70},"in_reply_to":"434c6b26_dc84dec3","updated":"2021-11-23 03:12:42.000000000","message":"Done","commit_id":"411d2575968dbe79b414960eea1fc65b9ecfcc9d"},{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"2717019cab0b84cde5554ac3f986fcfa19daa13f","unresolved":true,"context_lines":[{"line_number":1800,"context_line":"        default_volume_type \u003d volume_types.get_default_volume_type(context)"},{"line_number":1801,"context_line":"        if volume_type or default_volume_type:"},{"line_number":1802,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"},{"line_number":1803,"context_line":"                                                     volume_type[\u0027id\u0027] or"},{"line_number":1804,"context_line":"                                                     default_volume_type.id)"},{"line_number":1805,"context_line":"            if is_encrypted:"},{"line_number":1806,"context_line":"                msg \u003d _(\"Managing to encrypted volume type is not supported.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"434c6b26_dc84dec3","line":1803,"range":{"start_line":1803,"start_character":53,"end_line":1803,"end_character":70},"in_reply_to":"6bfef1fe_2c3f4837","updated":"2021-09-27 11:34:46.000000000","message":"got it, thanks very much","commit_id":"411d2575968dbe79b414960eea1fc65b9ecfcc9d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4765d185cfdb150f671c72f8284d57734090c638","unresolved":true,"context_lines":[{"line_number":1801,"context_line":"        if volume_type or default_volume_type:"},{"line_number":1802,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"},{"line_number":1803,"context_line":"                                                     volume_type[\u0027id\u0027] or"},{"line_number":1804,"context_line":"                                                     default_volume_type.id)"},{"line_number":1805,"context_line":"            if is_encrypted:"},{"line_number":1806,"context_line":"                msg \u003d _(\"Managing to encrypted volume type is not supported.\")"},{"line_number":1807,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"d063b15d_991bcc70","line":1804,"range":{"start_line":1804,"start_character":53,"end_line":1804,"end_character":75},"updated":"2021-09-27 07:53:04.000000000","message":"default volume type is returned as dict and not OVO so we need to do default_volume_type[\u0027id\u0027] here","commit_id":"411d2575968dbe79b414960eea1fc65b9ecfcc9d"},{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"23320b72b9e7fee82b72dc07d85693f8b1590d87","unresolved":false,"context_lines":[{"line_number":1801,"context_line":"        if volume_type or default_volume_type:"},{"line_number":1802,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"},{"line_number":1803,"context_line":"                                                     volume_type[\u0027id\u0027] or"},{"line_number":1804,"context_line":"                                                     default_volume_type.id)"},{"line_number":1805,"context_line":"            if is_encrypted:"},{"line_number":1806,"context_line":"                msg \u003d _(\"Managing to encrypted volume type is not supported.\")"},{"line_number":1807,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"4d34d86d_b2a9a15f","line":1804,"range":{"start_line":1804,"start_character":53,"end_line":1804,"end_character":75},"in_reply_to":"93c57618_36c58c6f","updated":"2021-11-23 03:12:42.000000000","message":"Done","commit_id":"411d2575968dbe79b414960eea1fc65b9ecfcc9d"},{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"2717019cab0b84cde5554ac3f986fcfa19daa13f","unresolved":true,"context_lines":[{"line_number":1801,"context_line":"        if volume_type or default_volume_type:"},{"line_number":1802,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"},{"line_number":1803,"context_line":"                                                     volume_type[\u0027id\u0027] or"},{"line_number":1804,"context_line":"                                                     default_volume_type.id)"},{"line_number":1805,"context_line":"            if is_encrypted:"},{"line_number":1806,"context_line":"                msg \u003d _(\"Managing to encrypted volume type is not supported.\")"},{"line_number":1807,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"93c57618_36c58c6f","line":1804,"range":{"start_line":1804,"start_character":53,"end_line":1804,"end_character":75},"in_reply_to":"d063b15d_991bcc70","updated":"2021-09-27 11:34:46.000000000","message":"got it, thanks very much","commit_id":"411d2575968dbe79b414960eea1fc65b9ecfcc9d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"97978bd13d9b1965ef0781b3db3cb9f6843659a7","unresolved":true,"context_lines":[{"line_number":1801,"context_line":"        if not volume_type:"},{"line_number":1802,"context_line":"            volume_type \u003d default_volume_type"},{"line_number":1803,"context_line":""},{"line_number":1804,"context_line":"        if volume_type:"},{"line_number":1805,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"},{"line_number":1806,"context_line":"                                                     volume_type[\u0027id\u0027])"},{"line_number":1807,"context_line":"            if is_encrypted:"}],"source_content_type":"text/x-python","patch_set":11,"id":"ac2b69c6_8cc11419","line":1804,"updated":"2021-09-27 12:28:37.000000000","message":"Hi,\n\nAt lines 1801 \u0026 1802, if volume_type is None;\nthen volume_type is given value as default_volume_type.\n\nThus volume_type will always have some value;\ni.e it will not be None.\n\nSo, can the \"if\" condition skipped here ?","commit_id":"c16b1c19d3e7f4874b4c9d864831374437c06132"},{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"f62c6d09bf650955078847671020784a2ec301bc","unresolved":false,"context_lines":[{"line_number":1801,"context_line":"        if not volume_type:"},{"line_number":1802,"context_line":"            volume_type \u003d default_volume_type"},{"line_number":1803,"context_line":""},{"line_number":1804,"context_line":"        if volume_type:"},{"line_number":1805,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"},{"line_number":1806,"context_line":"                                                     volume_type[\u0027id\u0027])"},{"line_number":1807,"context_line":"            if is_encrypted:"}],"source_content_type":"text/x-python","patch_set":11,"id":"ca3a61e3_266dee84","line":1804,"in_reply_to":"ac2b69c6_8cc11419","updated":"2021-11-21 12:49:29.000000000","message":"Done","commit_id":"c16b1c19d3e7f4874b4c9d864831374437c06132"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d9901bd83a41d8cf13889014cb1c7523b4f75d92","unresolved":true,"context_lines":[{"line_number":1797,"context_line":"                raise exception.InvalidVolume("},{"line_number":1798,"context_line":"                    _(\"Unable to manage existing volume.\""},{"line_number":1799,"context_line":"                      \" The volume is already managed\"))"},{"line_number":1800,"context_line":"        default_volume_type \u003d volume_types.get_default_volume_type(context)"},{"line_number":1801,"context_line":"        if not volume_type:"},{"line_number":1802,"context_line":"            volume_type \u003d default_volume_type"},{"line_number":1803,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"adc04e89_c99488a7","line":1800,"updated":"2021-11-22 14:33:37.000000000","message":"nit: if the user gives us a volume_type, then this is a wasted function call.  I suggest removing this and changing line 1802 to\n\n  volume_type \u003d volume_types.get_default_volume_type(context)","commit_id":"de102eddc2ea75ad16ab9277caedc1714e5ab507"},{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"23320b72b9e7fee82b72dc07d85693f8b1590d87","unresolved":false,"context_lines":[{"line_number":1797,"context_line":"                raise exception.InvalidVolume("},{"line_number":1798,"context_line":"                    _(\"Unable to manage existing volume.\""},{"line_number":1799,"context_line":"                      \" The volume is already managed\"))"},{"line_number":1800,"context_line":"        default_volume_type \u003d volume_types.get_default_volume_type(context)"},{"line_number":1801,"context_line":"        if not volume_type:"},{"line_number":1802,"context_line":"            volume_type \u003d default_volume_type"},{"line_number":1803,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"6ef445d4_5a39e0fd","line":1800,"in_reply_to":"adc04e89_c99488a7","updated":"2021-11-23 03:12:42.000000000","message":"Done","commit_id":"de102eddc2ea75ad16ab9277caedc1714e5ab507"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c95bb1b91c2da162a518c8706a5851d54c783188","unresolved":true,"context_lines":[{"line_number":1801,"context_line":"            try:"},{"line_number":1802,"context_line":"                volume_type \u003d volume_types.get_default_volume_type(context)"},{"line_number":1803,"context_line":"            except exception.VolumeTypeDefaultMisconfiguredError:"},{"line_number":1804,"context_line":"                LOG.info(\"Default volume type not found.\")"},{"line_number":1805,"context_line":"        is_encrypted \u003d False"},{"line_number":1806,"context_line":"        if volume_type:"},{"line_number":1807,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"}],"source_content_type":"text/x-python","patch_set":17,"id":"31a6d94d_e3779f2e","line":1804,"range":{"start_line":1804,"start_character":16,"end_line":1804,"end_character":58},"updated":"2022-02-11 13:50:37.000000000","message":"I think this should be \u0027error\u0027 because it\u0027s something the operator can (and should) correct immediately.  Also, if we don\u0027t have a volume type, and we can\u0027t get a default type, what\u0027s going to happen when we call manage_existing.get_flow() ? (It should fail at some point.)  It might make sense to raise here so that we fail early before creating the flow etc which will ultimately fail anyway.\n\nThis will also allow you remove all the \"if volume_type\" stuff, because if we get past this part of the code, we know we have a volume_type.","commit_id":"1656e8e5c6b833bbe8d0ed2ae587a6a72e2a165f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"21d08b53bc95c968f93b7a6cd7cda6efaffcde14","unresolved":true,"context_lines":[{"line_number":1801,"context_line":"            try:"},{"line_number":1802,"context_line":"                volume_type \u003d volume_types.get_default_volume_type(context)"},{"line_number":1803,"context_line":"            except exception.VolumeTypeDefaultMisconfiguredError:"},{"line_number":1804,"context_line":"                LOG.info(\"Default volume type not found.\")"},{"line_number":1805,"context_line":"        is_encrypted \u003d False"},{"line_number":1806,"context_line":"        if volume_type:"},{"line_number":1807,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"}],"source_content_type":"text/x-python","patch_set":17,"id":"cffb6393_e3b902ea","line":1804,"range":{"start_line":1804,"start_character":16,"end_line":1804,"end_character":58},"in_reply_to":"0958ce6c_97b87bd9","updated":"2022-03-10 02:51:22.000000000","message":"It\u0027s going to fail at some point because the volume_type_id column in the volumes table in the database is non-nullable","commit_id":"1656e8e5c6b833bbe8d0ed2ae587a6a72e2a165f"},{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"1f71ee51787974e0c50fc4efdecf48d5d8a0d4cb","unresolved":true,"context_lines":[{"line_number":1801,"context_line":"            try:"},{"line_number":1802,"context_line":"                volume_type \u003d volume_types.get_default_volume_type(context)"},{"line_number":1803,"context_line":"            except exception.VolumeTypeDefaultMisconfiguredError:"},{"line_number":1804,"context_line":"                LOG.info(\"Default volume type not found.\")"},{"line_number":1805,"context_line":"        is_encrypted \u003d False"},{"line_number":1806,"context_line":"        if volume_type:"},{"line_number":1807,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"}],"source_content_type":"text/x-python","patch_set":17,"id":"0958ce6c_97b87bd9","line":1804,"range":{"start_line":1804,"start_character":16,"end_line":1804,"end_character":58},"in_reply_to":"31a6d94d_e3779f2e","updated":"2022-03-02 03:08:19.000000000","message":"ok， i read the manage_existing flow, it will not failed when the volume_type is none. if not volume type, the volume_type_id set none.","commit_id":"1656e8e5c6b833bbe8d0ed2ae587a6a72e2a165f"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"cf52a4dcfd58357795a7171a9d58b108d8edcfac","unresolved":false,"context_lines":[{"line_number":1801,"context_line":"            try:"},{"line_number":1802,"context_line":"                volume_type \u003d volume_types.get_default_volume_type(context)"},{"line_number":1803,"context_line":"            except exception.VolumeTypeDefaultMisconfiguredError:"},{"line_number":1804,"context_line":"                LOG.info(\"Default volume type not found.\")"},{"line_number":1805,"context_line":"        is_encrypted \u003d False"},{"line_number":1806,"context_line":"        if volume_type:"},{"line_number":1807,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5bcd3df6_0026d12c","line":1804,"range":{"start_line":1804,"start_character":16,"end_line":1804,"end_character":58},"in_reply_to":"cffb6393_e3b902ea","updated":"2022-03-21 16:55:39.000000000","message":"Done","commit_id":"1656e8e5c6b833bbe8d0ed2ae587a6a72e2a165f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"21d08b53bc95c968f93b7a6cd7cda6efaffcde14","unresolved":true,"context_lines":[{"line_number":1801,"context_line":"            try:"},{"line_number":1802,"context_line":"                volume_type \u003d volume_types.get_default_volume_type(context)"},{"line_number":1803,"context_line":"            except exception.VolumeTypeDefaultMisconfiguredError:"},{"line_number":1804,"context_line":"                LOG.error(\"Default volume type not found.\")"},{"line_number":1805,"context_line":"        is_encrypted \u003d False"},{"line_number":1806,"context_line":"        if volume_type:"},{"line_number":1807,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"}],"source_content_type":"text/x-python","patch_set":18,"id":"2fcba04d_4522d32b","line":1804,"updated":"2022-03-10 02:51:22.000000000","message":"I think you should raise here and let the caller handle the VolumeTypeDefaultMisconfiguredError, because this call will eventually fail (see my comment on PS17).","commit_id":"ec849592d03f4070f69d423ff4ef044ab2512389"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"cf52a4dcfd58357795a7171a9d58b108d8edcfac","unresolved":false,"context_lines":[{"line_number":1801,"context_line":"            try:"},{"line_number":1802,"context_line":"                volume_type \u003d volume_types.get_default_volume_type(context)"},{"line_number":1803,"context_line":"            except exception.VolumeTypeDefaultMisconfiguredError:"},{"line_number":1804,"context_line":"                LOG.error(\"Default volume type not found.\")"},{"line_number":1805,"context_line":"        is_encrypted \u003d False"},{"line_number":1806,"context_line":"        if volume_type:"},{"line_number":1807,"context_line":"            is_encrypted \u003d volume_types.is_encrypted(context,"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa6baf0b_773395fe","line":1804,"in_reply_to":"2fcba04d_4522d32b","updated":"2022-03-21 16:55:39.000000000","message":"Ack. Sounds good!","commit_id":"ec849592d03f4070f69d423ff4ef044ab2512389"}]}