)]}'
{"cinder/tests/unit/volume/drivers/hitachi/test_hitachi_hbsd_rest_fc.py":[{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"c7ada743820f3022f67ec0a1fed4715e7a4fca4a","unresolved":true,"context_lines":[{"line_number":597,"context_line":"    @mock.patch.object(driver.FibreChannelDriver, \"get_goodness_function\")"},{"line_number":598,"context_line":"    @mock.patch.object(driver.FibreChannelDriver, \"get_filter_function\")"},{"line_number":599,"context_line":"    @mock.patch.object(requests.Session, \"request\")"},{"line_number":600,"context_line":"    def test__update_volume_stats("},{"line_number":601,"context_line":"            self, request, get_filter_function, get_goodness_function):"},{"line_number":602,"context_line":"        request.return_value \u003d FakeResponse(200, GET_POOL_RESULT)"},{"line_number":603,"context_line":"        get_filter_function.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"a57481b5_685220a6","line":600,"updated":"2021-02-04 04:58:52.000000000","message":"Typo.\u0027_\u0027 is duplicated.","commit_id":"929f32c498a5cfd2fa777af5478e6c434e77e1a8"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"a3ae06ec31d241103f4745613ebb3dfba3563e1c","unresolved":false,"context_lines":[{"line_number":597,"context_line":"    @mock.patch.object(driver.FibreChannelDriver, \"get_goodness_function\")"},{"line_number":598,"context_line":"    @mock.patch.object(driver.FibreChannelDriver, \"get_filter_function\")"},{"line_number":599,"context_line":"    @mock.patch.object(requests.Session, \"request\")"},{"line_number":600,"context_line":"    def test__update_volume_stats("},{"line_number":601,"context_line":"            self, request, get_filter_function, get_goodness_function):"},{"line_number":602,"context_line":"        request.return_value \u003d FakeResponse(200, GET_POOL_RESULT)"},{"line_number":603,"context_line":"        get_filter_function.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"8bf12eec_47a6eb62","line":600,"in_reply_to":"0eb360a9_b6c7ba81","updated":"2021-02-16 08:15:48.000000000","message":"Done","commit_id":"929f32c498a5cfd2fa777af5478e6c434e77e1a8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9a8a25a42775698b15c6b14bbc8f19f94f7d83a7","unresolved":true,"context_lines":[{"line_number":597,"context_line":"    @mock.patch.object(driver.FibreChannelDriver, \"get_goodness_function\")"},{"line_number":598,"context_line":"    @mock.patch.object(driver.FibreChannelDriver, \"get_filter_function\")"},{"line_number":599,"context_line":"    @mock.patch.object(requests.Session, \"request\")"},{"line_number":600,"context_line":"    def test__update_volume_stats("},{"line_number":601,"context_line":"            self, request, get_filter_function, get_goodness_function):"},{"line_number":602,"context_line":"        request.return_value \u003d FakeResponse(200, GET_POOL_RESULT)"},{"line_number":603,"context_line":"        get_filter_function.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"0eb360a9_b6c7ba81","line":600,"in_reply_to":"a57481b5_685220a6","updated":"2021-02-11 22:05:19.000000000","message":"I see your point, but the convention is \"test_\" prefixing the name of the function being tested, so two underscores do make sense here.  I don\u0027t think we are consistent about it throughout the test code, though.","commit_id":"929f32c498a5cfd2fa777af5478e6c434e77e1a8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9a8a25a42775698b15c6b14bbc8f19f94f7d83a7","unresolved":true,"context_lines":[{"line_number":602,"context_line":"        request.return_value \u003d FakeResponse(200, GET_POOL_RESULT)"},{"line_number":603,"context_line":"        get_filter_function.return_value \u003d None"},{"line_number":604,"context_line":"        get_goodness_function.return_value \u003d None"},{"line_number":605,"context_line":"        self.driver._update_volume_stats()"},{"line_number":606,"context_line":"        self.assertEqual(\u0027Hitachi\u0027, self.driver._stats[\u0027vendor_name\u0027])"},{"line_number":607,"context_line":"        self.assertTrue(self.driver._stats[\"pools\"][0][\u0027multiattach\u0027])"},{"line_number":608,"context_line":"        self.assertEqual(1, request.call_count)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6e53e741_98581e80","line":605,"updated":"2021-02-11 22:05:19.000000000","message":"I think instead of calling _update_volume_stats() directly, I think you should call update_volume_stats() to make sure you\u0027ve got the plumbing correct between the BaseVD and your driver class.  Or you could add a different test that does that.  Key thing is to make sure that update_volume_stats() works correctly, because that\u0027s what the consumer of your driver will call.\n\nSame thing in the iscsi driver file.","commit_id":"929f32c498a5cfd2fa777af5478e6c434e77e1a8"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"a3ae06ec31d241103f4745613ebb3dfba3563e1c","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        request.return_value \u003d FakeResponse(200, GET_POOL_RESULT)"},{"line_number":603,"context_line":"        get_filter_function.return_value \u003d None"},{"line_number":604,"context_line":"        get_goodness_function.return_value \u003d None"},{"line_number":605,"context_line":"        self.driver._update_volume_stats()"},{"line_number":606,"context_line":"        self.assertEqual(\u0027Hitachi\u0027, self.driver._stats[\u0027vendor_name\u0027])"},{"line_number":607,"context_line":"        self.assertTrue(self.driver._stats[\"pools\"][0][\u0027multiattach\u0027])"},{"line_number":608,"context_line":"        self.assertEqual(1, request.call_count)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1048cc98_5fce4e79","line":605,"in_reply_to":"6e53e741_98581e80","updated":"2021-02-16 08:15:48.000000000","message":"I restored the test code from test__update_volume_stats() to test_get_volume_stats().","commit_id":"929f32c498a5cfd2fa777af5478e6c434e77e1a8"}],"cinder/tests/unit/volume/drivers/hitachi/test_hitachi_hbsd_rest_iscsi.py":[{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"c7ada743820f3022f67ec0a1fed4715e7a4fca4a","unresolved":true,"context_lines":[{"line_number":425,"context_line":"    @mock.patch.object(driver.ISCSIDriver, \"get_goodness_function\")"},{"line_number":426,"context_line":"    @mock.patch.object(driver.ISCSIDriver, \"get_filter_function\")"},{"line_number":427,"context_line":"    @mock.patch.object(requests.Session, \"request\")"},{"line_number":428,"context_line":"    def test__update_volume_stats("},{"line_number":429,"context_line":"            self, request, get_filter_function, get_goodness_function):"},{"line_number":430,"context_line":"        request.return_value \u003d FakeResponse(200, GET_POOL_RESULT)"},{"line_number":431,"context_line":"        get_filter_function.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"0769483f_f5b0af03","line":428,"updated":"2021-02-04 04:58:52.000000000","message":"same.","commit_id":"929f32c498a5cfd2fa777af5478e6c434e77e1a8"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"a3ae06ec31d241103f4745613ebb3dfba3563e1c","unresolved":false,"context_lines":[{"line_number":425,"context_line":"    @mock.patch.object(driver.ISCSIDriver, \"get_goodness_function\")"},{"line_number":426,"context_line":"    @mock.patch.object(driver.ISCSIDriver, \"get_filter_function\")"},{"line_number":427,"context_line":"    @mock.patch.object(requests.Session, \"request\")"},{"line_number":428,"context_line":"    def test__update_volume_stats("},{"line_number":429,"context_line":"            self, request, get_filter_function, get_goodness_function):"},{"line_number":430,"context_line":"        request.return_value \u003d FakeResponse(200, GET_POOL_RESULT)"},{"line_number":431,"context_line":"        get_filter_function.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"bbb1ecf3_b9a94807","line":428,"in_reply_to":"0769483f_f5b0af03","updated":"2021-02-16 08:15:48.000000000","message":"Done","commit_id":"929f32c498a5cfd2fa777af5478e6c434e77e1a8"}],"cinder/volume/drivers/hitachi/hbsd_common.py":[{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"c7ada743820f3022f67ec0a1fed4715e7a4fca4a","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            \u0027portals\u0027: {},"},{"line_number":139,"context_line":"        }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        self._stats \u003d {}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def create_ldev(self, size):"},{"line_number":144,"context_line":"        \"\"\"Create an LDEV and return its LDEV number.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"0efd2d98_b89b80e9","line":141,"updated":"2021-02-04 04:58:52.000000000","message":"It seems that this variable no longer used. You can delete this variable.","commit_id":"929f32c498a5cfd2fa777af5478e6c434e77e1a8"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"a3ae06ec31d241103f4745613ebb3dfba3563e1c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            \u0027portals\u0027: {},"},{"line_number":139,"context_line":"        }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        self._stats \u003d {}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def create_ldev(self, size):"},{"line_number":144,"context_line":"        \"\"\"Create an LDEV and return its LDEV number.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"0b47ea8c_2560e096","line":141,"in_reply_to":"0efd2d98_b89b80e9","updated":"2021-02-16 08:15:48.000000000","message":"Done","commit_id":"929f32c498a5cfd2fa777af5478e6c434e77e1a8"}]}