)]}'
{"cinder/utils.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7273766f2c417f604b3af1162e06cb0399638268","unresolved":true,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\"Utilities and helper functions.\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import abc"},{"line_number":21,"context_line":"from collections import OrderedDict"}],"source_content_type":"text/x-python","patch_set":6,"id":"3c22cad9_6bf2a902","line":18,"updated":"2021-02-11 14:14:42.000000000","message":"nit: It would be useful to add to the docstring what kind of utils methods should go in here and which ones should go into volume.utils.  Good examples of things that should not go in here would be these that you are moving out and the tracing ones.","commit_id":"e7b4670516d9db4606efdeae36052c8da6470072"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ec61b1a7de7ebe5701529238a41f79f785026a37","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\"Utilities and helper functions.\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import abc"},{"line_number":21,"context_line":"from collections import OrderedDict"}],"source_content_type":"text/x-python","patch_set":6,"id":"f8e96e97_51d1c131","line":18,"in_reply_to":"3c22cad9_6bf2a902","updated":"2021-02-11 18:29:44.000000000","message":"Done in\n    https://review.opendev.org/c/openstack/cinder/+/775250","commit_id":"e7b4670516d9db4606efdeae36052c8da6470072"}],"cinder/volume/drivers/datera/datera_api21.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9e2ffdb615bab1c7d0d96d647f2af96ab7540eb9","unresolved":true,"context_lines":[{"line_number":885,"context_line":"            # export (ACL, IP-Pools, etc)"},{"line_number":886,"context_line":"            conn \u003d self._initialize_connection_2_1("},{"line_number":887,"context_line":"                vol, {\u0027multipath\u0027: False})"},{"line_number":888,"context_line":"            connector \u003d utils.brick_get_connector("},{"line_number":889,"context_line":"                conn[\u0027driver_volume_type\u0027],"},{"line_number":890,"context_line":"                use_multipath\u003dFalse,"},{"line_number":891,"context_line":"                device_scan_attempts\u003d10,"}],"source_content_type":"text/x-python","patch_set":5,"id":"469744f9_a84fde06","line":888,"range":{"start_line":888,"start_character":24,"end_line":888,"end_character":29},"updated":"2021-02-10 21:45:42.000000000","message":"volutils ?","commit_id":"aba3a77ef69a951dddb1cb3e98b117ba375b627a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5fdaeaa6cf9d29761f71688f010d081d4b5e389b","unresolved":true,"context_lines":[{"line_number":885,"context_line":"            # export (ACL, IP-Pools, etc)"},{"line_number":886,"context_line":"            conn \u003d self._initialize_connection_2_1("},{"line_number":887,"context_line":"                vol, {\u0027multipath\u0027: False})"},{"line_number":888,"context_line":"            connector \u003d utils.brick_get_connector("},{"line_number":889,"context_line":"                conn[\u0027driver_volume_type\u0027],"},{"line_number":890,"context_line":"                use_multipath\u003dFalse,"},{"line_number":891,"context_line":"                device_scan_attempts\u003d10,"}],"source_content_type":"text/x-python","patch_set":5,"id":"53205436_1b836724","line":888,"range":{"start_line":888,"start_character":24,"end_line":888,"end_character":29},"in_reply_to":"469744f9_a84fde06","updated":"2021-02-10 22:26:08.000000000","message":"This is not covered by unit tests. 😞\n\nDone","commit_id":"aba3a77ef69a951dddb1cb3e98b117ba375b627a"}],"cinder/volume/drivers/datera/datera_api22.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9e2ffdb615bab1c7d0d96d647f2af96ab7540eb9","unresolved":true,"context_lines":[{"line_number":935,"context_line":"            # export (ACL, IP-Pools, etc)"},{"line_number":936,"context_line":"            conn \u003d self._initialize_connection_2_2("},{"line_number":937,"context_line":"                vol, {\u0027multipath\u0027: False})"},{"line_number":938,"context_line":"            connector \u003d utils.brick_get_connector("},{"line_number":939,"context_line":"                conn[\u0027driver_volume_type\u0027],"},{"line_number":940,"context_line":"                use_multipath\u003dFalse,"},{"line_number":941,"context_line":"                device_scan_attempts\u003d10,"}],"source_content_type":"text/x-python","patch_set":5,"id":"de55323a_12c1bbb8","line":938,"range":{"start_line":938,"start_character":24,"end_line":938,"end_character":29},"updated":"2021-02-10 21:45:42.000000000","message":"volutils ?","commit_id":"aba3a77ef69a951dddb1cb3e98b117ba375b627a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5fdaeaa6cf9d29761f71688f010d081d4b5e389b","unresolved":false,"context_lines":[{"line_number":935,"context_line":"            # export (ACL, IP-Pools, etc)"},{"line_number":936,"context_line":"            conn \u003d self._initialize_connection_2_2("},{"line_number":937,"context_line":"                vol, {\u0027multipath\u0027: False})"},{"line_number":938,"context_line":"            connector \u003d utils.brick_get_connector("},{"line_number":939,"context_line":"                conn[\u0027driver_volume_type\u0027],"},{"line_number":940,"context_line":"                use_multipath\u003dFalse,"},{"line_number":941,"context_line":"                device_scan_attempts\u003d10,"}],"source_content_type":"text/x-python","patch_set":5,"id":"e75ae9bb_857e1533","line":938,"range":{"start_line":938,"start_character":24,"end_line":938,"end_character":29},"in_reply_to":"de55323a_12c1bbb8","updated":"2021-02-10 22:26:08.000000000","message":"Done","commit_id":"aba3a77ef69a951dddb1cb3e98b117ba375b627a"}],"cinder/volume/drivers/ibm/flashsystem_common.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9e2ffdb615bab1c7d0d96d647f2af96ab7540eb9","unresolved":true,"context_lines":[{"line_number":852,"context_line":"        use_multipath \u003d self.configuration.use_multipath_for_image_xfer"},{"line_number":853,"context_line":"        device_scan_attempts \u003d self.configuration.num_volume_device_scan_tries"},{"line_number":854,"context_line":"        protocol \u003d properties[\u0027driver_volume_type\u0027]"},{"line_number":855,"context_line":"        connector \u003d utils.brick_get_connector(protocol,"},{"line_number":856,"context_line":"                                              use_multipath\u003duse_multipath,"},{"line_number":857,"context_line":"                                              device_scan_attempts\u003d"},{"line_number":858,"context_line":"                                              device_scan_attempts,"}],"source_content_type":"text/x-python","patch_set":5,"id":"030e17ce_5012bbdf","line":855,"range":{"start_line":855,"start_character":20,"end_line":855,"end_character":25},"updated":"2021-02-10 21:45:42.000000000","message":"I think this should be volume_utils ?","commit_id":"aba3a77ef69a951dddb1cb3e98b117ba375b627a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5fdaeaa6cf9d29761f71688f010d081d4b5e389b","unresolved":false,"context_lines":[{"line_number":852,"context_line":"        use_multipath \u003d self.configuration.use_multipath_for_image_xfer"},{"line_number":853,"context_line":"        device_scan_attempts \u003d self.configuration.num_volume_device_scan_tries"},{"line_number":854,"context_line":"        protocol \u003d properties[\u0027driver_volume_type\u0027]"},{"line_number":855,"context_line":"        connector \u003d utils.brick_get_connector(protocol,"},{"line_number":856,"context_line":"                                              use_multipath\u003duse_multipath,"},{"line_number":857,"context_line":"                                              device_scan_attempts\u003d"},{"line_number":858,"context_line":"                                              device_scan_attempts,"}],"source_content_type":"text/x-python","patch_set":5,"id":"8694cf17_cc177f91","line":855,"range":{"start_line":855,"start_character":20,"end_line":855,"end_character":25},"in_reply_to":"030e17ce_5012bbdf","updated":"2021-02-10 22:26:08.000000000","message":"Done","commit_id":"aba3a77ef69a951dddb1cb3e98b117ba375b627a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9e2ffdb615bab1c7d0d96d647f2af96ab7540eb9","unresolved":true,"context_lines":[{"line_number":888,"context_line":"        use_multipath \u003d self.configuration.use_multipath_for_image_xfer"},{"line_number":889,"context_line":"        device_scan_attempts \u003d self.configuration.num_volume_device_scan_tries"},{"line_number":890,"context_line":"        protocol \u003d properties[\u0027driver_volume_type\u0027]"},{"line_number":891,"context_line":"        connector \u003d utils.brick_get_connector(protocol,"},{"line_number":892,"context_line":"                                              use_multipath\u003duse_multipath,"},{"line_number":893,"context_line":"                                              device_scan_attempts\u003d"},{"line_number":894,"context_line":"                                              device_scan_attempts,"}],"source_content_type":"text/x-python","patch_set":5,"id":"c32520e9_1932ef81","line":891,"range":{"start_line":891,"start_character":20,"end_line":891,"end_character":25},"updated":"2021-02-10 21:45:42.000000000","message":"volume_utils ?","commit_id":"aba3a77ef69a951dddb1cb3e98b117ba375b627a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5fdaeaa6cf9d29761f71688f010d081d4b5e389b","unresolved":false,"context_lines":[{"line_number":888,"context_line":"        use_multipath \u003d self.configuration.use_multipath_for_image_xfer"},{"line_number":889,"context_line":"        device_scan_attempts \u003d self.configuration.num_volume_device_scan_tries"},{"line_number":890,"context_line":"        protocol \u003d properties[\u0027driver_volume_type\u0027]"},{"line_number":891,"context_line":"        connector \u003d utils.brick_get_connector(protocol,"},{"line_number":892,"context_line":"                                              use_multipath\u003duse_multipath,"},{"line_number":893,"context_line":"                                              device_scan_attempts\u003d"},{"line_number":894,"context_line":"                                              device_scan_attempts,"}],"source_content_type":"text/x-python","patch_set":5,"id":"2dc6995f_7af22939","line":891,"range":{"start_line":891,"start_character":20,"end_line":891,"end_character":25},"in_reply_to":"c32520e9_1932ef81","updated":"2021-02-10 22:26:08.000000000","message":"Done","commit_id":"aba3a77ef69a951dddb1cb3e98b117ba375b627a"}],"cinder/volume/manager.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5fdaeaa6cf9d29761f71688f010d081d4b5e389b","unresolved":true,"context_lines":[{"line_number":2110,"context_line":"                encryption \u003d self.db.volume_encryption_metadata_get("},{"line_number":2111,"context_line":"                    ctxt.elevated(), volume.id)"},{"line_number":2112,"context_line":"                if encryption:"},{"line_number":2113,"context_line":"                    utils.brick_detach_volume_encryptor(attach_info,"},{"line_number":2114,"context_line":"                                                        encryption)"},{"line_number":2115,"context_line":"            connector.disconnect_volume(attach_info[\u0027conn\u0027][\u0027data\u0027],"},{"line_number":2116,"context_line":"                                        attach_info[\u0027device\u0027], force\u003dforce)"}],"source_content_type":"text/x-python","patch_set":5,"id":"cb8694a7_656f6093","line":2113,"range":{"start_line":2113,"start_character":20,"end_line":2113,"end_character":25},"updated":"2021-02-10 22:26:08.000000000","message":"?","commit_id":"aba3a77ef69a951dddb1cb3e98b117ba375b627a"}]}