)]}'
{"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2b83c21edf642e96b957cd19501407163ec507d4","unresolved":true,"context_lines":[{"line_number":155,"context_line":"        return exists"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def _create_vg(self, pv_list):"},{"line_number":158,"context_line":"        cinder.privsep.lvm.create_volume(self.vg_name, pv_list)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def _get_thin_pool_free_space(self, vg_name, thin_pool_name):"},{"line_number":161,"context_line":"        \"\"\"Returns available thin pool free space."}],"source_content_type":"text/x-python","patch_set":1,"id":"cb7bd28e_c589fd92","line":158,"range":{"start_line":158,"start_character":27,"end_line":158,"end_character":40},"updated":"2021-02-10 19:18:17.000000000","message":"should this be create_vg ?  I\u0027m trying to figure out why the change to generated_members in .pylintrc is necessary but I\u0027m stumped.","commit_id":"0a2e0e45d41fa0a8a7fb40377998f766f9c82b97"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0b2d7f1bd763ce300d7aee153232d206572c2637","unresolved":true,"context_lines":[{"line_number":155,"context_line":"        return exists"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def _create_vg(self, pv_list):"},{"line_number":158,"context_line":"        cinder.privsep.lvm.create_volume(self.vg_name, pv_list)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def _get_thin_pool_free_space(self, vg_name, thin_pool_name):"},{"line_number":161,"context_line":"        \"\"\"Returns available thin pool free space."}],"source_content_type":"text/x-python","patch_set":1,"id":"773a53a5_02fd422c","line":158,"range":{"start_line":158,"start_character":27,"end_line":158,"end_character":40},"in_reply_to":"54414525_ddcf28ba","updated":"2021-02-11 18:40:44.000000000","message":"Wrote a bug to track that:\n    https://bugs.launchpad.net/cinder/+bug/1915439","commit_id":"0a2e0e45d41fa0a8a7fb40377998f766f9c82b97"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d63c6da3642d6211e9de1b63ca525d643193c53c","unresolved":true,"context_lines":[{"line_number":155,"context_line":"        return exists"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def _create_vg(self, pv_list):"},{"line_number":158,"context_line":"        cinder.privsep.lvm.create_volume(self.vg_name, pv_list)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def _get_thin_pool_free_space(self, vg_name, thin_pool_name):"},{"line_number":161,"context_line":"        \"\"\"Returns available thin pool free space."}],"source_content_type":"text/x-python","patch_set":1,"id":"54414525_ddcf28ba","line":158,"range":{"start_line":158,"start_character":27,"end_line":158,"end_character":40},"in_reply_to":"cb7bd28e_c589fd92","updated":"2021-02-11 18:38:38.000000000","message":"This code doesn\u0027t work, it used to call vgcreate but was accidentally replaced w/ create_volume (lvcreate) here:\n    https://review.opendev.org/c/openstack/cinder/+/631599/2/cinder/brick/local_dev/lvm.py\n\nWe should probably just remove the functionality of creating a VG since it hasn\u0027t worked in two years with nobody noticing.  CI jobs and most deployments don\u0027t do it this way, they use externally created VGs.","commit_id":"0a2e0e45d41fa0a8a7fb40377998f766f9c82b97"}]}