)]}'
{"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"35a6879d1c9142845fb9c1144ed485367659d42b","unresolved":true,"context_lines":[{"line_number":2200,"context_line":"                      \u0027more than one fc map. Waiting.\u0027, name)"},{"line_number":2201,"context_line":"            for map_id in mapping_ids:"},{"line_number":2202,"context_line":"                attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"},{"line_number":2203,"context_line":"                if not attrs or \u0027yes\u0027 \u003d\u003d attrs[\u0027rc_controlled\u0027]:"},{"line_number":2204,"context_line":"                    if \u0027yes\u0027 \u003d\u003d attrs[\u0027rc_controlled\u0027]:"},{"line_number":2205,"context_line":"                        Rc_mapping_ids.append(map_id)"},{"line_number":2206,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"68f782ef_ed7ceb95","line":2203,"updated":"2021-01-21 10:59:37.000000000","message":"Scenario 1:\nIf attrs is {} or None, then 1st condition becomes true and 2nd condition after \"or\" will not be evaluated.\nAlso next line will throw KeyError or NoneType error; because attrs is {} or None.\n\nScenario 2:\nIf attrs has some keys; but key \u0027rc_controlled\u0027 is not present, KeyError will appear.\n\nScenario 3:\nIf attrs has key \u0027rc_controlled\u0027, code will work.","commit_id":"87ba6c932467c902c80db151bf00223ce2ff4b1f"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"9fa4c205f7ea3887fc1c7805d05368859245c6d0","unresolved":true,"context_lines":[{"line_number":2200,"context_line":"                      \u0027more than one fc map. Waiting.\u0027, name)"},{"line_number":2201,"context_line":"            for map_id in mapping_ids:"},{"line_number":2202,"context_line":"                attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"},{"line_number":2203,"context_line":"                if not attrs or \u0027yes\u0027 \u003d\u003d attrs[\u0027rc_controlled\u0027]:"},{"line_number":2204,"context_line":"                    if \u0027yes\u0027 \u003d\u003d attrs[\u0027rc_controlled\u0027]:"},{"line_number":2205,"context_line":"                        Rc_mapping_ids.append(map_id)"},{"line_number":2206,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"6b0cd2d4_bf03ed94","line":2203,"in_reply_to":"68f782ef_ed7ceb95","updated":"2021-02-05 03:44:13.000000000","message":"Scenario 1: We will fix the key Error at line number 2204, if the attrs is None. \nScenario 2: if attrs is not None, then attrs will always have the \u0027rc_controlled\u0027 key. Since we are running the storage command and getting the attrs from storage.","commit_id":"87ba6c932467c902c80db151bf00223ce2ff4b1f"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"9da6f8061bd84f96421c45dec89f5066b59001ed","unresolved":false,"context_lines":[{"line_number":2200,"context_line":"                      \u0027more than one fc map. Waiting.\u0027, name)"},{"line_number":2201,"context_line":"            for map_id in mapping_ids:"},{"line_number":2202,"context_line":"                attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"},{"line_number":2203,"context_line":"                if not attrs or \u0027yes\u0027 \u003d\u003d attrs[\u0027rc_controlled\u0027]:"},{"line_number":2204,"context_line":"                    if \u0027yes\u0027 \u003d\u003d attrs[\u0027rc_controlled\u0027]:"},{"line_number":2205,"context_line":"                        Rc_mapping_ids.append(map_id)"},{"line_number":2206,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"a758f3cf_f9aa80c5","line":2203,"in_reply_to":"6b0cd2d4_bf03ed94","updated":"2021-02-06 07:49:33.000000000","message":"Addressed the review comments.","commit_id":"87ba6c932467c902c80db151bf00223ce2ff4b1f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6a0a51b4a3eded4fdc59302c66d6ac76f0579b24","unresolved":true,"context_lines":[{"line_number":2200,"context_line":"                      \u0027more than one fc map. Waiting.\u0027, name)"},{"line_number":2201,"context_line":"            for map_id in mapping_ids:"},{"line_number":2202,"context_line":"                attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"},{"line_number":2203,"context_line":"                if not attrs or \u0027yes\u0027 \u003d\u003d attrs.get(\u0027rc_controlled\u0027, None):"},{"line_number":2204,"context_line":"                    if attrs and \u0027yes\u0027 \u003d\u003d attrs.get(\u0027rc_controlled\u0027, None):"},{"line_number":2205,"context_line":"                        Rc_mapping_ids.append(map_id)"},{"line_number":2206,"context_line":"                    continue"},{"line_number":2207,"context_line":"                source \u003d attrs[\u0027source_vdisk_name\u0027]"},{"line_number":2208,"context_line":"                target \u003d attrs[\u0027target_vdisk_name\u0027]"},{"line_number":2209,"context_line":"                copy_rate \u003d attrs[\u0027copy_rate\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"f38d300d_60900ffe","line":2206,"range":{"start_line":2203,"start_character":0,"end_line":2206,"end_character":28},"updated":"2021-03-16 21:53:50.000000000","message":"I think this would be more clear as:\n\n    if not attrs:\n        continue\n    if \u0027yes\u0027 \u003d\u003d attrs.get(\u0027rc_controlled\u0027):\n        Rc_mapping_ids.append(map_id)\n        continue","commit_id":"43a753a3f8b706f0d7ea59315cf35d7d779014d3"}]}