)]}'
{"cinder/volume/flows/manager/create_volume.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fd4f6c03cbacea80a9cb0930bf467d7a0282e841","unresolved":true,"context_lines":[{"line_number":631,"context_line":"            model_update \u003d self.driver.create_cloned_volume(volume, srcvol_ref)"},{"line_number":632,"context_line":"            if model_update is None:"},{"line_number":633,"context_line":"                model_update \u003d {}"},{"line_number":634,"context_line":"            if volume.encryption_key_id:"},{"line_number":635,"context_line":"                try:"},{"line_number":636,"context_line":"                    volume.update(model_update)"},{"line_number":637,"context_line":"                    volume.save()"}],"source_content_type":"text/x-python","patch_set":1,"id":"77dde745_523e814c","line":634,"range":{"start_line":634,"start_character":39,"end_line":634,"end_character":40},"updated":"2021-03-18 14:22:32.000000000","message":"Why change this from \"is not None\"?","commit_id":"f8ae16a63579b745da02c76c286ede4794b0e83b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a525fdfd9b97d8ace1195ddc6e348ef72ddc5054","unresolved":true,"context_lines":[{"line_number":634,"context_line":"            if volume.encryption_key_id is not None:"},{"line_number":635,"context_line":"                try:"},{"line_number":636,"context_line":"                    volume.update(model_update)"},{"line_number":637,"context_line":"                    volume.save()"},{"line_number":638,"context_line":"                except exception.CinderException:"},{"line_number":639,"context_line":"                    LOG.exception(\"Failed updating volume %(volume_id)s with \""},{"line_number":640,"context_line":"                                  \"%(updates)s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"12ca1b13_557b80a6","line":637,"range":{"start_line":637,"start_character":20,"end_line":637,"end_character":33},"updated":"2021-03-24 13:33:48.000000000","message":"Do we really need to call save() here?  The object has been updated before being passed to _rekey_volume() and then to self.driver._attach_volume()","commit_id":"3c2b5318422414942f4d06fd3ce21eb904077008"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"cd39988336d67ef1986362d5cc8f46d5a21b9f01","unresolved":true,"context_lines":[{"line_number":634,"context_line":"            if volume.encryption_key_id is not None:"},{"line_number":635,"context_line":"                try:"},{"line_number":636,"context_line":"                    volume.update(model_update)"},{"line_number":637,"context_line":"                    volume.save()"},{"line_number":638,"context_line":"                except exception.CinderException:"},{"line_number":639,"context_line":"                    LOG.exception(\"Failed updating volume %(volume_id)s with \""},{"line_number":640,"context_line":"                                  \"%(updates)s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"896c5eb9_775ecd86","line":637,"range":{"start_line":637,"start_character":20,"end_line":637,"end_character":33},"in_reply_to":"12ca1b13_557b80a6","updated":"2021-03-24 14:13:03.000000000","message":"Possibly not.  I will retest.","commit_id":"3c2b5318422414942f4d06fd3ce21eb904077008"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5d68a7fef308928633bce5c0e0c96901b0f69ad2","unresolved":true,"context_lines":[{"line_number":634,"context_line":"            if volume.encryption_key_id is not None:"},{"line_number":635,"context_line":"                try:"},{"line_number":636,"context_line":"                    volume.update(model_update)"},{"line_number":637,"context_line":"                except exception.CinderException:"},{"line_number":638,"context_line":"                    LOG.exception(\"Failed updating volume %(volume_id)s with \""},{"line_number":639,"context_line":"                                  \"%(updates)s\","},{"line_number":640,"context_line":"                                  {\u0027volume_id\u0027: volume.id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"52f2d143_e258c22d","line":637,"range":{"start_line":637,"start_character":0,"end_line":637,"end_character":49},"updated":"2021-03-25 14:28:15.000000000","message":"-1: the call to .update isn\u0027t actually updating the DB, the method is the update from the dict mixin, so what we are updating is the in-memory OVO, and it will be saved at some point when we call .save() on one of the parent callers, so there\u0027s no need to catch the exception.","commit_id":"19f745b9cb1911f2ebd59d08e31038f612892dca"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"76bd72ade3d3fa51f5bfb4cb3fb382644f73132a","unresolved":true,"context_lines":[{"line_number":634,"context_line":"            if volume.encryption_key_id is not None:"},{"line_number":635,"context_line":"                try:"},{"line_number":636,"context_line":"                    volume.update(model_update)"},{"line_number":637,"context_line":"                except exception.CinderException:"},{"line_number":638,"context_line":"                    LOG.exception(\"Failed updating volume %(volume_id)s with \""},{"line_number":639,"context_line":"                                  \"%(updates)s\","},{"line_number":640,"context_line":"                                  {\u0027volume_id\u0027: volume.id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"836816f0_3e9351dc","line":637,"range":{"start_line":637,"start_character":0,"end_line":637,"end_character":49},"in_reply_to":"52f2d143_e258c22d","updated":"2021-03-25 14:50:40.000000000","message":"Sure.  I\u0027ll update it now","commit_id":"19f745b9cb1911f2ebd59d08e31038f612892dca"}]}