)]}'
{"cinder/volume/drivers/toyou/acs5000/acs5000_common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"486d02da764e03f2715f5734821dcc5aef01a933","unresolved":true,"context_lines":[{"line_number":347,"context_line":"                       \u0027code_level\u0027: None,"},{"line_number":348,"context_line":"                       \u0027version\u0027: None}"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    @staticmethod"},{"line_number":351,"context_line":"    def get_driver_options():"},{"line_number":352,"context_line":"        additional_opts \u003d driver.BaseVD._get_oslo_driver_opts("},{"line_number":353,"context_line":"            \u0027san_ip\u0027, \u0027san_ssh_port\u0027, \u0027san_login\u0027, \u0027san_password\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"efd060e1_37882e76","line":350,"updated":"2021-02-22 14:08:55.000000000","message":"Static method needs to be on the concrete driver implementations. It does not get inherited.","commit_id":"11185189ba214c68294267fbcf38c4c4d1c2b69b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c6de0388864c8fb5046bf056574c4c90d8b002b1","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                       \u0027code_level\u0027: None,"},{"line_number":348,"context_line":"                       \u0027version\u0027: None}"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    @staticmethod"},{"line_number":351,"context_line":"    def get_driver_options():"},{"line_number":352,"context_line":"        additional_opts \u003d driver.BaseVD._get_oslo_driver_opts("},{"line_number":353,"context_line":"            \u0027san_ip\u0027, \u0027san_ssh_port\u0027, \u0027san_login\u0027, \u0027san_password\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3b472d2f_dafaf40b","line":350,"in_reply_to":"71be8cea_6bb5c33a","updated":"2021-02-23 02:35:22.000000000","message":"Sorry, I see now that you do have this method in the concrete implementation and use this to pull the data to return there.\n\nMy main concern was whether the driver options were being pulled into the expected output, but looking at the generated docs from the openstack-tox-docs job, everything does appear as expected:\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_946/773844/2/check/openstack-tox-docs/9469a6c/docs/drivers.html#acs5000iscsidriver\n\nSorry about the confusion.","commit_id":"11185189ba214c68294267fbcf38c4c4d1c2b69b"},{"author":{"_account_id":32833,"name":"yangheng","email":"yangheng@toyou.com.cn","username":"yangheng"},"change_message_id":"fc63ff22e34f484b5d878609a61744bba8edc978","unresolved":true,"context_lines":[{"line_number":347,"context_line":"                       \u0027code_level\u0027: None,"},{"line_number":348,"context_line":"                       \u0027version\u0027: None}"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    @staticmethod"},{"line_number":351,"context_line":"    def get_driver_options():"},{"line_number":352,"context_line":"        additional_opts \u003d driver.BaseVD._get_oslo_driver_opts("},{"line_number":353,"context_line":"            \u0027san_ip\u0027, \u0027san_ssh_port\u0027, \u0027san_login\u0027, \u0027san_password\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"71be8cea_6bb5c33a","line":350,"in_reply_to":"efd060e1_37882e76","updated":"2021-02-23 02:21:41.000000000","message":"Sorry, there\u0027s a problem with Get_driver_options.\n\nGet_driver_options method is proposed by Brian at https://review.opendev.org/c/openstack/cinder/+/767290.Then, Brian suggested that we can refer to https://review.opendev.org/c/openstack/cinder/+/770807 to solve this problem.\n\nPlease help us to confirm how to correct this problem. We will also communicate with Brian again to solve this problem.","commit_id":"11185189ba214c68294267fbcf38c4c4d1c2b69b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"486d02da764e03f2715f5734821dcc5aef01a933","unresolved":true,"context_lines":[{"line_number":366,"context_line":"        if len(ports) \u003e 0:"},{"line_number":367,"context_line":"            self._state[\u0027enabled_protocols\u0027].add(\u0027iSCSI\u0027)"},{"line_number":368,"context_line":"            for node in self._state[\u0027storage_nodes\u0027].values():"},{"line_number":369,"context_line":"                if node[\u0027id\u0027] in ports.keys():"},{"line_number":370,"context_line":"                    node[\u0027enabled_protocols\u0027].append(\u0027iSCSI\u0027)"},{"line_number":371,"context_line":"                    for port in ports[node[\u0027id\u0027]]:"},{"line_number":372,"context_line":"                        node[\u0027ipv4\u0027].append(port[\u0027ip\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1b8332ab_450c3144","line":369,"range":{"start_line":369,"start_character":38,"end_line":369,"end_character":45},"updated":"2021-02-22 14:08:55.000000000","message":"keys() is not needed here.","commit_id":"11185189ba214c68294267fbcf38c4c4d1c2b69b"},{"author":{"_account_id":32833,"name":"yangheng","email":"yangheng@toyou.com.cn","username":"yangheng"},"change_message_id":"fc63ff22e34f484b5d878609a61744bba8edc978","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        if len(ports) \u003e 0:"},{"line_number":367,"context_line":"            self._state[\u0027enabled_protocols\u0027].add(\u0027iSCSI\u0027)"},{"line_number":368,"context_line":"            for node in self._state[\u0027storage_nodes\u0027].values():"},{"line_number":369,"context_line":"                if node[\u0027id\u0027] in ports.keys():"},{"line_number":370,"context_line":"                    node[\u0027enabled_protocols\u0027].append(\u0027iSCSI\u0027)"},{"line_number":371,"context_line":"                    for port in ports[node[\u0027id\u0027]]:"},{"line_number":372,"context_line":"                        node[\u0027ipv4\u0027].append(port[\u0027ip\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"4041f5f3_564f089f","line":369,"range":{"start_line":369,"start_character":38,"end_line":369,"end_character":45},"in_reply_to":"1b8332ab_450c3144","updated":"2021-02-23 02:21:41.000000000","message":"Thank you for your review. I will fix it in the next patch.","commit_id":"11185189ba214c68294267fbcf38c4c4d1c2b69b"}]}