)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"82c4006ecd1b10f54334acaafb0e7a34f0367ff3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c5574503_5119c4cb","updated":"2021-11-20 14:53:02.000000000","message":"Sorry this has been sitting so long.  LGTM, but I\u0027d like a second opinion about Pavlo\u0027s point that we can get by with lower permissions on the intermediary directories since cinder backup always knows the full path.  (It looks to me like Ivan and Pavlo were in a race condition while reviewing, so I\u0027m not sure that Ivan saw Pavlo\u0027s comment.)","commit_id":"22d4d690bd4ed2ea91d4de6d1273ff3aaae215d2"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"c9eaee1c8bba1f737f14525e865b0d6727b0fc5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"86b8e507_86352016","updated":"2023-11-03 18:11:33.000000000","message":"recheck","commit_id":"22d4d690bd4ed2ea91d4de6d1273ff3aaae215d2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"62b4aef1e81d97a39866892693a4be6e217b04ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a78adbfa_1db34de5","updated":"2021-11-02 16:00:23.000000000","message":"recheck","commit_id":"22d4d690bd4ed2ea91d4de6d1273ff3aaae215d2"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"9ca52a28749c022281ecd6cd10344ea93956e626","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"341adf10_058cb1e4","in_reply_to":"64f0237c_5bbb0478","updated":"2023-10-12 14:33:58.000000000","message":"It\u0027s been 2 years. Anyone wants to land this patch?","commit_id":"22d4d690bd4ed2ea91d4de6d1273ff3aaae215d2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7aabf6f5b8fdfc3ae65011b5346785215b8e1bd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"64f0237c_5bbb0478","in_reply_to":"c5574503_5119c4cb","updated":"2021-11-22 13:08:18.000000000","message":"@Brian: thanks. Let\u0027s wait for Ivan to double check","commit_id":"22d4d690bd4ed2ea91d4de6d1273ff3aaae215d2"}],"cinder/backup/drivers/nfs.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6ce55af2e5ce516bb17e164efca187e9b3353542","unresolved":true,"context_lines":[{"line_number":110,"context_line":"                          run_as_root\u003dTrue)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # If some of the rights are missing then make sure that they are added"},{"line_number":113,"context_line":"        if not ((current_mode \u0026 stat.S_IRGRP) and"},{"line_number":114,"context_line":"                (current_mode \u0026 stat.S_IWGRP) and"},{"line_number":115,"context_line":"                (current_mode \u0026 stat.S_IXGRP)):"},{"line_number":116,"context_line":"            # Capital X mode adds directory access but only adds execution"}],"source_content_type":"text/x-python","patch_set":1,"id":"8c51c1b1_46fd40ca","line":113,"range":{"start_line":113,"start_character":17,"end_line":113,"end_character":44},"updated":"2021-02-04 14:54:39.000000000","message":"btw, when using the pre-defined paths as cinder does and not making listings of a folder, wx folder access seems to be sufficient","commit_id":"a0528ef8cb7fe806ed7061f8191c4a071eb3a61f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c37be1aa06172b1573335b37d101850d271a5125","unresolved":true,"context_lines":[{"line_number":110,"context_line":"                          run_as_root\u003dTrue)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # If some of the rights are missing then make sure that they are added"},{"line_number":113,"context_line":"        if not ((current_mode \u0026 stat.S_IRGRP) and"},{"line_number":114,"context_line":"                (current_mode \u0026 stat.S_IWGRP) and"},{"line_number":115,"context_line":"                (current_mode \u0026 stat.S_IXGRP)):"},{"line_number":116,"context_line":"            # Capital X mode adds directory access but only adds execution"}],"source_content_type":"text/x-python","patch_set":1,"id":"dbed0009_d554f1e6","line":113,"range":{"start_line":113,"start_character":17,"end_line":113,"end_character":44},"in_reply_to":"8c51c1b1_46fd40ca","updated":"2021-02-08 09:28:11.000000000","message":"I assume the restore process needs to read what the backup process wrote. So I assume we need the g+r too","commit_id":"a0528ef8cb7fe806ed7061f8191c4a071eb3a61f"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"a15ec38c1af2094781a4389ba1ee6f49167db4fd","unresolved":true,"context_lines":[{"line_number":110,"context_line":"                          run_as_root\u003dTrue)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # If some of the rights are missing then make sure that they are added"},{"line_number":113,"context_line":"        if not ((current_mode \u0026 stat.S_IRGRP) and"},{"line_number":114,"context_line":"                (current_mode \u0026 stat.S_IWGRP) and"},{"line_number":115,"context_line":"                (current_mode \u0026 stat.S_IXGRP)):"},{"line_number":116,"context_line":"            # Capital X mode adds directory access but only adds execution"}],"source_content_type":"text/x-python","patch_set":1,"id":"078005b7_1f94fde1","line":113,"range":{"start_line":113,"start_character":17,"end_line":113,"end_character":44},"in_reply_to":"dbed0009_d554f1e6","updated":"2021-02-08 16:14:55.000000000","message":"when you know the path and do not have to do e.g \u0027ls\u0027 in CLI or \u0027glob\u0027 in Python, you can actually read from a file by that full path when the file has the \u0027r\u0027 but all the folders in it\u0027s path have only \u0027x\u0027.\n\n   $ sudo ls -lR\n   .:\n   total 4\n   drwx-wxr-x 2 root ubuntu 4096 Feb  8 11:16 foo\n\n   ./foo:\n   total 0\n   $ echo test \u003e foo/bar\n   $ sudo ls -lR\n   .:\n   total 4\n   drwx-wxr-x 2 root ubuntu 4096 Feb  8 11:18 foo\n\n   ./foo:\n   total 4\n   -rw-rw-r-- 1 ubuntu ubuntu 5 Feb  8 11:18 bar\n   $ cat foo/bar\n   test","commit_id":"a0528ef8cb7fe806ed7061f8191c4a071eb3a61f"}]}