)]}'
{"cinder/tests/unit/volume/drivers/ibm/test_ds8k_proxy.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d14b3268ce5c253f9ceb0d323cc5a9c716784955","unresolved":true,"context_lines":[{"line_number":4516,"context_line":""},{"line_number":4517,"context_line":"    @mock.patch.object(eventlet, \u0027sleep\u0027)"},{"line_number":4518,"context_line":"    @mock.patch.object(helper.DS8KCommonHelper, \u0027get_flashcopy\u0027)"},{"line_number":4519,"context_line":"    def test_revert_to_snapshot_nor_vol(self, mock_get_flashcopy,"},{"line_number":4520,"context_line":"                                        mock_sleep):"},{"line_number":4521,"context_line":"        self.driver \u003d FakeDS8KProxy(self.storage_info, self.logger,"},{"line_number":4522,"context_line":"                                    self.exception, self)"}],"source_content_type":"text/x-python","patch_set":2,"id":"34f7d756_ee972dd7","line":4519,"range":{"start_line":4519,"start_character":32,"end_line":4519,"end_character":35},"updated":"2021-02-08 12:43:33.000000000","message":"nit: In case another patchset is submitted ...\ncan this be renamed as test_revert_to_snapshot_normal_vol.\n\nUsing \"normal\" instead of \"nor\" will make it easier to read.","commit_id":"fc70886446fc7d13c9f4fb9d70e9ab82fe0854d1"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"a754d3696d4cabf19023a13c78b05861617176e1","unresolved":false,"context_lines":[{"line_number":4516,"context_line":""},{"line_number":4517,"context_line":"    @mock.patch.object(eventlet, \u0027sleep\u0027)"},{"line_number":4518,"context_line":"    @mock.patch.object(helper.DS8KCommonHelper, \u0027get_flashcopy\u0027)"},{"line_number":4519,"context_line":"    def test_revert_to_snapshot_nor_vol(self, mock_get_flashcopy,"},{"line_number":4520,"context_line":"                                        mock_sleep):"},{"line_number":4521,"context_line":"        self.driver \u003d FakeDS8KProxy(self.storage_info, self.logger,"},{"line_number":4522,"context_line":"                                    self.exception, self)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f03699d5_09ca0a4c","line":4519,"range":{"start_line":4519,"start_character":32,"end_line":4519,"end_character":35},"in_reply_to":"34f7d756_ee972dd7","updated":"2021-02-10 13:58:50.000000000","message":"Addressed nit comments.","commit_id":"fc70886446fc7d13c9f4fb9d70e9ab82fe0854d1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"91979d8e6e20b144728c20025b817c7ed255e480","unresolved":true,"context_lines":[{"line_number":4522,"context_line":"                                    self.exception, self)"},{"line_number":4523,"context_line":"        self.driver.setup(self.ctxt)"},{"line_number":4524,"context_line":""},{"line_number":4525,"context_line":"        vol_type \u003d volume_types.create(self.ctxt, \u0027VOL_TYPE\u0027, {})"},{"line_number":4526,"context_line":"        location \u003d six.text_type({\u0027vol_hex_id\u0027: \u00270002\u0027})"},{"line_number":4527,"context_line":"        volume \u003d self._create_volume(volume_type_id\u003dvol_type.id,"},{"line_number":4528,"context_line":"                                     provider_location\u003dlocation)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f92bed22_1c710178","line":4525,"range":{"start_line":4525,"start_character":8,"end_line":4525,"end_character":65},"updated":"2021-03-03 08:54:42.000000000","message":"we should not make call to the actual volume type create method in tests, please use fake_volume_type_obj method in cinder.tests.unit.fake_volume instead\nOR\ntestutils.create_volume_type","commit_id":"89fb842c633ecb8b517fc99cd39f6429fa48e3ed"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"f54c9abd84647d7841c8b660e4667983ee5ffbac","unresolved":false,"context_lines":[{"line_number":4522,"context_line":"                                    self.exception, self)"},{"line_number":4523,"context_line":"        self.driver.setup(self.ctxt)"},{"line_number":4524,"context_line":""},{"line_number":4525,"context_line":"        vol_type \u003d volume_types.create(self.ctxt, \u0027VOL_TYPE\u0027, {})"},{"line_number":4526,"context_line":"        location \u003d six.text_type({\u0027vol_hex_id\u0027: \u00270002\u0027})"},{"line_number":4527,"context_line":"        volume \u003d self._create_volume(volume_type_id\u003dvol_type.id,"},{"line_number":4528,"context_line":"                                     provider_location\u003dlocation)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fdcd3bca_cb0265d4","line":4525,"range":{"start_line":4525,"start_character":8,"end_line":4525,"end_character":65},"in_reply_to":"f92bed22_1c710178","updated":"2021-03-04 15:20:47.000000000","message":"Done","commit_id":"89fb842c633ecb8b517fc99cd39f6429fa48e3ed"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"91979d8e6e20b144728c20025b817c7ed255e480","unresolved":true,"context_lines":[{"line_number":4543,"context_line":"        self.driver.setup(self.ctxt)"},{"line_number":4544,"context_line":""},{"line_number":4545,"context_line":"        extra_spec \u003d {\u0027replication_enabled\u0027: \u0027\u003cis\u003e True\u0027}"},{"line_number":4546,"context_line":"        vol_type \u003d volume_types.create(self.ctxt, \u0027VOL_TYPE\u0027, extra_spec)"},{"line_number":4547,"context_line":"        location \u003d six.text_type({\u0027vol_hex_id\u0027: \u00270002\u0027})"},{"line_number":4548,"context_line":"        volume \u003d self._create_volume(volume_type_id\u003dvol_type.id,"},{"line_number":4549,"context_line":"                                     provider_location\u003dlocation)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfb0a0c9_efa71da0","line":4546,"range":{"start_line":4546,"start_character":8,"end_line":4546,"end_character":73},"updated":"2021-03-03 08:54:42.000000000","message":"same","commit_id":"89fb842c633ecb8b517fc99cd39f6429fa48e3ed"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"f54c9abd84647d7841c8b660e4667983ee5ffbac","unresolved":false,"context_lines":[{"line_number":4543,"context_line":"        self.driver.setup(self.ctxt)"},{"line_number":4544,"context_line":""},{"line_number":4545,"context_line":"        extra_spec \u003d {\u0027replication_enabled\u0027: \u0027\u003cis\u003e True\u0027}"},{"line_number":4546,"context_line":"        vol_type \u003d volume_types.create(self.ctxt, \u0027VOL_TYPE\u0027, extra_spec)"},{"line_number":4547,"context_line":"        location \u003d six.text_type({\u0027vol_hex_id\u0027: \u00270002\u0027})"},{"line_number":4548,"context_line":"        volume \u003d self._create_volume(volume_type_id\u003dvol_type.id,"},{"line_number":4549,"context_line":"                                     provider_location\u003dlocation)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7d4f5d2e_a47a1207","line":4546,"range":{"start_line":4546,"start_character":8,"end_line":4546,"end_character":73},"in_reply_to":"dfb0a0c9_efa71da0","updated":"2021-03-04 15:20:47.000000000","message":"Done","commit_id":"89fb842c633ecb8b517fc99cd39f6429fa48e3ed"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"91979d8e6e20b144728c20025b817c7ed255e480","unresolved":true,"context_lines":[{"line_number":4563,"context_line":"                                    self.exception, self)"},{"line_number":4564,"context_line":"        self.driver.setup(self.ctxt)"},{"line_number":4565,"context_line":""},{"line_number":4566,"context_line":"        vol_type \u003d volume_types.create(self.ctxt, \u0027VOL_TYPE\u0027, {})"},{"line_number":4567,"context_line":"        location \u003d six.text_type({\u0027vol_hex_id\u0027: \u0027fake_volume_id_2\u0027})"},{"line_number":4568,"context_line":"        volume \u003d self._create_volume(volume_type_id\u003dvol_type.id,"},{"line_number":4569,"context_line":"                                     provider_location\u003dlocation)"}],"source_content_type":"text/x-python","patch_set":3,"id":"66faa5e2_18972463","line":4566,"range":{"start_line":4566,"start_character":8,"end_line":4566,"end_character":65},"updated":"2021-03-03 08:54:42.000000000","message":"same","commit_id":"89fb842c633ecb8b517fc99cd39f6429fa48e3ed"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"f54c9abd84647d7841c8b660e4667983ee5ffbac","unresolved":false,"context_lines":[{"line_number":4563,"context_line":"                                    self.exception, self)"},{"line_number":4564,"context_line":"        self.driver.setup(self.ctxt)"},{"line_number":4565,"context_line":""},{"line_number":4566,"context_line":"        vol_type \u003d volume_types.create(self.ctxt, \u0027VOL_TYPE\u0027, {})"},{"line_number":4567,"context_line":"        location \u003d six.text_type({\u0027vol_hex_id\u0027: \u0027fake_volume_id_2\u0027})"},{"line_number":4568,"context_line":"        volume \u003d self._create_volume(volume_type_id\u003dvol_type.id,"},{"line_number":4569,"context_line":"                                     provider_location\u003dlocation)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0765bd1e_cc7970d7","line":4566,"range":{"start_line":4566,"start_character":8,"end_line":4566,"end_character":65},"in_reply_to":"66faa5e2_18972463","updated":"2021-03-04 15:20:47.000000000","message":"Done","commit_id":"89fb842c633ecb8b517fc99cd39f6429fa48e3ed"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"91979d8e6e20b144728c20025b817c7ed255e480","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6b68a25a_c7ad603b","line":4577,"updated":"2021-03-03 08:54:42.000000000","message":"we can also add a test when volume size and snapshot size are not same","commit_id":"89fb842c633ecb8b517fc99cd39f6429fa48e3ed"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"f54c9abd84647d7841c8b660e4667983ee5ffbac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b29beb13_80439cde","line":4577,"in_reply_to":"6b68a25a_c7ad603b","updated":"2021-03-04 15:20:47.000000000","message":"Done","commit_id":"89fb842c633ecb8b517fc99cd39f6429fa48e3ed"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"62ff16408a8a7cd0381c77ff5d7e8013fb9c3d81","unresolved":true,"context_lines":[{"line_number":4536,"context_line":"    @mock.patch.object(helper.DS8KCommonHelper, \u0027get_flashcopy\u0027)"},{"line_number":4537,"context_line":"    def test_revert_to_snapshot_replication_vol(self, mock_get_flashcopy,"},{"line_number":4538,"context_line":"                                                mock_sleep):"},{"line_number":4539,"context_line":"        \"\"\"test a successful creation of snapshot.\"\"\""},{"line_number":4540,"context_line":"        self.configuration.replication_device \u003d [TEST_REPLICATION_DEVICE]"},{"line_number":4541,"context_line":"        self.driver \u003d FakeDS8KProxy(self.storage_info, self.logger,"},{"line_number":4542,"context_line":"                                    self.exception, self)"}],"source_content_type":"text/x-python","patch_set":5,"id":"6536cef7_9d4a2306","line":4539,"range":{"start_line":4539,"start_character":11,"end_line":4539,"end_character":50},"updated":"2021-03-12 23:35:38.000000000","message":"This is kind of misleading about what\u0027s being tested in this function.","commit_id":"17a25eafc8fb09a5783838f450861316c46b66d5"}],"cinder/volume/drivers/ibm/ibm_storage/ds8k_proxy.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"91979d8e6e20b144728c20025b817c7ed255e480","unresolved":true,"context_lines":[{"line_number":1069,"context_line":"                reason\u003d_(\u0027Reverting volume is not supported if the volume \u0027"},{"line_number":1070,"context_line":"                         \u0027size is not equal to the snapshot size.\u0027))"},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"        Vol_lun \u003d Lun(volume)"},{"line_number":1073,"context_line":"        Snap_lun \u003d Lun(snapshot, is_snapshot\u003dTrue)"},{"line_number":1074,"context_line":"        if Vol_lun.type_replication:"},{"line_number":1075,"context_line":"            raise exception.VolumeDriverException("}],"source_content_type":"text/x-python","patch_set":3,"id":"3256f714_b0a49c1c","line":1072,"range":{"start_line":1072,"start_character":8,"end_line":1072,"end_character":15},"updated":"2021-03-03 08:54:42.000000000","message":"It\u0027s recommended to start a variable name with lowercase letter (camel case)","commit_id":"89fb842c633ecb8b517fc99cd39f6429fa48e3ed"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"f54c9abd84647d7841c8b660e4667983ee5ffbac","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"                reason\u003d_(\u0027Reverting volume is not supported if the volume \u0027"},{"line_number":1070,"context_line":"                         \u0027size is not equal to the snapshot size.\u0027))"},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"        Vol_lun \u003d Lun(volume)"},{"line_number":1073,"context_line":"        Snap_lun \u003d Lun(snapshot, is_snapshot\u003dTrue)"},{"line_number":1074,"context_line":"        if Vol_lun.type_replication:"},{"line_number":1075,"context_line":"            raise exception.VolumeDriverException("}],"source_content_type":"text/x-python","patch_set":3,"id":"26d66960_53686775","line":1072,"range":{"start_line":1072,"start_character":8,"end_line":1072,"end_character":15},"in_reply_to":"3256f714_b0a49c1c","updated":"2021-03-04 15:20:47.000000000","message":"Done","commit_id":"89fb842c633ecb8b517fc99cd39f6429fa48e3ed"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"91979d8e6e20b144728c20025b817c7ed255e480","unresolved":true,"context_lines":[{"line_number":1070,"context_line":"                         \u0027size is not equal to the snapshot size.\u0027))"},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"        Vol_lun \u003d Lun(volume)"},{"line_number":1073,"context_line":"        Snap_lun \u003d Lun(snapshot, is_snapshot\u003dTrue)"},{"line_number":1074,"context_line":"        if Vol_lun.type_replication:"},{"line_number":1075,"context_line":"            raise exception.VolumeDriverException("},{"line_number":1076,"context_line":"                message\u003d_(\u0027Driver does not support migrate replicated \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3640e05a_d13c3bcd","line":1073,"range":{"start_line":1073,"start_character":8,"end_line":1073,"end_character":16},"updated":"2021-03-03 08:54:42.000000000","message":"same","commit_id":"89fb842c633ecb8b517fc99cd39f6429fa48e3ed"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"f54c9abd84647d7841c8b660e4667983ee5ffbac","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"                         \u0027size is not equal to the snapshot size.\u0027))"},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"        Vol_lun \u003d Lun(volume)"},{"line_number":1073,"context_line":"        Snap_lun \u003d Lun(snapshot, is_snapshot\u003dTrue)"},{"line_number":1074,"context_line":"        if Vol_lun.type_replication:"},{"line_number":1075,"context_line":"            raise exception.VolumeDriverException("},{"line_number":1076,"context_line":"                message\u003d_(\u0027Driver does not support migrate replicated \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5b159896_08106f0b","line":1073,"range":{"start_line":1073,"start_character":8,"end_line":1073,"end_character":16},"in_reply_to":"3640e05a_d13c3bcd","updated":"2021-03-04 15:20:47.000000000","message":"Done","commit_id":"89fb842c633ecb8b517fc99cd39f6429fa48e3ed"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"ee8e8ad140904b3a324ccc872afce828dd67c64c","unresolved":true,"context_lines":[{"line_number":1073,"context_line":"        snap_lun \u003d Lun(snapshot, is_snapshot\u003dTrue)"},{"line_number":1074,"context_line":"        if vol_lun.type_replication:"},{"line_number":1075,"context_line":"            raise exception.VolumeDriverException("},{"line_number":1076,"context_line":"                message\u003d_(\u0027Driver does not support migrate replicated \u0027"},{"line_number":1077,"context_line":"                          \u0027volume, it can be done via retype.\u0027))"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"        try:"},{"line_number":1080,"context_line":"            self._clone_lun(snap_lun, vol_lun)"}],"source_content_type":"text/x-python","patch_set":4,"id":"8a016304_c0d9c484","line":1077,"range":{"start_line":1076,"start_character":16,"end_line":1077,"end_character":64},"updated":"2021-03-05 22:39:20.000000000","message":"Is the message correct? Seems it\u0027s not related to this function.","commit_id":"9236e79328031b4a05e5586e9eb775d120fc1a01"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"fe84a6d72663bace9a1b305d750c16b273ccaf87","unresolved":true,"context_lines":[{"line_number":1073,"context_line":"        snap_lun \u003d Lun(snapshot, is_snapshot\u003dTrue)"},{"line_number":1074,"context_line":"        if vol_lun.type_replication:"},{"line_number":1075,"context_line":"            raise exception.VolumeDriverException("},{"line_number":1076,"context_line":"                message\u003d_(\u0027Driver does not support migrate replicated \u0027"},{"line_number":1077,"context_line":"                          \u0027volume, it can be done via retype.\u0027))"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"        try:"},{"line_number":1080,"context_line":"            self._clone_lun(snap_lun, vol_lun)"}],"source_content_type":"text/x-python","patch_set":4,"id":"d9dd8ac6_5c9bea0c","line":1077,"range":{"start_line":1076,"start_character":16,"end_line":1077,"end_character":64},"in_reply_to":"8a016304_c0d9c484","updated":"2021-03-06 03:37:14.000000000","message":"Thanks Ivan, \ncorrected the message.","commit_id":"9236e79328031b4a05e5586e9eb775d120fc1a01"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"8773348a137fa3f8191f727de016514ee3c4eb2d","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"        snap_lun \u003d Lun(snapshot, is_snapshot\u003dTrue)"},{"line_number":1074,"context_line":"        if vol_lun.type_replication:"},{"line_number":1075,"context_line":"            raise exception.VolumeDriverException("},{"line_number":1076,"context_line":"                message\u003d_(\u0027Driver does not support migrate replicated \u0027"},{"line_number":1077,"context_line":"                          \u0027volume, it can be done via retype.\u0027))"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"        try:"},{"line_number":1080,"context_line":"            self._clone_lun(snap_lun, vol_lun)"}],"source_content_type":"text/x-python","patch_set":4,"id":"6ec153cb_6635caa0","line":1077,"range":{"start_line":1076,"start_character":16,"end_line":1077,"end_character":64},"in_reply_to":"d9dd8ac6_5c9bea0c","updated":"2021-03-06 06:44:45.000000000","message":"Done","commit_id":"9236e79328031b4a05e5586e9eb775d120fc1a01"}]}