)]}'
{"cinder/tests/unit/volume/drivers/test_rbd.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"30762f2d85af37ae526718391bf0b6ea41c14783","unresolved":true,"context_lines":[{"line_number":908,"context_line":"        volume_get_by_id.return_value \u003d self.volume_a"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        self.mock_proxy().__enter__().volume.op_features.return_value \u003d 0"},{"line_number":911,"context_line":"        self.mock_rbd.RBD_OPERATION_FEATURE_CLONE_PARENT \u003d 0"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"        snapshot \u003d mock.Mock()"},{"line_number":914,"context_line":"        self.cfg.rbd_flatten_volume_from_snapshot \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"5216fc27_6effbb29","line":911,"updated":"2021-02-05 23:05:38.000000000","message":"It doesn\u0027t look correct to set RBD_...CLONE_PARENT to 1 above and to 0 here.  It\u0027s a flag that should have a constant value.  This needs more examination.\n\n(Context: I ran into weird failures in these unit tests while working on something else, but this looks suspicious.)","commit_id":"362ba29c598baf492511626dd21bf35b5dec3fa3"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"54c76424c7eb979dcbbf4ecbff651e4bb165df55","unresolved":false,"context_lines":[{"line_number":908,"context_line":"        volume_get_by_id.return_value \u003d self.volume_a"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        self.mock_proxy().__enter__().volume.op_features.return_value \u003d 0"},{"line_number":911,"context_line":"        self.mock_rbd.RBD_OPERATION_FEATURE_CLONE_PARENT \u003d 0"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"        snapshot \u003d mock.Mock()"},{"line_number":914,"context_line":"        self.cfg.rbd_flatten_volume_from_snapshot \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"b98eefd4_dd053ec7","line":911,"in_reply_to":"5216fc27_6effbb29","updated":"2021-02-08 15:35:41.000000000","message":"I thought that self.mock_rbd.RBD_OPERATION_FEATURE_CLONE_PARENT \u003d 0 could happen eventually, that\u0027s why I set it on the unit test, but now that you mentioned it, I agree that the flag should be a constant value...\n\nI proposed a fix on master [1] and I\u0027d backported it with this when merged.\n[1] https://review.opendev.org/c/openstack/cinder/+/774496","commit_id":"362ba29c598baf492511626dd21bf35b5dec3fa3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2cb8966b308eeaaf542767204b2a30ddc3640abc","unresolved":true,"context_lines":[{"line_number":919,"context_line":"            self.driver.create_volume_from_snapshot(self.volume_a, snapshot)"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"            mock_log.warning.assert_called_once_with(mock.ANY)"},{"line_number":922,"context_line":"            mock_log.info.assert_not_called()"},{"line_number":923,"context_line":"            self.assertTrue(self.driver._clone_v2_api_checked)"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"    @common_mocks"}],"source_content_type":"text/x-python","patch_set":2,"id":"8da219bc_a16882b6","line":922,"range":{"start_line":922,"start_character":12,"end_line":922,"end_character":45},"updated":"2021-02-09 10:23:41.000000000","message":"This caused a gate failure due to the looping call to _trash_purge which logs info msg[1]\nI think it\u0027s not safe to assume that an info/warning message will not be logged while a gate run of all tests.\n\n[1] https://9646a7fb82b47fbe6288-a22e2178400a1d74c0dfc0d0570ba9cf.ssl.cf2.rackcdn.com/773694/2/gate/openstack-tox-py38/e305e07/testr_results.html","commit_id":"bd281097f1df9c86580d79ae01f9e4fd4e545c0b"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"f571efd1f1b7d0354f4655c68d6bdb276f06f80b","unresolved":true,"context_lines":[{"line_number":919,"context_line":"            self.driver.create_volume_from_snapshot(self.volume_a, snapshot)"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"            mock_log.warning.assert_called_once_with(mock.ANY)"},{"line_number":922,"context_line":"            mock_log.info.assert_not_called()"},{"line_number":923,"context_line":"            self.assertTrue(self.driver._clone_v2_api_checked)"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"    @common_mocks"}],"source_content_type":"text/x-python","patch_set":2,"id":"7d0cc8bd_7bb01674","line":922,"range":{"start_line":922,"start_character":12,"end_line":922,"end_character":45},"in_reply_to":"8da219bc_a16882b6","updated":"2021-02-09 14:51:34.000000000","message":"I haven\u0027t thought about it and am not sure why this didn\u0027t happen in master so I may have fixed it early. I\u0027ve addressed Eric\u0027s comments on [1] and I just updated it with your comments too. Let me know your thoughts, I\u0027ll backport it with this simultaneously.\n\n[1] https://review.opendev.org/c/openstack/cinder/+/774496\n\nJust in case the output disappear I\u0027m gonna copy paste it here:\n\n```\nTraceback (most recent call last):\n  File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/tests/unit/volume/drivers/test_rbd.py\", line 118, in _common_inner_inner1\n    return _common_inner_inner2()\n  File \"/usr/lib/python3.8/unittest/mock.py\", line 1325, in patched\n    return func(*newargs, **newkeywargs)\n  File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/tests/unit/volume/drivers/test_rbd.py\", line 116, in _common_inner_inner2\n    return f(inst, *args, **kwargs)\n  File \"/usr/lib/python3.8/unittest/mock.py\", line 1325, in patched\n    return func(*newargs, **newkeywargs)\n  File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/tests/unit/volume/drivers/test_rbd.py\", line 922, in test_log_create_vol_from_snap_without_v2_clone_api\n    mock_log.info.assert_not_called()\n  File \"/usr/lib/python3.8/unittest/mock.py\", line 874, in assert_not_called\n    raise AssertionError(msg)\nAssertionError: Expected \u0027info\u0027 to not have been called. Called 1 times.\nCalls: [call(\"Purging trash for backend \u0027%s\u0027\", \u0027RBDDriver\u0027)].\n```","commit_id":"bd281097f1df9c86580d79ae01f9e4fd4e545c0b"}]}