)]}'
{"cinder/image/image_utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"41971312054fcb1e9556ce8bd7d1c92f51515b57","unresolved":true,"context_lines":[{"line_number":182,"context_line":"                               src_format: Optional[str] \u003d None,"},{"line_number":183,"context_line":"                               out_subformat: Optional[str] \u003d None,"},{"line_number":184,"context_line":"                               cache_mode: Optional[str] \u003d None,"},{"line_number":185,"context_line":"                               prefix\u003dNone,"},{"line_number":186,"context_line":"                               cipher_spec: Optional[dict] \u003d None,"},{"line_number":187,"context_line":"                               passphrase_file: Optional[str] \u003d None,"},{"line_number":188,"context_line":"                               src_passphrase_file\u003dNone) -\u003e List[str]:"}],"source_content_type":"text/x-python","patch_set":12,"id":"8d7e48fb_3832ce92","line":185,"range":{"start_line":185,"start_character":31,"end_line":185,"end_character":37},"updated":"2021-05-07 12:50:11.000000000","message":"Too bad we can\u0027t put a type on this thing, but it looks like it could be a list, a tuple, a string, ...","commit_id":"5e25c9845a62dde6f6a909cee1237cd68bf52e39"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"41971312054fcb1e9556ce8bd7d1c92f51515b57","unresolved":true,"context_lines":[{"line_number":215,"context_line":"                          cache_mode: str \u003d None, prefix\u003dNone,"},{"line_number":216,"context_line":"                          cipher_spec: dict \u003d None,"},{"line_number":217,"context_line":"                          passphrase_file: str \u003d None, compress\u003dFalse,"},{"line_number":218,"context_line":"                          src_passphrase_file\u003dNone) -\u003e List[str]:"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    if src_passphrase_file is not None:"},{"line_number":221,"context_line":"        if passphrase_file is None:"}],"source_content_type":"text/x-python","patch_set":12,"id":"a7caada3_9f445647","line":218,"updated":"2021-05-07 12:50:11.000000000","message":"FWIW, I prefer the parameter style you used at lines 179-188, I think it\u0027s much easier to read.  The type annotations + default values really clutter up the parameter list IMO.","commit_id":"5e25c9845a62dde6f6a909cee1237cd68bf52e39"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"212cf10bde72169015e5e72d722b796bae7bf85c","unresolved":true,"context_lines":[{"line_number":215,"context_line":"                          cache_mode: str \u003d None, prefix\u003dNone,"},{"line_number":216,"context_line":"                          cipher_spec: dict \u003d None,"},{"line_number":217,"context_line":"                          passphrase_file: str \u003d None, compress\u003dFalse,"},{"line_number":218,"context_line":"                          src_passphrase_file\u003dNone) -\u003e List[str]:"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    if src_passphrase_file is not None:"},{"line_number":221,"context_line":"        if passphrase_file is None:"}],"source_content_type":"text/x-python","patch_set":12,"id":"c0ce571b_0846fb35","line":218,"in_reply_to":"a7caada3_9f445647","updated":"2021-05-10 13:46:00.000000000","message":"I agree, will clean this up a bit.","commit_id":"5e25c9845a62dde6f6a909cee1237cd68bf52e39"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"da2f2ae4c508130e5f8922d71bb208aefa7cfe70","unresolved":true,"context_lines":[{"line_number":1059,"context_line":""},{"line_number":1060,"context_line":"    @staticmethod"},{"line_number":1061,"context_line":"    def for_image_service("},{"line_number":1062,"context_line":"            image_service: glance.GlanceImageService) -\u003e \u0027TemporaryImages\u0027:"},{"line_number":1063,"context_line":"        instance \u003d image_service.temp_images"},{"line_number":1064,"context_line":"        if instance:"},{"line_number":1065,"context_line":"            return instance"}],"source_content_type":"text/x-python","patch_set":18,"id":"95964085_219877d2","line":1062,"range":{"start_line":1062,"start_character":57,"end_line":1062,"end_character":74},"updated":"2021-07-07 01:19:33.000000000","message":"nit: If you need to put up another PS, you can drop the quotes and simply use the class name here.  (It worked for me locally, anyway.)","commit_id":"334485dc5ffa54391ba8133678cd579009f3f24b"}]}