)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"580a8a355a4dea191056327c742bf955911431a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7a0b5384_ebe3cc79","updated":"2022-02-02 09:41:23.000000000","message":"LGTM. +1 only because I\u0027m not sure it\u0027s OK to merge it so late in a release cycle","commit_id":"efd476c74e476fd463a7db4bc63923239489edeb"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"434ab353f2d5b6eb3da4e3fac663c86c5dee2fa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"c8937685_9aa5f210","updated":"2022-02-22 18:44:12.000000000","message":"Thanks for working on this","commit_id":"efd476c74e476fd463a7db4bc63923239489edeb"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"43771c739470862da8e2864dbb0036c82c6fecf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"c30607ce_62a0f2e5","updated":"2022-02-01 18:05:43.000000000","message":"recheck","commit_id":"efd476c74e476fd463a7db4bc63923239489edeb"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"1327854cab787c44e0be4f27bc2743ee7f74ce3a","unresolved":true,"context_lines":[{"line_number":384,"context_line":"            self._replication_targets.append(replication_target)"},{"line_number":385,"context_line":"            self._target_names.append(name)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def _get_config_tuple(self, remote\u003dNone) -\u003e Tuple[str, str, str, str]:"},{"line_number":388,"context_line":"        if not remote:"},{"line_number":389,"context_line":"            remote \u003d self._active_config"},{"line_number":390,"context_line":"        return (remote.get(\u0027name\u0027), remote.get(\u0027conf\u0027), remote.get(\u0027user\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"63cc71e6_4460ee38","line":387,"updated":"2021-04-30 16:12:22.000000000","message":"Not sure about this one perhaps\nremote: Optional[dict] \u003d None","commit_id":"d6d6a06343e4bb6e73d360973ef2ad16c07b0df9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7aadde8d577f5e20b0c6d0f0de61ab30a790e221","unresolved":false,"context_lines":[{"line_number":384,"context_line":"            self._replication_targets.append(replication_target)"},{"line_number":385,"context_line":"            self._target_names.append(name)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def _get_config_tuple(self, remote\u003dNone) -\u003e Tuple[str, str, str, str]:"},{"line_number":388,"context_line":"        if not remote:"},{"line_number":389,"context_line":"            remote \u003d self._active_config"},{"line_number":390,"context_line":"        return (remote.get(\u0027name\u0027), remote.get(\u0027conf\u0027), remote.get(\u0027user\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"97938080_66c78c64","line":387,"in_reply_to":"63cc71e6_4460ee38","updated":"2021-10-13 14:55:51.000000000","message":"Done","commit_id":"d6d6a06343e4bb6e73d360973ef2ad16c07b0df9"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"1327854cab787c44e0be4f27bc2743ee7f74ce3a","unresolved":true,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def _connect_to_rados(self,"},{"line_number":484,"context_line":"                          pool: Optional[str] \u003d None,"},{"line_number":485,"context_line":"                          remote\u003dNone,"},{"line_number":486,"context_line":"                          timeout: Optional[int] \u003d None) -\u003e \\"},{"line_number":487,"context_line":"            Tuple[\u0027rados.Rados\u0027, \u0027rados.Ioctx\u0027]:"},{"line_number":488,"context_line":"        @utils.retry(exception.VolumeBackendAPIException,"}],"source_content_type":"text/x-python","patch_set":5,"id":"855237aa_58b8562e","line":485,"updated":"2021-04-30 16:12:22.000000000","message":"?\nremote: Optional[dict] \u003d None","commit_id":"d6d6a06343e4bb6e73d360973ef2ad16c07b0df9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7aadde8d577f5e20b0c6d0f0de61ab30a790e221","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def _connect_to_rados(self,"},{"line_number":484,"context_line":"                          pool: Optional[str] \u003d None,"},{"line_number":485,"context_line":"                          remote\u003dNone,"},{"line_number":486,"context_line":"                          timeout: Optional[int] \u003d None) -\u003e \\"},{"line_number":487,"context_line":"            Tuple[\u0027rados.Rados\u0027, \u0027rados.Ioctx\u0027]:"},{"line_number":488,"context_line":"        @utils.retry(exception.VolumeBackendAPIException,"}],"source_content_type":"text/x-python","patch_set":5,"id":"4e5846fd_c6c6e7aa","line":485,"in_reply_to":"855237aa_58b8562e","updated":"2021-10-13 14:55:51.000000000","message":"Done","commit_id":"d6d6a06343e4bb6e73d360973ef2ad16c07b0df9"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"1327854cab787c44e0be4f27bc2743ee7f74ce3a","unresolved":true,"context_lines":[{"line_number":489,"context_line":"                     self.configuration.rados_connection_interval,"},{"line_number":490,"context_line":"                     self.configuration.rados_connection_retries)"},{"line_number":491,"context_line":"        def _do_conn(pool: Optional[str],"},{"line_number":492,"context_line":"                     remote,"},{"line_number":493,"context_line":"                     timeout: Optional[int]) -\u003e Tuple[\u0027rados.Rados\u0027,"},{"line_number":494,"context_line":"                                                      \u0027rados.Ioctx\u0027]:"},{"line_number":495,"context_line":"            name, conf, user, secret_uuid \u003d self._get_config_tuple(remote)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df85668d_c0c7c150","line":492,"updated":"2021-04-30 16:12:22.000000000","message":"?\nremote: Optional[dict] \u003d None","commit_id":"d6d6a06343e4bb6e73d360973ef2ad16c07b0df9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7aadde8d577f5e20b0c6d0f0de61ab30a790e221","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                     self.configuration.rados_connection_interval,"},{"line_number":490,"context_line":"                     self.configuration.rados_connection_retries)"},{"line_number":491,"context_line":"        def _do_conn(pool: Optional[str],"},{"line_number":492,"context_line":"                     remote,"},{"line_number":493,"context_line":"                     timeout: Optional[int]) -\u003e Tuple[\u0027rados.Rados\u0027,"},{"line_number":494,"context_line":"                                                      \u0027rados.Ioctx\u0027]:"},{"line_number":495,"context_line":"            name, conf, user, secret_uuid \u003d self._get_config_tuple(remote)"}],"source_content_type":"text/x-python","patch_set":5,"id":"c35ef106_d0c04ff8","line":492,"in_reply_to":"df85668d_c0c7c150","updated":"2021-10-13 14:55:51.000000000","message":"Done","commit_id":"d6d6a06343e4bb6e73d360973ef2ad16c07b0df9"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"1327854cab787c44e0be4f27bc2743ee7f74ce3a","unresolved":true,"context_lines":[{"line_number":1197,"context_line":"                g_parent_snap \u003d typing.cast(str, g_parent_snap)"},{"line_number":1198,"context_line":"                self._delete_clone_parent_refs(client, g_parent, g_parent_snap)"},{"line_number":1199,"context_line":""},{"line_number":1200,"context_line":"    def delete_volume(self, volume: objects.Volume) -\u003e None:"},{"line_number":1201,"context_line":"        \"\"\"Deletes a logical volume.\"\"\""},{"line_number":1202,"context_line":"        # NOTE(dosaboy): this was broken by commit cbe1d5f. Ensure names are"},{"line_number":1203,"context_line":"        #                utf-8 otherwise librbd will barf."}],"source_content_type":"text/x-python","patch_set":5,"id":"954e88d4_9a29c87e","line":1200,"updated":"2021-04-30 16:12:22.000000000","message":"Should this be volume: Volume","commit_id":"d6d6a06343e4bb6e73d360973ef2ad16c07b0df9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7aadde8d577f5e20b0c6d0f0de61ab30a790e221","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"                g_parent_snap \u003d typing.cast(str, g_parent_snap)"},{"line_number":1198,"context_line":"                self._delete_clone_parent_refs(client, g_parent, g_parent_snap)"},{"line_number":1199,"context_line":""},{"line_number":1200,"context_line":"    def delete_volume(self, volume: objects.Volume) -\u003e None:"},{"line_number":1201,"context_line":"        \"\"\"Deletes a logical volume.\"\"\""},{"line_number":1202,"context_line":"        # NOTE(dosaboy): this was broken by commit cbe1d5f. Ensure names are"},{"line_number":1203,"context_line":"        #                utf-8 otherwise librbd will barf."}],"source_content_type":"text/x-python","patch_set":5,"id":"739b065d_d419e66e","line":1200,"in_reply_to":"954e88d4_9a29c87e","updated":"2021-10-13 14:55:51.000000000","message":"Done","commit_id":"d6d6a06343e4bb6e73d360973ef2ad16c07b0df9"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"1327854cab787c44e0be4f27bc2743ee7f74ce3a","unresolved":true,"context_lines":[{"line_number":1545,"context_line":"        pass"},{"line_number":1546,"context_line":""},{"line_number":1547,"context_line":"    def initialize_connection(self,"},{"line_number":1548,"context_line":"                              volume: \u0027objects.Volume\u0027,"},{"line_number":1549,"context_line":"                              connector: dict) -\u003e Dict[str, Any]:"},{"line_number":1550,"context_line":"        hosts, ports \u003d self._get_mon_addrs()"},{"line_number":1551,"context_line":"        name, conf, user, secret_uuid \u003d self._get_config_tuple()"}],"source_content_type":"text/x-python","patch_set":5,"id":"d8f7f4a4_673536a5","line":1548,"updated":"2021-04-30 16:12:22.000000000","message":"Does this not work here?\nvolume: Volume","commit_id":"d6d6a06343e4bb6e73d360973ef2ad16c07b0df9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7aadde8d577f5e20b0c6d0f0de61ab30a790e221","unresolved":false,"context_lines":[{"line_number":1545,"context_line":"        pass"},{"line_number":1546,"context_line":""},{"line_number":1547,"context_line":"    def initialize_connection(self,"},{"line_number":1548,"context_line":"                              volume: \u0027objects.Volume\u0027,"},{"line_number":1549,"context_line":"                              connector: dict) -\u003e Dict[str, Any]:"},{"line_number":1550,"context_line":"        hosts, ports \u003d self._get_mon_addrs()"},{"line_number":1551,"context_line":"        name, conf, user, secret_uuid \u003d self._get_config_tuple()"}],"source_content_type":"text/x-python","patch_set":5,"id":"259b3862_50aa30a6","line":1548,"in_reply_to":"d8f7f4a4_673536a5","updated":"2021-10-13 14:55:51.000000000","message":"Done","commit_id":"d6d6a06343e4bb6e73d360973ef2ad16c07b0df9"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"1327854cab787c44e0be4f27bc2743ee7f74ce3a","unresolved":true,"context_lines":[{"line_number":1637,"context_line":""},{"line_number":1638,"context_line":"    def clone_image(self,"},{"line_number":1639,"context_line":"                    context: context.RequestContext,"},{"line_number":1640,"context_line":"                    volume: \u0027objects.Volume\u0027,"},{"line_number":1641,"context_line":"                    image_location: Optional[list],"},{"line_number":1642,"context_line":"                    image_meta: dict,"},{"line_number":1643,"context_line":"                    image_service) -\u003e Tuple[dict, bool]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"8e5f8b1e_016c4aba","line":1640,"updated":"2021-04-30 16:12:22.000000000","message":"Does this not work here?\nvolume: Volume","commit_id":"d6d6a06343e4bb6e73d360973ef2ad16c07b0df9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"72982b84e561fa71207c99fc7569390e80252bb6","unresolved":false,"context_lines":[{"line_number":1637,"context_line":""},{"line_number":1638,"context_line":"    def clone_image(self,"},{"line_number":1639,"context_line":"                    context: context.RequestContext,"},{"line_number":1640,"context_line":"                    volume: \u0027objects.Volume\u0027,"},{"line_number":1641,"context_line":"                    image_location: Optional[list],"},{"line_number":1642,"context_line":"                    image_meta: dict,"},{"line_number":1643,"context_line":"                    image_service) -\u003e Tuple[dict, bool]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9840d98c_896ef4c5","line":1640,"in_reply_to":"8e5f8b1e_016c4aba","updated":"2022-01-27 16:00:27.000000000","message":"Done","commit_id":"d6d6a06343e4bb6e73d360973ef2ad16c07b0df9"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"2577e7043e3c1c83c7683d7b2242be6c5654e856","unresolved":true,"context_lines":[{"line_number":1246,"context_line":"                g_parent_snap \u003d typing.cast(str, g_parent_snap)"},{"line_number":1247,"context_line":"                self._delete_clone_parent_refs(client, g_parent, g_parent_snap)"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    def delete_volume(self, volume: objects.Volume) -\u003e None:"},{"line_number":1250,"context_line":"        \"\"\"Deletes a logical volume.\"\"\""},{"line_number":1251,"context_line":"        # NOTE(dosaboy): this was broken by commit cbe1d5f. Ensure names are"},{"line_number":1252,"context_line":"        #                utf-8 otherwise librbd will barf."}],"source_content_type":"text/x-python","patch_set":7,"id":"600a18a4_dc62a02b","line":1249,"updated":"2021-09-14 10:38:49.000000000","message":"Can this just be Volume instead of objects.Volume to be consistent with elsewhere in this file","commit_id":"4d4b3fe32221eadfe88a888511358e9b221b8410"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2fd73092c08cdfe132d2782e47114c71b36d3c0c","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"                g_parent_snap \u003d typing.cast(str, g_parent_snap)"},{"line_number":1247,"context_line":"                self._delete_clone_parent_refs(client, g_parent, g_parent_snap)"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    def delete_volume(self, volume: objects.Volume) -\u003e None:"},{"line_number":1250,"context_line":"        \"\"\"Deletes a logical volume.\"\"\""},{"line_number":1251,"context_line":"        # NOTE(dosaboy): this was broken by commit cbe1d5f. Ensure names are"},{"line_number":1252,"context_line":"        #                utf-8 otherwise librbd will barf."}],"source_content_type":"text/x-python","patch_set":7,"id":"c3f03a81_e79fec66","line":1249,"in_reply_to":"600a18a4_dc62a02b","updated":"2021-09-14 13:49:58.000000000","message":"Done","commit_id":"4d4b3fe32221eadfe88a888511358e9b221b8410"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"2577e7043e3c1c83c7683d7b2242be6c5654e856","unresolved":true,"context_lines":[{"line_number":1492,"context_line":"        return error_result"},{"line_number":1493,"context_line":""},{"line_number":1494,"context_line":"    def _demote_volumes(self,"},{"line_number":1495,"context_line":"                        volumes: List[objects.Volume],"},{"line_number":1496,"context_line":"                        until_failure: bool \u003d True) -\u003e List[bool]:"},{"line_number":1497,"context_line":"        \"\"\"Try to demote volumes on the current primary cluster.\"\"\""},{"line_number":1498,"context_line":"        result \u003d []"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0ffdf9_15a84dff","line":1495,"updated":"2021-09-14 10:38:49.000000000","message":"as above, I think Volume instead of objects.Volume","commit_id":"4d4b3fe32221eadfe88a888511358e9b221b8410"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2fd73092c08cdfe132d2782e47114c71b36d3c0c","unresolved":false,"context_lines":[{"line_number":1492,"context_line":"        return error_result"},{"line_number":1493,"context_line":""},{"line_number":1494,"context_line":"    def _demote_volumes(self,"},{"line_number":1495,"context_line":"                        volumes: List[objects.Volume],"},{"line_number":1496,"context_line":"                        until_failure: bool \u003d True) -\u003e List[bool]:"},{"line_number":1497,"context_line":"        \"\"\"Try to demote volumes on the current primary cluster.\"\"\""},{"line_number":1498,"context_line":"        result \u003d []"}],"source_content_type":"text/x-python","patch_set":7,"id":"6a77fb12_d81cd8fd","line":1495,"in_reply_to":"ff0ffdf9_15a84dff","updated":"2021-09-14 13:49:58.000000000","message":"Done","commit_id":"4d4b3fe32221eadfe88a888511358e9b221b8410"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"2577e7043e3c1c83c7683d7b2242be6c5654e856","unresolved":true,"context_lines":[{"line_number":1527,"context_line":"        return secondary_id, self._get_target_config(secondary_id)"},{"line_number":1528,"context_line":""},{"line_number":1529,"context_line":"    def failover(self,"},{"line_number":1530,"context_line":"                 context: context.RequestContext,"},{"line_number":1531,"context_line":"                 volumes: list,"},{"line_number":1532,"context_line":"                 secondary_id: Optional[str] \u003d None,"},{"line_number":1533,"context_line":"                 groups\u003dNone) -\u003e Tuple[str, list, list]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"0eb6025a_1761cfdc","line":1530,"updated":"2021-09-14 10:38:49.000000000","message":"Will just RequestContext instead of context.RequestContext suffice?","commit_id":"4d4b3fe32221eadfe88a888511358e9b221b8410"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2fd73092c08cdfe132d2782e47114c71b36d3c0c","unresolved":false,"context_lines":[{"line_number":1527,"context_line":"        return secondary_id, self._get_target_config(secondary_id)"},{"line_number":1528,"context_line":""},{"line_number":1529,"context_line":"    def failover(self,"},{"line_number":1530,"context_line":"                 context: context.RequestContext,"},{"line_number":1531,"context_line":"                 volumes: list,"},{"line_number":1532,"context_line":"                 secondary_id: Optional[str] \u003d None,"},{"line_number":1533,"context_line":"                 groups\u003dNone) -\u003e Tuple[str, list, list]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ad9358a6_d3ae15ba","line":1530,"in_reply_to":"0eb6025a_1761cfdc","updated":"2021-09-14 13:49:58.000000000","message":"Done","commit_id":"4d4b3fe32221eadfe88a888511358e9b221b8410"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"2577e7043e3c1c83c7683d7b2242be6c5654e856","unresolved":true,"context_lines":[{"line_number":1582,"context_line":"        return active_backend_id, volume_update_list, group_update_list"},{"line_number":1583,"context_line":""},{"line_number":1584,"context_line":"    def ensure_export(self,"},{"line_number":1585,"context_line":"                      context: context.RequestContext,"},{"line_number":1586,"context_line":"                      volume: objects.Volume):"},{"line_number":1587,"context_line":"        \"\"\"Synchronously recreates an export for a logical volume.\"\"\""},{"line_number":1588,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":7,"id":"1cd66cd1_e415b094","line":1585,"updated":"2021-09-14 10:38:49.000000000","message":"as above.","commit_id":"4d4b3fe32221eadfe88a888511358e9b221b8410"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2fd73092c08cdfe132d2782e47114c71b36d3c0c","unresolved":false,"context_lines":[{"line_number":1582,"context_line":"        return active_backend_id, volume_update_list, group_update_list"},{"line_number":1583,"context_line":""},{"line_number":1584,"context_line":"    def ensure_export(self,"},{"line_number":1585,"context_line":"                      context: context.RequestContext,"},{"line_number":1586,"context_line":"                      volume: objects.Volume):"},{"line_number":1587,"context_line":"        \"\"\"Synchronously recreates an export for a logical volume.\"\"\""},{"line_number":1588,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":7,"id":"89463117_9da03570","line":1585,"in_reply_to":"1cd66cd1_e415b094","updated":"2021-09-14 13:49:58.000000000","message":"Done","commit_id":"4d4b3fe32221eadfe88a888511358e9b221b8410"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"2577e7043e3c1c83c7683d7b2242be6c5654e856","unresolved":true,"context_lines":[{"line_number":1583,"context_line":""},{"line_number":1584,"context_line":"    def ensure_export(self,"},{"line_number":1585,"context_line":"                      context: context.RequestContext,"},{"line_number":1586,"context_line":"                      volume: objects.Volume):"},{"line_number":1587,"context_line":"        \"\"\"Synchronously recreates an export for a logical volume.\"\"\""},{"line_number":1588,"context_line":"        pass"},{"line_number":1589,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"a5d82fcd_12a7e1e2","line":1586,"updated":"2021-09-14 10:38:49.000000000","message":"same here.","commit_id":"4d4b3fe32221eadfe88a888511358e9b221b8410"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2fd73092c08cdfe132d2782e47114c71b36d3c0c","unresolved":false,"context_lines":[{"line_number":1583,"context_line":""},{"line_number":1584,"context_line":"    def ensure_export(self,"},{"line_number":1585,"context_line":"                      context: context.RequestContext,"},{"line_number":1586,"context_line":"                      volume: objects.Volume):"},{"line_number":1587,"context_line":"        \"\"\"Synchronously recreates an export for a logical volume.\"\"\""},{"line_number":1588,"context_line":"        pass"},{"line_number":1589,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"d1ecdbde_3a558324","line":1586,"in_reply_to":"a5d82fcd_12a7e1e2","updated":"2021-09-14 13:49:58.000000000","message":"Done","commit_id":"4d4b3fe32221eadfe88a888511358e9b221b8410"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a22a891c93d631fba58a2d6be7dff28a94fb6bc3","unresolved":true,"context_lines":[{"line_number":1121,"context_line":"        return new_size_bytes"},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"    def create_volume_from_snapshot(self,"},{"line_number":1124,"context_line":"                                    volume: Volume, snapshot: Any) -\u003e dict:"},{"line_number":1125,"context_line":"        \"\"\"Creates a volume from a snapshot.\"\"\""},{"line_number":1126,"context_line":"        volume_update \u003d self._clone(volume, self.configuration.rbd_pool,"},{"line_number":1127,"context_line":"                                    snapshot.volume_name, snapshot.name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"4a5e5819_2972337f","line":1124,"range":{"start_line":1124,"start_character":52,"end_line":1124,"end_character":65},"updated":"2021-11-02 15:04:19.000000000","message":"I think instead of Any, we should use Snapshot","commit_id":"0c5914932fb698c91570096dd363f8d1f44fd9c1"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d33ea01ecd4b0c9e5cdff6613e52ce2ba9b9eea8","unresolved":false,"context_lines":[{"line_number":1121,"context_line":"        return new_size_bytes"},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"    def create_volume_from_snapshot(self,"},{"line_number":1124,"context_line":"                                    volume: Volume, snapshot: Any) -\u003e dict:"},{"line_number":1125,"context_line":"        \"\"\"Creates a volume from a snapshot.\"\"\""},{"line_number":1126,"context_line":"        volume_update \u003d self._clone(volume, self.configuration.rbd_pool,"},{"line_number":1127,"context_line":"                                    snapshot.volume_name, snapshot.name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"87ec4e18_26b00fb8","line":1124,"range":{"start_line":1124,"start_character":52,"end_line":1124,"end_character":65},"in_reply_to":"4a5e5819_2972337f","updated":"2021-11-11 15:26:17.000000000","message":"Done","commit_id":"0c5914932fb698c91570096dd363f8d1f44fd9c1"}]}