)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32075,"name":"Amar","display_name":"Amar Rajeev Singuluri","email":"amar.rajeev.singuluri@ibm.com","username":"amar7ibm"},"change_message_id":"ad6da0117611d6180d0ebacd9c0a1d19a93601d3","unresolved":true,"context_lines":[{"line_number":9,"context_line":"[Spectrum Virtualize Family] Adding support to extend a volume"},{"line_number":10,"context_line":"which is created using hyperswap volume-type template"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"closes bug: #1915113"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I19bc034343bc106acb6a217bc5e53c7f60c58ef2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4e21249d_a57d3bfe","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"updated":"2021-04-05 17:41:18.000000000","message":"It should be in this format \"Closes-Bug\"","commit_id":"40d5f3b6ed4563fa1898b312655fba1d2842420c"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"8500669c6812933662609132fb0cd0adad024dda","unresolved":false,"context_lines":[{"line_number":9,"context_line":"[Spectrum Virtualize Family] Adding support to extend a volume"},{"line_number":10,"context_line":"which is created using hyperswap volume-type template"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"closes bug: #1915113"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I19bc034343bc106acb6a217bc5e53c7f60c58ef2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"41117981_16a00e97","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"in_reply_to":"4e21249d_a57d3bfe","updated":"2021-05-25 16:46:18.000000000","message":"Done","commit_id":"40d5f3b6ed4563fa1898b312655fba1d2842420c"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":32075,"name":"Amar","display_name":"Amar Rajeev Singuluri","email":"amar.rajeev.singuluri@ibm.com","username":"amar7ibm"},"change_message_id":"feb42c0188f4d9c8a6f2fe6c997f67f83e9e9708","unresolved":true,"context_lines":[{"line_number":3468,"context_line":"        extend_amt \u003d int(new_size) - old_size"},{"line_number":3469,"context_line":""},{"line_number":3470,"context_line":"        rel_info \u003d self._helpers.get_relationship_info(volume_name)"},{"line_number":3471,"context_line":"        if self.is_volume_hyperswap(volume):"},{"line_number":3472,"context_line":"            hs_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"},{"line_number":3473,"context_line":"                                             volume_metadata\u003d"},{"line_number":3474,"context_line":"                                             volume.get(\u0027volume_matadata\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"81822947_f86f0f67","line":3471,"updated":"2021-04-05 15:32:01.000000000","message":"Instead we can make use of rel_info i.e, condition with [copy_type]\n    if rel_info and rel_info[\u0027copy_type\u0027] \u003d\u003d \"activeactive\":\n        hs_opts \u003d ....","commit_id":"863f618c5dcc8c18a746d3ad307c68b6c9661393"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"8500669c6812933662609132fb0cd0adad024dda","unresolved":false,"context_lines":[{"line_number":3468,"context_line":"        extend_amt \u003d int(new_size) - old_size"},{"line_number":3469,"context_line":""},{"line_number":3470,"context_line":"        rel_info \u003d self._helpers.get_relationship_info(volume_name)"},{"line_number":3471,"context_line":"        if self.is_volume_hyperswap(volume):"},{"line_number":3472,"context_line":"            hs_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"},{"line_number":3473,"context_line":"                                             volume_metadata\u003d"},{"line_number":3474,"context_line":"                                             volume.get(\u0027volume_matadata\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"97f8195b_566076e7","line":3471,"in_reply_to":"81822947_f86f0f67","updated":"2021-05-25 16:46:18.000000000","message":"Current approach is with readability. Updated the code.","commit_id":"863f618c5dcc8c18a746d3ad307c68b6c9661393"},{"author":{"_account_id":32075,"name":"Amar","display_name":"Amar Rajeev Singuluri","email":"amar.rajeev.singuluri@ibm.com","username":"amar7ibm"},"change_message_id":"ad6da0117611d6180d0ebacd9c0a1d19a93601d3","unresolved":true,"context_lines":[{"line_number":3533,"context_line":"        extend_amt \u003d int(new_size) - old_size"},{"line_number":3534,"context_line":""},{"line_number":3535,"context_line":"        rel_info \u003d self._helpers.get_relationship_info(volume_name)"},{"line_number":3536,"context_line":"        if self.is_volume_hyperswap(volume):"},{"line_number":3537,"context_line":"            hs_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"},{"line_number":3538,"context_line":"                                             volume_metadata\u003d"},{"line_number":3539,"context_line":"                                             volume.get(\u0027volume_matadata\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"d0bb3b7c_efc016f5","line":3536,"updated":"2021-04-05 17:41:18.000000000","message":"It is good to have a warning message as below, as we are converting to normal volume followed by extend operation and then converting back to HyperSwap Volume.\n  LOG.warning(\u0027_extend_volume_op: Extending a volume with \u0027active-active\u0027 relationship is not    recommended\u0027)","commit_id":"40d5f3b6ed4563fa1898b312655fba1d2842420c"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"a300f3c82993b2a8adf579902576164b70962270","unresolved":true,"context_lines":[{"line_number":3533,"context_line":"        extend_amt \u003d int(new_size) - old_size"},{"line_number":3534,"context_line":""},{"line_number":3535,"context_line":"        rel_info \u003d self._helpers.get_relationship_info(volume_name)"},{"line_number":3536,"context_line":"        if self.is_volume_hyperswap(volume):"},{"line_number":3537,"context_line":"            hs_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"},{"line_number":3538,"context_line":"                                             volume_metadata\u003d"},{"line_number":3539,"context_line":"                                             volume.get(\u0027volume_matadata\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"4c4ebe9f_0a0e0c80","line":3536,"updated":"2021-04-08 09:33:47.000000000","message":"this should be before fetching the relationship info.\nor if we can detect hyperswap from the rel_info.\nit will be good to use rel_info to check hyperswap instead of making additional calls.","commit_id":"40d5f3b6ed4563fa1898b312655fba1d2842420c"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"8500669c6812933662609132fb0cd0adad024dda","unresolved":false,"context_lines":[{"line_number":3533,"context_line":"        extend_amt \u003d int(new_size) - old_size"},{"line_number":3534,"context_line":""},{"line_number":3535,"context_line":"        rel_info \u003d self._helpers.get_relationship_info(volume_name)"},{"line_number":3536,"context_line":"        if self.is_volume_hyperswap(volume):"},{"line_number":3537,"context_line":"            hs_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"},{"line_number":3538,"context_line":"                                             volume_metadata\u003d"},{"line_number":3539,"context_line":"                                             volume.get(\u0027volume_matadata\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"0e67be08_8fa26e54","line":3536,"in_reply_to":"4c4ebe9f_0a0e0c80","updated":"2021-05-25 16:46:18.000000000","message":"added a condition with rel_info","commit_id":"40d5f3b6ed4563fa1898b312655fba1d2842420c"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"8500669c6812933662609132fb0cd0adad024dda","unresolved":false,"context_lines":[{"line_number":3533,"context_line":"        extend_amt \u003d int(new_size) - old_size"},{"line_number":3534,"context_line":""},{"line_number":3535,"context_line":"        rel_info \u003d self._helpers.get_relationship_info(volume_name)"},{"line_number":3536,"context_line":"        if self.is_volume_hyperswap(volume):"},{"line_number":3537,"context_line":"            hs_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"},{"line_number":3538,"context_line":"                                             volume_metadata\u003d"},{"line_number":3539,"context_line":"                                             volume.get(\u0027volume_matadata\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"0b35d089_024e2d75","line":3536,"in_reply_to":"d0bb3b7c_efc016f5","updated":"2021-05-25 16:46:18.000000000","message":"Done","commit_id":"40d5f3b6ed4563fa1898b312655fba1d2842420c"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"a300f3c82993b2a8adf579902576164b70962270","unresolved":true,"context_lines":[{"line_number":3539,"context_line":"                                             volume.get(\u0027volume_matadata\u0027))"},{"line_number":3540,"context_line":""},{"line_number":3541,"context_line":"            self._helpers.convert_hyperswap_volume_to_normal("},{"line_number":3542,"context_line":"                volume_name, hs_opts[\u0027peer_pool\u0027])"},{"line_number":3543,"context_line":"            self._master_backend_helpers.extend_vdisk(volume_name, extend_amt)"},{"line_number":3544,"context_line":"            self._helpers.convert_volume_to_hyperswap(volume_name,"},{"line_number":3545,"context_line":"                                                      hs_opts,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e5da0150_232c2bef","line":3542,"updated":"2021-04-08 09:33:47.000000000","message":"if convert_hyperswap_to_normal has failed it should throw an exception the resize failed but we should not put the volume into error state, since resize is not started.","commit_id":"40d5f3b6ed4563fa1898b312655fba1d2842420c"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"8500669c6812933662609132fb0cd0adad024dda","unresolved":true,"context_lines":[{"line_number":3539,"context_line":"                                             volume.get(\u0027volume_matadata\u0027))"},{"line_number":3540,"context_line":""},{"line_number":3541,"context_line":"            self._helpers.convert_hyperswap_volume_to_normal("},{"line_number":3542,"context_line":"                volume_name, hs_opts[\u0027peer_pool\u0027])"},{"line_number":3543,"context_line":"            self._master_backend_helpers.extend_vdisk(volume_name, extend_amt)"},{"line_number":3544,"context_line":"            self._helpers.convert_volume_to_hyperswap(volume_name,"},{"line_number":3545,"context_line":"                                                      hs_opts,"}],"source_content_type":"text/x-python","patch_set":2,"id":"0175aadb_630eda0c","line":3542,"in_reply_to":"e5da0150_232c2bef","updated":"2021-05-25 16:46:18.000000000","message":"It is a bit complicated. As volume-manager updating the volume info in the DATABASE with new size, if it gets no ERROR message while executing volume-extend operation.\nFor this case, I have been tried by keeping the statement \u0027return\u0027 and other possible statements to skip the following instructions but if we skip all of them and return the function, that means a Successful volume-extend for volume-manager(cinder/volume/manager.py) and DATABASE will be updated with new extend-size.\n\nOr If we raise an exception, manager would update volume-status as \u0027error_extending\u0027.\n\nAs per my knowledge, there is no control for us to handle this case, as volume-manager is responsible to update DATABASE in this case. Please suggest me if I miss something.","commit_id":"40d5f3b6ed4563fa1898b312655fba1d2842420c"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"a300f3c82993b2a8adf579902576164b70962270","unresolved":true,"context_lines":[{"line_number":3540,"context_line":""},{"line_number":3541,"context_line":"            self._helpers.convert_hyperswap_volume_to_normal("},{"line_number":3542,"context_line":"                volume_name, hs_opts[\u0027peer_pool\u0027])"},{"line_number":3543,"context_line":"            self._master_backend_helpers.extend_vdisk(volume_name, extend_amt)"},{"line_number":3544,"context_line":"            self._helpers.convert_volume_to_hyperswap(volume_name,"},{"line_number":3545,"context_line":"                                                      hs_opts,"},{"line_number":3546,"context_line":"                                                      self._state)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a5c0eedb_f9920445","line":3543,"updated":"2021-04-08 09:33:47.000000000","message":"let\u0027s have these operation in try catch","commit_id":"40d5f3b6ed4563fa1898b312655fba1d2842420c"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"8500669c6812933662609132fb0cd0adad024dda","unresolved":false,"context_lines":[{"line_number":3540,"context_line":""},{"line_number":3541,"context_line":"            self._helpers.convert_hyperswap_volume_to_normal("},{"line_number":3542,"context_line":"                volume_name, hs_opts[\u0027peer_pool\u0027])"},{"line_number":3543,"context_line":"            self._master_backend_helpers.extend_vdisk(volume_name, extend_amt)"},{"line_number":3544,"context_line":"            self._helpers.convert_volume_to_hyperswap(volume_name,"},{"line_number":3545,"context_line":"                                                      hs_opts,"},{"line_number":3546,"context_line":"                                                      self._state)"}],"source_content_type":"text/x-python","patch_set":2,"id":"84176e64_9f375090","line":3543,"in_reply_to":"a5c0eedb_f9920445","updated":"2021-05-25 16:46:18.000000000","message":"Done","commit_id":"40d5f3b6ed4563fa1898b312655fba1d2842420c"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"a300f3c82993b2a8adf579902576164b70962270","unresolved":true,"context_lines":[{"line_number":3541,"context_line":"            self._helpers.convert_hyperswap_volume_to_normal("},{"line_number":3542,"context_line":"                volume_name, hs_opts[\u0027peer_pool\u0027])"},{"line_number":3543,"context_line":"            self._master_backend_helpers.extend_vdisk(volume_name, extend_amt)"},{"line_number":3544,"context_line":"            self._helpers.convert_volume_to_hyperswap(volume_name,"},{"line_number":3545,"context_line":"                                                      hs_opts,"},{"line_number":3546,"context_line":"                                                      self._state)"},{"line_number":3547,"context_line":"        elif rel_info:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bc43c505_746f2e67","line":3544,"updated":"2021-04-08 09:33:47.000000000","message":"if extend has failed then we need to re-convert the normal volume to hyperswap.","commit_id":"40d5f3b6ed4563fa1898b312655fba1d2842420c"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"8500669c6812933662609132fb0cd0adad024dda","unresolved":false,"context_lines":[{"line_number":3541,"context_line":"            self._helpers.convert_hyperswap_volume_to_normal("},{"line_number":3542,"context_line":"                volume_name, hs_opts[\u0027peer_pool\u0027])"},{"line_number":3543,"context_line":"            self._master_backend_helpers.extend_vdisk(volume_name, extend_amt)"},{"line_number":3544,"context_line":"            self._helpers.convert_volume_to_hyperswap(volume_name,"},{"line_number":3545,"context_line":"                                                      hs_opts,"},{"line_number":3546,"context_line":"                                                      self._state)"},{"line_number":3547,"context_line":"        elif rel_info:"}],"source_content_type":"text/x-python","patch_set":2,"id":"e646c882_a7f7953a","line":3544,"in_reply_to":"bc43c505_746f2e67","updated":"2021-05-25 16:46:18.000000000","message":"Done","commit_id":"40d5f3b6ed4563fa1898b312655fba1d2842420c"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"2df9843516bcee7781a689a125a66a7f9025613d","unresolved":true,"context_lines":[{"line_number":3539,"context_line":"                        \u0027not recommended.\u0027)"},{"line_number":3540,"context_line":"            rep_type \u003d rel_info[\u0027copy_type\u0027]"},{"line_number":3541,"context_line":"            cyclingmode \u003d rel_info[\u0027cycling_mode\u0027]"},{"line_number":3542,"context_line":"            self.master_helper \u003d self._master_backend_helpers"},{"line_number":3543,"context_line":"            self.target_helper \u003d self._aux_backend_helpers"},{"line_number":3544,"context_line":"            if rep_type \u003d\u003d \u0027activeactive\u0027:"},{"line_number":3545,"context_line":"                hs_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"aa33f7be_1ae070eb","line":3542,"range":{"start_line":3542,"start_character":12,"end_line":3542,"end_character":30},"updated":"2021-05-14 16:21:04.000000000","message":"master_helper variable is duplicated in StorwizeSVCCommonDriver class when there is already a _master_backend_helpers. Is it required to declare \"master_helper\" as a class member variable when master_helper variable is used only in this method.","commit_id":"1719f03ec3720384626d7f819b24692379cb5b00"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"9b6925b98a369b599ec3c5fcb7553347786844ee","unresolved":false,"context_lines":[{"line_number":3539,"context_line":"                        \u0027not recommended.\u0027)"},{"line_number":3540,"context_line":"            rep_type \u003d rel_info[\u0027copy_type\u0027]"},{"line_number":3541,"context_line":"            cyclingmode \u003d rel_info[\u0027cycling_mode\u0027]"},{"line_number":3542,"context_line":"            self.master_helper \u003d self._master_backend_helpers"},{"line_number":3543,"context_line":"            self.target_helper \u003d self._aux_backend_helpers"},{"line_number":3544,"context_line":"            if rep_type \u003d\u003d \u0027activeactive\u0027:"},{"line_number":3545,"context_line":"                hs_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"ce207b44_bd58ff91","line":3542,"range":{"start_line":3542,"start_character":12,"end_line":3542,"end_character":30},"in_reply_to":"8184f45e_2839acba","updated":"2021-05-25 16:49:31.000000000","message":"Done","commit_id":"1719f03ec3720384626d7f819b24692379cb5b00"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"fa1d9b5302b0d933a80ce5f0205656da3a1cac34","unresolved":false,"context_lines":[{"line_number":3539,"context_line":"                        \u0027not recommended.\u0027)"},{"line_number":3540,"context_line":"            rep_type \u003d rel_info[\u0027copy_type\u0027]"},{"line_number":3541,"context_line":"            cyclingmode \u003d rel_info[\u0027cycling_mode\u0027]"},{"line_number":3542,"context_line":"            self.master_helper \u003d self._master_backend_helpers"},{"line_number":3543,"context_line":"            self.target_helper \u003d self._aux_backend_helpers"},{"line_number":3544,"context_line":"            if rep_type \u003d\u003d \u0027activeactive\u0027:"},{"line_number":3545,"context_line":"                hs_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"8184f45e_2839acba","line":3542,"range":{"start_line":3542,"start_character":12,"end_line":3542,"end_character":30},"in_reply_to":"aa33f7be_1ae070eb","updated":"2021-05-14 16:23:59.000000000","message":"Same comment posted in PS5","commit_id":"1719f03ec3720384626d7f819b24692379cb5b00"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"2df9843516bcee7781a689a125a66a7f9025613d","unresolved":true,"context_lines":[{"line_number":1714,"context_line":"            self.check_hyperswap_pool(pool, opts[\u0027peer_pool\u0027])"},{"line_number":1715,"context_line":"            hyper_pool \u003d \u0027%s\u0027 % opts[\u0027peer_pool\u0027]"},{"line_number":1716,"context_line":"            is_dr_pool \u003d self.is_volume_type_dr_pools(pool, opts)"},{"line_number":1717,"context_line":"            if is_dr_pool and opts[\u0027rsize\u0027] !\u003d -1:"},{"line_number":1718,"context_line":"                self.check_data_reduction_pool_params(opts)"},{"line_number":1719,"context_line":"            params \u003d []"},{"line_number":1720,"context_line":"            if opts[\u0027rsize\u0027] !\u003d -1:"},{"line_number":1721,"context_line":"                params \u003d self._get_hyperswap_volume_create_params(opts,"},{"line_number":1722,"context_line":"                                                                  is_dr_pool)"},{"line_number":1723,"context_line":"            self.ssh.addvolumecopy(vol_name, hyper_pool, params)"},{"line_number":1724,"context_line":""},{"line_number":1725,"context_line":"    def convert_extended_volume_to_hyperswap(self, vol_name, opts, state):"}],"source_content_type":"text/x-python","patch_set":5,"id":"09dc5961_cb3c6496","line":1722,"range":{"start_line":1717,"start_character":12,"end_line":1722,"end_character":77},"updated":"2021-05-14 16:21:04.000000000","message":"Use the same logic/code as used in \"create_hyperswap_volume\" to get the HyperSwap volume create params, which will be easier to understand.","commit_id":"ef047f7ca8f3dcc57d53a3ada72ce9e4ac23ec74"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"9b6925b98a369b599ec3c5fcb7553347786844ee","unresolved":false,"context_lines":[{"line_number":1714,"context_line":"            self.check_hyperswap_pool(pool, opts[\u0027peer_pool\u0027])"},{"line_number":1715,"context_line":"            hyper_pool \u003d \u0027%s\u0027 % opts[\u0027peer_pool\u0027]"},{"line_number":1716,"context_line":"            is_dr_pool \u003d self.is_volume_type_dr_pools(pool, opts)"},{"line_number":1717,"context_line":"            if is_dr_pool and opts[\u0027rsize\u0027] !\u003d -1:"},{"line_number":1718,"context_line":"                self.check_data_reduction_pool_params(opts)"},{"line_number":1719,"context_line":"            params \u003d []"},{"line_number":1720,"context_line":"            if opts[\u0027rsize\u0027] !\u003d -1:"},{"line_number":1721,"context_line":"                params \u003d self._get_hyperswap_volume_create_params(opts,"},{"line_number":1722,"context_line":"                                                                  is_dr_pool)"},{"line_number":1723,"context_line":"            self.ssh.addvolumecopy(vol_name, hyper_pool, params)"},{"line_number":1724,"context_line":""},{"line_number":1725,"context_line":"    def convert_extended_volume_to_hyperswap(self, vol_name, opts, state):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1cc5bf5e_020ec40f","line":1722,"range":{"start_line":1717,"start_character":12,"end_line":1722,"end_character":77},"in_reply_to":"09dc5961_cb3c6496","updated":"2021-05-25 16:49:31.000000000","message":"Done","commit_id":"ef047f7ca8f3dcc57d53a3ada72ce9e4ac23ec74"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"2df9843516bcee7781a689a125a66a7f9025613d","unresolved":true,"context_lines":[{"line_number":1732,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":1733,"context_line":"        hyper_pool \u003d \u0027%s\u0027 % opts[\u0027peer_pool\u0027]"},{"line_number":1734,"context_line":"        is_dr_pool \u003d self.is_volume_type_dr_pools(attr[\u0027mdisk_grp_name\u0027], opts)"},{"line_number":1735,"context_line":"        if is_dr_pool and opts[\u0027rsize\u0027] !\u003d -1:"},{"line_number":1736,"context_line":"            self.check_data_reduction_pool_params(opts)"},{"line_number":1737,"context_line":"        params \u003d []"},{"line_number":1738,"context_line":"        if opts[\u0027rsize\u0027] !\u003d -1:"},{"line_number":1739,"context_line":"            params \u003d self._get_hyperswap_volume_create_params(opts, is_dr_pool)"},{"line_number":1740,"context_line":"        self.ssh.addvolumecopy(vol_name, hyper_pool, params)"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    def convert_hyperswap_volume_to_normal(self, vol_name, peer_pool):"}],"source_content_type":"text/x-python","patch_set":5,"id":"17ce6083_29100039","line":1739,"range":{"start_line":1735,"start_character":8,"end_line":1739,"end_character":79},"updated":"2021-05-14 16:21:04.000000000","message":"same as above comment.","commit_id":"ef047f7ca8f3dcc57d53a3ada72ce9e4ac23ec74"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"9b6925b98a369b599ec3c5fcb7553347786844ee","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":1733,"context_line":"        hyper_pool \u003d \u0027%s\u0027 % opts[\u0027peer_pool\u0027]"},{"line_number":1734,"context_line":"        is_dr_pool \u003d self.is_volume_type_dr_pools(attr[\u0027mdisk_grp_name\u0027], opts)"},{"line_number":1735,"context_line":"        if is_dr_pool and opts[\u0027rsize\u0027] !\u003d -1:"},{"line_number":1736,"context_line":"            self.check_data_reduction_pool_params(opts)"},{"line_number":1737,"context_line":"        params \u003d []"},{"line_number":1738,"context_line":"        if opts[\u0027rsize\u0027] !\u003d -1:"},{"line_number":1739,"context_line":"            params \u003d self._get_hyperswap_volume_create_params(opts, is_dr_pool)"},{"line_number":1740,"context_line":"        self.ssh.addvolumecopy(vol_name, hyper_pool, params)"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    def convert_hyperswap_volume_to_normal(self, vol_name, peer_pool):"}],"source_content_type":"text/x-python","patch_set":5,"id":"634591c9_082da7ac","line":1739,"range":{"start_line":1735,"start_character":8,"end_line":1739,"end_character":79},"in_reply_to":"17ce6083_29100039","updated":"2021-05-25 16:49:31.000000000","message":"Done","commit_id":"ef047f7ca8f3dcc57d53a3ada72ce9e4ac23ec74"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"2df9843516bcee7781a689a125a66a7f9025613d","unresolved":true,"context_lines":[{"line_number":3560,"context_line":"                        \u0027not recommended.\u0027)"},{"line_number":3561,"context_line":"            rep_type \u003d rel_info[\u0027copy_type\u0027]"},{"line_number":3562,"context_line":"            cyclingmode \u003d rel_info[\u0027cycling_mode\u0027]"},{"line_number":3563,"context_line":"            self.master_helper \u003d self._master_backend_helpers"},{"line_number":3564,"context_line":"            self.target_helper \u003d self._aux_backend_helpers"},{"line_number":3565,"context_line":"            if rep_type \u003d\u003d \u0027activeactive\u0027:"},{"line_number":3566,"context_line":"                hs_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"2abcdc45_fc6af6bf","line":3563,"range":{"start_line":3563,"start_character":12,"end_line":3563,"end_character":30},"updated":"2021-05-14 16:21:04.000000000","message":"master_helper variable is duplicated in StorwizeSVCCommonDriver class when there is already a _master_backend_helpers. Is it required to declare \"master_helper\" as a class member variable when master_helper variable is used only in this method.\n\nIt\u0027s better to use some local variables.","commit_id":"ef047f7ca8f3dcc57d53a3ada72ce9e4ac23ec74"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"9b6925b98a369b599ec3c5fcb7553347786844ee","unresolved":false,"context_lines":[{"line_number":3560,"context_line":"                        \u0027not recommended.\u0027)"},{"line_number":3561,"context_line":"            rep_type \u003d rel_info[\u0027copy_type\u0027]"},{"line_number":3562,"context_line":"            cyclingmode \u003d rel_info[\u0027cycling_mode\u0027]"},{"line_number":3563,"context_line":"            self.master_helper \u003d self._master_backend_helpers"},{"line_number":3564,"context_line":"            self.target_helper \u003d self._aux_backend_helpers"},{"line_number":3565,"context_line":"            if rep_type \u003d\u003d \u0027activeactive\u0027:"},{"line_number":3566,"context_line":"                hs_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"2a1fdf8d_ee7e0136","line":3563,"range":{"start_line":3563,"start_character":12,"end_line":3563,"end_character":30},"in_reply_to":"2abcdc45_fc6af6bf","updated":"2021-05-25 16:49:31.000000000","message":"Done","commit_id":"ef047f7ca8f3dcc57d53a3ada72ce9e4ac23ec74"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"9b6925b98a369b599ec3c5fcb7553347786844ee","unresolved":false,"context_lines":[{"line_number":3560,"context_line":"                        \u0027not recommended.\u0027)"},{"line_number":3561,"context_line":"            rep_type \u003d rel_info[\u0027copy_type\u0027]"},{"line_number":3562,"context_line":"            cyclingmode \u003d rel_info[\u0027cycling_mode\u0027]"},{"line_number":3563,"context_line":"            self.master_helper \u003d self._master_backend_helpers"},{"line_number":3564,"context_line":"            self.target_helper \u003d self._aux_backend_helpers"},{"line_number":3565,"context_line":"            if rep_type \u003d\u003d \u0027activeactive\u0027:"},{"line_number":3566,"context_line":"                hs_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"e8aa97ba_e277434b","line":3563,"range":{"start_line":3563,"start_character":12,"end_line":3563,"end_character":30},"in_reply_to":"2abcdc45_fc6af6bf","updated":"2021-05-25 16:49:31.000000000","message":"Done","commit_id":"ef047f7ca8f3dcc57d53a3ada72ce9e4ac23ec74"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"2df9843516bcee7781a689a125a66a7f9025613d","unresolved":true,"context_lines":[{"line_number":3584,"context_line":"                             \u0027volume %(volume)s. Exception: \u0027"},{"line_number":3585,"context_line":"                             \u0027%(err)s.\u0027) % {\u0027volume\u0027: volume.id, \u0027err\u0027: e})"},{"line_number":3586,"context_line":"                    LOG.error(msg)"},{"line_number":3587,"context_line":"                    self.master_helper.convert_extended_volume_to_hyperswap("},{"line_number":3588,"context_line":"                        volume_name, hs_opts, self._state)"},{"line_number":3589,"context_line":"                    raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":3590,"context_line":""},{"line_number":3591,"context_line":"                try:"},{"line_number":3592,"context_line":"                    self.master_helper.convert_extended_volume_to_hyperswap("},{"line_number":3593,"context_line":"                        volume_name, hs_opts, self._state)"},{"line_number":3594,"context_line":"                except Exception as e:"},{"line_number":3595,"context_line":"                    msg \u003d (_(\u0027_extend_volume_op: Failed to convert volume to \u0027"},{"line_number":3596,"context_line":"                             \u0027hyperswap volume %(volume)s. Exception: \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"2a11f573_d64c3b94","line":3593,"range":{"start_line":3587,"start_character":20,"end_line":3593,"end_character":58},"updated":"2021-05-14 16:21:04.000000000","message":"convert_extended_volume_to_hyperswap can be handled finally block of try catch exception, finally will call the \"convert_extended_volume_to_hyperswap\" if the try block raises an exception or not.","commit_id":"ef047f7ca8f3dcc57d53a3ada72ce9e4ac23ec74"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"9b6925b98a369b599ec3c5fcb7553347786844ee","unresolved":false,"context_lines":[{"line_number":3584,"context_line":"                             \u0027volume %(volume)s. Exception: \u0027"},{"line_number":3585,"context_line":"                             \u0027%(err)s.\u0027) % {\u0027volume\u0027: volume.id, \u0027err\u0027: e})"},{"line_number":3586,"context_line":"                    LOG.error(msg)"},{"line_number":3587,"context_line":"                    self.master_helper.convert_extended_volume_to_hyperswap("},{"line_number":3588,"context_line":"                        volume_name, hs_opts, self._state)"},{"line_number":3589,"context_line":"                    raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":3590,"context_line":""},{"line_number":3591,"context_line":"                try:"},{"line_number":3592,"context_line":"                    self.master_helper.convert_extended_volume_to_hyperswap("},{"line_number":3593,"context_line":"                        volume_name, hs_opts, self._state)"},{"line_number":3594,"context_line":"                except Exception as e:"},{"line_number":3595,"context_line":"                    msg \u003d (_(\u0027_extend_volume_op: Failed to convert volume to \u0027"},{"line_number":3596,"context_line":"                             \u0027hyperswap volume %(volume)s. Exception: \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"d2132414_71d4781b","line":3593,"range":{"start_line":3587,"start_character":20,"end_line":3593,"end_character":58},"in_reply_to":"2a11f573_d64c3b94","updated":"2021-05-25 16:49:31.000000000","message":"Done","commit_id":"ef047f7ca8f3dcc57d53a3ada72ce9e4ac23ec74"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"52606e905cbe0d7c6ab7f7cf7fd2016d5cc56c8e","unresolved":true,"context_lines":[{"line_number":3592,"context_line":"                            volume_name, hs_opts, self._state)"},{"line_number":3593,"context_line":"                    except Exception as e:"},{"line_number":3594,"context_line":"                        msg \u003d (_(\u0027_extend_volume_op: Failed to convert volume \u0027"},{"line_number":3595,"context_line":"                                 \u0027to hyperswap volume %(volume)s. Exception: \u0027"},{"line_number":3596,"context_line":"                                 \u0027%(err)s.\u0027) % {\u0027volume\u0027: volume.id, \u0027err\u0027: e})"},{"line_number":3597,"context_line":"                        LOG.error(msg)"},{"line_number":3598,"context_line":"                        raise exception.VolumeDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5e616028_379191d5","line":3595,"range":{"start_line":3595,"start_character":34,"end_line":3595,"end_character":36},"updated":"2021-08-07 14:04:33.000000000","message":"maybe \"back to\"?","commit_id":"e832ddb061402869fb46a833307c18596cf4db4c"}]}