)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"8da851ec9510470eda88eb758e7b6d40db78c62d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ports filtering support to Dell EMC XtremIO driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there are some iSCSI target ports (ESXi for example) that"},{"line_number":10,"context_line":"are not connected to the OpenStack host,"},{"line_number":11,"context_line":"Openstack iSCSI login command wait until iSCSI login timeout."},{"line_number":12,"context_line":"The XtremIO Cinder driver needs a new option to support ports"},{"line_number":13,"context_line":"filtering."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2a521118598de336148a56c1d5352107ece80721"},{"line_number":16,"context_line":"Closes-Bug: #1915800"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f3bd1547_121e6529","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":10},"updated":"2021-02-16 15:54:07.000000000","message":"The patch seems to handle both iSCSI and FC. Commit message should reflect it.","commit_id":"3147e7d9de901bb245721e8af9f2118e976f00b3"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"4ad8d92f1534469cb03fa7f0d177c36c51e30c37","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ports filtering support to Dell EMC XtremIO driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there are some iSCSI target ports (ESXi for example) that"},{"line_number":10,"context_line":"are not connected to the OpenStack host,"},{"line_number":11,"context_line":"Openstack iSCSI login command wait until iSCSI login timeout."},{"line_number":12,"context_line":"The XtremIO Cinder driver needs a new option to support ports"},{"line_number":13,"context_line":"filtering."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2a521118598de336148a56c1d5352107ece80721"},{"line_number":16,"context_line":"Closes-Bug: #1915800"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7268a953_80a665ce","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":10},"in_reply_to":"f3bd1547_121e6529","updated":"2021-02-16 16:14:08.000000000","message":"The original issue was with the iSCSI. However, I have added filtering for both \niSCSI and FC driver so that they have the same capabilities.\nI\u0027ve changed the commit message to reflect that both drivers are updated.","commit_id":"3147e7d9de901bb245721e8af9f2118e976f00b3"}],"cinder/volume/drivers/dell_emc/xtremio.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"8da851ec9510470eda88eb758e7b6d40db78c62d","unresolved":true,"context_lines":[{"line_number":84,"context_line":"                     \u0027without connected volumes); setting this parameter \u0027"},{"line_number":85,"context_line":"                     \u0027to True will remove any IG after terminating its \u0027"},{"line_number":86,"context_line":"                     \u0027connection to the last volume.\u0027),"},{"line_number":87,"context_line":"    cfg.ListOpt(\u0027xtremio_ports\u0027,"},{"line_number":88,"context_line":"                default\u003d[],"},{"line_number":89,"context_line":"                help\u003d\u0027Allowed ports. Comma separated list of XtremIO \u0027"},{"line_number":90,"context_line":"                     \u0027iSCSI IPs or FC WWNs (ex. 58:cc:f0:98:49:22:07:02) \u0027"},{"line_number":91,"context_line":"                     \u0027to be used. If option is not set all ports are allowed.\u0027)"},{"line_number":92,"context_line":"]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"CONF.register_opts(XTREMIO_OPTS, group\u003dconfiguration.SHARED_CONF_GROUP)"}],"source_content_type":"text/x-python","patch_set":1,"id":"84ddaba9_234a26b6","line":91,"range":{"start_line":87,"start_character":0,"end_line":91,"end_character":79},"updated":"2021-02-16 15:54:07.000000000","message":"This brings the question if we support mixed AND model for ISCSI and FC for a driver?\nDo not recall that was documented anywhere.","commit_id":"3147e7d9de901bb245721e8af9f2118e976f00b3"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"4ad8d92f1534469cb03fa7f0d177c36c51e30c37","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                     \u0027without connected volumes); setting this parameter \u0027"},{"line_number":85,"context_line":"                     \u0027to True will remove any IG after terminating its \u0027"},{"line_number":86,"context_line":"                     \u0027connection to the last volume.\u0027),"},{"line_number":87,"context_line":"    cfg.ListOpt(\u0027xtremio_ports\u0027,"},{"line_number":88,"context_line":"                default\u003d[],"},{"line_number":89,"context_line":"                help\u003d\u0027Allowed ports. Comma separated list of XtremIO \u0027"},{"line_number":90,"context_line":"                     \u0027iSCSI IPs or FC WWNs (ex. 58:cc:f0:98:49:22:07:02) \u0027"},{"line_number":91,"context_line":"                     \u0027to be used. If option is not set all ports are allowed.\u0027)"},{"line_number":92,"context_line":"]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"CONF.register_opts(XTREMIO_OPTS, group\u003dconfiguration.SHARED_CONF_GROUP)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0e3879f6_1f00490e","line":91,"range":{"start_line":87,"start_character":0,"end_line":91,"end_character":79},"in_reply_to":"84ddaba9_234a26b6","updated":"2021-02-16 16:14:08.000000000","message":"We don\u0027t. iSCSI and FC drivers can\u0027t be mixed in one storage backend\nas they are of different python classes.","commit_id":"3147e7d9de901bb245721e8af9f2118e976f00b3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f68fb3ffc09b5dee86d1b1057b0aa8afe252cbd7","unresolved":true,"context_lines":[{"line_number":1210,"context_line":"                       {\u0027ip\u0027: portal[\u0027ip-addr\u0027],"},{"line_number":1211,"context_line":"                        \u0027port\u0027: portal[\u0027ip-port\u0027]})"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"        tg_portals \u003d [\u0027%(ip)s:%(port)d\u0027 % {\u0027ip\u0027: p[\u0027ip-addr\u0027],"},{"line_number":1214,"context_line":"                                           \u0027port\u0027: p[\u0027ip-port\u0027]}"},{"line_number":1215,"context_line":"                      for p in allowed_portals]"},{"line_number":1216,"context_line":"        properties \u003d {\u0027target_discovered\u0027: False,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a27b5173_96c783a0","line":1213,"updated":"2021-02-25 16:09:30.000000000","message":"Appending the port with a colon may not work if the ip is an IPv6 address -- is that an issue for this driver?","commit_id":"e175d64cac735e8845165d0e8b48c4a8f2402ea1"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"aa1b0020cb24147ddc24934fb2cba1c602b13a49","unresolved":true,"context_lines":[{"line_number":1210,"context_line":"                       {\u0027ip\u0027: portal[\u0027ip-addr\u0027],"},{"line_number":1211,"context_line":"                        \u0027port\u0027: portal[\u0027ip-port\u0027]})"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"        tg_portals \u003d [\u0027%(ip)s:%(port)d\u0027 % {\u0027ip\u0027: p[\u0027ip-addr\u0027],"},{"line_number":1214,"context_line":"                                           \u0027port\u0027: p[\u0027ip-port\u0027]}"},{"line_number":1215,"context_line":"                      for p in allowed_portals]"},{"line_number":1216,"context_line":"        properties \u003d {\u0027target_discovered\u0027: False,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d4bfaf29_5b6b2086","line":1213,"in_reply_to":"79c03f47_11fb2f79","updated":"2021-03-01 21:03:29.000000000","message":"Understood. We\u0027ll test IPv6 setup and I\u0027ll return with results.","commit_id":"e175d64cac735e8845165d0e8b48c4a8f2402ea1"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"9a8de6544012de0a80cc94883ab6dfd688927e52","unresolved":false,"context_lines":[{"line_number":1210,"context_line":"                       {\u0027ip\u0027: portal[\u0027ip-addr\u0027],"},{"line_number":1211,"context_line":"                        \u0027port\u0027: portal[\u0027ip-port\u0027]})"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"        tg_portals \u003d [\u0027%(ip)s:%(port)d\u0027 % {\u0027ip\u0027: p[\u0027ip-addr\u0027],"},{"line_number":1214,"context_line":"                                           \u0027port\u0027: p[\u0027ip-port\u0027]}"},{"line_number":1215,"context_line":"                      for p in allowed_portals]"},{"line_number":1216,"context_line":"        properties \u003d {\u0027target_discovered\u0027: False,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e8636ad4_3898ce3c","line":1213,"in_reply_to":"a27b5173_96c783a0","updated":"2021-02-25 19:40:34.000000000","message":"This line is the same as in the original driver. \nSo everything is fine as there were no issues before.","commit_id":"e175d64cac735e8845165d0e8b48c4a8f2402ea1"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"1fca4992f438cedea1df6e882c3b007e9b273201","unresolved":true,"context_lines":[{"line_number":1210,"context_line":"                       {\u0027ip\u0027: portal[\u0027ip-addr\u0027],"},{"line_number":1211,"context_line":"                        \u0027port\u0027: portal[\u0027ip-port\u0027]})"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"        tg_portals \u003d [\u0027%(ip)s:%(port)d\u0027 % {\u0027ip\u0027: p[\u0027ip-addr\u0027],"},{"line_number":1214,"context_line":"                                           \u0027port\u0027: p[\u0027ip-port\u0027]}"},{"line_number":1215,"context_line":"                      for p in allowed_portals]"},{"line_number":1216,"context_line":"        properties \u003d {\u0027target_discovered\u0027: False,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e1d35d18_dffbcfce","line":1213,"in_reply_to":"d4bfaf29_5b6b2086","updated":"2021-03-01 22:02:04.000000000","message":"It looks likely to not work, but this was the case before this patch too, so we don\u0027t need to hold up this patch for it.","commit_id":"e175d64cac735e8845165d0e8b48c4a8f2402ea1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a15657c9e5bb2a24e072a4ca6ce4b6aba8ee1782","unresolved":true,"context_lines":[{"line_number":1210,"context_line":"                       {\u0027ip\u0027: portal[\u0027ip-addr\u0027],"},{"line_number":1211,"context_line":"                        \u0027port\u0027: portal[\u0027ip-port\u0027]})"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"        tg_portals \u003d [\u0027%(ip)s:%(port)d\u0027 % {\u0027ip\u0027: p[\u0027ip-addr\u0027],"},{"line_number":1214,"context_line":"                                           \u0027port\u0027: p[\u0027ip-port\u0027]}"},{"line_number":1215,"context_line":"                      for p in allowed_portals]"},{"line_number":1216,"context_line":"        properties \u003d {\u0027target_discovered\u0027: False,"}],"source_content_type":"text/x-python","patch_set":2,"id":"79c03f47_11fb2f79","line":1213,"in_reply_to":"e8636ad4_3898ce3c","updated":"2021-03-01 19:17:37.000000000","message":"I think what Eric is asking is does this work if we get an ipv6 address here\nIf the original driver is tested with ipv6 then this should work fine else we should verify this scenario","commit_id":"e175d64cac735e8845165d0e8b48c4a8f2402ea1"}],"doc/source/configuration/block-storage/drivers/dell-emc-xtremio-driver.rst":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"8da851ec9510470eda88eb758e7b6d40db78c62d","unresolved":true,"context_lines":[{"line_number":260,"context_line":"   volume_driver \u003d cinder.volume.drivers.dell_emc.xtremio.XtremIOFibreChannelDriver"},{"line_number":261,"context_line":"   san_ip \u003d XMS_IP"},{"line_number":262,"context_line":"   xtremio_cluster_name \u003d Cluster01"},{"line_number":263,"context_line":"   xtremio_ports \u003d 21:00:00:24:ff:57:b2:36,21:00:00:24:ff:57:b2:55"},{"line_number":264,"context_line":"   san_login \u003d XMS_USER"},{"line_number":265,"context_line":"   san_password \u003d XMS_PASSWD"},{"line_number":266,"context_line":"   volume_backend_name \u003d XtremIOAFA"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bd63dae4_170d7df0","line":263,"range":{"start_line":263,"start_character":0,"end_line":263,"end_character":66},"updated":"2021-02-16 15:54:07.000000000","message":"should we have 2 examples, one for FC and one for iSCSI?","commit_id":"3147e7d9de901bb245721e8af9f2118e976f00b3"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"4ad8d92f1534469cb03fa7f0d177c36c51e30c37","unresolved":false,"context_lines":[{"line_number":260,"context_line":"   volume_driver \u003d cinder.volume.drivers.dell_emc.xtremio.XtremIOFibreChannelDriver"},{"line_number":261,"context_line":"   san_ip \u003d XMS_IP"},{"line_number":262,"context_line":"   xtremio_cluster_name \u003d Cluster01"},{"line_number":263,"context_line":"   xtremio_ports \u003d 21:00:00:24:ff:57:b2:36,21:00:00:24:ff:57:b2:55"},{"line_number":264,"context_line":"   san_login \u003d XMS_USER"},{"line_number":265,"context_line":"   san_password \u003d XMS_PASSWD"},{"line_number":266,"context_line":"   volume_backend_name \u003d XtremIOAFA"}],"source_content_type":"text/x-rst","patch_set":1,"id":"88fc12bc_69d5469a","line":263,"range":{"start_line":263,"start_character":0,"end_line":263,"end_character":66},"in_reply_to":"bd63dae4_170d7df0","updated":"2021-02-16 16:14:08.000000000","message":"Don\u0027t think it is really necessary as there is a description of this option above.","commit_id":"3147e7d9de901bb245721e8af9f2118e976f00b3"}]}