)]}'
{"cinder/volume/drivers/pure.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"91067c31257ce06d78deb7258fd65551c23391ea","unresolved":true,"context_lines":[{"line_number":2682,"context_line":"            LOG.info(\"Re-using existing purity host %(host_name)r\","},{"line_number":2683,"context_line":"                     {\"host_name\": host_name})"},{"line_number":2684,"context_line":"        else:"},{"line_number":2685,"context_line":"            personality \u003d self.configuration.safe_get(\u0027pure_host_personality\u0027)"},{"line_number":2686,"context_line":"            if personality:"},{"line_number":2687,"context_line":"                api_version \u003d array.get_rest_version()"},{"line_number":2688,"context_line":"                if api_version not in PERSONALITY_REQUIRED_API_VERSIONS:"},{"line_number":2689,"context_line":"                    # Continuing here would mean creating a host not according"},{"line_number":2690,"context_line":"                    # to specificiations, possibly leading to unexpected"},{"line_number":2691,"context_line":"                    # behavior later on."},{"line_number":2692,"context_line":"                    msg \u003d _(\u0027Unable to set host personality with Purity REST \u0027"},{"line_number":2693,"context_line":"                            \u0027API version %(api_version)s, requires \u0027"},{"line_number":2694,"context_line":"                            \u0027%(required_versions)s.\u0027) % {"},{"line_number":2695,"context_line":"                        \u0027api_version\u0027: api_version,"},{"line_number":2696,"context_line":"                        \u0027required_versions\u0027: PERSONALITY_REQUIRED_API_VERSIONS"},{"line_number":2697,"context_line":"                    }"},{"line_number":2698,"context_line":"                    raise PureDriverException(reason\u003dmsg)"},{"line_number":2699,"context_line":""},{"line_number":2700,"context_line":"            host_name \u003d self._generate_purity_host_name(connector[\"host\"])"},{"line_number":2701,"context_line":"            LOG.info(\"Creating host object %(host_name)r with WWN:\""}],"source_content_type":"text/x-python","patch_set":4,"id":"b70c84a7_64a0c2da","line":2698,"range":{"start_line":2685,"start_character":0,"end_line":2698,"end_character":57},"updated":"2021-02-19 19:56:32.000000000","message":"this looks identical to the code in the PureISCSIDriver -- how do you feel about moving it to a function in the PureBaseDriver and then call it here and in the iscsi driver, something like\n\n    personality \u003d self.get_and_check_personality()","commit_id":"9a751dfe585ad3b7d22d66fae320a632a01a20f3"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"f08f41f6aa068306709943002104fbffd30cf748","unresolved":false,"context_lines":[{"line_number":2682,"context_line":"            LOG.info(\"Re-using existing purity host %(host_name)r\","},{"line_number":2683,"context_line":"                     {\"host_name\": host_name})"},{"line_number":2684,"context_line":"        else:"},{"line_number":2685,"context_line":"            personality \u003d self.configuration.safe_get(\u0027pure_host_personality\u0027)"},{"line_number":2686,"context_line":"            if personality:"},{"line_number":2687,"context_line":"                api_version \u003d array.get_rest_version()"},{"line_number":2688,"context_line":"                if api_version not in PERSONALITY_REQUIRED_API_VERSIONS:"},{"line_number":2689,"context_line":"                    # Continuing here would mean creating a host not according"},{"line_number":2690,"context_line":"                    # to specificiations, possibly leading to unexpected"},{"line_number":2691,"context_line":"                    # behavior later on."},{"line_number":2692,"context_line":"                    msg \u003d _(\u0027Unable to set host personality with Purity REST \u0027"},{"line_number":2693,"context_line":"                            \u0027API version %(api_version)s, requires \u0027"},{"line_number":2694,"context_line":"                            \u0027%(required_versions)s.\u0027) % {"},{"line_number":2695,"context_line":"                        \u0027api_version\u0027: api_version,"},{"line_number":2696,"context_line":"                        \u0027required_versions\u0027: PERSONALITY_REQUIRED_API_VERSIONS"},{"line_number":2697,"context_line":"                    }"},{"line_number":2698,"context_line":"                    raise PureDriverException(reason\u003dmsg)"},{"line_number":2699,"context_line":""},{"line_number":2700,"context_line":"            host_name \u003d self._generate_purity_host_name(connector[\"host\"])"},{"line_number":2701,"context_line":"            LOG.info(\"Creating host object %(host_name)r with WWN:\""}],"source_content_type":"text/x-python","patch_set":4,"id":"b71a8a9a_e14779c3","line":2698,"range":{"start_line":2685,"start_character":0,"end_line":2698,"end_character":57},"in_reply_to":"b70c84a7_64a0c2da","updated":"2021-02-19 21:45:10.000000000","message":"Done","commit_id":"9a751dfe585ad3b7d22d66fae320a632a01a20f3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"91067c31257ce06d78deb7258fd65551c23391ea","unresolved":true,"context_lines":[{"line_number":2712,"context_line":"                    raise PureRetryableException()"},{"line_number":2713,"context_line":""},{"line_number":2714,"context_line":"            if personality:"},{"line_number":2715,"context_line":"                try:"},{"line_number":2716,"context_line":"                    array.set_host(host_name, personality\u003dpersonality)"},{"line_number":2717,"context_line":"                except purestorage.PureHTTPError as err:"},{"line_number":2718,"context_line":"                    if (err.code \u003d\u003d 400 and"},{"line_number":2719,"context_line":"                            ERR_MSG_HOST_NOT_EXIST in err.text):"},{"line_number":2720,"context_line":"                        # If the host disappeared out from under us that\u0027s"},{"line_number":2721,"context_line":"                        # ok, we will just retry and snag a new host."},{"line_number":2722,"context_line":"                        LOG.debug(\u0027Unable to set host personality: %s\u0027,"},{"line_number":2723,"context_line":"                                  err.text)"},{"line_number":2724,"context_line":"                        raise PureRetryableException()"},{"line_number":2725,"context_line":""},{"line_number":2726,"context_line":"        # TODO(patrickeast): Ensure that the host has the correct preferred"},{"line_number":2727,"context_line":"        # arrays configured for it."}],"source_content_type":"text/x-python","patch_set":4,"id":"538da613_7a461aa5","line":2724,"range":{"start_line":2715,"start_character":0,"end_line":2724,"end_character":54},"updated":"2021-02-19 19:56:32.000000000","message":"maybe move this to the PureBaseDriver as set_personality(array, hostname, personality)?\n\n(I know it seems kind of overkill, but if you ever have to modify the logic, it will only have to be fixed in 1 place for both fc and iscsi drivers.)","commit_id":"9a751dfe585ad3b7d22d66fae320a632a01a20f3"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"f08f41f6aa068306709943002104fbffd30cf748","unresolved":false,"context_lines":[{"line_number":2712,"context_line":"                    raise PureRetryableException()"},{"line_number":2713,"context_line":""},{"line_number":2714,"context_line":"            if personality:"},{"line_number":2715,"context_line":"                try:"},{"line_number":2716,"context_line":"                    array.set_host(host_name, personality\u003dpersonality)"},{"line_number":2717,"context_line":"                except purestorage.PureHTTPError as err:"},{"line_number":2718,"context_line":"                    if (err.code \u003d\u003d 400 and"},{"line_number":2719,"context_line":"                            ERR_MSG_HOST_NOT_EXIST in err.text):"},{"line_number":2720,"context_line":"                        # If the host disappeared out from under us that\u0027s"},{"line_number":2721,"context_line":"                        # ok, we will just retry and snag a new host."},{"line_number":2722,"context_line":"                        LOG.debug(\u0027Unable to set host personality: %s\u0027,"},{"line_number":2723,"context_line":"                                  err.text)"},{"line_number":2724,"context_line":"                        raise PureRetryableException()"},{"line_number":2725,"context_line":""},{"line_number":2726,"context_line":"        # TODO(patrickeast): Ensure that the host has the correct preferred"},{"line_number":2727,"context_line":"        # arrays configured for it."}],"source_content_type":"text/x-python","patch_set":4,"id":"66ae3c4d_393e6c94","line":2724,"range":{"start_line":2715,"start_character":0,"end_line":2724,"end_character":54},"in_reply_to":"538da613_7a461aa5","updated":"2021-02-19 21:45:10.000000000","message":"Done","commit_id":"9a751dfe585ad3b7d22d66fae320a632a01a20f3"}],"releasenotes/notes/pure_fc_personality-3cada97fc940e498.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"349ea009e1c4a6b23c60ad476e18756c54eeff64","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add missing support for host_personality setting for FC-based hosts"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"6757ff77_ad6a1529","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":71},"updated":"2021-03-04 22:40:59.000000000","message":"Please use the official style for driver-related release notes:\nhttps://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers\n\n(The notes get all munged together, so unless you identify the driver, there\u0027s no way for an operator to know what this fix applies to.)","commit_id":"c4cf12c0b5d865baf848950971ad940455b2d110"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"0b3b8eb4cb585b5a36ae2734e02dd1bf13e262e2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add missing support for host_personality setting for FC-based hosts"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"729d0843_0db372f5","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":71},"in_reply_to":"6757ff77_ad6a1529","updated":"2021-03-05 15:15:14.000000000","message":"Done","commit_id":"c4cf12c0b5d865baf848950971ad940455b2d110"}]}