)]}'
{"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"297c716f1833929581529089acebdbc7fc920261","unresolved":true,"context_lines":[{"line_number":4982,"context_line":"        self.driver.create_volume(vol)"},{"line_number":4983,"context_line":"        return vol"},{"line_number":4984,"context_line":""},{"line_number":4985,"context_line":"    def _generate_hyperswap_vol_info(self, hyper_type, size\u003d10):"},{"line_number":4986,"context_line":"        pool \u003d \u0027hyperswap1\u0027"},{"line_number":4987,"context_line":"        prop \u003d {\u0027host\u0027: \u0027openstack@svc#%s\u0027 % pool,"},{"line_number":4988,"context_line":"                \u0027size\u0027: size,"}],"source_content_type":"text/x-python","patch_set":8,"id":"be6cc474_09211f90","line":4985,"range":{"start_line":4985,"start_character":8,"end_line":4985,"end_character":36},"updated":"2021-09-09 13:02:57.000000000","message":"This method is same as _generate_vol_info, check this method can be removed.","commit_id":"86ad38defcdc43ce5913220f7eb895b51a02b512"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"6921fccdf57b8d34b3b27c00dca33272ba3a17cb","unresolved":true,"context_lines":[{"line_number":4982,"context_line":"        self.driver.create_volume(vol)"},{"line_number":4983,"context_line":"        return vol"},{"line_number":4984,"context_line":""},{"line_number":4985,"context_line":"    def _generate_hyperswap_vol_info(self, hyper_type, size\u003d10):"},{"line_number":4986,"context_line":"        pool \u003d \u0027hyperswap1\u0027"},{"line_number":4987,"context_line":"        prop \u003d {\u0027host\u0027: \u0027openstack@svc#%s\u0027 % pool,"},{"line_number":4988,"context_line":"                \u0027size\u0027: size,"}],"source_content_type":"text/x-python","patch_set":8,"id":"b1d20941_f541513f","line":4985,"range":{"start_line":4985,"start_character":8,"end_line":4985,"end_character":36},"in_reply_to":"be6cc474_09211f90","updated":"2021-09-09 14:45:56.000000000","message":"My intention on the new function is to maintain a separate one for the Hyperswap replication type, as the existing one covers the mirror replication type. Both types are dealing with different storage pools and it would be easy to update those as per the new requirements in the future.\nHope this covers your comment.","commit_id":"86ad38defcdc43ce5913220f7eb895b51a02b512"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"297c716f1833929581529089acebdbc7fc920261","unresolved":true,"context_lines":[{"line_number":8139,"context_line":"                                \u0027system_id\u0027: \u00270123456789ABCDEF\u0027}"},{"line_number":8140,"context_line":"            get_system_info.return_value \u003d fake_system_info"},{"line_number":8141,"context_line":"            self.driver.do_setup(None)"},{"line_number":8142,"context_line":"        spec \u003d {\u0027drivers:volume_topology\u0027: \u0027hyperswap\u0027,"},{"line_number":8143,"context_line":"                \u0027peer_pool\u0027: \u0027hyperswap2\u0027}"},{"line_number":8144,"context_line":"        vol_type_ref \u003d volume_types.create(self.ctxt, \u0027test_hyperswap_type\u0027,"},{"line_number":8145,"context_line":"                                           spec)"},{"line_number":8146,"context_line":"        vol \u003d self._create_hyperswap_volume(vol_type_ref)"},{"line_number":8147,"context_line":"        self._assert_vol_exists(vol.name, True)"},{"line_number":8148,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"b87beafd_b94f5596","line":8145,"range":{"start_line":8142,"start_character":8,"end_line":8145,"end_character":48},"updated":"2021-09-09 13:02:57.000000000","message":"Replace the code with hyper_type \u003d self._create_hyperswap_type(\u0027test_hyperswap_type\u0027)","commit_id":"86ad38defcdc43ce5913220f7eb895b51a02b512"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"6921fccdf57b8d34b3b27c00dca33272ba3a17cb","unresolved":false,"context_lines":[{"line_number":8139,"context_line":"                                \u0027system_id\u0027: \u00270123456789ABCDEF\u0027}"},{"line_number":8140,"context_line":"            get_system_info.return_value \u003d fake_system_info"},{"line_number":8141,"context_line":"            self.driver.do_setup(None)"},{"line_number":8142,"context_line":"        spec \u003d {\u0027drivers:volume_topology\u0027: \u0027hyperswap\u0027,"},{"line_number":8143,"context_line":"                \u0027peer_pool\u0027: \u0027hyperswap2\u0027}"},{"line_number":8144,"context_line":"        vol_type_ref \u003d volume_types.create(self.ctxt, \u0027test_hyperswap_type\u0027,"},{"line_number":8145,"context_line":"                                           spec)"},{"line_number":8146,"context_line":"        vol \u003d self._create_hyperswap_volume(vol_type_ref)"},{"line_number":8147,"context_line":"        self._assert_vol_exists(vol.name, True)"},{"line_number":8148,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"d3b8b482_22e58c2e","line":8145,"range":{"start_line":8142,"start_character":8,"end_line":8145,"end_character":48},"in_reply_to":"b87beafd_b94f5596","updated":"2021-09-09 14:45:56.000000000","message":"Addressed.","commit_id":"86ad38defcdc43ce5913220f7eb895b51a02b512"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"297c716f1833929581529089acebdbc7fc920261","unresolved":true,"context_lines":[{"line_number":8185,"context_line":"        self.driver.delete_volume(vol)"},{"line_number":8186,"context_line":""},{"line_number":8187,"context_line":"        # Extend hyperswap volume with thick_provisioning_support."},{"line_number":8188,"context_line":"        spec \u003d {\u0027drivers:volume_topology\u0027: \u0027hyperswap\u0027,"},{"line_number":8189,"context_line":"                \u0027peer_pool\u0027: \u0027hyperswap2\u0027,"},{"line_number":8190,"context_line":"                \u0027drivers:rsize\u0027: -1}"},{"line_number":8191,"context_line":"        hs_thick_type \u003d volume_types.create("},{"line_number":8192,"context_line":"            self.ctxt, \u0027test_hyperswap_thick_type\u0027, spec)"},{"line_number":8193,"context_line":"        hs_vol \u003d self._create_hyperswap_volume(hs_thick_type)"},{"line_number":8194,"context_line":"        self._assert_vol_exists(hs_vol.name, True)"},{"line_number":8195,"context_line":"        if self.USESIM:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9e936551_6b4f12b8","line":8192,"range":{"start_line":8188,"start_character":8,"end_line":8192,"end_character":57},"updated":"2021-09-09 13:02:57.000000000","message":"Add kwargs optional argument to _create_hyperswap_type, if kwargs is given as input check and update the spec with kwargs. Use the _create_hyperswap_type method and pass the rsize parameter to _create_hyperswap_type.","commit_id":"86ad38defcdc43ce5913220f7eb895b51a02b512"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"6921fccdf57b8d34b3b27c00dca33272ba3a17cb","unresolved":true,"context_lines":[{"line_number":8185,"context_line":"        self.driver.delete_volume(vol)"},{"line_number":8186,"context_line":""},{"line_number":8187,"context_line":"        # Extend hyperswap volume with thick_provisioning_support."},{"line_number":8188,"context_line":"        spec \u003d {\u0027drivers:volume_topology\u0027: \u0027hyperswap\u0027,"},{"line_number":8189,"context_line":"                \u0027peer_pool\u0027: \u0027hyperswap2\u0027,"},{"line_number":8190,"context_line":"                \u0027drivers:rsize\u0027: -1}"},{"line_number":8191,"context_line":"        hs_thick_type \u003d volume_types.create("},{"line_number":8192,"context_line":"            self.ctxt, \u0027test_hyperswap_thick_type\u0027, spec)"},{"line_number":8193,"context_line":"        hs_vol \u003d self._create_hyperswap_volume(hs_thick_type)"},{"line_number":8194,"context_line":"        self._assert_vol_exists(hs_vol.name, True)"},{"line_number":8195,"context_line":"        if self.USESIM:"}],"source_content_type":"text/x-python","patch_set":8,"id":"4e5ba906_a1cbbdee","line":8192,"range":{"start_line":8188,"start_character":8,"end_line":8192,"end_character":57},"in_reply_to":"9e936551_6b4f12b8","updated":"2021-09-09 14:45:56.000000000","message":"Adding a new parameter to _create_hyperswap_type and update the spec based on the value of that parameter, would add some extra execution cycles as this function is being called so often. \nAnd the above case is very rare. So to avoid extra cycles, I have created volume_type with explicit calls. Hope this answered your comment.","commit_id":"86ad38defcdc43ce5913220f7eb895b51a02b512"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3ce71b5bb3ed334f23077b737907e02bbbfb7183","unresolved":true,"context_lines":[{"line_number":3715,"context_line":"                                                               model_update)"},{"line_number":3716,"context_line":""},{"line_number":3717,"context_line":"        if opts[\u0027volume_topology\u0027] \u003d\u003d \u0027hyperswap\u0027:"},{"line_number":3718,"context_line":"            LOG.debug(\u0027The source volume %s to be created is a hyperswap \u0027"},{"line_number":3719,"context_line":"                      \u0027volume.\u0027, volume.name)"},{"line_number":3720,"context_line":"            # Ensures the vdisk is not part of FC mapping."},{"line_number":3721,"context_line":"            # Otherwize convert it to hyperswap volume will be failed."}],"source_content_type":"text/x-python","patch_set":9,"id":"da12df81_e84e9080","line":3718,"range":{"start_line":3718,"start_character":27,"end_line":3718,"end_character":33},"updated":"2021-09-13 13:53:41.000000000","message":"Is \"source\" the right term here?","commit_id":"fb222dae52dfb1ea05b999552b74b7a1708b0e65"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"3d849934bfa8cef4c2d663b1c726ded49daf62fd","unresolved":false,"context_lines":[{"line_number":3715,"context_line":"                                                               model_update)"},{"line_number":3716,"context_line":""},{"line_number":3717,"context_line":"        if opts[\u0027volume_topology\u0027] \u003d\u003d \u0027hyperswap\u0027:"},{"line_number":3718,"context_line":"            LOG.debug(\u0027The source volume %s to be created is a hyperswap \u0027"},{"line_number":3719,"context_line":"                      \u0027volume.\u0027, volume.name)"},{"line_number":3720,"context_line":"            # Ensures the vdisk is not part of FC mapping."},{"line_number":3721,"context_line":"            # Otherwize convert it to hyperswap volume will be failed."}],"source_content_type":"text/x-python","patch_set":9,"id":"4c103d0b_7e4dacd9","line":3718,"range":{"start_line":3718,"start_character":27,"end_line":3718,"end_character":33},"in_reply_to":"60ee05d1_1a203025","updated":"2021-09-13 17:26:17.000000000","message":"Thanks for the comment. Updated.","commit_id":"fb222dae52dfb1ea05b999552b74b7a1708b0e65"},{"author":{"_account_id":32036,"name":"katari manoj kumar","email":"katkumar@in.ibm.com","username":"katarimanojkumar"},"change_message_id":"907a468a89c8c85087e7a169b27f1846ad837f55","unresolved":true,"context_lines":[{"line_number":3715,"context_line":"                                                               model_update)"},{"line_number":3716,"context_line":""},{"line_number":3717,"context_line":"        if opts[\u0027volume_topology\u0027] \u003d\u003d \u0027hyperswap\u0027:"},{"line_number":3718,"context_line":"            LOG.debug(\u0027The source volume %s to be created is a hyperswap \u0027"},{"line_number":3719,"context_line":"                      \u0027volume.\u0027, volume.name)"},{"line_number":3720,"context_line":"            # Ensures the vdisk is not part of FC mapping."},{"line_number":3721,"context_line":"            # Otherwize convert it to hyperswap volume will be failed."}],"source_content_type":"text/x-python","patch_set":9,"id":"eeb055e5_77270644","line":3718,"range":{"start_line":3718,"start_character":27,"end_line":3718,"end_character":33},"in_reply_to":"72c8d29d_c7a6d0cc","updated":"2021-09-13 14:27:05.000000000","message":"As this is create_volume_from_snapshot:  source-\u003esnapshot, target-\u003evolume for mkfcmap operation.\nI feel it is better to remove the word \u0027source\u0027 to avoid confusion as the \u0027to be created\u0027 hyperswap volume is always a target","commit_id":"fb222dae52dfb1ea05b999552b74b7a1708b0e65"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"a11c3969fce206c48ea606dbcb59b704ef4bb5f5","unresolved":true,"context_lines":[{"line_number":3715,"context_line":"                                                               model_update)"},{"line_number":3716,"context_line":""},{"line_number":3717,"context_line":"        if opts[\u0027volume_topology\u0027] \u003d\u003d \u0027hyperswap\u0027:"},{"line_number":3718,"context_line":"            LOG.debug(\u0027The source volume %s to be created is a hyperswap \u0027"},{"line_number":3719,"context_line":"                      \u0027volume.\u0027, volume.name)"},{"line_number":3720,"context_line":"            # Ensures the vdisk is not part of FC mapping."},{"line_number":3721,"context_line":"            # Otherwize convert it to hyperswap volume will be failed."}],"source_content_type":"text/x-python","patch_set":9,"id":"72c8d29d_c7a6d0cc","line":3718,"range":{"start_line":3718,"start_character":27,"end_line":3718,"end_character":33},"in_reply_to":"da12df81_e84e9080","updated":"2021-09-13 13:57:19.000000000","message":"Yes. That is the correct word in this context.","commit_id":"fb222dae52dfb1ea05b999552b74b7a1708b0e65"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"37671d7bd73eee87431bc47ea73ed21485b0c5f1","unresolved":true,"context_lines":[{"line_number":3715,"context_line":"                                                               model_update)"},{"line_number":3716,"context_line":""},{"line_number":3717,"context_line":"        if opts[\u0027volume_topology\u0027] \u003d\u003d \u0027hyperswap\u0027:"},{"line_number":3718,"context_line":"            LOG.debug(\u0027The source volume %s to be created is a hyperswap \u0027"},{"line_number":3719,"context_line":"                      \u0027volume.\u0027, volume.name)"},{"line_number":3720,"context_line":"            # Ensures the vdisk is not part of FC mapping."},{"line_number":3721,"context_line":"            # Otherwize convert it to hyperswap volume will be failed."}],"source_content_type":"text/x-python","patch_set":9,"id":"60ee05d1_1a203025","line":3718,"range":{"start_line":3718,"start_character":27,"end_line":3718,"end_character":33},"in_reply_to":"eeb055e5_77270644","updated":"2021-09-13 16:53:09.000000000","message":"Agreed, \"source volume\" meaning the volume that is being created is confusing in typical Cinder terminology.  Would be better to just remove this word.","commit_id":"fb222dae52dfb1ea05b999552b74b7a1708b0e65"}]}