)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d1c987dc8715dd5c508c3b4b79e4f99425538b51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"32fb0ee7_f1341086","updated":"2021-11-11 16:36:01.000000000","message":"This looks very interesting.  Please add a release note, because I imagine that due to the performance characteristics you describe in your commit message, operators may not be creating encrypted volume-types for rbd backends, and you need to tell them that it\u0027s safe to do so now.\n\nhttps://docs.openstack.org/cinder/latest/contributor/releasenotes.html","commit_id":"8e54eb68224caec96d3bd948154680f07b72e81e"},{"author":{"_account_id":32098,"name":"wanwencong","email":"wanwc@chinatelecom.cn","username":"wanwencong"},"change_message_id":"c8680018c69f9b62473434395a966214bba9a4bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b1fec9dd_573ce694","in_reply_to":"32fb0ee7_f1341086","updated":"2021-11-12 14:13:58.000000000","message":"I have done the work, please review it.","commit_id":"8e54eb68224caec96d3bd948154680f07b72e81e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e28ebe1bcb34414e1248f3f942c54ef2070ac804","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0d84eec9_3611ad9a","updated":"2021-11-20 14:34:24.000000000","message":"Suggestion for improving the release note inline.  In the meantime, I\u0027ll ping some of our ceph experts to give you feedback.  Code LGTM.","commit_id":"6569005595928ecc2996304e9162428393844a2b"},{"author":{"_account_id":32098,"name":"wanwencong","email":"wanwc@chinatelecom.cn","username":"wanwencong"},"change_message_id":"c8680018c69f9b62473434395a966214bba9a4bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0cafcc84_bfa2193a","updated":"2021-11-12 14:13:58.000000000","message":"recheck","commit_id":"6569005595928ecc2996304e9162428393844a2b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"48a6b27c9b74450e0d3bbe84ae074a6c35b6d9ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b891d3f6_3c5c51a9","updated":"2023-04-11 17:23:09.000000000","message":"Have we confirmed that the result of this is byte-to-byte identical with the previous method?  I\u0027m wondering about potential differences between the import and qemu-img create method -- i.e. did import ever round the size with regards to \"order\"?","commit_id":"9e6c02bda3c37a3b193a0ef939ef4b5a1ac2069a"},{"author":{"_account_id":33436,"name":"YuehuiLei","display_name":"leiyuehui","email":"leiyuehui-s@inspur.com","username":"leiyuehui"},"change_message_id":"b24504b2c8c6cdf307dac8ff0b9187bc9a6f9e0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"00cb5954_0faeed44","updated":"2023-04-03 03:07:55.000000000","message":"LGTM","commit_id":"9e6c02bda3c37a3b193a0ef939ef4b5a1ac2069a"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"508686e5ebb65d507004204420d826644f631e5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"be20ea5f_fa2f83cb","updated":"2023-02-12 08:16:31.000000000","message":"LGTM","commit_id":"9e6c02bda3c37a3b193a0ef939ef4b5a1ac2069a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d1942a8b55f10b3fe1817f3988044ac5c86c3d77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2a518273_d278ae2f","updated":"2023-04-11 12:14:26.000000000","message":"Sorry this has been sitting so long.  Questions inline.","commit_id":"9e6c02bda3c37a3b193a0ef939ef4b5a1ac2069a"},{"author":{"_account_id":32098,"name":"wanwencong","email":"wanwc@chinatelecom.cn","username":"wanwencong"},"change_message_id":"bf8a5c8e6f8e31c2d133791ee4b78b6115271d43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cc08812e_93c63465","updated":"2021-11-21 04:04:00.000000000","message":"Thank you for your suggestion.","commit_id":"9e6c02bda3c37a3b193a0ef939ef4b5a1ac2069a"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d1942a8b55f10b3fe1817f3988044ac5c86c3d77","unresolved":true,"context_lines":[{"line_number":955,"context_line":"                \u0027format\u003draw,file\u003d%(passfile)s\u0027 % {\u0027passfile\u0027:"},{"line_number":956,"context_line":"                                                  tmp_key.name},"},{"line_number":957,"context_line":"                \u0027-o\u0027, \u0027key-secret\u003dluks_sec\u0027,"},{"line_number":958,"context_line":"                \u0027-o\u0027, \u0027cluster_size\u003d%sM\u0027 % chunk_size,"},{"line_number":959,"context_line":"                \u0027rbd:%s/%s:id\u003d%s:conf\u003d%s\u0027 % (ceph_pool,"},{"line_number":960,"context_line":"                                             volume.name,"},{"line_number":961,"context_line":"                                             ceph_user,"}],"source_content_type":"text/x-python","patch_set":6,"id":"a6448610_08dddfa1","line":958,"range":{"start_line":958,"start_character":43,"end_line":958,"end_character":53},"updated":"2023-04-11 12:14:26.000000000","message":"Two questions:\n\n1. The old code did not use this value directly, but multiplied by units.Mi ... this value is being passed to ceph, do we know whether \u0027M\u0027 is decimal or binary? \n\n2. qemu-img create\u0027s \u0027size\u0027 at line 963 is documented that \u0027M\u0027\u003d\u003dmebibytes. qemu-img also directly supports Gibbibytes, so is there any reason not to use \u0027%sG\u0027 in line 963 (and then just pass volume.size)?","commit_id":"9e6c02bda3c37a3b193a0ef939ef4b5a1ac2069a"},{"author":{"_account_id":32098,"name":"wanwencong","email":"wanwc@chinatelecom.cn","username":"wanwencong"},"change_message_id":"112e5b4748cca8d320dd76bf250da2bd8579c4f9","unresolved":false,"context_lines":[{"line_number":955,"context_line":"                \u0027format\u003draw,file\u003d%(passfile)s\u0027 % {\u0027passfile\u0027:"},{"line_number":956,"context_line":"                                                  tmp_key.name},"},{"line_number":957,"context_line":"                \u0027-o\u0027, \u0027key-secret\u003dluks_sec\u0027,"},{"line_number":958,"context_line":"                \u0027-o\u0027, \u0027cluster_size\u003d%sM\u0027 % chunk_size,"},{"line_number":959,"context_line":"                \u0027rbd:%s/%s:id\u003d%s:conf\u003d%s\u0027 % (ceph_pool,"},{"line_number":960,"context_line":"                                             volume.name,"},{"line_number":961,"context_line":"                                             ceph_user,"}],"source_content_type":"text/x-python","patch_set":6,"id":"02c7a955_ca7a2ddb","line":958,"range":{"start_line":958,"start_character":43,"end_line":958,"end_character":53},"in_reply_to":"a6448610_08dddfa1","updated":"2023-04-11 17:10:17.000000000","message":"1、https://github.com/qemu/qemu/blob/master/util/qemu-option.c,qemu options support M instead of Mi, M means 1024*1024 Bytes.\n2、Of course we can use G, the original code use M（line 955）.","commit_id":"9e6c02bda3c37a3b193a0ef939ef4b5a1ac2069a"}],"releasenotes/notes/bug-1883470-fix-the-time-consuming-issue-of-creating-RBD-encrypted-volumes.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e28ebe1bcb34414e1248f3f942c54ef2070ac804","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1883470 \u003chttps://bugs.launchpad.net/cinder/+bug/1883470\u003e`_: Fixed"},{"line_number":5,"context_line":"    the time-consuming issue of creating RBD encrypted volumes."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f0b48662_dc34fe49","line":5,"range":{"start_line":4,"start_character":70,"end_line":5,"end_character":63},"updated":"2021-11-20 14:34:24.000000000","message":"I think you can include some more info from your commit message here, something like:\n\nPreviously the creation of RBD encrypted volumes required a time-consuming rbd import operation.  With this fix, RBD encrypted volumes are created directly in the backend, which vastly reduces the creation time of large-capacity encrypted volumes.","commit_id":"6569005595928ecc2996304e9162428393844a2b"},{"author":{"_account_id":32098,"name":"wanwencong","email":"wanwc@chinatelecom.cn","username":"wanwencong"},"change_message_id":"bf8a5c8e6f8e31c2d133791ee4b78b6115271d43","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1883470 \u003chttps://bugs.launchpad.net/cinder/+bug/1883470\u003e`_: Fixed"},{"line_number":5,"context_line":"    the time-consuming issue of creating RBD encrypted volumes."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d6ad2351_d15e33d1","line":5,"range":{"start_line":4,"start_character":70,"end_line":5,"end_character":63},"in_reply_to":"f0b48662_dc34fe49","updated":"2021-11-21 04:04:00.000000000","message":"Done, thx.","commit_id":"6569005595928ecc2996304e9162428393844a2b"}]}