)]}'
{"cinder/cmd/manage.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"5f0132191cef313309292b2ec93dba81353a6165","unresolved":true,"context_lines":[{"line_number":485,"context_line":"                        keep_usage.in_use +\u003d usage.in_use"},{"line_number":486,"context_line":"                        keep_usage.reserved +\u003d usage.reserved"},{"line_number":487,"context_line":"                        usage.delete(session\u003dsession)"},{"line_number":488,"context_line":"                    print(\u0027duplicated removed \u0026 %s reservations reassigned\u0027 %"},{"line_number":489,"context_line":"                          reassigned)"},{"line_number":490,"context_line":"                else:"},{"line_number":491,"context_line":"                    print(\u0027ignored\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff9793f_8eef69b7","line":488,"range":{"start_line":488,"start_character":27,"end_line":488,"end_character":37},"updated":"2021-03-24 16:45:02.000000000","message":"Think this should be \u0027duplicates\u0027","commit_id":"9d7818b89875c008b27921bae637f90f1d627b26"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"63f76271738ea574502593f97bc4cc9efeb2f74c","unresolved":false,"context_lines":[{"line_number":485,"context_line":"                        keep_usage.in_use +\u003d usage.in_use"},{"line_number":486,"context_line":"                        keep_usage.reserved +\u003d usage.reserved"},{"line_number":487,"context_line":"                        usage.delete(session\u003dsession)"},{"line_number":488,"context_line":"                    print(\u0027duplicated removed \u0026 %s reservations reassigned\u0027 %"},{"line_number":489,"context_line":"                          reassigned)"},{"line_number":490,"context_line":"                else:"},{"line_number":491,"context_line":"                    print(\u0027ignored\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a8c154b3_454a7d07","line":488,"range":{"start_line":488,"start_character":27,"end_line":488,"end_character":37},"in_reply_to":"bff9793f_8eef69b7","updated":"2021-03-26 11:28:24.000000000","message":"Done","commit_id":"9d7818b89875c008b27921bae637f90f1d627b26"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"5f0132191cef313309292b2ec93dba81353a6165","unresolved":true,"context_lines":[{"line_number":537,"context_line":"                            usage.in_use \u003d in_use"},{"line_number":538,"context_line":"                            print(\u0027fixed\u0027)"},{"line_number":539,"context_line":"                        else:"},{"line_number":540,"context_line":"                            print(\u0027ignored\u0027)"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"                    reservations \u003d self._get_reservations(ctxt, session,"},{"line_number":543,"context_line":"                                                          project, usage.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f97a64e6_8c142f0d","line":540,"range":{"start_line":540,"start_character":28,"end_line":540,"end_character":44},"updated":"2021-03-24 16:45:02.000000000","message":"Might be clearer to remove this or to indicate that no action was taken as this was just a check run.  Otherwise it appears on a successful run of the check that some things were not done.","commit_id":"9d7818b89875c008b27921bae637f90f1d627b26"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"63f76271738ea574502593f97bc4cc9efeb2f74c","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                            usage.in_use \u003d in_use"},{"line_number":538,"context_line":"                            print(\u0027fixed\u0027)"},{"line_number":539,"context_line":"                        else:"},{"line_number":540,"context_line":"                            print(\u0027ignored\u0027)"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"                    reservations \u003d self._get_reservations(ctxt, session,"},{"line_number":543,"context_line":"                                                          project, usage.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a906966_643513aa","line":540,"range":{"start_line":540,"start_character":28,"end_line":540,"end_character":44},"in_reply_to":"f97a64e6_8c142f0d","updated":"2021-03-26 11:28:24.000000000","message":"Done","commit_id":"9d7818b89875c008b27921bae637f90f1d627b26"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"5f0132191cef313309292b2ec93dba81353a6165","unresolved":true,"context_lines":[{"line_number":552,"context_line":"                            usage.reserved \u003d num_reservations"},{"line_number":553,"context_line":"                            print(\u0027fixed\u0027)"},{"line_number":554,"context_line":"                        else:"},{"line_number":555,"context_line":"                            print(\u0027ignored\u0027)"},{"line_number":556,"context_line":"        print(\u0027Action successfully completed\u0027)"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1d359be6_2b93d427","line":555,"range":{"start_line":555,"start_character":28,"end_line":555,"end_character":44},"updated":"2021-03-24 16:45:02.000000000","message":"Same here.","commit_id":"9d7818b89875c008b27921bae637f90f1d627b26"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"63f76271738ea574502593f97bc4cc9efeb2f74c","unresolved":false,"context_lines":[{"line_number":552,"context_line":"                            usage.reserved \u003d num_reservations"},{"line_number":553,"context_line":"                            print(\u0027fixed\u0027)"},{"line_number":554,"context_line":"                        else:"},{"line_number":555,"context_line":"                            print(\u0027ignored\u0027)"},{"line_number":556,"context_line":"        print(\u0027Action successfully completed\u0027)"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"438e2f94_b4a28b83","line":555,"range":{"start_line":555,"start_character":28,"end_line":555,"end_character":44},"in_reply_to":"1d359be6_2b93d427","updated":"2021-03-26 11:28:24.000000000","message":"Done","commit_id":"9d7818b89875c008b27921bae637f90f1d627b26"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6f125785610c5e25393f79d880dc6f5674cc7c43","unresolved":true,"context_lines":[{"line_number":534,"context_line":"                    if in_use !\u003d usage.in_use:"},{"line_number":535,"context_line":"                        if do_fix:"},{"line_number":536,"context_line":"                            usage.in_use \u003d in_use"},{"line_number":537,"context_line":"                        print(\u0027\\t%s: invalid usage saved\u003d%s actual\u003d%s%s\u0027 %"},{"line_number":538,"context_line":"                              (usage.resource, usage.in_use, in_use,"},{"line_number":539,"context_line":"                               action_msg))"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"                    reservations \u003d self._get_reservations(ctxt, session,"},{"line_number":542,"context_line":"                                                          project, usage.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"12ef1dc0_e2f13753","line":539,"range":{"start_line":537,"start_character":0,"end_line":539,"end_character":43},"updated":"2021-03-30 13:43:39.000000000","message":"Moving this print after the do_fix is what introduced the issue eharney mentions.  we print the same saved and actual values when fixing.  :-(","commit_id":"89de17d9bfd1bd7c4490921368ab83b30e6c5bd5"}],"doc/source/cli/cinder-manage.rst":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"919dacafdfef4be2df4cd4be332eff05418f617e","unresolved":true,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"This operation is best executed when Cinder is not running, as it requires"},{"line_number":111,"context_line":"locking many tables (affecting all tenants) to make sure that then sync is"},{"line_number":112,"context_line":"accurate."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"If accuracy is not our top priority, or we know that a specific project is not"},{"line_number":115,"context_line":"in use, we can disable the locking."}],"source_content_type":"text/x-rst","patch_set":1,"id":"499ec2c4_f9505e07","line":112,"updated":"2021-02-25 15:42:22.000000000","message":"Should this recommend disabling c-vol or cinder services as a way to help this (instead of taking the services down)?","commit_id":"b2aa0bd1d943ccc8673f07aafcd83b1a76999506"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"517cc247a626c84bf432793da7166fc4ccdca820","unresolved":true,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"This operation is best executed when Cinder is not running, as it requires"},{"line_number":111,"context_line":"locking many tables (affecting all tenants) to make sure that then sync is"},{"line_number":112,"context_line":"accurate."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"If accuracy is not our top priority, or we know that a specific project is not"},{"line_number":115,"context_line":"in use, we can disable the locking."}],"source_content_type":"text/x-rst","patch_set":1,"id":"4cf945df_4e3187fb","line":112,"in_reply_to":"499ec2c4_f9505e07","updated":"2021-03-01 15:14:12.000000000","message":"We cannot disable the cinder-api service, and that one also modifies quota usage.  :-(","commit_id":"b2aa0bd1d943ccc8673f07aafcd83b1a76999506"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5b8adfb9ccfd8de6a627700b8716fee25703fb06","unresolved":true,"context_lines":[{"line_number":37,"context_line":"Run without arguments to see a list of available command categories:"},{"line_number":38,"context_line":"``cinder-manage``"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Categories are shell, logs, migrate, db, volume, host, service, backup,"},{"line_number":41,"context_line":"version, and config. Detailed descriptions are below."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"You can also run with a category argument such as \u0027db\u0027 to see a list of all"}],"source_content_type":"text/x-rst","patch_set":2,"id":"6849229d_6dbfd25d","line":40,"range":{"start_line":40,"start_character":15,"end_line":40,"end_character":20},"updated":"2021-03-19 00:36:05.000000000","message":"I was going to say that you can replace this with \u0027quota\u0027 (\u0027shell\u0027 was removed by Change-Id: I61effa4a7141617ad6971597e9d1d167a4758a5c last year), but this list looks out of date, I think everyone misses it when updating the file.  So maybe just replace lines 40-41 with \"The categories are listed below, along with detailed descriptions.\"  Or if you prefer the list of categories here, this is what we\u0027ve got currently:\n\n  ``backup``, ``config``, ``cluster``, ``cg``, ``db``, ``host``, ``quota``, ``service``, ``version``, ``volume``","commit_id":"9d7818b89875c008b27921bae637f90f1d627b26"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"63f76271738ea574502593f97bc4cc9efeb2f74c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Run without arguments to see a list of available command categories:"},{"line_number":38,"context_line":"``cinder-manage``"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Categories are shell, logs, migrate, db, volume, host, service, backup,"},{"line_number":41,"context_line":"version, and config. Detailed descriptions are below."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"You can also run with a category argument such as \u0027db\u0027 to see a list of all"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f3f2df44_cd1016af","line":40,"range":{"start_line":40,"start_character":15,"end_line":40,"end_character":20},"in_reply_to":"6849229d_6dbfd25d","updated":"2021-03-26 11:28:24.000000000","message":"Done","commit_id":"9d7818b89875c008b27921bae637f90f1d627b26"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"5f0132191cef313309292b2ec93dba81353a6165","unresolved":true,"context_lines":[{"line_number":51,"context_line":"~~~~~~~~~~~~"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Cinder quotas sometimes run out of sync, and while there are some mechanisms"},{"line_number":54,"context_line":"in place in Cinder that, with the proper configuration, try to do a resync"},{"line_number":55,"context_line":"the quotas, they are not perfect and are susceptible to race conditions,"},{"line_number":56,"context_line":"so they may result in less that perfect accuracy in refreshed quotas."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"The cinder-manage quota commands are meant to help manage these issues while"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f03b6c18_e6127be8","line":55,"range":{"start_line":54,"start_character":68,"end_line":55,"end_character":10},"updated":"2021-03-24 16:45:02.000000000","message":"resync of the quotas","commit_id":"9d7818b89875c008b27921bae637f90f1d627b26"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"63f76271738ea574502593f97bc4cc9efeb2f74c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"~~~~~~~~~~~~"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Cinder quotas sometimes run out of sync, and while there are some mechanisms"},{"line_number":54,"context_line":"in place in Cinder that, with the proper configuration, try to do a resync"},{"line_number":55,"context_line":"the quotas, they are not perfect and are susceptible to race conditions,"},{"line_number":56,"context_line":"so they may result in less that perfect accuracy in refreshed quotas."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"The cinder-manage quota commands are meant to help manage these issues while"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3c713486_bb3f86f4","line":55,"range":{"start_line":54,"start_character":68,"end_line":55,"end_character":10},"in_reply_to":"f03b6c18_e6127be8","updated":"2021-03-26 11:28:24.000000000","message":"Done","commit_id":"9d7818b89875c008b27921bae637f90f1d627b26"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5b8adfb9ccfd8de6a627700b8716fee25703fb06","unresolved":true,"context_lines":[{"line_number":53,"context_line":"Cinder quotas sometimes run out of sync, and while there are some mechanisms"},{"line_number":54,"context_line":"in place in Cinder that, with the proper configuration, try to do a resync"},{"line_number":55,"context_line":"the quotas, they are not perfect and are susceptible to race conditions,"},{"line_number":56,"context_line":"so they may result in less that perfect accuracy in refreshed quotas."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"The cinder-manage quota commands are meant to help manage these issues while"},{"line_number":59,"context_line":"allowing a finer control of when and what quotas are fixed."}],"source_content_type":"text/x-rst","patch_set":2,"id":"59f1710f_7a5a82c4","line":56,"range":{"start_line":56,"start_character":27,"end_line":56,"end_character":31},"updated":"2021-03-19 00:36:05.000000000","message":"than","commit_id":"9d7818b89875c008b27921bae637f90f1d627b26"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"63f76271738ea574502593f97bc4cc9efeb2f74c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"Cinder quotas sometimes run out of sync, and while there are some mechanisms"},{"line_number":54,"context_line":"in place in Cinder that, with the proper configuration, try to do a resync"},{"line_number":55,"context_line":"the quotas, they are not perfect and are susceptible to race conditions,"},{"line_number":56,"context_line":"so they may result in less that perfect accuracy in refreshed quotas."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"The cinder-manage quota commands are meant to help manage these issues while"},{"line_number":59,"context_line":"allowing a finer control of when and what quotas are fixed."}],"source_content_type":"text/x-rst","patch_set":2,"id":"d26b5ea4_0f1fa845","line":56,"range":{"start_line":56,"start_character":27,"end_line":56,"end_character":31},"in_reply_to":"59f1710f_7a5a82c4","updated":"2021-03-26 11:28:24.000000000","message":"Done","commit_id":"9d7818b89875c008b27921bae637f90f1d627b26"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5b8adfb9ccfd8de6a627700b8716fee25703fb06","unresolved":true,"context_lines":[{"line_number":108,"context_line":"The refresh will also remove duplicated entries."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"This operation is best executed when Cinder is not running, as it requires"},{"line_number":111,"context_line":"locking many tables (affecting all tenants) to make sure that then sync is"},{"line_number":112,"context_line":"accurate."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"If accuracy is not our top priority, or we know that a specific project is not"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa240e5_748ecf71","line":111,"range":{"start_line":111,"start_character":62,"end_line":111,"end_character":66},"updated":"2021-03-19 00:36:05.000000000","message":"the","commit_id":"9d7818b89875c008b27921bae637f90f1d627b26"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"63f76271738ea574502593f97bc4cc9efeb2f74c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"The refresh will also remove duplicated entries."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"This operation is best executed when Cinder is not running, as it requires"},{"line_number":111,"context_line":"locking many tables (affecting all tenants) to make sure that then sync is"},{"line_number":112,"context_line":"accurate."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"If accuracy is not our top priority, or we know that a specific project is not"}],"source_content_type":"text/x-rst","patch_set":2,"id":"51e70ab7_a1e40e31","line":111,"range":{"start_line":111,"start_character":62,"end_line":111,"end_character":66},"in_reply_to":"7aa240e5_748ecf71","updated":"2021-03-26 11:28:24.000000000","message":"Done","commit_id":"9d7818b89875c008b27921bae637f90f1d627b26"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7cf6dbbc6f32dc23804d6a501d291526476a5d31","unresolved":true,"context_lines":[{"line_number":107,"context_line":"The refresh will also remove duplicated entries."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"This operation is best executed when Cinder is not running, as it requires"},{"line_number":110,"context_line":"locking many tables (affecting all tenants) to make sure that then sync is"},{"line_number":111,"context_line":"accurate."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"If accuracy is not our top priority, or we know that a specific project is not"}],"source_content_type":"text/x-rst","patch_set":3,"id":"68413db7_8f1ad3e8","line":110,"range":{"start_line":110,"start_character":62,"end_line":110,"end_character":66},"updated":"2021-03-26 17:45:29.000000000","message":"!","commit_id":"89de17d9bfd1bd7c4490921368ab83b30e6c5bd5"}]}