)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"26a41a9dd95c6726a0d0ff43a24823488c4fc2a1","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Reset state robustification for backup os-reset_status"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit changes the os-reset_status backup-api"},{"line_number":10,"context_line":"to handle the bellow use case"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"1.backup reset from available,deleting,error deleting to"},{"line_number":13,"context_line":"something else because user should only reset backup status"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"83c02002_1e634ad5","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":20},"updated":"2022-03-07 15:56:57.000000000","message":"Nit:  below","commit_id":"e2216f8143c501848e13f9f24f54f259ea2e96b1"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"44677212561ab5dc94b07a0537764a9b817adce7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reset state robustification for backup os-reset_status"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit changes the os-reset_status backup-api"},{"line_number":10,"context_line":"to handle the bellow use case"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"1.backup reset from available,deleting,error deleting to"},{"line_number":13,"context_line":"something else because user should only reset backup status"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"2da65b7a_613cf100","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":20},"in_reply_to":"83c02002_1e634ad5","updated":"2022-03-07 16:01:56.000000000","message":"Done","commit_id":"e2216f8143c501848e13f9f24f54f259ea2e96b1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9ab646bb5722df2e78d483c6f5d5f5551fb8290d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This commit changes the os-reset_status backup-api"},{"line_number":10,"context_line":"to handle the below use case"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"1.reset backup to the \"ing\" state"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partial implement blueprint reset-state-robustification"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"4a58df4e_8766fed6","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":33},"updated":"2022-03-07 23:40:34.000000000","message":"For people who haven\u0027t read the spec, this is confusing.  You should explicitly state that what you are doing is:\n\n 1. reset a group-snapshot to the \u0027deleting\u0027 or \u0027error_deleting\u0027 status is now disallowed\n\nAlso, don\u0027t forget to add the \"boilerplate\" text from https://etherpad.opendev.org/p/no-foot-shooting in this commit message.","commit_id":"2457c57fb17113cf34d3cd14b16184c975aa828b"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"debd08badfde5ac7e800c310a1714f2cf04293a0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit changes the os-reset_status backup-api"},{"line_number":10,"context_line":"to handle the below use case"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"1.reset backup to the \"ing\" state"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partial implement blueprint reset-state-robustification"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"0ec262a1_5713daff","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":33},"in_reply_to":"4a58df4e_8766fed6","updated":"2022-03-10 03:19:22.000000000","message":"Done","commit_id":"2457c57fb17113cf34d3cd14b16184c975aa828b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"44837914d27daca8d4d8707d74e5a5a581521e4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"43e182e3_b7b4694b","updated":"2021-11-25 07:55:54.000000000","message":"recheck","commit_id":"08f70bde92449f15ac89ef4608d21ec8be1fee6c"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"fed1f79642dd45a05342067528a9650cc2f16c78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"2226fcd1_dd087c11","updated":"2022-03-02 14:52:03.000000000","message":"eric ok i\u0027ll update that\n","commit_id":"be402c3ca103833401f8f2fdc531f087dd24a85b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"26a41a9dd95c6726a0d0ff43a24823488c4fc2a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"7fced1fa_86c7916f","updated":"2022-03-07 15:56:57.000000000","message":"I have one nit on the commit message.  Not a blocker.  Otherwise, think the others who have previously commented need to vote.","commit_id":"e2216f8143c501848e13f9f24f54f259ea2e96b1"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"d1e5430f4a37b321eeecee92119685ac2a1fe45d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"092801c9_3cdd28e3","updated":"2022-03-07 15:50:55.000000000","message":"LGTM.","commit_id":"e2216f8143c501848e13f9f24f54f259ea2e96b1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9ab646bb5722df2e78d483c6f5d5f5551fb8290d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"dd696524_5e65c668","updated":"2022-03-07 23:40:34.000000000","message":"You may not need this patch.  See comments inline.","commit_id":"2457c57fb17113cf34d3cd14b16184c975aa828b"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"c9cff003be50e542ffb8e22bebd00e11d21286e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"e6e27903_d7b779a8","updated":"2022-09-01 10:35:50.000000000","message":"hi core reviewers could you help me to merge this patch","commit_id":"d3425b8be6c3a2b6e261a2b1ef310f32a54ae123"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"fa6234442dc2898fb7b0bf68869d4fb0c6a2cd40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"9dbac507_fbefc37b","updated":"2022-11-25 07:18:33.000000000","message":"run-DellEMC PowerStore CI","commit_id":"72c066cc2cb2f0bde805d8a5e845303ee6faf637"}],"cinder/api/contrib/admin_actions.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c755f30e3b94c24125d8e52f9fb83d20194a078f","unresolved":true,"context_lines":[{"line_number":354,"context_line":"        backup \u003d self._get(context, id)"},{"line_number":355,"context_line":"        status \u003d update[\u0027status\u0027]"},{"line_number":356,"context_line":"        if status \u003d\u003d backup[\u0027status\u0027]:"},{"line_number":357,"context_line":"            msg \u003d _(\"Cannot reset-state to same state\")"},{"line_number":358,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":359,"context_line":"        # Not found exception will be handled at the wsgi level"},{"line_number":360,"context_line":"        self.backup_api.reset_status(context\u003dcontext, backup_id\u003did,"}],"source_content_type":"text/x-python","patch_set":8,"id":"4d302155_ee745142","line":357,"updated":"2021-09-10 16:12:22.000000000","message":"See discussion on\n    https://review.opendev.org/c/openstack/cinder/+/773985","commit_id":"6753f889b6deec2788fe6a658f87312fab2c556a"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"780b07ed5c21d1d36ea8dde99179da59a07481b7","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        backup \u003d self._get(context, id)"},{"line_number":355,"context_line":"        status \u003d update[\u0027status\u0027]"},{"line_number":356,"context_line":"        if status \u003d\u003d backup[\u0027status\u0027]:"},{"line_number":357,"context_line":"            msg \u003d _(\"Cannot reset-state to same state\")"},{"line_number":358,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":359,"context_line":"        # Not found exception will be handled at the wsgi level"},{"line_number":360,"context_line":"        self.backup_api.reset_status(context\u003dcontext, backup_id\u003did,"}],"source_content_type":"text/x-python","patch_set":8,"id":"60a15853_5765d515","line":357,"in_reply_to":"4d302155_ee745142","updated":"2022-02-15 11:07:37.000000000","message":"Done","commit_id":"6753f889b6deec2788fe6a658f87312fab2c556a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"63f10eea96e7e373af6354f306ce00d9f012bb74","unresolved":true,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        self._notify_reset_status(context, id, \u0027reset_status.start\u0027)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        # backup \u003d self._get(context, id)"},{"line_number":350,"context_line":"        status \u003d update[\u0027status\u0027]"},{"line_number":351,"context_line":"        if status in (\u0027available\u0027, \u0027deleting\u0027, \u0027error_deleting\u0027):"},{"line_number":352,"context_line":"            msg \u003d _(\"Cannot reset-state to %s\" % status)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3aaeaaa3_6069354c","line":349,"range":{"start_line":349,"start_character":8,"end_line":349,"end_character":41},"updated":"2022-03-02 14:46:29.000000000","message":"This comment should be removed.","commit_id":"be402c3ca103833401f8f2fdc531f087dd24a85b"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"a96341e8e8d318b148e6a38c7a9cd21e9fd4bb95","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        self._notify_reset_status(context, id, \u0027reset_status.start\u0027)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        # backup \u003d self._get(context, id)"},{"line_number":350,"context_line":"        status \u003d update[\u0027status\u0027]"},{"line_number":351,"context_line":"        if status in (\u0027available\u0027, \u0027deleting\u0027, \u0027error_deleting\u0027):"},{"line_number":352,"context_line":"            msg \u003d _(\"Cannot reset-state to %s\" % status)"}],"source_content_type":"text/x-python","patch_set":21,"id":"da85c180_cc614700","line":349,"range":{"start_line":349,"start_character":8,"end_line":349,"end_character":41},"in_reply_to":"3aaeaaa3_6069354c","updated":"2022-03-02 16:20:31.000000000","message":"Done","commit_id":"be402c3ca103833401f8f2fdc531f087dd24a85b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"63f10eea96e7e373af6354f306ce00d9f012bb74","unresolved":true,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        # backup \u003d self._get(context, id)"},{"line_number":350,"context_line":"        status \u003d update[\u0027status\u0027]"},{"line_number":351,"context_line":"        if status in (\u0027available\u0027, \u0027deleting\u0027, \u0027error_deleting\u0027):"},{"line_number":352,"context_line":"            msg \u003d _(\"Cannot reset-state to %s\" % status)"},{"line_number":353,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":354,"context_line":"        # Not found exception will be handled at the wsgi level"}],"source_content_type":"text/x-python","patch_set":21,"id":"6be96581_61785deb","line":351,"range":{"start_line":351,"start_character":22,"end_line":351,"end_character":33},"updated":"2022-03-02 14:46:29.000000000","message":"This appears to block reset state to the \"available\" status.  Why do we want to do this in all cases?  Reset state from \"available\" to \"available\" should just be a no-op that succeeds.","commit_id":"be402c3ca103833401f8f2fdc531f087dd24a85b"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"fed1f79642dd45a05342067528a9650cc2f16c78","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        # backup \u003d self._get(context, id)"},{"line_number":350,"context_line":"        status \u003d update[\u0027status\u0027]"},{"line_number":351,"context_line":"        if status in (\u0027available\u0027, \u0027deleting\u0027, \u0027error_deleting\u0027):"},{"line_number":352,"context_line":"            msg \u003d _(\"Cannot reset-state to %s\" % status)"},{"line_number":353,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":354,"context_line":"        # Not found exception will be handled at the wsgi level"}],"source_content_type":"text/x-python","patch_set":21,"id":"3e5aa557_3bdf5bb3","line":351,"range":{"start_line":351,"start_character":22,"end_line":351,"end_character":33},"in_reply_to":"6be96581_61785deb","updated":"2022-03-02 14:52:03.000000000","message":"Done","commit_id":"be402c3ca103833401f8f2fdc531f087dd24a85b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9ab646bb5722df2e78d483c6f5d5f5551fb8290d","unresolved":true,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        self._notify_reset_status(context, id, \u0027reset_status.start\u0027)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        status \u003d update[\u0027status\u0027]"},{"line_number":350,"context_line":"        if status in (\u0027deleting\u0027, \u0027error_deleting\u0027):"},{"line_number":351,"context_line":"            msg \u003d _(\"Cannot reset-state to %s\" % status)"},{"line_number":352,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":353,"context_line":"        # Not found exception will be handled at the wsgi level"},{"line_number":354,"context_line":"        self.backup_api.reset_status(context\u003dcontext, backup_id\u003did,"},{"line_number":355,"context_line":"                                     status\u003dupdate[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":24,"id":"ae4c618b_a70507cf","line":352,"range":{"start_line":349,"start_character":0,"end_line":352,"end_character":59},"updated":"2022-03-07 23:40:34.000000000","message":"I don\u0027t think you need to do this.  The schema already prevents someone from trying to make this call.  See my comment in validators.py.","commit_id":"2457c57fb17113cf34d3cd14b16184c975aa828b"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"debd08badfde5ac7e800c310a1714f2cf04293a0","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        self._notify_reset_status(context, id, \u0027reset_status.start\u0027)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        status \u003d update[\u0027status\u0027]"},{"line_number":350,"context_line":"        if status in (\u0027deleting\u0027, \u0027error_deleting\u0027):"},{"line_number":351,"context_line":"            msg \u003d _(\"Cannot reset-state to %s\" % status)"},{"line_number":352,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":353,"context_line":"        # Not found exception will be handled at the wsgi level"},{"line_number":354,"context_line":"        self.backup_api.reset_status(context\u003dcontext, backup_id\u003did,"},{"line_number":355,"context_line":"                                     status\u003dupdate[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":24,"id":"6aa0543d_d2080066","line":352,"range":{"start_line":349,"start_character":0,"end_line":352,"end_character":59},"in_reply_to":"ae4c618b_a70507cf","updated":"2022-03-10 03:19:22.000000000","message":"Done","commit_id":"2457c57fb17113cf34d3cd14b16184c975aa828b"}],"cinder/api/validation/validators.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9ab646bb5722df2e78d483c6f5d5f5551fb8290d","unresolved":true,"context_lines":[{"line_number":380,"context_line":"    valid_status \u003d [c_fields.BackupStatus.AVAILABLE,"},{"line_number":381,"context_line":"                    c_fields.BackupStatus.ERROR]"},{"line_number":382,"context_line":"    if not param_value or ("},{"line_number":383,"context_line":"            param_value.lower() not in valid_status):"},{"line_number":384,"context_line":"        msg \u003d _(\"Backup status: %(status)s is invalid, \""},{"line_number":385,"context_line":"                \"valid statuses are: \""},{"line_number":386,"context_line":"                \"%(valid)s.\") % {\u0027status\u0027: param_value,"}],"source_content_type":"text/x-python","patch_set":24,"id":"483eb489_eecaf3db","line":383,"range":{"start_line":383,"start_character":32,"end_line":383,"end_character":51},"updated":"2022-03-07 23:40:34.000000000","message":"Looks like we only allow reset-state to \u0027available\u0027 or \u0027error\u0027.","commit_id":"2457c57fb17113cf34d3cd14b16184c975aa828b"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"debd08badfde5ac7e800c310a1714f2cf04293a0","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    valid_status \u003d [c_fields.BackupStatus.AVAILABLE,"},{"line_number":381,"context_line":"                    c_fields.BackupStatus.ERROR]"},{"line_number":382,"context_line":"    if not param_value or ("},{"line_number":383,"context_line":"            param_value.lower() not in valid_status):"},{"line_number":384,"context_line":"        msg \u003d _(\"Backup status: %(status)s is invalid, \""},{"line_number":385,"context_line":"                \"valid statuses are: \""},{"line_number":386,"context_line":"                \"%(valid)s.\") % {\u0027status\u0027: param_value,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3b344070_5829e1b3","line":383,"range":{"start_line":383,"start_character":32,"end_line":383,"end_character":51},"in_reply_to":"483eb489_eecaf3db","updated":"2022-03-10 03:19:22.000000000","message":"yes we only allow reset state to available and error that why what if someone raise request to something else which is invalid.","commit_id":"2457c57fb17113cf34d3cd14b16184c975aa828b"}]}