)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"84325f0ad9d2dacdbaa6314d0b2e9d3412d13241","unresolved":false,"context_lines":[{"line_number":977,"context_line":"            # If this is a destination volume, we have to clear the database"},{"line_number":978,"context_line":"            # record to avoid user confusion."},{"line_number":979,"context_line":"            self._clear_db(is_migrating_dest, volume, \u0027available\u0027)"},{"line_number":980,"context_line":"            return True  # Let caller know we skipped deletion"},{"line_number":981,"context_line":"        except Exception:"},{"line_number":982,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":983,"context_line":"                # If this is a destination volume, we have to clear the"}],"source_content_type":"text/x-python","patch_set":7,"id":"e87cbd79_ddadfe64","line":980,"in_reply_to":"59c35360_3cad61e7","updated":"2021-08-26 15:35:48.000000000","message":"No, this code was recently added to let callers know that the volume has actually been removed and that the file locks for this volume can be removed.\n\nWhat we need to do to remove this complain is to `return False` in the other cases and change the return type of the method to boolean so we don\u0027t return `None` or `True` but `False` and `True` instead.","commit_id":"dcf143c7733d128b84a005481b0c9e501080085f"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"2d366807f711af6c4b831c238ecfb8ad5550f6e5","unresolved":true,"context_lines":[{"line_number":977,"context_line":"            # If this is a destination volume, we have to clear the database"},{"line_number":978,"context_line":"            # record to avoid user confusion."},{"line_number":979,"context_line":"            self._clear_db(is_migrating_dest, volume, \u0027available\u0027)"},{"line_number":980,"context_line":"            return True  # Let caller know we skipped deletion"},{"line_number":981,"context_line":"        except Exception:"},{"line_number":982,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":983,"context_line":"                # If this is a destination volume, we have to clear the"}],"source_content_type":"text/x-python","patch_set":7,"id":"59c35360_3cad61e7","line":980,"in_reply_to":"f0072033_e5f3f06c","updated":"2021-08-19 20:46:39.000000000","message":"\u003e mypy: error: No return value expected \n\nShould this line be removed?","commit_id":"dcf143c7733d128b84a005481b0c9e501080085f"}]}