)]}'
{"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"9d54e553922e25325ccbb6d2963bb22ba7178106","unresolved":true,"context_lines":[{"line_number":2651,"context_line":"                         \u0027please configure the peer pool.\u0027))"},{"line_number":2652,"context_line":"        pool_attr \u003d None"},{"line_number":2653,"context_line":"        peer_pool_attr \u003d None"},{"line_number":2654,"context_line":"        for stat_pool in self.stats.get(\u0027pools\u0027, []):"},{"line_number":2655,"context_line":"            if stat_pool[\u0027pool_name\u0027] \u003d\u003d pool:"},{"line_number":2656,"context_line":"                pool_attr \u003d stat_pool"},{"line_number":2657,"context_line":"            elif stat_pool[\u0027pool_name\u0027] \u003d\u003d peer_pool:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f5502015_b739cfd5","line":2654,"range":{"start_line":2654,"start_character":30,"end_line":2654,"end_character":35},"updated":"2021-03-09 12:20:16.000000000","message":"can\u0027t we use self._stats instead of self.stats","commit_id":"e78fd71b9cea9a046b811cff5928cb3dae04a791"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"4e4ee621f5b8df9e413140e1cf26cc2763d41f59","unresolved":false,"context_lines":[{"line_number":2651,"context_line":"                         \u0027please configure the peer pool.\u0027))"},{"line_number":2652,"context_line":"        pool_attr \u003d None"},{"line_number":2653,"context_line":"        peer_pool_attr \u003d None"},{"line_number":2654,"context_line":"        for stat_pool in self.stats.get(\u0027pools\u0027, []):"},{"line_number":2655,"context_line":"            if stat_pool[\u0027pool_name\u0027] \u003d\u003d pool:"},{"line_number":2656,"context_line":"                pool_attr \u003d stat_pool"},{"line_number":2657,"context_line":"            elif stat_pool[\u0027pool_name\u0027] \u003d\u003d peer_pool:"}],"source_content_type":"text/x-python","patch_set":1,"id":"6c2a98b5_1725743e","line":2654,"range":{"start_line":2654,"start_character":30,"end_line":2654,"end_character":35},"in_reply_to":"f5502015_b739cfd5","updated":"2021-03-15 10:43:58.000000000","message":"_stats cannot be used since it\u0027s not part of helpers, so using stats should be fine","commit_id":"e78fd71b9cea9a046b811cff5928cb3dae04a791"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"9d54e553922e25325ccbb6d2963bb22ba7178106","unresolved":true,"context_lines":[{"line_number":5711,"context_line":"                         for pool in"},{"line_number":5712,"context_line":"                         self._get_backend_pools()]"},{"line_number":5713,"context_line":""},{"line_number":5714,"context_line":"        if self._helpers.is_system_topology_hyperswap(self._state):"},{"line_number":5715,"context_line":"            peer_pool \u003d self._get_backend_peer_pool()"},{"line_number":5716,"context_line":"            data[\u0027pools\u0027].append(self._build_pool_stats(peer_pool))"},{"line_number":5717,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d05f99ff_a8240764","line":5714,"updated":"2021-03-09 12:20:16.000000000","message":"isn\u0027t the peer_pool listed as part of build_pool_stats","commit_id":"e78fd71b9cea9a046b811cff5928cb3dae04a791"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"ce7ca4153f5b2a6a0a0d26ecae8b10db012a122d","unresolved":true,"context_lines":[{"line_number":5711,"context_line":"                         for pool in"},{"line_number":5712,"context_line":"                         self._get_backend_pools()]"},{"line_number":5713,"context_line":""},{"line_number":5714,"context_line":"        if self._helpers.is_system_topology_hyperswap(self._state):"},{"line_number":5715,"context_line":"            peer_pool \u003d self._get_backend_peer_pool()"},{"line_number":5716,"context_line":"            data[\u0027pools\u0027].append(self._build_pool_stats(peer_pool))"},{"line_number":5717,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c0eef75f_e0eb3a2a","line":5714,"in_reply_to":"d05f99ff_a8240764","updated":"2021-04-21 06:25:14.000000000","message":"\u0027storwize_peer_pool\u0027 is the attribute to give the peer_pool, \u0027storwize_svc_volpool_name\u0027 is the attribute to give the pool. get_backend_pools will return only the pools which are configured with \u0027storwize_svc_volpool_name\u0027. So added get_backend_peer_pool to get the peer_pool configured.","commit_id":"e78fd71b9cea9a046b811cff5928cb3dae04a791"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"4e4ee621f5b8df9e413140e1cf26cc2763d41f59","unresolved":true,"context_lines":[{"line_number":5713,"context_line":""},{"line_number":5714,"context_line":"        if self._helpers.is_system_topology_hyperswap(self._state):"},{"line_number":5715,"context_line":"            peer_pool \u003d self._get_backend_peer_pool()"},{"line_number":5716,"context_line":"            data[\u0027pools\u0027].append(self._build_pool_stats(peer_pool))"},{"line_number":5717,"context_line":""},{"line_number":5718,"context_line":"        if self._replica_enabled:"},{"line_number":5719,"context_line":"            data[\u0027replication\u0027] \u003d self._replica_enabled"}],"source_content_type":"text/x-python","patch_set":1,"id":"4c580a54_85a61538","line":5716,"updated":"2021-03-15 10:43:58.000000000","message":"it should have a NoneType check, if the peer_pool does not exists it should not append.","commit_id":"e78fd71b9cea9a046b811cff5928cb3dae04a791"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"ce7ca4153f5b2a6a0a0d26ecae8b10db012a122d","unresolved":true,"context_lines":[{"line_number":5713,"context_line":""},{"line_number":5714,"context_line":"        if self._helpers.is_system_topology_hyperswap(self._state):"},{"line_number":5715,"context_line":"            peer_pool \u003d self._get_backend_peer_pool()"},{"line_number":5716,"context_line":"            data[\u0027pools\u0027].append(self._build_pool_stats(peer_pool))"},{"line_number":5717,"context_line":""},{"line_number":5718,"context_line":"        if self._replica_enabled:"},{"line_number":5719,"context_line":"            data[\u0027replication\u0027] \u003d self._replica_enabled"}],"source_content_type":"text/x-python","patch_set":1,"id":"f482157d_a5cc7b91","line":5716,"in_reply_to":"4c580a54_85a61538","updated":"2021-04-21 06:25:14.000000000","message":"Added check for NoneType.","commit_id":"e78fd71b9cea9a046b811cff5928cb3dae04a791"}]}