)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"428fbeb8cd8a8965b4a31e3ba109b16f9b13b2de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"97431d42_62bfea52","updated":"2022-05-31 14:01:59.000000000","message":"Nice optimization.  See comment inline about the log message.","commit_id":"997f6e3755e6f949676cd57c406f959962e81678"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"28b5d9f1eed3747b086aecbdbfe6ac7e46a946f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"01fced52_f77efdad","updated":"2022-04-24 02:28:33.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"997f6e3755e6f949676cd57c406f959962e81678"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"8060a612807acb92b1c6a6c1a4a90202238f2b2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b4f8ed7_30598007","updated":"2022-04-20 00:37:00.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"997f6e3755e6f949676cd57c406f959962e81678"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"3afed79f379e84c6a940c9ce7eb76c2c34c4a3ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a05f6728_c6ae5bfd","updated":"2022-04-22 02:13:15.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"997f6e3755e6f949676cd57c406f959962e81678"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"8047f881c46a74b4d8c550b2f9334c39dfc17ae9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a9197205_75c75fd2","updated":"2022-04-25 06:08:23.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"997f6e3755e6f949676cd57c406f959962e81678"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"e61ab26be14f68a595f38d74106783835525406c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c5f62477_4a81b7a6","updated":"2021-11-04 05:01:28.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"997f6e3755e6f949676cd57c406f959962e81678"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"601095d0dab5a22ce7c3bcf631e130decea3a442","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c6dd1bbb_14d31efa","updated":"2022-04-21 09:01:17.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"997f6e3755e6f949676cd57c406f959962e81678"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"4ac3fc5249ffde55a0cb51e7a12b6adc7f6e40ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f0d73e0c_5bfd97b4","updated":"2021-11-05 01:22:48.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"997f6e3755e6f949676cd57c406f959962e81678"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ec275d2684c2f41bca9c05b113d14468099f5322","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f7c2ba3d_bb2b8664","updated":"2021-10-13 14:15:29.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"997f6e3755e6f949676cd57c406f959962e81678"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3084045b1173cb0dee4909a5d30842267be09d54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"73d0a9b5_103b094e","updated":"2022-06-17 15:11:11.000000000","message":"LGTM. Seems more of an optimization than a fix so looks good without a bug/releasenote.","commit_id":"147b24a00aee53ac7a5415477eb02ca80b5b920d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9a1409a625e3f7f49c530ba3e02fe6b88b326f5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"949032b5_64b99b58","updated":"2022-08-11 03:04:57.000000000","message":"Revision looks good to me.","commit_id":"147b24a00aee53ac7a5415477eb02ca80b5b920d"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"81e97fdf61159bde6a7d6c018a782810eb30dfb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8ddea665_20311f19","updated":"2022-07-05 07:41:36.000000000","message":"looks good to me","commit_id":"147b24a00aee53ac7a5415477eb02ca80b5b920d"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"ee1301bccc204f6f3fb0b44092d3146d56caaea4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3fad227b_35948add","updated":"2022-06-14 06:31:55.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"147b24a00aee53ac7a5415477eb02ca80b5b920d"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"53411bb94d08d422e015cb4ca092a153eb097e10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4ee914bb_7baf2414","updated":"2022-06-13 15:25:04.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"147b24a00aee53ac7a5415477eb02ca80b5b920d"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"02551ae5a6f16b3eb2cb276678af2e428f13360e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a9562115_0b0ddb55","updated":"2022-06-14 03:24:45.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"147b24a00aee53ac7a5415477eb02ca80b5b920d"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"07e683f40f28a4deff3b862616fe42eaf95021d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ed4112ae_0617f295","updated":"2022-06-15 09:44:15.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"147b24a00aee53ac7a5415477eb02ca80b5b920d"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"a5278132c44a6f2cff36cea72c4f60bdca85ce27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ef226b38_d8e48757","updated":"2022-06-16 09:06:51.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"147b24a00aee53ac7a5415477eb02ca80b5b920d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"be3643e254e532da6a1f83132d7feb6dab3da0bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2413e954_0c6c6601","in_reply_to":"73d0a9b5_103b094e","updated":"2022-06-17 15:11:42.000000000","message":"Also powermax CI reported success","commit_id":"147b24a00aee53ac7a5415477eb02ca80b5b920d"}],"cinder/volume/drivers/dell_emc/powermax/masking.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a33b684381c3ff072c4494a7de9c13380d9cff59","unresolved":true,"context_lines":[{"line_number":592,"context_line":"        if source_storage_group_name.lower() \u003d\u003d ("},{"line_number":593,"context_line":"                target_storage_group_name.lower()):"},{"line_number":594,"context_line":"            LOG.warning("},{"line_number":595,"context_line":"                \"Source storage group %(src)s and target storage\""},{"line_number":596,"context_line":"                \"group %(tgt)s are the same, no move operation\""},{"line_number":597,"context_line":"                \"required.\","},{"line_number":598,"context_line":"                {\u0027src\u0027: source_storage_group_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"044d7b03_aba10881","line":595,"range":{"start_line":595,"start_character":62,"end_line":595,"end_character":65},"updated":"2021-09-09 15:19:59.000000000","message":"missing space at EOL.","commit_id":"8ddfed414d1b2433f309d93cdb6b6d2cf5f00c85"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"87a30da76b08ba55c1d4053730f4dbdff0cdff02","unresolved":false,"context_lines":[{"line_number":592,"context_line":"        if source_storage_group_name.lower() \u003d\u003d ("},{"line_number":593,"context_line":"                target_storage_group_name.lower()):"},{"line_number":594,"context_line":"            LOG.warning("},{"line_number":595,"context_line":"                \"Source storage group %(src)s and target storage\""},{"line_number":596,"context_line":"                \"group %(tgt)s are the same, no move operation\""},{"line_number":597,"context_line":"                \"required.\","},{"line_number":598,"context_line":"                {\u0027src\u0027: source_storage_group_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c9c3ffe5_7235c5fc","line":595,"range":{"start_line":595,"start_character":62,"end_line":595,"end_character":65},"in_reply_to":"044d7b03_aba10881","updated":"2021-10-12 10:32:45.000000000","message":"Done","commit_id":"8ddfed414d1b2433f309d93cdb6b6d2cf5f00c85"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a33b684381c3ff072c4494a7de9c13380d9cff59","unresolved":true,"context_lines":[{"line_number":593,"context_line":"                target_storage_group_name.lower()):"},{"line_number":594,"context_line":"            LOG.warning("},{"line_number":595,"context_line":"                \"Source storage group %(src)s and target storage\""},{"line_number":596,"context_line":"                \"group %(tgt)s are the same, no move operation\""},{"line_number":597,"context_line":"                \"required.\","},{"line_number":598,"context_line":"                {\u0027src\u0027: source_storage_group_name,"},{"line_number":599,"context_line":"                 \u0027tgt\u0027: target_storage_group_name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"64e3cbde_2093d62c","line":596,"range":{"start_line":596,"start_character":60,"end_line":596,"end_character":63},"updated":"2021-09-09 15:19:59.000000000","message":"Same comment here.","commit_id":"8ddfed414d1b2433f309d93cdb6b6d2cf5f00c85"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"87a30da76b08ba55c1d4053730f4dbdff0cdff02","unresolved":false,"context_lines":[{"line_number":593,"context_line":"                target_storage_group_name.lower()):"},{"line_number":594,"context_line":"            LOG.warning("},{"line_number":595,"context_line":"                \"Source storage group %(src)s and target storage\""},{"line_number":596,"context_line":"                \"group %(tgt)s are the same, no move operation\""},{"line_number":597,"context_line":"                \"required.\","},{"line_number":598,"context_line":"                {\u0027src\u0027: source_storage_group_name,"},{"line_number":599,"context_line":"                 \u0027tgt\u0027: target_storage_group_name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f8a243e_fdabc292","line":596,"range":{"start_line":596,"start_character":60,"end_line":596,"end_character":63},"in_reply_to":"64e3cbde_2093d62c","updated":"2021-10-12 10:32:45.000000000","message":"Done","commit_id":"8ddfed414d1b2433f309d93cdb6b6d2cf5f00c85"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"428fbeb8cd8a8965b4a31e3ba109b16f9b13b2de","unresolved":true,"context_lines":[{"line_number":576,"context_line":"        return child_sg_name, msg"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    def move_volume_between_storage_groups("},{"line_number":579,"context_line":"            self, serial_number, device_id, source_storage_group_name,"},{"line_number":580,"context_line":"            target_storage_group_name, extra_specs, force\u003dFalse,"},{"line_number":581,"context_line":"            parent_sg\u003dNone):"},{"line_number":582,"context_line":"        \"\"\"Move a volume between storage groups."},{"line_number":583,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffbb743b_abc5906c","line":580,"range":{"start_line":579,"start_character":44,"end_line":580,"end_character":37},"updated":"2022-05-31 14:01:59.000000000","message":"looks like all the current calls to this function are using positional arguments, so since you haven\u0027t changed the ordering, changing the spelling is ok","commit_id":"997f6e3755e6f949676cd57c406f959962e81678"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"dd67e1f5df91f7a4122dfd7077c441534650f4ad","unresolved":false,"context_lines":[{"line_number":576,"context_line":"        return child_sg_name, msg"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    def move_volume_between_storage_groups("},{"line_number":579,"context_line":"            self, serial_number, device_id, source_storage_group_name,"},{"line_number":580,"context_line":"            target_storage_group_name, extra_specs, force\u003dFalse,"},{"line_number":581,"context_line":"            parent_sg\u003dNone):"},{"line_number":582,"context_line":"        \"\"\"Move a volume between storage groups."},{"line_number":583,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"17d3a419_13c1a98a","line":580,"range":{"start_line":579,"start_character":44,"end_line":580,"end_character":37},"in_reply_to":"ffbb743b_abc5906c","updated":"2022-06-15 12:41:55.000000000","message":"Ack","commit_id":"997f6e3755e6f949676cd57c406f959962e81678"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"428fbeb8cd8a8965b4a31e3ba109b16f9b13b2de","unresolved":true,"context_lines":[{"line_number":591,"context_line":"        \"\"\""},{"line_number":592,"context_line":"        if source_storage_group_name.lower() \u003d\u003d ("},{"line_number":593,"context_line":"                target_storage_group_name.lower()):"},{"line_number":594,"context_line":"            LOG.warning("},{"line_number":595,"context_line":"                \"Source storage group %(src)s and target storage \""},{"line_number":596,"context_line":"                \"group %(tgt)s are the same, no move operation \""},{"line_number":597,"context_line":"                \"required.\","}],"source_content_type":"text/x-python","patch_set":2,"id":"064ac276_57d70f0f","line":594,"range":{"start_line":594,"start_character":16,"end_line":594,"end_character":23},"updated":"2022-05-31 14:01:59.000000000","message":"I think this would be better as info level?  There\u0027s nothing wrong that could indicate a potential problem, the log message is really there in case an operator causes a bunch of moves and is then wondering why nothing is logged on the backend, the operator can look in the c-vol log and find this message.\n\nFeel free to disagree and I\u0027ll reconsider.","commit_id":"997f6e3755e6f949676cd57c406f959962e81678"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"14fb14c7b07267bf4b03877e8cd9fef56ad56245","unresolved":true,"context_lines":[{"line_number":591,"context_line":"        \"\"\""},{"line_number":592,"context_line":"        if source_storage_group_name.lower() \u003d\u003d ("},{"line_number":593,"context_line":"                target_storage_group_name.lower()):"},{"line_number":594,"context_line":"            LOG.warning("},{"line_number":595,"context_line":"                \"Source storage group %(src)s and target storage \""},{"line_number":596,"context_line":"                \"group %(tgt)s are the same, no move operation \""},{"line_number":597,"context_line":"                \"required.\","}],"source_content_type":"text/x-python","patch_set":2,"id":"ccc9766a_ed95b3e5","line":594,"range":{"start_line":594,"start_character":16,"end_line":594,"end_character":23},"in_reply_to":"064ac276_57d70f0f","updated":"2022-06-03 14:42:23.000000000","message":"I agree with you. Done.","commit_id":"997f6e3755e6f949676cd57c406f959962e81678"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"dd67e1f5df91f7a4122dfd7077c441534650f4ad","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        \"\"\""},{"line_number":592,"context_line":"        if source_storage_group_name.lower() \u003d\u003d ("},{"line_number":593,"context_line":"                target_storage_group_name.lower()):"},{"line_number":594,"context_line":"            LOG.warning("},{"line_number":595,"context_line":"                \"Source storage group %(src)s and target storage \""},{"line_number":596,"context_line":"                \"group %(tgt)s are the same, no move operation \""},{"line_number":597,"context_line":"                \"required.\","}],"source_content_type":"text/x-python","patch_set":2,"id":"abac11bc_581996d4","line":594,"range":{"start_line":594,"start_character":16,"end_line":594,"end_character":23},"in_reply_to":"ccc9766a_ed95b3e5","updated":"2022-06-15 12:41:55.000000000","message":"Done","commit_id":"997f6e3755e6f949676cd57c406f959962e81678"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3084045b1173cb0dee4909a5d30842267be09d54","unresolved":true,"context_lines":[{"line_number":603,"context_line":"            \"emc-sg-{source_storage_group_name}-{serial_number}\")"},{"line_number":604,"context_line":"        @coordination.synchronized("},{"line_number":605,"context_line":"            \"emc-sg-{target_storage_group_name}-{serial_number}\")"},{"line_number":606,"context_line":"        def do_move_volume_between_storage_groups("},{"line_number":607,"context_line":"                serial_number, source_storage_group_name,"},{"line_number":608,"context_line":"                target_storage_group_name):"},{"line_number":609,"context_line":"            self._check_child_storage_group_exists("}],"source_content_type":"text/x-python","patch_set":3,"id":"b0049468_37fbee0a","line":606,"range":{"start_line":606,"start_character":12,"end_line":606,"end_character":49},"updated":"2022-06-17 15:11:11.000000000","message":"would\u0027ve been better to create it as a private helper method instead of the inner function.","commit_id":"147b24a00aee53ac7a5415477eb02ca80b5b920d"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"e64838893ee54ace6b747bb09ca91fcb3f35d4e1","unresolved":false,"context_lines":[{"line_number":603,"context_line":"            \"emc-sg-{source_storage_group_name}-{serial_number}\")"},{"line_number":604,"context_line":"        @coordination.synchronized("},{"line_number":605,"context_line":"            \"emc-sg-{target_storage_group_name}-{serial_number}\")"},{"line_number":606,"context_line":"        def do_move_volume_between_storage_groups("},{"line_number":607,"context_line":"                serial_number, source_storage_group_name,"},{"line_number":608,"context_line":"                target_storage_group_name):"},{"line_number":609,"context_line":"            self._check_child_storage_group_exists("}],"source_content_type":"text/x-python","patch_set":3,"id":"00a22608_a29c048d","line":606,"range":{"start_line":606,"start_character":12,"end_line":606,"end_character":49},"in_reply_to":"b0049468_37fbee0a","updated":"2022-07-21 13:30:09.000000000","message":"Ack","commit_id":"147b24a00aee53ac7a5415477eb02ca80b5b920d"}]}