)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/test_xtremio.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1cedf39a4078816b578952f40ec6af94b7a68ea5","unresolved":true,"context_lines":[{"line_number":716,"context_line":"        lunmap \u003d {\u0027lun\u0027: 4}"},{"line_number":717,"context_line":"        connection_properties \u003d self.driver._get_iscsi_properties(lunmap)"},{"line_number":718,"context_line":"        result_addr, _ \u003d connection_properties[\u0027target_portal\u0027].rsplit(\u0027:\u0027, 1)"},{"line_number":719,"context_line":"        self.assertEqual(netutils.escape_ipv6(\u0027fd00:206:553::7\u0027), result_addr)"},{"line_number":720,"context_line":"        xms_data[\u0027iscsi-portals\u0027] \u003d portals"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    def test_terminate_connection(self, req):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ee0b73c6_47b34026","line":719,"range":{"start_line":719,"start_character":25,"end_line":719,"end_character":64},"updated":"2021-09-17 15:31:22.000000000","message":"nit: I think you should use the literal string you expect here, namely, \u0027[fd00:206:553::7]\u0027.  This is duplicating what you have in the code, and if netutils.escape_ipv6 doesn\u0027t behave the way you think it does, this unit test would not detect that.","commit_id":"b9bc30779310410b3e1df588c6ddf9ca035dfa55"}]}